- 29 Aug, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6fd327e4a714884196186b7a6ee6d6ba9972c322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383471Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802895}
-
Trevor Perrier authored
This second of four CLs to enable Clank to be in a seperate locale from the system. This CL adds the Android preference key APPLICATION_OVERRIDE_LANGUAGE that will be used to store the override language for Clank. It also adds utility functions and tests for managing the language preference and modifying Configuration locales. Bug: 1068667 Change-Id: Ia8aa6d55c6373696b8af12be43c8741d29bf38d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355489 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#802894}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598601518-e5c4427f7e0d3b1c20c8bd75b29ccde9f832fa2b.profdata to chrome-win32-master-1598658096-a64278c47873df00bb292e7f5bde23944317e855.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I1725d877da6cdf07bdef6662c4235034c2e1d2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383034Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c6fa19fccc98..fe980adabf55 2020-08-29 thestig@chromium.org Simplify some code in fx_agg_driver.cpp. 2020-08-29 tsepez@chromium.org Make CXFA_ReadyNodeIterator a stack-only type. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ia610a30fdcb371e4664a98288837fbc4b6964485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383470Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598637591-8ae79944c569ee90562dcd97e5dcdbd0077c5a06.profdata to chrome-mac-master-1598680344-aa469a0f04e08491eb84b2521bf3eecf90475733.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6113805762862b431a5e9d31dc84c6564fa71454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383042Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/459271df6a8a..f00f89fca0f4 2020-08-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idfa873c36fd0552b5a9ecbf13e2f642e16b0041f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383040Reviewed-by:
-
Ankit Kumar 🌪️ authored
Update PDFiumRange to use gfx::Rect instead of pp::Rect. Update callers to expect gfx::Rect as return value instead of pp::Rect. Noteworthy point: PDFiumRange::GetScreenRects() returns a vector of rects. Instead of converting the returned vector of gfx::Rect to a vector of pp::Rect, the CL modifies recursively the usage of pp::Rect to gfx::Rect of the callers. The reason of updating the callers recursively is to prevent a copy of vector from one structure to another at caller site. Even temporarily, the additional copy of vectors is avoided in this way. Additional points: - In pp::Rect, Union() and Subtract() are utility methods which takes in two rects and returns a rect with the specified operation of input rects. Whereas in gfx::Rect, Union() and Subtract() are member methods which modify the rect in-place. All usage of Union() and Subtract() which are replaced in the CL modify the rect in-place. - In pp::Rect, Intersect() is a utility method which takes in two rects and returns the intersected rect. The counterpart in gfx::Rect is IntersectRects() and not Intersect(). Bug: 1101101 Change-Id: I90dce2c8b33fcced11c4e8a03e2cfb5ae1064abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371142Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#802889} -
Kuo Jen Wei authored
Replace will createElement('canvas') call with new util.newDrawingCanvas() function with good typed return value. Bug: 1122444 Test: tast run <DUT> "camera.CCAUI*" Change-Id: I7c9f994fdbeec6b6f49b3039be032c578c37099b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379348 Commit-Queue: Inker Kuo <inker@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#802888}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5ac807b26749..b4efc051da9d 2020-08-29 jmadill@chromium.org Enable -Wdeprecated-copy. 2020-08-29 jmadill@chromium.org Force impicit fallthrough off in xxhash. 2020-08-29 syoussefi@chromium.org Make copy*Texture parameters consistent for level indices 2020-08-28 cclao@google.com Vulkan: Use context staging buffer for CopyTexSubImage 2020-08-28 timvp@google.com Convert unordered_map to absl::flat_hash_map for select files 2020-08-28 jmadill@chromium.org Enable MSVC warning 4312. 2020-08-28 lehoangq@gmail.com Metal: autogen for EXT_occlusion_query_boolean. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Ibf2fdad9a7df77fe7d955cb8dbe9b1e1e634addc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383038Reviewed-by:
-
Joe DeBlasio authored
This CL is a small tweak to allow us to tune whether or not the keyword matching heuristic applies to the e2LD or not. To maintain current behavior, the default value of the parameter is kept to true. Fixed: 1123151 Change-Id: Ifc85b464776e874a24fe4ec69be6c2aae0960eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382404 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#802886}
-
Palak Agarwal authored
Bug: 974149 Change-Id: Ie4753ea473fbfd8448d772c1e07d440e74085ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377718Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Palak Agarwal <agpalak@chromium.org> Cr-Commit-Position: refs/heads/master@{#802885}
-
Darwin Huang authored
Update the comment and explain it a bit better. Bitmaps have been supported in the Native Android clipboard since https://crrev.com/c/2147890. While I'm unsure of the first instance of this comment, an early iteration is active in March 2012(https://crrev.com/9264014), and a recent, more well-documented change that expanded this comment is available here(https://crrev.com/12633009) Change-Id: I192d3abd050577c026f126ed99c9d9313756555c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382881 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#802884}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f609a00aca46..4720732dc405 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1098447,chromium:1117068,chromium:1119885,chromium:1123108 Tbr: Change-Id: I61aa66525971132dc34a414afd392f1c28509081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383037Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802883}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6ec121d8c3d5..459271df6a8a 2020-08-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I81192f9c1d1910f3ef06c02f0cb2a37745506075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383036Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I0c067c8b927baae4ce5c81dde91bbd1d45df635b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382813 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Puthikorn Voravootivat authored
Add proto for power manager to provide thermal hinting to Chrome. Bug: 1081959 Test: See ThermalEvent in chrome://device-log chromeos_unittest --gtest_filter=PowerManagerClientTest.ChangeThermalState Change-Id: Ie7435852da01a5acf3580b5bb569ba117113f658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300983 Commit-Queue: Puthikorn Voravootivat <puthik@chromium.org> Auto-Submit: Puthikorn Voravootivat <puthik@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#802880}
-
Kramer Ge authored
create_immed is available since protocol version 2. Exo is at version 2. This method implicitly enables committing a frame of buffers atomically. Change-Id: I46c25af1e257dbef68cc3c810a87ba2dd10b26ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381652 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#802879}
-
Aaron Leventhal authored
Often, the AX Object Cache will be called with a children changed that is immediately followed by a text change on the same node. Since children changed processing is a superset of text changed processing, the extra text changed processing can be removed in this case. Also, since children changed processing is a superset of text changed processing, reuse the code in AXNodeObject::TextChanged() rather than repeating it in AXNodeObject::ChildrenChanged(). AX-RelNotes: performance improvements Bug: None Change-Id: I82fa983620b36a99f755017f576fddf85d7a5cd9 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360319 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#802878}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb235b33d3dd..f609a00aca46 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mek@google.com Change-Id: I7ef36658b5380598760b6eda34cf5a2dddd3899c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383031Reviewed-by:
-
Rulong Chen（陈汝龙） authored
One large favicon might cause an OOM crash when it is converted to a Java-backed Bitmap in Android. Failing to render the favicon still seems preferable than *ever* crash here. R=torne@chromium.org,boliu@chromium.org Bug: 1112794 Change-Id: Idca46d2e1484ce4538b79e8df6910de7b18ef1f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376929 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802876}
-
Dirk Pranke authored
The "generic_wrapper" scripts now being generated during the build need to know whether or not to use Xvfb when running a test; this CL adds that logic. Bug: 816629 Change-Id: Ic2cae1295d7edf583236d6d2640c220c883324ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370507 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#802875}
-
Maksim Ivanov authored
Enable for Chromium the "bugprone-use-after-move" diagnostic provided by clang-tidy. This check attempts to catch bugs when a C++ variable is used after it was std::move()'ed elsewhere. This diagnostic was discussed at https://groups.google.com/a/chromium.org/d/topic/cxx/IDD4f6Pmnxc/discussion (see also the doc attached to that thread). Bug: 1122844 Change-Id: I9aa1996dcac8307259d86821ce7b4f5cf2175dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383010Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#802874}
-
zhaoyangli authored
Replicated iOS 13.6 form factors to iOS 14 in the full-configs CQ bot. Moved iOS12 runtimes on full configs bot to ios-simulator-noncq for capacity restrain. Bug: 1123108 Change-Id: I34109ef9278b916de94457b12f4c247eac54d073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382223Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#802873}
-
Richard Knoll authored
This removes all hardcoded strings from the HTML WebUI files and adds proper strings to the grdp file. Also replaces the button to configure the device name externally with an inline edit control. Bug: None Change-Id: Ibd2a17b5b9b8234633399fd6c50fae11fc15e45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376857 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#802872}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9100465414a9..5ac807b26749 2020-08-28 cclao@google.com Vulkan: Let stageSubresourceUpdateAndGetData use ctx staging buffer 2020-08-28 jmadill@chromium.org Enable -Wreturn-std-move-in-c++11. 2020-08-28 jmadill@chromium.org Enable -Wbad-function-cast. 2020-08-28 timvp@google.com Add third_party/abseil-cpp to ANGLE 2020-08-28 cclao@google.com Vulkan: Fix alignment issue with context staging buffer 2020-08-28 lehoangq@gmail.com Metal: Fix handling of vertex attrib offset not multiple of 4 2020-08-28 jmadill@chromium.org Enable two override suggestion warnings. 2020-08-28 cnorthrop@google.com Capture/Replay: Track groups of strings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Test: Test: Manhattan MEC works again Change-Id: Ic6832b238622ddf56538b74026ca8185cb59a9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382699Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fb7c6ea5..4b3de99d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iad218fcbb8d2f936003619ed6f262dd3841e0620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382911Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802870}
-
Peng Huang authored
This is a reland of a37811d1 Original change's description: > SkiaOutputDevice: use buffer format passed to Reshape > > Bug: 1108406 > Change-Id: Iaca79e3b6c1d66e421711c46f75a1cb614b7f961 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378745 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802450} Bug: 1108406 Change-Id: Iec517b1f5b711d9457a09841cedd2db22b520aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382197Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#802869}
-
Andrey Kosyakov authored
This reverts commit 82b85893. Reason for revert: let's give this test another change. it seems to reliable pass for me locally and I think the original failure was rather due to a front-end race fixed here: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2242769 Original change's description: > Revert "DevTools: add tests for extensions on DOM UI pages" > > This reverts commit 3c0f2556. > > Reason for revert: test is extremely flaky > > Per https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUgsSBUZsYWtlIkdjaHJvbWl1bUBicm93c2VyX3Rlc3RzQERldlRvb2xzRXh0ZW5zaW9uVGVzdC5UZXN0RXZhbHVhdGVPbkNocm9tZVNjaGVtZQw this flakily fails about 10 times an hour. > > Original change's description: > > DevTools: add tests for extensions on DOM UI pages > > > > This is the chrome-side counterpart of > > https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2128732 > > > > Bug: 1059577, 795595 > > Change-Id: Iec2ee772a42b4c7bc2249627c0839f7506f0cd1d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129344 > > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#756375} > > TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org,caseq@chromium.org,bmeurer@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1059577, 795595 > Change-Id: I2919088167b064086b315d8c3a64df569d95c844 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188512 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#766575} TBR=dgozman@chromium.org,mek@chromium.org,rdevlin.cronin@chromium.org,caseq@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1059577 Bug: 795595 Change-Id: Ibd719500160685664de90415d718b88b4621b52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382487Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#802868}
-
Himanshu Jaju authored
Removes pending TODO and implements the test for registering a send surface when we are already receiving incoming files. Change-Id: I9dd8955b4c423ed6b567ebb2028ed839b9a1f63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382753 Auto-Submit: Himanshu Jaju <himanshujaju@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
-
Austin Eng authored
Mapped GPUBuffers' memory is owned and externally managed by dawn_wire. Using EmptyDeleter tells the backing store this allocation does not hold memory and will not increase GC pressure. Bug: 1061960 Change-Id: Ia44a5dc1be89d7b55540247c90bce614172fa2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380086 Commit-Queue: Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#802866}
-
Lei Zhang authored
Make PrintViewManager::PrintForSystemDialogNow() consistent with PrintViewManagerBase::PrintNow(). Disconnect from the existing print job before starting a new one. Bug: 704900 Change-Id: I40a2fae0f22651be489596c34c448b84c1665503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382615Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#802865}
-
Daniel Classon authored
This is a reland of dd30c5d1 Change was unrelated to the test failures. Original change's description: > [CrostiniPage] Link "Set up Crostini" search result to the setting > > Fix a bug where the "Set up Crostini" search result did not connect to > the eponymous setting, so the setting was inaccessible for deep linking. > > Bug: 1084154 > Change-Id: I0b5452425eb19203c61c8b45ba4d2d96afc16264 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380749 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Daniel Classon <dclasson@google.com> > Cr-Commit-Position: refs/heads/master@{#802704} TBR=khorimoto@chromium.org,dclasson@google.com Bug: 1084154, 1123194 Change-Id: Ia08b6010bba1975e446174c552f465d4d5d49765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383091Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
David Black authored
This delegate is the first of the `HoldingSpaceKeyedServiceDelegates` to be added. A follow up CL will refactor existing service logic into a `HoldingSpaceDownloadsDelegate` and `HoldingSpacePersistenceDelegate`. The delegate added in this CL is tasked with watching the local file system for changes to files backing holding space items. It notifies the service on file removal so that it can perform model updates. Currently, a watcher is added per file but this will later be changed to a single watcher per directory. This CL is mostly concerned with getting things in place and additional optimization can come later. Bug: 1122418 Change-Id: I9a796bd1318268a62e0c7227a9a299b566cc2ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382399 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802863}
-
rbpotter authored
Fixed: 1123220 Change-Id: Iefc01cc978f6aff863f3c4244c32ed57b137df59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382884Reviewed-by:
-
wutao authored
Bug: b/164190937 Test: manual Change-Id: I8b2f4bf1ec90cb1869add3f1f71c8b96175589a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382214 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802861}
-
nancylingwang authored
The new app icon factory code in AppService calls display::Screen::GetScreen to get the scale, so in unit tests, sometime, it crashes: 0x7f3430a96390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) #4 0x558ca24e91ea (anonymous namespace)::GetPrimaryDisplayScaleFactor() Modify unit tests to set the TestScreen. Built bots run 20 times, and there is no flaky tests for BuiltInAppTest.Build. BUG=1115837 Change-Id: Id3ad017f5e15dbadfc6b28ef0d65295bfcc799b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379419 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802860}
-
Thomas Guilbert authored
WebCodec already has UseCounters on its different subcomponents. Origin trial infrastructure cannot aggregate UseCounters. This CL adds a global counter that tracks anytime WebCodecs is used, to allow running an origin trial. Bug: 1123170 Change-Id: Ic8c816d99af16c78a50ebc16d693362368a7483b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382408 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#802859}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ae1672bdb5c3..6fd391a016f3 2020-08-28 herb@google.com uv in x - fix iphone6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ia54f3d5e2bd63b26676d4a830693a371bdf3198f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382018Reviewed-by:
-
Brandon Jones authored
Blink counterpart to https://bugs.chromium.org/p/dawn/issues/detail?id=502 Due to an issue with Blink's bindings generation this CL needed to be a bit sneaky about handling the method overloading, which resulted in some annoying manual validation. The alternative, however, would be exposing a different method name which would add several more steps to the whole deprecation process, so this feels worthwhile. Bug: 1121762 Change-Id: I3f4ac324c6d91a27bfd5fabb17b1b142f7021598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376456 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I93ca2df444e6277bfe02c22ac19666f0a137896b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383231Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802856}
-
