- 08 Oct, 2020 40 commits
-
-
Yoshifumi Inoue authored
This patch makes |LayoutText::PositionForPoint()| to find text fragment considering line height to return valid |Position| for point between lines. Example: <style> #container { font-size: 10px; line-height: 3; font-family: Ahem; width: 5ch; // to break line after "line1" } </style> <div id=container>line1 line2</div> In this example, we have two line boxes: line1 box: {0,0}x{50,30} "line1" {0,10}+{50,10} line2 box: {0,30}x{50,30} "line2" {0,10}+{50,10} Before this path, |LayoutText::PositionForPoint({10,30})| returns "line1 line2"[0] instead of "line1 line2"[7] because text fragment "line2" doesn't contains {10,30}. After this patch, we find the line contains {10,30} then locate fragment in line by using inline offset e.g. x-coordinate for horizontal writing mode, y-coordinate for vertical writing mode. Bug: 1133786 Change-Id: I7f76aadf6e1be4c3d8517562242158fadf5f2876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452169 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#815070}
-
Julie Jeongeun Kim authored
The request id could not be set from PrintRenderFrameHelper when it calls PrintPreviewFailed(), PrintPreviewCancelled(), or PrinterSettingsInvalid() as the request id is set from |print_pages_params_| and it could be null. This CL adds early return when the request id is -1. Bug: 1136025 Change-Id: I06caaef4050653ddb9ff82b477a74600e9796a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455826 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#815069}
-
Rainhard Findling authored
Bug: 1087263 Change-Id: If6f8928141ee1569cf522fe738403143a4197bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442735Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#815068}
-
Alan Screen authored
Adding support for PrintBackend queries to happen out of the browser process requires related data structures to be made available via a Mojo interface. These are moved into their own mojom file separate from the common definition in printing/mojom since they are specific to a new process being introduced and do not need to be encumbered by the dependencies which exist for print.mojom. Starting with the historically most prolific cause of browser crashes from printing (GetPrinterSemanticCapsAndDefaults), work towards having support definitions to enable that query to be moved out-of-process. Add the mojo definition for PrinterSemanticCapsAndDefaults to expose the needed structure for the query. Bug: 809738 Change-Id: Idf971066982ff989668e1b227276b13844e7a054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387545 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Bettina Dea authored
After clicking on the Enhanced Protection promo on desktop, the Security settings page should open with the Enhanced Protection section expanded. Bug: 1130722 Change-Id: I646566199755862055e8be0fba00259ecf48d704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454404Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#815066}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I58b94352a5f4cb28c144f5b2089a91caecb4c3b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460752Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815065}
-
Hidehiko Abe authored
Currently OS_LINUX is defined on Chrome OS build, but it will be unset. This is preparation ot keep the current behavior. Bug: 1110266 Test: Built locally. Change-Id: Ia587de5b23cbe6e6622c0a9aaa918880d9762d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449654Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#815064}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602115190-7131f9189957170a35177f66dc087c48158aec91.profdata to chrome-linux-master-1602136563-0d72642499ba1a8379313d017bceff00a59e9e7c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I030a5a8ab31eacb7d2f486660aef3d6970f93b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460240Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815063}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602115190-6522495ca352d45be49e234f0c6bf7d20bdcb906.profdata to chrome-mac-master-1602136563-35c37307a75e48d8d50dea3abef2bbe00d3f301f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7fd3bf5cf8996187a2376379235daa21fafe630a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460550Reviewed-by:
-
Takashi Sakamoto authored
If use_ozone=true or use_x11=true, we need //ui/base:features. Change-Id: Id3ba57d5205c17de3c1f10230639e58131e8ea93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459945Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#815061}
-
Felipe Erias authored
Update LayoutBlockFlow::DetermineLogicalLeftPositionForChild to correctly take into account all the cases where the width of the logical left scrollbar may be different from 0. This fixes a problem where the "both" value of scrollbar-gutter was producing the wrong layout when LayoutNG was disabled. Bug: 710214 Change-Id: If3481ff2486fc3a7a447b892edc8ef98fa658f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459793Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Felipe Erias Morandeira <felipeerias@gmail.com> Cr-Commit-Position: refs/heads/master@{#815060}
-
Reilly Grant authored
This changes the documentation for the WebUsbAllowDevicesForUrls policy to clarify when it is referring to a field in the JSON object that must be specified by the administrator. Bug: b:170255974 Change-Id: I23cdfa5fecdc8001df8d195fc1c63a529d60bc81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459935 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#815059}
-
Colin Blundell authored
//chrome currently defines and tracks metrics related to user interactions with the subresource filter feature. This CL componentizes the definition of these metrics in advance of componentizing some of the code doing the tracking (e.g., the ads blocked infobar) for reuse in WebLayer. Bug: 1116095 Change-Id: If9033d2aa4e2714b4610974409d1fdb179578740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456608Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#815058}
-
Sven Zheng authored
We hope the crash might get fixed by using newer win version. Or at least we can have DLL symbols for debugging. Bug: 1123944 Change-Id: Ib8dfdfe99c166bbf692d7014b4bec4832357b767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454311 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#815057}
-
Makoto Shimazu authored
Ozone also includes ui/base/ui_base_features.h. Added a dependency of //ui/base:features. TBR=hashimoto@chromium.org Bug: 1136388 Change-Id: I2a8f4f3ba449f089b46710dc52562ab6b5898f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460255Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815056}
-
Klaus Weidner authored
Instead of using a heuristic to estimate how long ARCore's update is expected to block, place a GLFence after rendering and check its status to decide when the rendered frame is complete. Change-Id: I60de470302127d619ae1cfd44d194c7ed284fd70 Bug: 1136276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459230 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#815055}
-
Olga Sharonova authored
This reverts commit a5354ff6. Reason for revert: multiple crostini tests failing with "Failed to take screenshot by Chrome API: cdp.Runtime: Evaluate: context deadline exceeded.". Examples of first failing builds : https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/10585, https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/29400, https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/10585. Original change's description: > Move the entire modeset operation to Plane Manager Commit > > 1. Set all props for CRTC, Connector and Plane to Plane Manager to Commit. > 2. Maintain a consolidated path to modeset both Atomic and Legacy. > 3. Simplify CRTC Controller by removing all modeset operations and maintain its state from PlaneManager::CrtcState. > 4. This makes all CRTCs on the same hardware display controller to be modeset at the same time. > > BUG=1082882,1015104 > TEST=hardware_display_plane_manager_unittest > > Change-Id: I2401a1b40ce74158416484e6418239d5fb8c1c25 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429586 > Commit-Queue: Mark Yacoub <markyacoub@google.com> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814933} TBR=dnicoara@chromium.org,markyacoub@google.com Change-Id: If2d243c39d9d4940113b4c46382c1ad6635f9c83 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082882 Bug: 1015104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460807Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#815054}
-
Harvey Yang authored
This commit adds fake classes: FakeSensorService and FakeSensorDevice in chromeos/components/sensors to add unit tests of sensor clients in Chromium, such as ash/accelerometer and Generic Sensor. BUG=chromium:1006141 TEST=unit tests of ash/accelerometer Change-Id: If4cab4907a3db0e84214ec274ce9dab0a7f2cc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449311 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
-
Bartek Nowierski authored
There are two functions named GetAllocatedSize, but return different value. Improve comments while at it. Change-Id: I5aef0fbf8f63bf94f184b85d40187363e05b08db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455947 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Eric Willigers authored
The tests in app_service_app_model_builder_unittest.cc no longer need to support bookmark apps, as DesktopPWAsWithoutExtensions has shipped. Bug: 1065748 Change-Id: I0da59a448fa5fab619c10fdb4bd6f761ef8bca15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454554 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#815051}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/36ccb695bd6b..1a87f1f025ef 2020-10-08 syoussefi@chromium.org Add a test for deferred clears and 0-sized scissor clears If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ibadd22634eb171c00f99d3896320c602d62eaa17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460546Reviewed-by:
-
Colin Blundell authored
There is currently a check for the subresource filter feature being enabled that gates whether //chrome attaches a ContentSubresourceFilterThrottleManager instance as a tab helper. This CL moves the check to inside ContentSubresourceFilterThrottleManager::CreateForWebContents() itself to (1) ensure that all //chrome-level invocations of this method respect the state of the feature, and (2) ensure that //weblayer also transparently reflects the state of the feature in this flow once the ThrottleManager is brought up there. This CL also adds a relevant //components-level unittest. Bug: 1116095 Change-Id: Iadfe6e40979307746e9573da85b05ea1306dfd7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456526Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#815049}
-
Ewann authored
This CL adds ExtendOpenInFilesSupport to the fieldtrial testing config Bug: 1117398 Change-Id: I9d52da7c57e101b1e2607b0c9c6e700e9415468c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454075Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815048}
-
Hayato Ito authored
Add path restriction so that this matches the recent change [1] of the explainer. Subresource path restriction is: > its [path](https://url.spec.whatwg.org/#concept-url-path) contains > the bundle's path as a prefix, Note that the explainer says "the bundle's path as a prefix", however, this CL uses "the bundle's path *without a filename* as a prefix" as subresource path restriction. For example, if a bundle's URL is "https://foo.com/dir/foo.wbn", a subresource's path should contain "dir/", instead of "dir/foo.wbn", as a prefix. We'll update the explainer to match the implementation. - [1] https://github.com/WICG/webpackage/pull/601. Bug: 1082020 Change-Id: I9c2d25108c4169310c395372ac8f7ae74c6a7325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460366 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#815047}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/306f83589eb0..c267a5583028 2020-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I2b23ba5a807f4e259b1ea3e910d28b94f0e2d744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460585Reviewed-by:
-
Prakhar authored
Bug: 1024915 Change-Id: Ie78693d6b88d6d852144aaac755009954e6ab941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423672 Commit-Queue: Prakhar Asthana <pasthana@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Prakhar Asthana <pasthana@google.com> Cr-Commit-Position: refs/heads/master@{#815045}
-
Noel Gordon authored
◑ Install upstream emscripten at version 1.38.33 (git hash 7e841b5) ◑ Pull upstream android.googlesource.com PIEX (git hash 6672dab) ◑ % make clean && make, run tests PASS ◑ Binary size: reduced by 1.3 kByte ◑ Assess performance: unchanged Test: browser_tests --gtest_filter="QuickView*FilesAppBrowserTest*" Bug: 1132695 Change-Id: I52787b1b9ac31a927899672261895037e8cc3bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460570Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#815044}
-
Gavin Williams authored
Update the tests to expect Save to Drive being a default destination on Chrome OS. Bug: 1112416 Change-Id: I548cb97b1fa07a43d5fd4553786f05a56fb08a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440986 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#815043}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6f4898e52832..cdd72c9222b3 2020-10-08 szuend@chromium.org [ts] Type-check network/NetworkDataGridNode.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6cc3725f971411fb214deff9a5dfed22587ffe2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460545Reviewed-by:
-
Christopher Cameron authored
Pass the color space from CoreMedia or CoreVideo to the FrameReceiver, and to the rest of the pipeline. Prefer to use the ColorSpace specified by the CVPixelBuffer over the CMSampleBuffer. Of note is that on macOS, the default capture transfer function is BT709_APPLE (gamma of 1.961) which is different from regular BT709 (sRGB transfer function, in our interpretation). This fixes a bug whereby the colors of a captured IOSurface are different based on if it is being composited by CoreAnimation (in which case it getting the BT709_APPLE via IOSurface metadata) versus viz::GLRenderer (in which case it used to be defaulting to BT709). Bug: 959962 Change-Id: Idb2fdab39e4b4b292932c9bdb2f62dd3f662d4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459690Reviewed-by:
Markus Handell <handellm@google.com> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#815041}
-
My Nguyen authored
We need to show users "Learn more about suggestion" option in VK as per b/166670314 so adding the api to open the suggestion page in Chrome OS settings app. Drive-by: - Rename IsLanguageSettingsEnabled to IsSettingsEnabled because it only checks that. - Add VirtualKeyboard.OpenLanguageSettings to separate metrics between opening settings from VK and from system tray. Bug: b/166670314 Test: Manual test Change-Id: I25d138fb04e96812db80e5e918b51c69b98aa9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455077Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#815040}
-
Takuto Ikuta authored
Change-Id: Ieced88baa380ba8952385b67035f50547b364cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460530Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#815039}
-
Jacobo Aragunde Pérez authored
Bubbles that extend LocationBarBubbleDelegateView have the member function ShowForReason, which may show them in an inactive way when they are not displayed as a result of direct user action. Bubbles displayed in an active way would get focus and ATs would immediately read them, so their role would be a dialog. Likewise, bubbles that show inactive would not get focus and we need them to behave like alert dialogs so ATs can announce them properly. This fixes several bugs: * crbug.com/1119367: the save credit card bubble was not announced because it didn't have the alert dialog role. * crbug.com/1119734: the translate page bubble was not announced because it didn't have the alert dialog role. * crbug.com/1132318: the password bubble was read twice because it was getting focus in addition to sending an alert event. properly announce save credit card bubble, properly announce translate page bubble. Bug: 1119367, 1119734, 1132318 Change-Id: I1c46d65ec2a47a25947f6a75a8935595d974bfa1 AX-relnotes: Do not read password bubble twice when explictly opened, Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431526Reviewed-by:Allen Bauer <kylixrd@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#815038}
-
Brandon Wylie authored
The dependency was removed in crrev.com/c/2438639, but the exception wasn't removed. Bug: 1123209 Change-Id: I65b1557d8458ffc150d7f36dfb6aa323ada999f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453505 Commit-Queue: David Trainor <dtrainor@chromium.org> Auto-Submit: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. SystemWebAppManagerTest tests have replaced the corresponding bookmark app tests. Bug: 1065748 Change-Id: Iacdab45883210bd5b74b21eba72e07a8fdfb12e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455466 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#815036}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602039546-1494d436e25ae807c20aabdd04cfd168e713ca95.profdata to chrome-win32-master-1602104345-f59e702ee5ca3195d69eeaf0b87216343ca1f336.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icc4a2ed3dbac3336cb37abf9ea9782981441b271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459887Reviewed-by:
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. The test no longer needs to be parameterized Bug: 1065748 Change-Id: I961a892e59aa651bd81a48cb3467746fc5c60e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454921 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Wei Lee authored
This reverts commit 79e008a0. Reason for revert: The CL is reverted but the failure (SystemWebAppManagerUpgradeBrowserTest.Upgrade/WebApps) does not fix: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9028 So it is very likely that the CL is not the culprit. Original change's description: > Revert "[CCA WebUI] Don't capture navigation other than main page URL for CCA" > > This reverts commit ab12c6e3. > > Reason for revert: Breaks browser_tests: SystemWebAppManagerUpgradeBrowserTest.Upgrade/WebApps > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9011 > > Original change's description: > > [CCA WebUI] Don't capture navigation other than main page URL for CCA > > > > We have the following requirements: > > 1. We prefer loading CCA UI in the app window rather than browser tab > > => Therefore we added "capture_navigation=true" for CCA > > 2. We don't want to load resource URLs or invalid URL in the app window > > => Short term: Landing this CL to filter out unwanted URLs > > > > We decide not to support URL filtering feature for capture navigation > > since only camera app has such requirement at this moment. > > (crbug.com/1132151) > > > > Bug: 980846 > > Test: Type CCA url other than chrome://camera-app/views/main.html and > > the page is loaded in browser tab > > > > Change-Id: I467aa1498aa9fe975d34bdf82adee7f6dff6a14c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440076 > > Commit-Queue: Wei Lee <wtlee@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Reviewed-by: Jiewei Qian <qjw@chromium.org> > > Auto-Submit: Wei Lee <wtlee@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#814557} > > TBR=ortuno@chromium.org,wtlee@chromium.org,qjw@chromium.org > > Change-Id: I12e4bbd7ee461e7ed0a3d0664e90ca3e4ea435f9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 980846 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457586 > Reviewed-by: Ella Ge <eirage@chromium.org> > Commit-Queue: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814741} TBR=ortuno@chromium.org,eirage@chromium.org,wtlee@chromium.org,qjw@chromium.org # Not skipping CQ checks because this is a reland. Bug: 980846 Change-Id: Ia0244f12f8d12c03184b73c27e374072b8c76b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460250Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#815033}
-
Makoto Shimazu authored
This reverts commit 3c5a2dff. Reason for revert: All/SystemWebAppManagerUpgradeBrowserTest.Upgrade/WebApps consistently fails and this CL touches web_applications and makes substantial changes. Let me speculatively revert this CL. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9011 is the first build that we see the failure. Original change's description: > PWA on Desktop Windows: Implement uninstallation via OS settings. > > When user uninstall a PWA from Windows Settings or Control, it also > uninstall PWA from browser registrar. > > The detailed design spec: > https://docs.google.com/document/d/1XjFYnHXCJt08UsbWrQKw5vLW3_vQumOPrB7A9bpHq_s/edit?usp=sharing > > Bug: 957043 > Change-Id: I927213c847033ddf5767679f3d7081d2c6760343 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316848 > Commit-Queue: Sunggook Chue <sunggch@microsoft.com> > Reviewed-by: Phillis Tang <phillis@chromium.org> > Reviewed-by: Ben Wells <benwells@chromium.org> > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814546} TBR=gab@chromium.org,dmurph@chromium.org,benwells@chromium.org,loyso@chromium.org,tmartino@chromium.org,grt@chromium.org,sunggch@microsoft.com,phillis@chromium.org,johnjan@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 957043 Change-Id: I14559730f89d0334bb417be9e4ec128950313fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459309Reviewed-by:
-
Hiroki Sato authored
This change exposes the docked magnifier preferences via extension API. Bug: 1125420 Test: browser_test ChromeOSInfoPrivateTest Change-Id: Id38a8a486e8c082e8f5d7973332f1fb8f26673d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409072Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#815031}
-
