- 25 Jul, 2020 40 commits
-
-
Siye Liu authored
On Windows platform, omnibox has a special handling that if the input method is Chinese, Japanese or Korean, then the input type of is changed to TEXT_INPUT_TYPE_SEARCH. We should notify input mothod that the input type has been changed. Bug: 1108845 Change-Id: I0266d9617277696ccb8bfa42ad76f9cbc3d802f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314686 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#791443}
-
Sadrul Habib Chowdhury authored
Presubmit API is changing: . input_api.DEFAULT_BLACK_LIST -> input_api.DEFAULT_FILES_TO_SKIP Update the presubmit scripts for cc and viz accordingly. BUG=1101491 R=kylechar@chromium.org Change-Id: I40963a559aa0f519bfe3925c535a8dd6ca7cdfe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316928Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#791442}
-
Xiaohui Chen authored
Bug: b:156522092 Change-Id: Ia43529bfd8372db5c9f2362715db742fd356b940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315246 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#791441}
-
Chris Harrelson authored
The callsites are not needed, and just need to either call PaintInvalidationOnCompositingChange directly or be removed, because PaintInvalidationOnCompositingChange was going to be called later because the PaintLayer was going to be added to layers_needing_paint_invalidation anyway. When PrePaint is moved before compositing, we should be able to get rid of the remaining two callsites to InvalidatePaintIncludingNonCompositingDescendants. Change-Id: I012a1319f1ad0afbbcbf4024b35f1c2b7a222c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316949Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791440}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I20b06a7fa762d6b9d5f0c46739eff4c253b24d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316290Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791439}
-
rbpotter authored
These tests are occasionally failing with timeouts, and seem slow when run locally in a debug build, so split the tests into 3 suites instead of one to reduce the chances of timing out. Also re-enabling a test case that no longer appears to be flaky, and adding closure compilation for this test file. Bug: 1000989, 1060981 Change-Id: I8d6f17bc398e40b9585f3f21c8e30e75565a126d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316856Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#791438}
-
Sven Zheng authored
Disable for pixel test suites. This test is flaky even when pixel verification is not enabled. Bug: 1108988 Change-Id: I1c5b09fc340d2ee9cb89c6b6b4540671ce66f29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316786Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#791437}
-
Marijn Kruisselbrink authored
Makes sure quarantine is invoked whenever a file is successfully moved, even if the writer itself happens to be destroyed during the move operation. Bug: 1108091 Change-Id: I809f0238870315d54f103fd5a3d27ba747ba2a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311416 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#791436}
-
Tommy Nyquist authored
An earlier refactoring CL had a side effect that lead to the VersionConfig data not being stored to disk anymore, which meant there was never any data available. This CL adds back storing the VersionConfig the same times as the code before the refactor did. Two regression tests are also added to ensure we continue to store the data going forward. Bug: 1095755 Change-Id: Id285758db0d37e0ef05cefe51c18bd4895b2744e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317170Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#791435}
-
Yuwei Huang authored
Turns out I just accidentally deleted the register_request creation code. Bug: 1103416 Change-Id: I99e0a8e54be01ebe3aef29e1051840b36a1277d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318051 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#791434}
-
Garrett Beaty authored
This reverts commit cb86ee41. Reason for revert: Restoring full functionality Original change's description: > Remove GPU's Linux tests from the CQ. > > The datacenter holding GPU's bots is offline, so these CQ tests are > stuck. Remove them from the CQ while we work on getting ATL back online. > > TBR=gbeaty > > No-Try: true > Bug: 1108842 > Change-Id: I3833475c71d7f79380c22303c989d05baf2fd8fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316438 > Reviewed-by: Haiyang Pan <hypan@google.com> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#791275} TBR=estaab@chromium.org,gbeaty@chromium.org,hypan@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1108842 Change-Id: I7da7f5d8bb91a4d9e5f6fe50ca97dbd0be0dbd89 No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318509 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#791433}
-
Lei Zhang authored
They are inactive on Chromium. Change-Id: I3a02442bf520a1b619fabea8cc741b58a930106b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315821Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#791432}
-
Rahul Arakeri authored
This CL refactors InputScrollElasticityController and introduces 2 new subclasses - InputScrollElasticityControllerBezier will be used for managing Windows based overscroll and bounce back. The other subclass InputScrollElasticityControllerExponential will be used on Mac for the same purpose. The CL also allows an overscrolled root scroller to "bounce back" via an animation based on a Bezier curve. This animation is driven by OverscrollBounceController::Animate. The duration of this animation is determined by how far the scroller has been stretched. At every "tick" of the animation, the progress of the animation is determined based on the elapsed time. Animating flings will be added in a follow up CL. Bug: 1058071 Change-Id: Ia4278105eac5cadae191a50c25654c88a92c5a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231254 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791431}
-
James Long authored
A few UI controls have been added with the aim of making edge directions easier to see in the visualization. * Curve checkbox: Determines if edges should be curved to the right of their direction. * Color on hover checkbox: Determines if the edge colors should only be shown when hovering on a node that touches those edges. * Color scheme dropdown: Various preset color schemes determined to work well. Bug: 1106107 Change-Id: I15585251ad1ef3eef4b16e1ce536a1b1f527868c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314818 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#791430}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/ba92b11e1fca..ff8fe2df3529 2020-07-23 dneto@google.com Use the non-posix MinGW compiler as fallback (#1117) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I69fae3d9bc784205128c26f92794e50fe1294d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315811Reviewed-by:
-
Yi Xu authored
Moved 7 more tests from fast/canvas to wpt tests: Deleted 2 due to duplications, canvas-context-attributes-default-value.html and canvas-ImageData-behaviour.html, created 5 new tests. Bug: 1071659 Change-Id: Ib439525798a4fe899d77a5469dc5590bbc8be5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314991Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#791428}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I6a09abce38e97b5ff0c04fb9eec29d39f1494adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317763Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#791427}
-
Lijin Shen authored
This reverts commit 61ac41eb. Reason for revert: Constant failures on checking components/browser_ui/strings/android/browser_ui_strings.grd Original change's description: > Add presubmit to detect inappropriate punctuation usage in strings > > Google material standards usually prefer curly double/single quotes to > neutral quotes. The presubmit detects these punctuations in string > resources and then prints warnings. > > Bug: 1100941 > Change-Id: I2b21c146be352b6857e55b3dd9c4bb5f27a9e5c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290774 > Commit-Queue: Lijin Shen <lazzzis@google.com> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788187} TBR=twellington@chromium.org,agrieve@chromium.org,lazzzis@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1100941 Change-Id: I8f981e9afd3f42e5f054cf636b39852542bbe987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317775Reviewed-by:
Lijin Shen <lazzzis@google.com> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#791426}
-
Tarun Bansal authored
(i) If the mainframe is ineligible (e.g., if it's a non-http/https) page, then skip recording metrics. (ii) Update main frame navigation ID on same-document main frame navigations Bug: 1109068 Change-Id: I839393b607b6c2d090ff75ae927be7049fa4cd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317167Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#791425}
-
Maxim Kolosovskiy authored
Bug: 1108692 Change-Id: I86a4d8618cd36563b1819ede1a6c7c734f96a1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315865 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#791424}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f89cfd4944e..df7cabc2cd02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC melzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1077274 Tbr: melzhang@google.com Change-Id: I4dcf697c5b8f2c026395e73cfa47b8bb601c6fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316251Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791423}
-
Kenneth Russell authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/a503e42..803227b Bug: 1097235 Tbr: jdarpinian@chromium.org Tbr: shrekshao@google.com Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: I256ec579eef86885e20a183806b30aad58f812c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318649Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791422}
-
Nina Satragno authored
Add a dark mode version of the fingerprint checkmark animation and use it in cr-fingerprint-progress-arc when dark mode is enabled. The animation looks bad with a dark background otherwise. Since we're using MockController on a test that is closure-compiled, fix all its compilation issues. See the bug for screenshots. Fixed: 1041877 Change-Id: I7d7fcdb01c372038c8580cdad1c7177fdc16ac80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290779 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#791421}
-
Sangwoo Ko authored
ui::ImageModel should be preferred to ImageSkia. There's no intended behavior change. Bug: 1048901, 1100034 Change-Id: I3ab2e538bb12136c74cb12db5712eb47a7b21074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315372 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#791420}
-
ssid authored
This is to verify that we currently do not create any database in incognito profile. Support for in-memory database for incognito will be added in future. BUG= 1109349 Change-Id: I7dbda9226c207315a4b6b807fac2791f45b89725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303436Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#791419}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595634856-273b35e9c5e7a1fe88efc52ccb79b7a01140c642.profdata to chrome-mac-master-1595656565-f8273935e4463fa6320c26f96bf11cce31594e4d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I056968a303b532c102b3c9cc58d64c622c4618fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318987Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/921d95386ccd..8c11e26c0dfd 2020-07-23 mfoltz@chromium.org [Open Screen] Use racially neutral terminology per style guide. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Id528ba19b3b8b78be894ae989e34807f6be8baec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316289Reviewed-by:
-
Istiaque Ahmed authored
Loading unpacked extension causes an extension to reload quickly, which makes EventsToStoppedWorker test heavily flaky with SW storage migration CL (ref: https://chromium-review.googlesource.com/c/chromium/src/+/2243071). This CL packs and loads the extension instead to avoid the reload. Bug: 1095959 Test: Locally running the test 2000 times didn't flake in cloudtop linux build. Change-Id: I79f37a4e5721d1d995fddb20f31c6efb95066e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318508Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#791416}
-
Livvie Lin authored
If the ShowFullUrlsInAddress bar is set by policy, the "Always show full URLs" context menu item should not appear. Bug: 1092654 Change-Id: I948e34a53abda81a89820399b26162c5678dac55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298324Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791415}
-
Steven Bennetts authored
For release in M86 Bug: 1093135 Change-Id: Id42946691b02ddd3cc281546d3b20953a35ce16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317003Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#791414}
-
Joao Victor Almeida authored
After commit crrev.com/917ce177 introduced the AverageLagTrackingManager some cc_unittests started failing. These test tested scenarios where frames were Drawn but didn't receive a PresentationFeedback on LayerTreeHostImpl. They were failing due to a DCHECK at AverageLagTrackingManager that checked the amount of pending frames without feedback before destruction. These frames never received a PresentationFeedback because LayerTreeFrameSink was purposefully losing its context (LayerTreeFrameSink::OnContextLost). This prevents DisplayScheduler to post the tasks that will ultimately call LayerTreeHostImpl::DidPresentCompositorFrame. In this CL the list in AverageLagTrackingManager is cleaned whenever LayerTreeFrameSink loses its context, as it is a sign that the current pending frames will never receive a presentation feedback. Also, frames that don't have relevant latency_info aren't added to the list anymore as this was one of the reasons why the tests where flaky too. Bug: 1103289, 1104841, 1106020, 1104202 Change-Id: I9b74ac22adb6db6af7c8e727304dc2e0b02e8899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303363Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
-
Yi Xu authored
After verifying the spec, I learned that measureText('A B').width != measureText('A B').width. The spaces do not suppose to collapse: -> Replace all ASCII whitespace in text with U+0020 SPACE characters. -> Then the 'white-space' property set to 'pre'. -> Then Let result be an array constructed by iterating over each glyph in the inline box from left to right (if any), adding to the array, for each glyph, the shape of the glyph as it is in the inline box, positioned on a coordinate space using CSS pixels with its origin is at the anchor point. Update the test expectation accordingly. Bug: 1066953 Change-Id: Ifb9885815f3cbf3d46432107abf16af6ed5b4cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306575Reviewed-by:Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#791412}
-
Eric Orth authored
Documents the implementation and use of host resolution. Remove net/docs/host-resolver.md as it is old, dated, and largely replaced by this newer documentation. Change-Id: Ia440e7593446a1b7af5646c1fd5fd630eee4073d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597224 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#791411}
-
My Nguyen authored
We are merging languages settings in browser into OS settings in Chrome OS, so some metrics are added to track users responses and interactions. This is the first CL, the second CL will add metrics for Chrome OS languages browser settings. Bug: 1106033 Change-Id: I00aa1c7507927622bb7ef8ff51fb811170a8d93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315728 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#791410}
-
Rachel Carpenter authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/hDrQ1hG023-nuNtIIehQNIQY9tTQgBnjI31EiuAFH_sC Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202007230800_RC00.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Ifec04c2cd4b6f9db03b0256ce3e9d7b8c52ddd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316965 Auto-Submit: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791409}
-
ccameron authored
This reverts commit 1849602c. Reason for revert: Caused crbug.com/1093121 Original change's description: > Mac: Don't manually start frame drag on 10.12+ > > On 10.12, the window server is fine initiating a drag without this, so > we end up with two drags starting. > > This actually doesn't fix the teleporting windows bug, but it can't help! > > Bug: 897274 > Change-Id: I2e181659c504c90db0a0928747f5485419728fe8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207980 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771854} TBR=ellyjones@chromium.org,lgrey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 897274 Change-Id: Ie48f7546eed24cc83b82711d7ca3ab0d93dc6c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316851Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#791408}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/038b9b33775b..b7260027e661 2020-07-23 brgoddar@microsoft.com Grid: Display grid line names in the overlay 2020-07-23 jalyn@microsoft.com Only show Network datagrid focus when keyboard-focused 2020-07-23 szuend@chromium.org Revert "Fix path escaping" 2020-07-23 aerotwist@chromium.org List formatter_worker_entrypoint and acorn.mjs in GRD 2020-07-23 mathias@chromium.org Integrate client variations parser 2020-07-23 jacktfranklin@chromium.org Use local `tsc` for cross-referencing script. 2020-07-23 mathias@chromium.org Revert "Integrate client variations parser" 2020-07-23 fawazm@google.com [WebAuthn] Customize authenticator name 2020-07-23 mathias@chromium.org Integrate client variations parser 2020-07-23 aerotwist@chromium.org Adds more cases for TS/GN cross-reference 2020-07-23 aerotwist@chromium.org Adds cross reference script 2020-07-23 leese@chromium.org Fix path escaping If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1034663,chromium:1094436,chromium:1098701,chromium:1100385,chromium:1103854,chromium:1107859 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7378411ad2b464575c7cca04b65ec98841b7874d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316988Reviewed-by:
-
Miguel Casas authored
This CL lands a tiny fix in the DisplayChangeObserver's: we should only fill in the HDR DisplayColorSpaces if the monitor actually supports it. I just stumbled upon it while debugging the next CL in the chain. Bug: 958166 Change-Id: I3ee41501c04b692e12e1e96959a0d6cbf3c7489b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317815 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
-
Renato Silva authored
Extend PinBackend to support the PIN auto submit functionality. PIN auto submit just exposes the user's PIN length in local state when its enabled. Normal users are prompted with a dialog in Settings for their PIN. After checking that the PIN is correct, the length is exposed. Managed users who cannot control the feature have their PIN lengths collected upon a successful authentication attempt. A new method - SetPinAutoSubmitEnabled - was added to allow Chrome OS Settings to control the functionality directly. The basic operations in PinBackend (Set, Remove, TryAuthenticate) were extended so that they now call PIN auto submit subroutines to do additional steps that are necessary for the new functionality. These methods were named PinAutosubmitOnSet, PinAutosubmitOnRemove and PinAutosubmitOnTryAuth. In order to extract the PIN length upon a successful authentication attempt, the call to Cryptohome is now calling the new method 'OnCryptohomeAuthenticationResponse' first, instead of the original caller. All of the PIN auto submit subroutines are guarded by the feature flag, which is disabled by default. Unit tests were added to cover all the possible user flows. Design Document - https://goto.google.com/chromeos-oac-pin-authentication-refinements Bug: 1107367, 1107367 Change-Id: Ie770727c73c9abece174a10fd8c618575f849b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306258 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#791405}
-
James Cook authored
chops recently updated the depot_tools input_api, which makes this possible. input_api.DEFAULT_ALLOW_LIST -> input_api.DEFAULT_FILES_TO_CHECK input_api.DEFAULT_BLACK_LIST -> input_api.DEFAULT_FILES_TO_SKIP For named parameters: white_list/whitelist -> files_to_check black_list/blacklist -> files_to_skip Bug: 1098562 Change-Id: Ie023436a9f86e130a09d214a75c53b6bf97b4a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317770 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#791404}
-
