GitLab

While trying to bullet proof a unit test, I had trouble getting very far when
running all tests in shuffle mode. Tracked that back to a few other tests doing
stuff that accessed Singleton()s outside of a test-scoped
ShadowingAtExitManager. Seemed to me that should be an invariant around any
unit test, so created this towards that end, hopefully helping stabilize out
unit_tests a bit more.

BUG=133403


Review URL: https://chromiumcodereview.appspot.com/10582012

TBR=scottbyer@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10834010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148405 0039d316-1c4b-4281-b951-d872f2087c98

Changed FirstPotentialDefaultEngine histogram to log whether or not we are syncing function is called by FindNewDSP outside of a current sync cycle.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10790153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148404 0039d316-1c4b-4281-b951-d872f2087c98

Implemented the api_index.html and experimental.html pages using an
api_list_data_source.

BUG=131095

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147995

Review URL: https://chromiumcodereview.appspot.com/10815042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148403 0039d316-1c4b-4281-b951-d872f2087c98

According to windbg, it was crashing on this line:
  it->Run(host);
My hypothesis is that one of the tasks modified the task list, corrupting
the iterator.

BUG=138790
TEST=no


Review URL: https://chromiumcodereview.appspot.com/10827003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148402 0039d316-1c4b-4281-b951-d872f2087c98

CID=104369
BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10825015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148401 0039d316-1c4b-4281-b951-d872f2087c98

BUG=118684
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10754014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148400 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10824024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148398 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148397 0039d316-1c4b-4281-b951-d872f2087c98

. Make all instantiators use a single ctor that takes CreateParams.
. Get rid of InitBrowserWindow() and make CreateBrowserWindow() a anonymous namespace function in browser.cc

http://crbug.com/133576
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10692195

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148396 0039d316-1c4b-4281-b951-d872f2087c98

- Adding hook to print device information
- Removing some unnecessary buildbot steps

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10829005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148395 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/webrtc/issues/detail?id=687

Review URL: https://chromiumcodereview.appspot.com/10829012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148394 0039d316-1c4b-4281-b951-d872f2087c98

(-pie is incompatible with -shared and -static)

Review URL: https://chromiumcodereview.appspot.com/10690103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148393 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scherkus@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10825014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148392 0039d316-1c4b-4281-b951-d872f2087c98

It was reverted in https://chromiumcodereview.appspot.com/10807083/ because it unveiled a problem of build_nexe.py on Windows (http://crbug.com/138687).
Now the bug is fixed so submit this CL again.

Review URL: https://chromiumcodereview.appspot.com/10809076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148391 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=
CID=104365
TBR=dmurph@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10828013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148390 0039d316-1c4b-4281-b951-d872f2087c98

This is a direct-submit to put the binary files in their new place (to enable
running try jobs, CQ, etc.).  The real work/review will happen in
http://codereview.chromium.org/10701105/, at which time I'll remove the
corresponding images from their old location.

Also adds the 2x version of textarea_resize_corner.

TBR=tony@chromium.org
BUG=134046
TEST=

Review URL: https://chromiumcodereview.appspot.com/10821023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148389 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138954
TEST=


Review URL: https://chromiumcodereview.appspot.com/10818031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148388 0039d316-1c4b-4281-b951-d872f2087c98

New OOBE boot up sequence revealed an issue when tray was shown on boot, then hidden again.

1. OOBE WebUI is not initialized as it waits for wallpaper animation to finish. That means tray was not hidden by WebUI.
3. Wallpaper animations happens
4. At some point tray is shown
5. WebUI is initialized, tray is hidden.

BUG=133279
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10827009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148387 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise, Clang will warn about the declaration of 'tc_mallinfo' because it has C-linkage, but has an incomplete return type.

This was sent upstream in http://code.google.com/p/gperftools/issues/detail?id=450

BUG=138571
TEST=it builds without warning


Review URL: https://chromiumcodereview.appspot.com/10818025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148386 0039d316-1c4b-4281-b951-d872f2087c98

This change introduces an issue when Shift+Alt  is pressed (http://code.google.com/p/chromium/issues/detail?id=131159).
I'll fix it shortly together with the more general issue (http://code.google.com/p/chromium/issues/detail?id=129834).

BUG=124222
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10829003

TBR=mazda@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10823017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148385 0039d316-1c4b-4281-b951-d872f2087c98

Uses the MessagePumpFactory functionality to install a default message pump in
unit tests.  This allows us to stop hard-coding a default message pump in many
separate tests and instead centralizes the logic.  When tests ask for a
MessageLoopForUI now, they will actually receive a message loop that is backed
by a default message pump, which means that calling Run() and Quit() will work
without crashing.

BUG=None
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10701172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148384 0039d316-1c4b-4281-b951-d872f2087c98

This change introduces an issue when Shift+Alt  is pressed (http://code.google.com/p/chromium/issues/detail?id=131159).
I'll fix it shortly together with the more general issue (http://code.google.com/p/chromium/issues/detail?id=129834).

BUG=124222
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10829003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148383 0039d316-1c4b-4281-b951-d872f2087c98

Second try of https://chromiumcodereview.appspot.com/10815083
BUG=None
TEST=None
TBR=satorux

Review URL: https://chromiumcodereview.appspot.com/10833011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148382 0039d316-1c4b-4281-b951-d872f2087c98

(Reland of 148355 with correct permissions on binary files.)

WebKit and Pepper need this, both define it as a valid image

TEST= http://trac.webkit.org/export/37902/trunk/WebCore/manual-tests/cursor.html and hover over "out grab" and "grabbing". You should see an open and closed hand cursor, respectively.
BUG=74699
Review URL: https://chromiumcodereview.appspot.com/10807090o

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148381 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=2
CID=102615,104536
BUG=none
TEST=none
R=gbillock
TBR=aa


Review URL: https://chromiumcodereview.appspot.com/10828012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148380 0039d316-1c4b-4281-b951-d872f2087c98

Relaxed some integrations tests that failed because of this.  A client
with type X disabled shouldn't be expected to quiesce with other clients
that with X enabled given a change to X.

Cleaned up indentation in preferences integration test.

BUG=138893
TEST=


Review URL: https://chromiumcodereview.appspot.com/10833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148379 0039d316-1c4b-4281-b951-d872f2087c98

Create Tooltip object lazily so that it gets proper drop shadow AND the TooltipController can be added to all root windows.

BUG=138870
TEST=manual.

Review URL: https://chromiumcodereview.appspot.com/10828007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148378 0039d316-1c4b-4281-b951-d872f2087c98

Splits helper functions out of envsetup into envsetup_functions.sh.
Also includes device helper functions in
build/android/adb_device_functions.sh.

Finally, some fixes to build/common.gypi that happened when
cherry-picked down https://chromiumcodereview.appspot.com/10807019

BUG=137569,136693


Review URL: https://chromiumcodereview.appspot.com/10796104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148377 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
R=gab@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10822020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148376 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137704
TEST=Tap on wrench menu and tap out of wrench menu, button returns to normal state.


Review URL: https://chromiumcodereview.appspot.com/10823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148375 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148374 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r9234: (jvoung) Prune glibc support from pnacl tarball (which will also
r9235: (mseaborn) x86-32: Use "%gs:4" to store the IRT's thread value
r9236: (khim) Rename standard ragel variables (p, pe, eof, and cs).
r9237: (bsy) Logic error in error detection/handling SelLdrLauncher::StartModuleAndSetupAppChannel.
r9238: (mseaborn) Cleanup: Remove the ARM springboard
r9239: (dschuff) Configure LLVM to use shared libraries
r9240: (jvoung) Use pnacl-dis instead of llvm-dis in build.sh, since that is more
r9241: (bradnelson) Avoid long command lines to build_nexe.
r9242: (dschuff) They were incorrect in the last CL, but it apparently didn't matter.
r9243: (arbenson) Bootstrap args for sel_ldr for pnacl
r9244: (cmp) Add HTTP proxy support for downloads.
r9245: (arbenson) setjmp asm for zero-based sandbox model
r9246: (halyavin) Debug stub: add simplified breakpoint test on Windows.

BUG=none
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/10833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148373 0039d316-1c4b-4281-b951-d872f2087c98

(Reland of 148355 with correct permissions on binary files.)

WebKit and Pepper need this, both define it as a valid image

TEST= http://trac.webkit.org/export/37902/trunk/WebCore/manual-tests/cursor.html and hover over "out grab" and "grabbing". You should see an open and closed hand cursor, respectively.
BUG=74699
Review URL: https://chromiumcodereview.appspot.com/10807090o

TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10830014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148372 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137914
TEST=AsyncDNS.HaveDnsConfig should reach 99%.


Review URL: https://chromiumcodereview.appspot.com/10796019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148371 0039d316-1c4b-4281-b951-d872f2087c98

The samples page can now handle names and descriptions of the form '__MSG_...',
and the locale is chosen based on the Accept-Languages HTTP header.

BUG=131095

Review URL: https://chromiumcodereview.appspot.com/10804036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148370 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138967
TEST=

Review URL: https://chromiumcodereview.appspot.com/10833007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148369 0039d316-1c4b-4281-b951-d872f2087c98

WebGL can run on Android but we need to assess how robust and secure
it is. This patch adds an --enable-experimental-webgl flag to allow
us to run conformance tests on various devices.

BUG=138958
TEST=Manual testing with flag, no change if flag is not used


Review URL: https://chromiumcodereview.appspot.com/10830011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148368 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10825010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148366 0039d316-1c4b-4281-b951-d872f2087c98

Without this change, the content shell would crash after pressing back
to the home screen and relaunching.  The two problems this fixes are:

1.) It was trying to initialize the command line even though it already
    was init'ed before.
2.) The shell wasn't being recreated because it is done during process
    start and the process is already running.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10701177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148365 0039d316-1c4b-4281-b951-d872f2087c98

(Reland of 148355 with correct permissions on binary files.)

WebKit and Pepper need this, both define it as a valid image

TEST= http://trac.webkit.org/export/37902/trunk/WebCore/manual-tests/cursor.html and hover over "out grab" and "grabbing". You should see an open and closed hand cursor, respectively.
BUG=74699
Review URL: https://chromiumcodereview.appspot.com/10807090o

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148364 0039d316-1c4b-4281-b951-d872f2087c98