- 12 Aug, 2020 40 commits
-
-
Eugene But authored
Synthetic Crash Report feature suppose to upload configs to go/crash after Unexpected Termonation Event, but there are no reports yet. This metric will help to understand where to look for a bug. Bug: 1103752 Change-Id: I350add1794bad8e2f41fb92e2633548884da173d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346941 Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#797112}
-
Toni Barzic authored
The method was not handling BOOKMARK_TITLE match type, even though it can be added to app list search results. BUG=1084862 Change-Id: I2d805f4553b12dede90226a8bb2150b2b26aff8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349969Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#797111}
-
Noel Gordon authored
CL:2344335 used .bind(this, fileBlob) to handle the metadata callback, or mime sniff callback, from the C++ for very good reasons. That's all discussed issue 415792, comment 12 in particular. Change the crbug ref comment in the code to point to that bug comment. Bug: 1114622 Change-Id: Ic70a1afdeb0f84df08c6763231993ca8015fd6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350859Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#797110}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f07b5182eeda..c4451adcce85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ife585a1ab1b32edead5c1e7b9c95f96ef09f9a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350021Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797109}
-
nancylingwang authored
When the adaptive icon feature (DD:go/appservice-adaptive-icon) is enabled, call AppServiceProxy's LoadIcon interface to generate the standard icons for windows . Those windows icons are shown on the mini window to switch between windows when click alt+tab. For some Chrome apps, those window icons could be used to set the Shelf icon. Modify the browser tests LauncherPlatformAppBrowserTest.SetIcon to increaset the callback count, because AppServiceProxy's load icon could update the window's icon. Also add the checking for the icon image. Modify the browser tests WebAppIconManagerBrowserTest.SingleIcon to check for the standard icon image. Tests: 1. Manul tests 2. LauncherPlatformAppBrowserTest.SetIcon is used to test the change for chrome_native_app_window_view* 3. WebAppIconManagerBrowserTest.SingleIcon is used to test the change for web_app_browser_controller.* 4. HostedAppTest.LoadIcon is used to test the change for hosted_app_browser_controller.* BUG=1113576 Change-Id: Icf3e6ad2cbf3d0c01e0f8e2fc29e5742c1cb59ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344428 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#797108}
-
Peter Boström authored
Enabling the pixel tests for this bubble will help in a pending refactor. Bug: 1102894, 1106422 Change-Id: I4ca54c867daf0f5bb477aa84cee5af3d86024a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350842 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#797107}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I2ed12d6c7d82f1ed82a6fb39185884c5fe93461d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350311Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#797106}
-
Peter Boström authored
Introduces a formal split between a dialog model and the bubble in which it's hosted. Refactors BookmarkBubbleView to use it. Several DCHECKs are in place and TODOs that need to be resolved while converting more dialogs to make this more flexible. Bug: 1106422 Change-Id: Ied4baeaf3237f22f770562dc3161030e8640354d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292700 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#797105}
-
Donn Denman authored
Extends the flags for two active contextual search experiements: Longpress and Translations. Change-Id: I25142bddfa815eec7a618faeab9f733645b0c3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350899 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#797104}
-
Ryan Sturm authored
Bug: 1114903 Change-Id: I14e3ae3cc1842686fd4b92e428729ef7f59cdbaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350745Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#797103}
-
Naoki Fukino authored
The histograms are important to know how many users needs the feature and it affect how we support this feature in future ARC versions. Let me extend the expiracy for 1 year. Bug: 1109809 Test: none Change-Id: Id715954e2a8a5ce38dc592da21627bfa424bebdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344328 Auto-Submit: Naoki Fukino <fukino@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#797102}
-
Jiawei Li authored
Changes to use std:string as ScriptId type which has been changed to base::StringPiece on CastWebContents. Using base::StringPiece breaks the normal behavior of injecting JS bindings and the browsertest. Changing it back to std::string fixed the problem. Bug: internal b/163431947, b/132986916 Test: cast_shell_internal_browsertest, CQ Change-Id: I2a4cef5f208880816a4be3068e4e460dd9cf9fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350314Reviewed-by:
Sean Topping <seantopping@chromium.org> Auto-Submit: Jiawei Li <lijiawei@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#797101}
-
Bettina authored
The plural message is the same as the non-plural message so there's no need for this. Bug: 1038797 Change-Id: I77b9a6a558fd4cfa4ceb70fb1ae98473d6c6a68d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350344 Auto-Submit: Bettina Dea <bdea@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797100}
-
Gavin Williams authored
Using a switch statement better represents the fact that the PrinterQueryResult enum only contains 3 possible options: SUCCESS, UNREACHABLE, or UNKNOWN_FAILURE. Bug: 1059607 Change-Id: I0887d532a9f2bc67f63ba218401480ae7e7b8762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349986 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#797099}
-
Chris Cunningham authored
Bug: 1105258 Change-Id: I48e2b4fc4737eef90f0cdc68b2c775c8d6c8efa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346824 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#797098}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I76d833dd4cbb7b0c7109d1fb43f90849ea83b7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350016Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797097}
-
Regan Hsu authored
Previously, the user click count inside settings was not being recorded. Fixed: 1105551 Change-Id: I7c662a5727141f4b1730184be2e155c0dc8835dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349908Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#797096}
-
Ian Wells authored
Bug: 1044139 Change-Id: I9afeba55bbe9b42c47073ac1801ab2ddb5d7b6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348546 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#797095}
-
Erik Chen authored
crashpad_handler needs to know where to put crashes. By default it uses the default UserDataDir and does not have support for --user-data-dir. If the default UserDataDir is not writable, then lacros fails to launch. This CL sets --breakpad-dump-location when launching lacros, effectively overriding the default. Change-Id: I9e31bc14ed721a3984f42f30f94d4214d672daa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350124 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#797094}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I981cb1a2310d28d603e401ff403a427dafc9eb17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351462Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797093}
-
Piotr Bialecki authored
Change-Id: I90ddb990333b1616887834a094b11a3aad25e0bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350740 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#797092}
-
Devlin Cronin authored
Bug: None Change-Id: Ice4ea067d91f45c485e357728899b74c60ba8c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343313 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#797091}
-
Dave Tapuska authored
This moves the setting of the page scale factor into blink part of the UpdateVisualProperties flow. BUG=1097816 Change-Id: Idac6921d93556c1ba4d942bce6abed000b398716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320891 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#797090}
-
Thomas Guilbert authored
This CL adds the necessary logic to allow serializing blink::VideoFrames. It only copies a reference to the underlying media::VideoFrame. Bug: 1096715 Change-Id: Iade841ebd4b2525035b3e81a3f384a0735a57d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317822 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#797089}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae8f8fdcda03..db1dd1b60d1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC slightlyoff@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917,chromium:1112941,chromium:1114729,chromium:1115022,chromium:1115073 Tbr: slightlyoff@google.com Change-Id: Ie70132a38ada362adba20c215d73f1bc7469f608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350019Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797088}
-
Yi Gu authored
Bug: None Change-Id: I8e79eb0c1a5d0394dc056a0d742b8704eb2ff988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350245Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797087}
-
Ian Kilpatrick authored
TBR: dgrogan@chromium.org Bug: 1114013 Change-Id: I41b8e08e80f1d8a6ecd9e293a12a5e8f83c2bec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348205 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#797086}
-
wutao authored
This patch adds the photo preview for album selection. Preview images are downloaded at the C++ side and converted to png url blob, and sent to JS side for display. The Google Photos and Art gallery have different CSS. ss: https://screenshot.googleplex.com/siwcThKwwp5 ss: https://screenshot.googleplex.com/9YTwncEZ8n0 Bug: b/161484670 Test: Added new js tests Change-Id: Ib8ba71c89ba90ac222b5c627ec1da3115a8b7ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336634 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#797085}
-
Jonathan Chavez authored
This CL removes the should_suppress_mixed_content_warning flag from SecurityState, which was originally added to support an enterprise policy that has since been removed. Bug: 1110090 Change-Id: I6b36f2c8edd18c9eb36f00d8dc5558a6cfde42f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343570Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Jonathan Chávez <tabaresj@google.com> Cr-Commit-Position: refs/heads/master@{#797084}
-
Sharon Yang authored
Support scrolling an offscreen node to be visible for screen reader use. Clean up unused param in DeleteSubtree. Test: AccessibilityBridgeTest.PerformScrollToMakeVisible Bug: fuchsia:55864 Change-Id: I3ab468e1cfb3084ee7517f6cf45e8cc0e3e8da1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142740 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797083}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/97adc5795ed2..9981690ea644 2020-08-11 saagarsanghavi@google.com New approach for timing lower-level checks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I8486f3bbe0155b92e2f14b0db3d3aa50c89929fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350197Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797082}
-
Alex Moshchuk authored
Although we now have a form of site isolation on Android, we're likely to be doing work to expand coverage to more devices and more sites, so it's still important to have an easily accessible opt-out switch to check for OOPIF issues. Change-Id: I9d9ee4fbcdbffffeda05b11b714d41918bf24d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350493Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#797081}
-
Brian Sheedy authored
This reverts commit 4edc0503. Reason for revert: Breaks minidump generation on Windows Original change's description: > Add dbghelp.dll to delay load list > > Currently, many of the binaries have a static dependency on dbghelp.dll. > This results in dbghelp getting loaded in all chrome processes. Upon > inspection, dbghelp.dll is only necessary for stack sampling and mini > dump handing in crashpad. Stack sampling is only enabled by default on > unofficial builds of dev and canary. All other times we are needlessly > loading this module which brings in 300k of image file refset and 60k > of Copy on Write costs per process. This change adds it to the delay > load list. > > Change-Id: I13da0ce0735431c5c51cdbc9ba2cfea0cc3cded7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336541 > Commit-Queue: Chris Davis <chrdavis@microsoft.com> > Reviewed-by: Cliff Smolinsky <cliffsmo@microsoft.com> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796707} TBR=thakis@chromium.org,brucedawson@chromium.org,cliffsmo@microsoft.com,chrdavis@microsoft.com Change-Id: I6051562e22eaa9e778b7077c3efab1129bdfd77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350744 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#797080}
-
Austin Eng authored
Bug: 1114781 Change-Id: I0e320c83772818bb487ded6af37c042c53804554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347426 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797079}
-
Noel Gordon authored
Test files come from //media/test/data. Change apitest C++ to copy the files to the 'testing' Volume before starting tests. id3_png_test.mp3: audio file with embedded album artwork image 90rotation.mp4: h264 video, with 90 degree rotation, no images Add test JS helpers to read the files from the 'testing' volume / file system and convert them to Blobs before starting the tests. Add fileManagerPrivate.getContentMimeType mime sniffing tests: testGetContentMimeTypeEmpty - input is an empty blob, returns undefined mimeType result testGetContentMimeTypeImage - input is an image file blob, sniff image/gif testGetContentMimeTypeAudio - input is an audio file blob, sniff audio/mpeg testGetContentMimeTypeVideo - input is a video file blob, sniff video/mp4 testGetContentMimeTypeUnknownMimeTypeError - net::mime_sniffer fails, sets chrome.runtime.LastError Add fileManagerPrivate.getContentMetadata metadata extraction tests: testGetContentMetadataEmpty - input is an empty blob, returns undefined MediaMetadata testGetContentMetadataAudioTags - extract tags only into the MediaMetadata result - vet result with JS verifyExpectedAudioMetadata() helper testGetContentMetadataAudioTagsImages - extract tags and images into the MediaMetadata result - vet result with JS verifyExpectedAudioMetadata() helper testGetContentMetadataVideoTagsImages - extract tags and images into the MediaMetadata result - vet result with verifyExpectedVideoMetadata() helper testGetContentMetadataRetainsInputMimeType - input mime type is copied through to MediaMetadata.mimeType testGetContentMetadataVideoResetsAudioMime - audio mime is changed to video if there is width and height testGetContentMetadataUnsupportedMimetypeError - input mime not video or audio, sets chrome.runtime.LastError Bug: 1114622 Change-Id: Ic96ce7faa409ae25d6b3c956666bbfd7db362f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345936 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#797078}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/398a874c9b85..48d951e22d45 2020-08-11 jmadill@chromium.org Perf Tests: Handle logError callback. 2020-08-11 ianelliott@google.com Vulkan: tell ContextVk when swapchain is re-created 2020-08-11 jmadill@chromium.org Vulkan: Optimize resource tracking in CommandBufferHelper. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: angle_perftests, *vulkan_null_index_buffer_changed_ushortTest: Test: run_angle_perftests --gtest_filter=TracePerfTest.Run/vulkan_angry*:*vulkan_candy* --verbose --local-output Change-Id: I62339c4f81491850d3cea67ad134c5eb50b62b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350489Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797077}
-
Xiaocheng Hu authored
After launching crbug.com/1040632, we disallow a 'font-display:optional' font from being used if it doesn't load before the first rendering cycle begins, so that it won't cause any relayout. This turns out to be too stringent. This patches allows using the font as long as we have never rendered fallback for it. In this way, we still guarantee no layout shifting, and the font can be used in more circumstances. Bug: 1114314 Change-Id: Id521e97b8882e2e3d1fb13c09e040c8e2fd3d47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343643 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#797076}
-
Maciej Malinowski authored
The MemoryDumpMapConverter is converting between the Chromium type MemoryDumpMap and Perfetto RawProcessMemoryNode. Using this class it is possible to process produced in Chromium MemoryDumpMap by Perfetto GraphProcessor. See crbug.com/1095982 for more details. Bug: 1095982 Change-Id: If7e852017c8efa51cd99b4f648c4a32e8fe0b8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299223 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#797075}
-
Nate Fischer authored
No change to logic. This exposes gpu_switches to Java with java_cpp_strings. Fixed: 1112006 Test: autoninja -C out/Default system_webview_apk Change-Id: I84fb22671a6ce42c288b2772f3d49722ccc79f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343776 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797074}
-
rajendrant authored
Change-Id: I4d74b36ecce4a905aa3ef922cd71080651fa7a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349987Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#797073}
-