- 15 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8718afb283b7..ac0a4cbbd850 git log 8718afb283b7..ac0a4cbbd850 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 nisse@webrtc.org Reland "Fix GetStats bytesSent/Received, wireup headerBytesSent/Received" 2019-10-15 philipel@webrtc.org Updated VideoStreamEncoder to destroy encoder_queue_ before encoder_switch_experiment_. 2019-10-15 sprang@webrtc.org Revert "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const" Created with: gclient setdep -r src/third_party/webrtc@ac0a4cbbd850 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:none Change-Id: I7f40da734ca52ec7e8e244237b80ff24ad3557db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862620Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705974}
-
Peter Boström authored
Removes updates to the highlight path done on every Layout() call. Bug: chromium:1007546 Change-Id: Ia179a182c39ada394e1076eae25f374922a1d2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861125 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#705973}
-
Peter Boström authored
Replaces OnBoundsChanged override which resulted in a lot of path generation (per-tab + frame) while opening new tabs or resizing the window. Also removes a ::GetInkDropMask() override which just generated the same path. Bug: chromium:1007546 Change-Id: I0131f9a589c1525e2c0eacd61c9fcd9f6ac05948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861016 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Peter Boström authored
Replaces probably a significant amount of path updates in ::OnBoundsChanged override (which this change also removes). This might reduce some jank in the tab strip while opening tabs or resizing windows, though it's unclear whether it amounts to a significant chunk of work as a fraction of total work here. Bug: chromium:1007546 Change-Id: I5aab0ce9cfcaeea2bec80f994d0586e588ff977e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861044 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Jit Yao Yap authored
Use a SessionStateWaiter instead of checking the SessionState directly as the check might be racy. Bug: 1014239 Change-Id: I521b3ba0c2247603fc7ff5dc2bb31eaa9a2f2a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862676Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#705970}
-
dalyk authored
Bug: 1012268, 963480 Change-Id: I3f2d72fdc6748088e6af2da0f4d31c70a89ad891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849992 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#705969}
-
Philip Rogers authored
This patch reverts https://crrev.com/563452 which is causing crashes due to not marking the paint layer as needing repaint (see new testcase). The inline outline painting code was re-designed in https://crrev.com/591748 to not paint from the container, so this invalidation codepath is no longer needed. The original test for https://crrev.com/563452 is no longer crashing. Bug: 1011699 Change-Id: I42af2ffd3a5a3425fc2acaf0771a992f09adde57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859831 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#705968}
-
Christian Biesinger authored
Running git is fairly slow. Removing this call improves gdb attach time from 34 sec to 27 sec (20.5%). It is also completely unnecessary, because we only need to load pretty printers once. R=thomasanderson@chromium.org Change-Id: I47de8cf198040d46dfdcaa22cc6c3f7d661d28ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863069 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#705967}
-
Kevin Ellis authored
PlayStateUpdateScope is problematic for handling timing of finished promises in addition to not conforming with the algorithm outlined in the web-animations spec. This patch removes several uses of PlayStateUpdateScope and refines handling of pending flags. Bug: 960944 Change-Id: I093a3aa86084adfbe128a5aedd36206d67dd12c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851927 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#705966}
-
Raphael Kubo da Costa authored
Follow-up to commit 1b7e6d75 ("ui/display: extend EdidParser for HDR metadata") to fix the build with libstdc++ (and maybe MSVC): ./../../ui/display/util/edid_parser.cc:416:22: error: no template named 'bitset' in namespace 'std' const std::bitset<kMaxNumColorimetryEntries> ~~~~~^ ./../../ui/display/util/edid_parser.cc:430:22: error: no template named 'bitset' in namespace 'std' const std::bitset<kMaxNumHDRStaticMedatataEntries> ~~~~~^ Bug: 957519, 1012846 Change-Id: Ic3c9c9416ac446bde9f190b9575ef1a386aa8e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862917 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Miguel Casas <mcasas@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#705965}
-
behdad authored
This CL reports the latency in case of no begin main frame. This can happen in any of the scenarios below: 1) WillBeginImplFrame -> DidFinishImplFrame -> DidSubmitCompositorFrame 2) WillBeginImplFrame -> WillBeginMainFrame -> BeginMainFrameAborted -> DidFinishImplFrame -> DidSubmitCompositorFrame 3) WillBeginImplFrame -> WillBeginMainFrame -> DidFinishImplFrame -> BeginMainFrameAborted -> DidSubmitCompositorFrame In these cases there will be no latency to report for stages of: - SendBeginMainFrameToCommit - Commit - EndCommitToActivation But the latency will be reported for the remaining stages. Bug: chromium:1003038 Change-Id: Id0d6a65603b2b15a0ee04a6974a4bd0b2a5a803b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799026 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#705964}
-
Himanshu Jaju authored
All usages of session_name have been renamed to client_name in components/sync_device_info/ for consistency. Bug: 1014439 Change-Id: Ie620281d81a938d83afbe4ede6dc503c4a0a7b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862910 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#705963}
-
Tommy Steimel authored
Bug: 1013757 Change-Id: I433871cd0b57b8c645ad60ac47bc69486b9eea92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857539 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#705962}
-
Peter Kasting authored
Bug: 82078 Change-Id: Ie8c47fe9839e499a6fbd7f91a0791689e6333f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861954 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#705961}
-
Francois Doray authored
This experiment enables: - Use THREAD_MODE_BACKGROUND_BEGIN/END to set the priority of background threads. This affects memory and IO priority in addition to CPU priority. - Increase thread priority to "normal" in scopes where background threads load modules. The expectation is that this will improve responsiveness of Chrome (input delay, first contentful paint), without regressing jank. We are adding the testing config in preparation for enabling this via Finch in M79. Bug: 973868 Change-Id: I467cae12503e3ad724b665f3aebdaeb94e1325c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835023 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#705960}
-
Christian Dullweber authored
Replace shield with an eye. https://screenshot.googleplex.com/MMf2t0rPZ0b.png Bug: 967668 Change-Id: Ic128c96254f4ffe6796f1122e99d12bf753e34d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863012Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#705959}
-
Julie Jeongeun Kim authored
This CL converts ProxyConfigClient to new Mojo types using PendingReceiver, PendingRemote, Remote, Receiver and RemoteSet. Bug: 955171 Change-Id: I7b261526378b4cf834ae480e6a2d1d68ce13ccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849739 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#705958}
-
Sean Harrison authored
Bug: 1014143 Change-Id: I6273867652e71c21d2dfe50b48adead7d200421c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859968Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#705957}
-
arthursonzogni authored
In RenderFrameHostManager, the speculative RenderFrameHost may be deleted by using CleanupNavigation(). The speculative RenderFrameHost may contain multiple pending NavigationRequests. When they are deleted, their matching pending NavigationEntry must be discarded. This is now done automatically in NavigationRequest's destructor by releasing the PendingEntryRef, thanks to patch: https://chromium-review.googlesource.com/c/chromium/src/+/1815129 Bug: None. Change-Id: I5f88e5dafa5188eeab29d5c5a55b8f8306bd83d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860031 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#705956}
-
Himanshu Jaju authored
For full sync we use the PII name, but for transport only mode we use the device's model name as client name. Bug: 1009454 Change-Id: I4a31e012ad81715af91b1dcaf782a4f0466b6f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852092 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#705955}
-
Dave Tapuska authored
The mojo filter allows us to record the debug URL in a crash key. BUG=1008432 Change-Id: Id753793e900763e41fc192bd2c50b21e4e243fe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852646Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#705954}
-
Jan Wilken Dörrie authored
This change adds a few list utility methods to base::Value. This change is in preparation for switching the return type of the mutable GetList() from ListStorage& to base::span<base::Value>, at which point it won't be possible anymore to remove Values using std::vector's API. Bug: 646113 Change-Id: Ia10e7f43723722e0a66794466c6ffca0fe221c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857118Reviewed-by:
-
Rodney Ding authored
- Use a mapping between runtime feature and command line switch to control the enable/disable logic for cleaner code Design docs: https://docs.google.com/document/d/1d6_NBVPXh7B2XMk3H9b_qIxeuSXq6MblVSJldN7bTBY/edit?usp=sharing Bug: 832393 Change-Id: I67c944e1d20d5c0d9ab871f87641cb6ea46fb8ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822864 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#705952}
-
Christian Dullweber authored
The UI would get updated twice when cookie blocking was enabled for a specific site. Avoid this unnecessary step by not stepping through state updates separately. Bug: 967668 Change-Id: I9d6c836031dc9ef7adf1a4888b6e8c8483c22ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862693 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/55f9cba6e2e7..f22c57ddcc8c git log 55f9cba6e2e7..f22c57ddcc8c --date=short --no-merges --format='%ad %ae %s' 2019-10-15 robertphillips@google.com Centralize GrSamplerState key creation Created with: gclient setdep -r src/third_party/skia@f22c57ddcc8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: I558f9193e97366ee59afb933e70f1804db7bd55b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862980Reviewed-by:
-
Marc Treib authored
The "best_matches" are now passed around in a vector instead of a map. This CL updates the last two places that accepted a map: - VotesUploader - PasswordFormMetricsRecorder Bug: 1011399 Change-Id: I42fa29549cfc02398f69b802a3d18cd1eb75e89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862448 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#705949}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a3fb0505..9b58c027 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id8d791cbbe6f3a597caedc240cd5c7287a7fb019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862577Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705948}
-
Virender Singh authored
This CL does code refactoring to make the intent of PdfAccessibilityTree .zoom variable clear. It stores the product of pdf zoom and system dpi. This change renames it to zoom_device_scale_factor. This change also refactors the zoom variable name in PP_PrivateAccessibilityViewportInfo to zoom_device_scale_factor. Corresponding change is also made in OutOfProcessInstance to reflect the variable name change. Bug: 1007169 Change-Id: I0a9c22f386fb4859afc80d9f281f41a15935bb09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823337Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Virender Singh <virens@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705947}
-
Maksim Sisov authored
At first, I wanted to remove these static methods, but then decided to keep them and remove later when we no longer need them. Bug: 990756 Change-Id: If6132986e25bb1c8712acdbc90ce29093616bff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860341Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#705946}
-
Thomas Tangl authored
Bug: 995720 Change-Id: I96acb6008bd074d9e68ddab1b8b4fc205ce1ab6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862689 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#705945}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e84f1d15029a..8d061254d2f4 git log e84f1d15029a..8d061254d2f4 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 fmayer@google.com Merge "Add heap_graph table test." Created with: gclient setdep -r src/third_party/perfetto@8d061254d2f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Icbc1f66508803e283df435e2165e4ce3a912e63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862974Reviewed-by:
-
Mikel Astiz authored
This works as a short-term solution to power certain sharing features that rely on a high-entropy per-user authentication key being available to all sync-ing clients, including transport-only clients. Bug: 1010968 Change-Id: I51613f0b3e5d91a82f688af13b61c4804057a57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841451Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Richard Knoll authored
Mostly mechanical change to pipe the origin through to the dialog view. The dialog shows the origin in a label with rounded corners, see screenshot: https://imgur.com/LPAWxy2 Changes the BubbleFrameView to size |header_view_| to the ContentBounds instead of centering it. Bug: 1010920,1005596 Change-Id: I72f2e163552165b39ef00aaa1d1ea7cce8ce4895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849382 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#705942}
-
David Bienvenu authored
This will be used to find hard links to or copies of web_app_shim.exe for a particular installed PWA, so they can be updated or deleted when the PWA is uninstalled. Bug: 960245 Change-Id: I62d6d6e263d0fdcdb2c5d4f89435cb657dd73a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849417 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#705941}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/52e19cbdc570..cc3b617bc9f8 git log 52e19cbdc570..cc3b617bc9f8 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 perezju@chromium.org [Telemetry] Move screenshot-on-failure tests to shared_page_state tests Created with: gclient setdep -r src/third_party/catapult@cc3b617bc9f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:928275 Change-Id: I89b3b72ca31dc23ab294e751e1dc9748764cf156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862976Reviewed-by:
-
Raul Tambre authored
* map() returns an iterable instead of a list in Python 3. Convert it explicitly to a list. * xrange() is replaced in Python 3 by the functionally equivalent range(). * Simplified checking whether an object is a string and introduced string_type that's set according to Python version. Still works with Python 2. Fixed errors: Traceback (most recent call last): File "../../components/policy/tools/generate_policy_source.py", line 1648, in <module> sys.exit(main()) File "../../components/policy/tools/generate_policy_source.py", line 361, in main policy_atomic_groups = [ File "../../components/policy/tools/generate_policy_source.py", line 362, in <listcomp> PolicyAtomicGroup(group, policy_details_set, policies_already_in_group) File "../../components/policy/tools/generate_policy_source.py", line 181, in __init__ self._CheckPoliciesValidity(available_policies, policies_already_in_group) File "../../components/policy/tools/generate_policy_source.py", line 196, in _CheckPoliciesValidity raise RuntimeError('Invalid policy: ' + policy + ' in atomic group ' + RuntimeError: Invalid policy: RemoteAccessClientFirewallTraversal in atomic group RemoteAccess. Traceback (most recent call last): File "../../components/policy/tools/generate_policy_source.py", line 1647, in <module> sys.exit(main()) File "../../components/policy/tools/generate_policy_source.py", line 379, in main GenerateFile(opts.source_path, _WritePolicyConstantSource, sorted=True) File "../../components/policy/tools/generate_policy_source.py", line 372, in GenerateFile writer(sorted and sorted_policy_details or policy_details, File "../../components/policy/tools/generate_policy_source.py", line 1079, in _WritePolicyConstantSource schema_generator.GenerateAndCollectID(chrome_schema, 'root node') File "../../components/policy/tools/generate_policy_source.py", line 839, in GenerateAndCollectID index = self.Generate(schema, name) File "../../components/policy/tools/generate_policy_source.py", line 787, in Generate properties = [ File "../../components/policy/tools/generate_policy_source.py", line 789, in <listcomp> self.GetString(key), self.GenerateAndCollectID(subschema, key)) File "../../components/policy/tools/generate_policy_source.py", line 839, in GenerateAndCollectID index = self.Generate(schema, name) File "../../components/policy/tools/generate_policy_source.py", line 752, in Generate return self.GetEnumType(schema, is_sensitive_value, name) File "../../components/policy/tools/generate_policy_source.py", line 694, in GetEnumType return self.GetEnumIntegerType(schema, is_sensitive_value, name) File "../../components/policy/tools/generate_policy_source.py", line 667, in GetEnumIntegerType if self.IsConsecutiveInterval(possible_values): File "../../components/policy/tools/generate_policy_source.py", line 662, in IsConsecutiveInterval for i in xrange(len(sortedSeq) - 1)) NameError: name 'xrange' is not defined Traceback (most recent call last): File "../../components/policy/tools/generate_policy_source.py", line 1648, in <module> sys.exit(main()) File "../../components/policy/tools/generate_policy_source.py", line 379, in main GenerateFile(opts.source_path, _WritePolicyConstantSource, sorted=True) File "../../components/policy/tools/generate_policy_source.py", line 372, in GenerateFile writer(sorted and sorted_policy_details or policy_details, File "../../components/policy/tools/generate_policy_source.py", line 1080, in _WritePolicyConstantSource schema_generator.GenerateAndCollectID(chrome_schema, 'root node') File "../../components/policy/tools/generate_policy_source.py", line 840, in GenerateAndCollectID index = self.Generate(schema, name) File "../../components/policy/tools/generate_policy_source.py", line 788, in Generate properties = [ File "../../components/policy/tools/generate_policy_source.py", line 790, in <listcomp> self.GetString(key), self.GenerateAndCollectID(subschema, key)) File "../../components/policy/tools/generate_policy_source.py", line 840, in GenerateAndCollectID index = self.Generate(schema, name) File "../../components/policy/tools/generate_policy_source.py", line 788, in Generate properties = [ File "../../components/policy/tools/generate_policy_source.py", line 790, in <listcomp> self.GetString(key), self.GenerateAndCollectID(subschema, key)) File "../../components/policy/tools/generate_policy_source.py", line 840, in GenerateAndCollectID index = self.Generate(schema, name) File "../../components/policy/tools/generate_policy_source.py", line 788, in Generate properties = [ File "../../components/policy/tools/generate_policy_source.py", line 790, in <listcomp> self.GetString(key), self.GenerateAndCollectID(subschema, key)) File "../../components/policy/tools/generate_policy_source.py", line 840, in GenerateAndCollectID index = self.Generate(schema, name) File "../../components/policy/tools/generate_policy_source.py", line 741, in Generate if not isinstance(schema['$ref'], types.StringTypes): AttributeError: module 'types' has no attribute 'StringTypes' Traceback (most recent call last): File "../../components/policy/tools/generate_policy_source.py", line 1651, in <module> sys.exit(main()) File "../../components/policy/tools/generate_policy_source.py", line 383, in main GenerateFile(opts.source_path, _WritePolicyConstantSource, sorted=True) File "../../components/policy/tools/generate_policy_source.py", line 376, in GenerateFile writer(sorted and sorted_policy_details or policy_details, File "../../components/policy/tools/generate_policy_source.py", line 1093, in _WritePolicyConstantSource schema_generator.FindSensitiveChildren() File "../../components/policy/tools/generate_policy_source.py", line 959, in FindSensitiveChildren self.FindSensitiveChildrenRecursive(0, set()) File "../../components/policy/tools/generate_policy_source.py", line 967, in FindSensitiveChildrenRecursive node = self.schema_nodes[index] TypeError: 'map' object is not subscriptable Bug: 941669 Change-Id: I9737aa44b1f395f6efeefadc94c39a084f82ed98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857122 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#705939}
-
Ioana Pandele authored
Bug: 983445 Change-Id: I3c5f67636397983c0765e7baf73ecb54bc45c889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862440 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Hans Wennborg authored
If there is a diff, build.py will nuke the repository anyway. And in pathological circumstances (see bug), printing the diff can take a very long time. Bug: 1014241 Change-Id: Ic045dfef66c7695b07ba9099352744d5becdcdfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862916Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#705937}
-
Ian Struiksma authored
This test is failing on the linux bot consistently. Disabling it for now as we investigate. More details in the bug description. Bug: 1014333 Change-Id: I0efb42942e05606a35df73a0e4a2b508c0cc4cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861020Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#705936}
-
Tanmoy Mollik authored
With this cl it is now possible to build chrome without referencing any instance of CoreAccountId as std::string. Bug: 959157 Change-Id: I206ce350bde21d97161719690d0db243bbdbc0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840236Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
-
