Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 12 Dec, 2019 37 commits
  3. 11 Dec, 2019 3 commits
    • Rakib Hasan's avatar
      Revert "Reland "[web tests] Add layout-test-results/ prefix to all artifact... · 1e90bd05
      Rakib Hasan authored 
      Revert "Reland "[web tests] Add layout-test-results/ prefix to all artifact relative paths in json results""

This reverts commit d1a27f9f.

Reason for revert: The change is breaking the blink builds. Below
is an example build.

https://ci.chromium.org/p/chromium/builders/try/linux-blink-rel/24569

Original change's description:
> Reland "[web tests] Add layout-test-results/ prefix to all artifact relative paths in json results"
> 
> This reverts commit 2e7eb004.
> 
> Reason: In crrev.com/c/1925687, the functions within the Port class were modified to set
> their output directory to the artifacts directory. Some scripts like run_webdriver_tests.py
> will not create the artifacts directory, therefore whenever classes like WPTServe were
> instantiated an exception would be raised because the artifacts sub-directory was not created.
> This CL will make the server classes create the artifacts directory. It will also add an optional
> parameter for the output directory to the server starter functions in the Port class.
> The default value for these parameters will be the artifacts directory.
> 
> Original Description of commit reverted:
> 
> Revert "[web tests] Add layout-test-results/ prefix to all artifact relative paths in json results"
> 
> This reverts commit 9138bb30.
> 
> Reason for revert: Suspect to cause:
> https://crbug.com/1032504
> 
> Original change's description:
> > [web tests] Add layout-test-results/ prefix to all artifact relative paths in json results
> >
> > This will make the artifacts paths consistent with the isolate output directory paths. All
> > test runners should follow this standard for outputting artifact paths in the JSON results.
> >
> > Bug: chromium:1026494
> > Change-Id: I36dbbb2a9bec507182610e959edf55f1819d2ca7
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925687
> > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > Reviewed-by: Robert Ma <robertma@chromium.org>
> > Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
> > Commit-Queue: Rakib Hasan <rmhasan@google.com>
> > Cr-Commit-Position: refs/heads/master@{#723270}
> 
> Bug: chromium:1026494
> Change-Id: I272242b00b9334c8bc6b6443638ead5aa17db54f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960716
> Commit-Queue: Rakib Hasan <rmhasan@google.com>
> Reviewed-by: John Chen <johnchen@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Robert Ma <robertma@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#724006}

TBR=johnchen@chromium.org,jbudorick@chromium.org,robertma@chromium.org,rmhasan@google.com

Change-Id: Iccbacb0ea91551ae1b48e0cc236d804c4066c9ba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1026494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963352Reviewed-by: default avatarRakib Hasan <rmhasan@google.com>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#724041}
      1e90bd05
    • Dana Fried's avatar
      Regression tests and some tweaks to FlexLayout. · 10cc1d4b
      Dana Fried authored 
      * Regression tests for attached bugs
* Fixes to address another minor issue the tests uncovered

Bug: 1012136
Change-Id: Ie57b9d37a997dc748d92dd68a27b42c106cde087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962592Reviewed-by: default avatarPeter Boström <pbos@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724040}
      10cc1d4b
    • Daniel Murphy's avatar
      Revert "[IndexedDB] Remove child policy permissions for blobs from IndexedDB" · 91fcd3b6
      Daniel Murphy authored 
      This reverts commit 71d64a4f.

Reason for revert: This seems to be causing attachment errors in gmail - I'm guessing that we still report these as files somehow?

Bug: 1033165

Original change's description:
> [IndexedDB] Remove child policy permissions for blobs from IndexedDB
> 
> Now that blobs from IndexedDB are backed & read by the IndexedDB system,
> they are no longer sent to the renderer as files. This means no content
> policy changes or grants are necessary.
> 
> Tracking document:
> https://docs.google.com/document/d/18suNOOzuEJbqgRJF0MB2VqdTyYqS4cvI2PGaCpyPXSw/edit?ts=5de6dc30&pli=1#heading=h.tw2iw2qfgduj
> 
> Bug: 1015212
> Change-Id: If3d2fd80b3254f19a56ab16ed7fc39cf5f0cf684
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955813
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: enne <enne@chromium.org>
> Commit-Queue: Daniel Murphy <dmurph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#722617}

TBR=dmurph@chromium.org,rockot@google.com,enne@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1015212
Change-Id: If5307dfa39ab1a74e62dec21dd55dd71d81a52ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963206Reviewed-by: default avatarDaniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724039}
      91fcd3b6