- 18 Apr, 2019 40 commits
-
-
Ben Pastene authored
This makes the "test_type" arg the very first arg. Previously, anything that came before it couldn't be passed in from the generated test script. eg: running `./$out/bin/run_gtest --device $DUT_IP` would have no effect since "--device" came before the "test_type" arg (which itself was set in the generated script). Bug: 866062 Change-Id: I7712f11b23f78f28e9831fe506b9467db8c217e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572959Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#652208}
-
Torne (Richard Coles) authored
Make the minimum SDK version for all components of Trichrome be Q, if we're building with the Q SDK. SDK28 builds of Trichrome are only for temporary testing and can be left alone until they're removed. Bug: 952383 Change-Id: I8e9bac555456868ccf414a56f499d03fd2d1ef34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566372 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#652207}
-
Nikita Podguzov authored
* Allow to save empty PIN in sticky settings. * Show the error if the PIN field is empty. Bug: 848942 Change-Id: If7c4f3af6b9d6a5ade041c06d4732903ce780ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570011Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#652206}
-
Mohamed Amir Yosef authored
Bug: 922900 Change-Id: Idde575a3f4ba559811ab98373f6fb3e30bef0ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572406 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#652205}
-
Yeol authored
QuotaPermissionContext is a base::RefCountedThreadSafe class. The method should return scoped_refptr instead of the raw pointer. Bug: 951154 Change-Id: Ida5c64b6b5ce9eea6d3b42b49c0ab25b0263778e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569376Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yeol Park <peary2@gmail.com> Cr-Commit-Position: refs/heads/master@{#652204}
-
Abhishek Arya authored
This reverts commit e646c056. Reason for revert: Broke UBSan vptr and Boris is OOO till early May. Original change's description: > [Signin][Android] Add Java side of ConsistencyCookieManager > > Adds ConsistencyCookieManager Java class that listens to > AccountManagerFacade.isUpdatePending and exposes it to the C++ code. > > Bug: 949562 > Change-Id: Ifc375bed3d0d878d89d106807f44f4e7807db999 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565880 > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652073} TBR=droger@chromium.org,bsazonov@chromium.org Change-Id: Id672685a05ecea8dcd2bee210369faa9a207c35d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 949562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573860Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#652203}
-
Austin Eng authored
This will be replaced when we implement the GPUAdapterOptions to select high/low power. Bug: chromium:852089 Change-Id: If698c1edd3c1cb8f6d10377133f276351d05dc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572533Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#652202}
-
Elly Fong-Jones authored
This flag never expires since it is used by TE to validate Payments features. Bug: None Change-Id: If0bfbfce132ef1f979c277c3e9ed6987598ba53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570921 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#652201}
-
Nate Chapin authored
Both FrameLoadRequest and the current input event from which the input start time is determined are stack allocated. So even if we reconstructed a FrameLoadRequest without using a copy constructor, it should still get the same input_start_time_. Change-Id: I3bd1213d6f8dfea518b687d5464c6a383be017f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572228 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652200}
-
Koji Ishii authored
This is a follow up fixes for r651389 (CL:1554210) which reduced |CollectInlines()| where possible. Before this change, |CollectInlines()| is responsible for |ClearNeedsLayout()| for the objects in an inline formatting context. By r651389 not requiring |CollectInlines()| for all layout, we started failing to |ClearNeedsLayout()| in some cases. Over 300 tests started to fail by reducing |CollectInlines()| further in WIP CL:1567555. In order to layout without running |CollectInlines()|, this patch changes |NGInlineItemsBuilder| to include text that are fully collapsed. They are not needed for the layout purposes, but |NGLineBreaker| calls |ClearNeedsLayout()| for them. The previous patch passed all tests means that we're not saving much |CollectInlines()| yet. Expect to save more in WIP CL:1567555, but this fix is needed for that. Bug: 636993 Change-Id: I6c543991208980cbb880a21d306b912e3b29affe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571113 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#652199}
-
Jazz Xu authored
Since there are situations where bottom pregress bar shows and mid overlay hides, we are going to have different hide timer for them. This CL add a hide timer logic into touchless element base class so that all sub element can have the hide timer (This is also a preparation for volume indicator hide timer). Bug: 942153 Change-Id: I980f1ec4439cad233a321a98bf1f2e6a535338eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570128 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#652198}
-
Roman Aleksandrov authored
Apply all strings changes. Bug: 879146 Change-Id: I14487919651070a1f91a461d66a4a2243a267b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565009Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#652197}
-
John Abd-El-Malek authored
For subresources the renderer was already loading it in-process. Now for navigations and downloads, we keep them in the browser process. This avoids: 1) sending GURLs bigger than 2MB to a different process, which strips them as they're bigger than url::kMaxURLChars 2) having the network process deal with a scheme that's not going over the network, which we avoid Bug: 937146, 939871 Change-Id: I8ca8225308b2a5f1f90594ab06943f0641a5c551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570805 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#652196}
-
Chris Blume authored
In a previous CL [1] some debug logging was added which shouldn't have been committed. This CL removes those accidental debug logs. [1] Add SharedImage thread safe flag https://chromium-review.googlesource.com/c/chromium/src/+/1504894 Bug: 938594 Change-Id: I938a8fd021823bde0b5017c3ac758ea78fccbf8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572602Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#652195}
-
François Doray authored
This reverts commit f9b9495c. Reason for revert: https://crbug.com/954217 Original change's description: > [IntersectionObserver] Handle hidden OOPIF's correctly > > When an OOPIF is hidden, by scrolling it outside the parent > document's viewport, or by setting display:none or visibility:hidden, > then the iframe process stops running lifecycle updates, and > IntersectionObserver notifications are not generated. That means that > an IntersectionObserver running in the iframe process will not get a > "not intersecting" notification until lifecycle updates resume. > > With this change, IntersectionObservers are forced to run when an > OOPIF is hidden, so that the "not intersecting" notifications will be > generated without waiting for a lifecycle update. > > Adding LocalFrame::WasShown and LocalFrame::WasHidden revealed another > latent bug -- LocalFrameView::visibility_observer_ was not turned off > in LocalFrameView::Dispose. As a result, it continued generating > notifications and sending IPC's to the browser, even after the > LocalFrameView was disposed. This is a problem with OOPIF's, because > all iframe's are initially created as a LocalFrameView and later > converted to a RemoteFrameView. The initial, temporary LFV would > start up its visibility_observer_, which would continue pumping out > notifications that were redundant -- and sometimes conflicting -- > with IPC's sent from the RemoteFrameView. This bug only became > apparent when writing the test included in this patch, which was > flaky until LFV::visibility_observer_ was properly shut down in > LFV::Dispose(). > > BUG=941231 > R=dtapuska@chromium.org,kenrb@chromium.org,chrishtr@chromium.org > > Change-Id: I9c78742930c1829c49998b6f0212d58292fda57f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568200 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Stefan Zager <szager@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652155} TBR=kenrb@chromium.org,szager@chromium.org,chrishtr@chromium.org,dtapuska@chromium.org Change-Id: I63555267638e7da6ac73ec85f526f5e1721c98d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 941231, 954217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572707Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#652194}
-
Justin DeWitt authored
This also changes the behavior of onStart - it previously cleared the timestamp too soon for other code to read the pref. Now the timestamp is stored in memory in the ChromeInactivityTracker even after the pref is cleared. Bug: 951874 Change-Id: Ic2c128e899749aac055e3fd2487f6024fb1fbdba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565278 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#652193}
-
Sébastien Séguin-Gagnon authored
Display an infobar on iOS when a tab is received via Sync. The infobar is only shown if the user has an active and visible WebState. The other cases will be handled in a future CL. The infobar includes an open button which opens the tab. Bug: 944602 Change-Id: I88e593dc77a7301a8b0aa20a8fc74afa1c106270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540061Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#652192}
-
Nathaniel Steinbock authored
Bug: internal 120282030 Change-Id: Ifa68f10107c0195683ec794f44220e1c80bc9aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573161 Auto-Submit: Nate Steinbock <steinbock@google.com> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Nate Steinbock <steinbock@google.com> Cr-Commit-Position: refs/heads/master@{#652191}
-
Hongchan Choi authored
Some Blink unit tests are failing after a new Page<Supplement> is introduced. This CL adds the support of Supplement to DummyPageHolder by providing modules to it so they can properly have the supplement for the test. A test uses PageTestBase class was also patched individually. This change is required for crrev.com/1456684. Bug: 837323 Change-Id: I96b1a49e2a7063ac2aa940376be6e264c23cf395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572701Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2a7de6b7406d..422c94bdab7a git log 2a7de6b7406d..422c94bdab7a --date=short --no-merges --format='%ad %ae %s' 2019-04-18 syoussefi@chromium.org Vulkan: Enable ES3 fragment output attribute locations Created with: gclient setdep -r src/third_party/angle@422c94bdab7a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I1ea86f7f7cd6a4d5233d47a80412e15f10c9d34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572694Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652189}
-
Becky Zhou authored
Bug: 951227 Change-Id: I388b1ce8955363a2499ac478a7f8978027f690ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572978Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#652188}
-
Richard Townsend authored
This CL integrates feature detection across the file so that similar sections do similar things across all operating systems. Bug: 810125 Change-Id: I066226be69453ada72fa67632d09567ce246a860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569929Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#652187}
-
Ioana Pandele authored
A pointer to the PasswordManagerDriver is sent to the modal dialog, which passes it back to the generation controller when the user accepts the generated password. The driver is frame scoped and is used to communicate back to the renderer that the password was accepted. Bug:835234, 954196 Change-Id: If9ddf66f5466f5f22a90bbb5ff7897f28ce236df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571664 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#652186}
-
Majid Valipour authored
In the current snap selection algorithm there is an inherent assumption that the selected snap position in the other axis is inside the scroller bounds. Breaking this invariant in snap selection algorithm causes it to not find any valid candidate. In practice this invariant was being violated. More concretely an snap operation with intended end and direction may have a base and intended snap positions that are outside the bounds when for example script does Element.scrollBy(-100,-100) or when user flings diagonally in a horizontal only scroller. This fix updates the logic so that instead of making the assumption we actively enforce it by clamping the out-of-bound values. An alternative approach may have been to perhaps sanitize the input from all the various entry points into the snap selection logic but the current approach seems simpler and more robust. Note that the problem applies to all snapping but manifested itself most obviously when |scroll-snap-stop:always| was used because in normal snapping even if fling didn't snap correctly we would re-snap at the end of the fling so it was less obvious. Other minor changes: - correct spelling mistake s/cros/cross/ - reuse base::ClampToRange to clamp TEST: 1. wpt/css/css-scroll-snap/scroll-snap-stop-always.html: cover snapping with scroll-snap-stop 2. wpt/css/css-scroll-snap/scrollTo-scrollBy-snaps.html: covers basic snapping 3. fast/scroll-snap/animate-fling-to-snap-points.html: cover user fling snapping Bug: 823998 Change-Id: I85ff8b2c87518358805064375e0386606aad7b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572286 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652185}
-
Misha Efimov authored
Bug: 930153 Change-Id: Ic0375059b6a427cc73cff1f703b7d503d7acf031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1461322 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#652184}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/abaecd5f2ba7..f45b3881ebc6 git log abaecd5f2ba7..f45b3881ebc6 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 swiftshader.regress@gmail.com Regres: Update test lists @ d853c12d Created with: gclient setdep -r src/third_party/swiftshader@f45b3881ebc6 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I254c2b0fb1f30c363c1e62a3d9ad31d1ccb882a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572689Reviewed-by:
-
Olivier Robin authored
The previous implementation of CacheUploadingEnabled was really ambiguous in multiple ways: - it is set to match the current status of the breakpad upload (which for example is disable on background) and it is used as a cache of the user preference. - it sets a UserDefault to be reused in the next startup early part but it relies on the startup sequence anyway to initialize it. The result is that there are multiple buggy scenarios, like killing the app in the background (while breakpad is not running) then crash looping. This CL simplifies the logic by caching the user preference only, independently to the actual status of breakpad_upload (which is not relevant on next startup). Bug: 948178 Tbr: rohitrao Change-Id: Ib43dac8e9de4a6fe4c663714bb32fefcdce0a354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561121 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#652182}
-
Francois Doray authored
Test failed multiple times on Android CFI. TBR=tiborg@chromium.org Bug: 954145 Change-Id: I3ac4820736d146bc16a31842905f4d504a974036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573646Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a0cf99f401ce..060c5300eae0 git log a0cf99f401ce..060c5300eae0 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 dburger@chromium.org Revert "Add a unittest to check config skew, old and new." Created with: gclient setdep -r src/third_party/chromite@060c5300eae0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I8d6a1e197d5ad5cf3785ed29bdbdc3d3de901b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572693Reviewed-by:
-
Roman Aleksandrov authored
Add tests to the ChromeOS only part of the code. Fix subtitle for the non-managed devices and managed/non-managed accounts. Bug: 879146 Change-Id: I7f24f7b527fcaa8d8ce0b165b3b276bf80ee8936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569705 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#652179}
-
Alexei Filippov authored
BUG=953914 Change-Id: Ifd1a96df53a3634ce192016c12f6371cf648ad58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572937Reviewed-by:
Paul Irish <paulirish@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#652178}
-
Nicolas Ouellet-payeur authored
TBR=rhalavati@chromium.org Bug: 954181 Change-Id: I7ff96420ad497cf4e3afc740a352b544dbccd386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572560 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#652177}
-
Ria Jiang authored
A RenderPassDrawQuad can be referenced many times, cache the result to avoid unnecessary re-computing. Bug: 947031 Test: viz_unittests Change-Id: I59c790d3f7e357e5af50c5c780d8078e975ac3cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555071Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#652176}
-
Alexei Filippov authored
Get rid of an extra thread. BUG=923459 Change-Id: I461ec8e437f0520274650a7922c29154fd57f23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573171 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#652175}
-
Maks Orlovich authored
Change-Id: Ib9e73eba4c94c79ea88f565817665cc3e7c17ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572580Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#652174}
-
Justin DeWitt authored
Some tablets failed because scrolling to a position did not guarantee that position would be the first visible, since the catalog is not big enough on a tablet. Also switches scrollToPosition -> scrollToPositionWithOffset to match behavior of moving a tile to the top. Bug: 953254 Change-Id: Id7671a73e4ce16cc834ac66daa25369205ed4eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570189Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#652173}
-
Elly Fong-Jones authored
Bug: None Change-Id: Icbf79142942e690dd1b5dedce376ff8a019f2620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573640Reviewed-by:
-
Joshua Pawlicki authored
Bug: 952753 Change-Id: I7443b3e0d6ff228113ef19ef718561ddfacd0f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573658 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#652171}
-
Owen Min authored
With the CloudPolicyOverridesPlatformPolicy enabled, Chrome cloud policies use POLICY_SOURCE_PRIORITY_CLOUD instead to override the paltform policies that have same scope. This only works for machie scope policies. Bug: 749530 Change-Id: Ib35b4143d81ab57722c67c7018eff5203a60a93d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572581 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#652170}
-
danakj authored
These callbacks are only called once, so change them to the correct spelling. This will allow bluetooth code to be converted to OnceCallback as well, which will then allow content code to be converted. TBR=hashimoto,rkc Bug: 953861 Change-Id: I49b0fcf6e00721e5e6bbb4439bad7c5cbb0d6463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572204 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#652169}
-
