- 04 Nov, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/580a95b0..99086cbb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9c352786bb3a045a81101d1525a6bfa089ae8db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898046Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712211}
-
Elly Fong-Jones authored
Despite the name, AXRelativeBounds are actually the absolute bounds when used with Views views. The code in TableView was treating them as though they were relative, which led to table rows and cells having their virtual positions near the origin of the screen. After this change, they are correctly positioned. This change also implements AXVirtualView::GetNSWindow, which is being called by VoiceOver when navigating these table cells. It doesn't seem to matter whether it returns a correct value or not but having it NOTREACHED() causes the browser to crash in dcheck builds, which is bad. Bug: 1009024 Change-Id: I67c0cd05786896de873fc8a36129cd2f0f3dff75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894308 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#712210}
-
Michael Crouse authored
This change renames the HintCacheStore to OptimizationGuideStore as future changes will allow the store to contain additional entry types that are not hints, including prediction models and host model features. A future change will initialize the store in the keyed service rather than within the hints manager and hint cache to allow its use throughout the optimization guide. Bug: 1001194 Change-Id: I68271ed1070829be40d21463eb976390a66109ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896774 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#712209}
-
Clark DuVall authored
Bug: 1021126 Change-Id: I5c7e6a1fe0bd0f3f3fe96d9ef71cae242973d073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898086Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#712208}
-
Lijin Shen authored
The background of URL bar is not displayed on swiping tabs or entering/existing tab switcher. This CL is trying to correct location bar background color by detecting whether it is an NTP and location bar is on top of the NTP or not. Bug: 874101 Change-Id: I6749d0829839cf753a99e1663e6c0565bd9bf279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887655 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#712207}
-
David Benjamin authored
If the input is divided into 1-byte chunks, our existing limits don't directly bound things and the PostTask machinery is slow enough with sanitizers on that doing it 500,000 times in sequence tends to blow through the newly-tightened limit in https://chromium-review.googlesource.com/c/chromium/src/+/1797203. Bug: 1014767 Change-Id: Iaa047613c1ace18c4639e442d2224c0abf16c741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898166 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#712206}
-
Joshua Pawlicki authored
Bug: 1021172 Change-Id: I0461cfab978517bd0d948487f785efce9df018df TBR=rdevlin.cronin@chromium.org Change-Id: I0461cfab978517bd0d948487f785efce9df018df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896505Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712205}
-
Archana Simha authored
Introduces the feature name and parameters, and overrides the middle slot promo with the extensions promo when the experiment is running. (Note: navigations to chrome scheme links from the NTP are currently blocked. This ability will be implemented in a future CL based on https://crrev.com/c/1893824) Design Doc: go/extensionscheckup Bug: 1019296 Change-Id: Ib1bf149e4ccdd38383ecb534b69ffac147b6e446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836021 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Philip Rogers authored
We are changing the behavior of trivial 3d transforms to not require compositing and this means we lose test coverage of some compositing codepaths in the compositing/ directory. This change replaces trivial transforms that were likely intended to be compositing triggers with will-change: transform. Bug: 1018260 Change-Id: I6ec7edcbb418c530c7bf2e3b9477c4347c5eedc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893513 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712203}
-
Xianzhu Wang authored
- Add back the rect parameter of PaintPart() method, so that the caller (which is cc, and will be also from blink for CompositeAfterPaint) can control where the part should be painted. It was removed in crrev.com/c/1834286 when I thought we wouldn't use it. - Rename TRACK to TRACK_BUTTONS_TICKMARKS to distinguish from the track part concept in blink which doesn't include buttons and tickmarks. - Add cc::Scrollbar::ThumbRect() which replaces ThumbThickness() and ThumbLength(). The location is not used in cc because the compositor will compute it from scroll offset, but it's useful for CompositeAfterPaint non-composited scrollbars which also use cc::Scrollbar. - Move custom scrollbar specific logic (for back/forward track, scrollbar background, track background, buttons in reversed direction etc.) from scroll/scrollbar_theme* to CustomScrollbarTheme. Bug: 931486 Change-Id: I912ea4c53334520204ec4e369f77a88c79983bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897118 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#712202}
-
Sylvain Defresne authored
Convert code abusing set_sources_assignment_filter to filter lists to instead manually filter the list using foreach and get_path_info. Bug: 1018739 Change-Id: I66205fe54ebdce67e23d0b14e594d237555bce8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890061Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#712201}
-
Alice Wang authored
This CL fixes bookmark signin promo dismiss tests on phone and on tablet. Bug: 789531 Change-Id: Ic71c24c9c46e00ccdf66b80240698e08c6da285b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893286 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#712200}
-
Jimmy Gong authored
- Fix was to include the cups-printer-shared styles in CupsSavedPrinters. Bug: 1020526 Change-Id: Idffcd0d64eef0f5bd923497214b88250bac15746 Tests: Manual Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895316Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#712199}
-
Tim Song authored
The current calculation for collapsing the message center when expanding the quick settings is not the same as the calculation when creating the message center. These should be consistent. Additionally, the current calculation for the expanded quick settings height is not correct either. TEST=manual BUG=1019926 Change-Id: I7ba344af148bea12ccaaf431c4b52c151f2b58ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891757Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712198}
-
Gang Wu authored
Change-Id: If23456e82fc5ffb2d298f27f9282455ead9e92ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893145Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712197}
-
Joe Mason authored
The current OWNERS of safe_browsing/settings_reset_prompt haven't dealt with this code for a long time. Removing them so the ownership falls back to the inherited safe_browsing team. Leaving the OWNERS file in existence to specify a different COMPONENT for this subdir though. R=csharp@chromium.org, vakh@chromium.org Bug: 1013608 Change-Id: I60d82877e1d235e732554c6d7d6e95cb67358e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893532Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712196}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b9ddfd577a20..5883a44b60c6 git log b9ddfd577a20..5883a44b60c6 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 jmadill@chromium.org Vulkan: Don't pass width/height to Surface constructors. 2019-11-04 tobine@google.com Vulkan:Ignore layer warnings about provoking vtx ext Created with: gclient setdep -r src/third_party/angle@5883a44b60c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: Ied641886e653f31821cf45d03ebadac1797f70e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897851Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712195}
-
Bence Béky authored
Multiple server developers approached me either in private or on the IETF mailing list asking for a way to test this feature. Bug: 1020233 Change-Id: Ibba5831e8153090b0dde81aa2519dfc75d4f362a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894305 Commit-Queue: Ryan Hamilton <rch@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#712194}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/48be9ec54eea..df482aad3e7e git log 48be9ec54eea..df482aad3e7e --date=short --no-merges --format='%ad %ae %s' 2019-11-04 seanabraham@chromium.org chromeos_config: make gale noncritical Created with: gclient setdep -r src/third_party/chromite@df482aad3e7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I616bd5825e0619814e041c5371955c493d6aad0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897911Reviewed-by:
-
Henry Jian authored
This is a reland of commit 274ea563 Previously, the original commit was reverted to land another CL and push the shell apk immediately. There was nothing wrong with the original CL. Since the other CL was landed and pushed, we can now reland this CL. Original change's description: > [Android WebAPK] Create resources for web shortcuts. > > Resources used need to be pre-declared in the shell. > > Since we don't know how many shortcuts are needed for a web app until > the creation request, we create 4 copies of the needed resources to > declare a shortcut, since that is the maximum number of shortcuts > allowed on Android. > > The following resources are needed (per shortcut): > - name > - short_name > - icon (placeholder taken from > https://material.io/resources/icons/?icon=filter_1&style=baseline) > The shortcuts.xml is also partially generated to use the resources, so > that building the shell apk doesn't fail. They are all disabled by > default, and will need to be re-enabled on the server-side. > Bug: 1010471 > Change-Id: I5371b145afd943029de8eb679b0cf3044545cbe3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875755 > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Glenn Hartmann <hartmanng@chromium.org> > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709189} Bug: 1010471 Change-Id: I72d7bb00e7bd80063e9eb5f87f61467ddc7a6889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895864 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712192}
-
Elly Fong-Jones authored
As of 10.15, an app must be registered with LaunchServices before the corresponding bundle ID can become a protocol scheme handler. This happens as part of app startup normally, but in tests where there is no app, it needs to be done manually. Unfortunately these tests do not have a bundle to register, so this change has them try to use the main browser bundle when registering. This is a less evil version of https://chromium-review.googlesource.com/c/chromium/src/+/1890960 Bug: 998740 Change-Id: I96b2d21b1966c304dba3d61e4539308d96221d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893582Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#712191}
-
Tim Song authored
Currently, only the quick settings bubble is updating its bounds when the display configuration changes (e.g. screen rotation). We also need to update the bounds of the message center as well. TEST=manually on tablet device BUG=1019506 Change-Id: I12e9d8f0ec92c5105f835b83a345e73f950baab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894319Reviewed-by:
-
Elly Fong-Jones authored
We never did this cleanup after shipping MacViews. This change removes all the remaining uses of it (blessedly only in tests) and removes the namespace altogether. Bug: 845389 Change-Id: Icb52064f8ad7a8c66030c941ba1cdf298a1ae73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895654 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#712189}
-
Kevin McNee authored
This tests that an extension background page is able to declare variables whose names are the same as guest view elements without the declarations being considered syntax errors. Bug: 1014385 Change-Id: I5ca92d739fe04fece2078f53e9f5eca4f73b040f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864407Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#712188}
-
Gil Dekel authored
This CL fixes a false assumption that both the horizontal and vertical sampling factors are powers of two in jpeg_image_decoder.cc when attempting to calculate the coded size of a jpeg in JPEGImageDecoder::MakeMetadataForDecodeAcceleration. Bug: 1016214 Change-Id: I687e5b9cd428abe507e22ba9d753a17b255436e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872639 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#712187}
-
Alex Cooper authored
Updates strings in keeping with UX guidance during WebXr launch review in 79 and also improves string "buildability" by making the bulleted list easier to concatenate at run time. Fixed: 1019393,1017467 Change-Id: I75bcaa1e8d6f92fd113089521fe177f6d3e48c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895395 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#712186}
-
Simeon Anfinrud authored
This target packages output artifacts into a format that the Cast internal build infrastructure expects. Bug: Internal b/143701141 Test: build atv and udon with internal patch Change-Id: I38bab1bdffbb2cb78ae503f554def458f296ab41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894831Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712185}
-
Alison Maher authored
Add support for the new system color names, Canvas and CanvasText. Canvas maps to the Window system color, and CanvasText maps to WindowText. Spec: https://drafts.csswg.org/css-color-4/#css-system-colors Intent-to-ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-apVTp8jBi0 Bug: 1015968 Change-Id: I0047e6b6d6c87f13f556d5ad147d9c4be421a592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864378 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#712184}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5f25e481c49d..5dba5c7ba486 git log 5f25e481c49d..5dba5c7ba486 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 lalitm@google.com Merge "trace_processor: add benchmark for table iterator" 2019-11-04 treehugger-gerrit@google.com Merge "processor: Extract HeapGraph parsing into module" 2019-11-04 taylori@google.com Merge "perfetto-ui: Condense track size" 2019-11-04 lalitm@google.com Merge "trace_processor: add support for like constraint" 2019-11-04 lalitm@google.com Merge "trace_processor: add benchmarks for filtering parent col in child" Created with: gclient setdep -r src/third_party/perfetto@5dba5c7ba486 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Icc8e425892d0ed149ca794e081135b868f6ce562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897908Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 176 177 TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Iacab391e8f61f7bdd3215d709e2b8a6ddf8b0186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897866Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#712182}
-
Ahmed Mehfooz authored
Bug: 1013680 Change-Id: Ic3e5ef9b61f01af716a11cf3c5de5c73f1a72e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884753Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712181}
-
Luke Zielinski authored
WPT Metadata builder bugfix - don't try to split the path for a test if the manifest returns None for that test name. Also added a unit test for this. TBR=robertma@chromium.org Change-Id: I45f2a1f2ff9380446e28d599337d22cf89830fa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897952Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712180}
-
Amin Hassani authored
Chrome OS does not use end of life status anymore. It has been replaced with end of life date. Bug: 1005511 Test: cq passes Change-Id: I0bbd438852a9243016e5e06881625da0a5149282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891467 Commit-Queue: Amin Hassani <ahassani@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#712179}
-
Bruce Dawson authored
While working on some installer changes I realized that misspelled patterns in chrome.release are silently ignored, which makes installer errors harder to find. This change adds optional diagnostics (verbose only) for patterns that don't match any files, and it cleans up the errors found by this. eventlog_provider.dll was not listed as a dependency and was therefore not reliably placed in chrome.7z. ffmpeg.dll, icudt.dll, and locales\*.dll no longer ship but were still listed in chrome.release. chrome_child.dll is missing but is retained for now so that we can go back to multi-dll builds if we want to. The default_apps and Chrome-branded logos were not in the GOOGLE_CHROME section. The only other warnings I have seen are from files that are configuration specific. We should also consider tagging which patterns are optional so that we can fail on unexpected missing files, although there may be too many files that are optional given config variations. While cleaning up the Python script I made some print-commands Python 3 compatible and changed how the archive command was printed so that back-slashes wouldn't be doubled-up. Bug: 920704, 445616 Change-Id: I96928ea1e1f18a4c52664cf19d0ccca0a10de1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894434Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#712178}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8abbd40c2a27..b2cba7759c45 Created with: gclient setdep -r src-internal@b2cba7759c45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Idd6eae1b7dad374a0008af9b270b920f5493a62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897849Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712177}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 349f218f. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 9be931cb "[WPT/common/security-features] Refactor navigable tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: timvolodine@chromium.org: external/wpt/battery-status NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9d52531cd19628e7482a958152748c3337762dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897777Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712176}
-
Nate Fischer authored
No change to production logic. This fixes a bug in aw_metrics_service_client_unittest.cc. SetInSample() should have changed IsInSample()'s return value, but it didn't. This fixes that. Tests are still passing with and without this change. Fixed: 1020780 Test: run_android_webview_unittests --gtest_filter=AwMetricsServiceClientTest.* Change-Id: Id2061d6cf80129cfa1dfb29a869e185615526fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895900 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#712175}
-
Sasha McIntosh authored
Add field trial testing for android webview tot the finch experiment DecodeWebPToYUV. Bug: 966008 Change-Id: I0939b730e5736b5bc9a6b6a194ee13aa3e8925d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895513Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Auto-Submit: Sasha McIntosh <sashamcintosh@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#712174}
-
Daniel McArdle authored
Bug: 1016184 Change-Id: I794d668dbfe12cc713e435ddc086490787627afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894462Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#712173}
-
Ahmed Fakhry authored
The Files app, as well as other apps, if they're evicted due to being occluded by other windows, will show as empty for a second or more in overview until reloaded. This CL makes them behave the same way as browser windows, that is they show stale contents until reloaded. BUG=986085 TEST=Manually: follow steps on bug, and note the issue no longer shows. TEST=Added new: browser_tests --gtest_filter=AppWindowBrowserTest.ShouldShowStaleContentOnEviction Change-Id: Ie5ad2f07be3eae8627f16d9ddd3977d22f9085a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894095Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
