- 24 Feb, 2020 7 commits
-
-
Anand K. Mistry authored
...where ChromeAsyncExtensionFunction is not used. Bug: 634140 Change-Id: Idd33df8e183cb716a9c430fda1cd17f3ededbe65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067817 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#743854}
-
Isabella Scalzi authored
Tests that after clicking on an image in Quick View, the user can still cycle through file list items, and also exit Quick View. Bug: 1038835 Change-Id: I375461d934d9398ca04edbb8d9f25d9503e49a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067820 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#743853}
-
Joel Hockey authored
Terminal System App uses an almost black (#101010) theme by default for the main tabbed window. However, UX have requested that the settings page always use white for the frame, similar to OS settings. Screenshots: old: crbug.com/1033339#c7 new: crbug.com/1033339#c19 Since both windows are part of the same app, and it is not possible to have a manifest with 2 different themes specified, we will control the theme for System App TYPE_APP_POPUP to always use default which is white for light-mode, and something suitable for dark-mode. Fix for BrowserNonClientFrameViewMac which had not yet been updated to support browser TYPE_APP_POPUP as revealed by the included test. Bug: 1033339 Change-Id: I7b0d7cc291e5f5895ddfda2ad384256c3519d0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066378 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#743852}
-
chrome://help-appRachel Carpenter authored
This CL defines a mojom file for the mojo interface between the Browser and the chrome://help-app page and implements the relevant CPP (Page Handler) and JS (mojo_api_bootstrap.js) interfaces. This interface is leveraged to expose the native browser open feedback dialog functionality to the page via a HelpAppUIDelegate. This Cl also adds the kFeedbackSourceHelpApp constant to the chrome::FeedbackSource enum to allow feedback dialogs opened by the help app to be correctly logged. Bug: 1012578,b/149709102 Change-Id: I2f8dbeeb03eebfaf4b43e4757e3830d79943ae41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064646Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#743851}
-
Victor Costan authored
This CL removes the content::OnceCompletionCallback alias, and replaces it with net::CompletionOnceCallback. Explicitly referencing the net:: namespace is intended to be a readability improvement, because it makes it clear that the callback's int argument follows the //net convention, where negative values are errors, and non-negative values are byte counts. Bug: 1055133 Change-Id: Ie5057f0abe27f97620ce1897ac839e9e1d53bf82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069507 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743850}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d1c90e10f0ca..998066127e0d git log d1c90e10f0ca..998066127e0d --date=short --first-parent --format='%ad %ae %s' 2020-02-23 benjaminwagner@google.com Update XCode Created with: gclient setdep -r src/third_party/skia@998066127e0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Idcc0c198a73b31dd5146cd8a18dee270266d9ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069897Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743849}
-
Eric Willigers authored
The result of GetAppLaunchURL() is no longer being used in WebAppUninstallBrowserTest::UninstallWebApp(). The call is removed. Change-Id: I39552fd7ce852fbf79a72b2559e06c8b581bae00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067772Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#743848}
-
- 23 Feb, 2020 30 commits
-
-
Rohit Rao authored
The policy system is initialized before about:flags or field trials, so it is not possible for either of those mechanisms to decide whether or not policy should be enabled at runtime. Instead, we will switch to looking for the presence (or absence) of a command line flag. This will allow us to easily turn policy on locally during development, and when we are ready to ship policy support, we can remove the command line flag. This partially reverts commit 8eefc0a1. BUG=1024115 Change-Id: I0839aa1ab0bd68b149d900dfe522b6d4081b5e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068681 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#743847}
-
Andreas Haas authored
ArrayPiece was only used by DOMArrayPiece, so I moved the implementation to DOMArrayPiece and deleted ArrayPiece itself. R=haraken@chromium.org CC=ulan@chromium.org Bug: chromium:1008840 Change-Id: If82cf00e2afac02d3e72882654751f596e1cd9b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066792Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#743846}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1e891d93. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia799561f9ae0e6fcdf684df1a727aa8db170a401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069857Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743845}
-
Lan Wei authored
This reverts commit 9658e86d. Reason for revert: <INSERT REASONING HERE> virtual/threaded-prefer-compositing/fast/scroll-behavior/main-frame-interrupted-scroll.html virtual/threaded-prefer-compositing/fast/scroll-behavior/subframe-interrupted-scroll.html virtual/threaded-prefer-compositing/fast/scroll-behavior/main-frame-scrollLeft.html are flaky on Builder Mac10.13 Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29?limit=50 Original change's description: > Skip commits for threaded scrolls. > > Threaded scrolls unnecessarily cause commits on every change. This > patch implements an optimization from pre-BlinkGenPropertyTrees in > layer list mode to avoid these commits. > > When an impl-side scroll occurs, cc can immediately apply the scroll > before notifying blink so that the blink update only causes a commit if > needed (e.g., interest rect changed). This has been implemented in > LayerTreeHost::UpdateScrollOffsetFromImpl. A second change was needed in > PropertyTreeManager::DirectlyUpdateScrollOffsetTransform to avoid > commits if cc already matches blink. > > Bug: 1048384f > Change-Id: Iae670ce3f99e1f8da83ae46e43f38356bf39f6c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058476 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743622} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1048384f Change-Id: I4ded532f492778c3603d875ec7d93218bc60bfca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069837Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#743844}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9e8f60534464..d1c90e10f0ca git log 9e8f60534464..d1c90e10f0ca --date=short --first-parent --format='%ad %ae %s' 2020-02-23 benjaminwagner@google.com Whitespace change to re-trigger Mac/iOS tests Created with: gclient setdep -r src/third_party/skia@d1c90e10f0ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Iba52a886dcab1194702222a35398e0f51ae52f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069782Reviewed-by:
-
Side Yilmaz authored
|getLastUsedProfile#hasOffTheRecordProfile|. |Profile#getLastUsedProfile| is depreciated and replaced with |Profile#getLastUsedRegularProfile|. This change replaces |Profile#getLastUsedProfile#hasOffTheRecordProfile| with |Profile#getLastUsedRegularProfile#hasOffTheRecordProfile|. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I57d1885c80770e8652ac3c1dc04cb82cb55b1010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064391Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743842}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d67e745f2923..5d18d90435ae Created with: gclient setdep -r src-internal@5d18d90435ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I16bb0107182c18ba72430a2f5a805d2490a4c456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069781Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743841}
-
Lan Wei authored
This reverts commit fbf84f9e. Reason for revert: <INSERT REASONING HERE> external/wpt/storage-access-api/requestStorageAccess.sub.window.html fast/peerconnection/RTCPeerConnection-applyConstraints-remoteVideoTrack.html fail on Builder Mac10.10 Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests?limit=100 Original change's description: > Import wpt@4ee848f494e37b02a7ff884dc405931bc4fe61b0 > > Using wpt-import in Chromium f385e383. > With Chromium commits locally applied on WPT: > d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" > 76ee218c "Split html/.../query-encoding/ tests" > 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" > > > Note to sheriffs: This CL imports external tests and adds > expectations for those tests; if this CL is large and causes > a few new failures, please fix the failures by adding new > lines to TestExpectations rather than reverting. See: > https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md > > NOAUTOREVERT=true > TBR=robertma > > No-Export: true > Change-Id: Ia67915c254a9ddfab4a877bacbf5a3e39dacc2dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069517 > Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#743817} TBR=robertma@chromium.org,wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com Change-Id: Iccc921fe3d653816e0d267c3c7a2741616ae1566 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069276Reviewed-by:
-
Lan Wei authored
This reverts commit 9ba868cd. Reason for revert: <INSERT REASONING HERE> interactive_ui_tests failed on Builder Linux TSan Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests Original change's description: > Create field trial for hover card images. > > This is required to deploy a finch configuration. > See cr/296239960 for WIP Finch config. > > Bug: 1032640 > Change-Id: Ifae3d2966d4ca908982cec37c5d88f786bf07367 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067558 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743826} TBR=rkaplow@chromium.org,dfried@chromium.org Change-Id: I27fbe4d67b42a42d63757e78427d86d31e045592 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1032640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069275Reviewed-by:
-
Christos Froussios authored
The feature is still under development. Change-Id: I1df61d578a7b70827f61d4484d1f80a5997d5f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065669 Auto-Submit: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#743838}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e03f6e1cacc3..d67e745f2923 Created with: gclient setdep -r src-internal@d67e745f2923 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If6da003d905992fce901af406179f9ef824a23c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069778Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af2194d1eb5e..e03f6e1cacc3 Created with: gclient setdep -r src-internal@e03f6e1cacc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I499ba9d39cc804d65297b4f5d85991a9bcb30e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069515Reviewed-by:
-
Joshua Pawlicki authored
Bug: 1054807 Fixed: 1054807 Change-Id: Ib7edaa00d05a68c4ca6b7a2fbe563fe09e25de83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068054 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#743835}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/104aa266e8e5..af2194d1eb5e Created with: gclient setdep -r src-internal@af2194d1eb5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ibcd384f4e6167090d105a52bdd5877600b36b871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069514Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/847856089dc3..214ec337a0b2 git log 847856089dc3..214ec337a0b2 --date=short --first-parent --format='%ad %ae %s' 2020-02-23 thakis@chromium.org Fix Wrange-loop-analysis warnings in swiftshader. Created with: gclient setdep -r src/third_party/swiftshader@214ec337a0b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1039697 Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic8ffe528de4710dd7df676944494de3c86424830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069513Reviewed-by:
-
Nico Weber authored
Bug: 1039697 Change-Id: Ibcfdf5f2b6142c29b028fb65c43889ce27eeac83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068314 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 1434 1437 1439 1441 1444 1445 1446 1447 1448 1449 1450 1451 1452 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 6 lines were removed and 19 lines were deflaked by consecutive results since 1506. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: If454cad4ef4be8f1890e454a9b358e356ead46b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061911Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#743831}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f0b181e44e96..104aa266e8e5 Created with: gclient setdep -r src-internal@104aa266e8e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9ccfbd59c8149a8e546ede367e114ddd81494f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069511Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60bf80eda8a8..f0b181e44e96 Created with: gclient setdep -r src-internal@f0b181e44e96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I3196a0c81a370af2a5609aee2d77574074c68a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069505Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2feb0e216c9a..60bf80eda8a8 Created with: gclient setdep -r src-internal@60bf80eda8a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Icf002fc6c3503c1bf353a59db7910b86c943c63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069602Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/07cf1f5a..a66f0bf6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If1e5cd3f23d4bf915afaf9883c9bf8be05a781af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069435Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743827}
-
Dana Fried authored
This is required to deploy a finch configuration. See cr/296239960 for WIP Finch config. Bug: 1032640 Change-Id: Ifae3d2966d4ca908982cec37c5d88f786bf07367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067558Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#743826}
-
Anand K. Mistry authored
This function is no longer necessary and can be replace with base::DoNothing(). Bug: None Change-Id: I0dabca9cae4dae091fa15bb5fd0c487a62eb3b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063510Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#743825}
-
Dana Fried authored
This reverts commit ef8dbf91. Reason for revert: Fixed tests that are still failing/flaky. Some of the logic around the layout of the PWA window in the original patch was not as deterministic as it should have been, which caused test flakiness. This addresses the problem along with several related bugs. One of the fixes in this CL is to return the final resize of the failing test back to something equivalent to the logic prior to the original version of the patch, which was clearly done in a particular way to handle different layout pathways on different platforms. Original change's description: > Revert "Reland "Make PWA titlebar and icons flex and animate properly."" > > This reverts commit e490a00a. > > Reason for revert: Sheriff here: > Consistent failure of Linux MSan Tests: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests > First failed run: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/22357 > > Original change's description: > > Reland "Make PWA titlebar and icons flex and animate properly." > > > > This reverts commit de7cd485. > > > > Reason for revert: Fixing issue with Mac tests. > > > > Original change's description: > > > Revert "Make PWA titlebar and icons flex and animate properly." > > > > > > This reverts commit 8f2f4243. > > > > > > Reason for revert: speculative revert for test failures on Mac > > > for WebAppFrameToolbarBrowserTest.SpaceConstrained, see e.g. > > > https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/31700 > > > > > > Original change's description: > > > > Make PWA titlebar and icons flex and animate properly. > > > > > > > > Nested layouts now allocate available space properly to their > > > > descendents. Also, we consistently use flex layout in the PWA titlebar. > > > > > > > > Removed a couple of invalid assumptions that were encoded as DCHECKs. > > > > > > > > There are still some inkdrop issues but they are purely cosmetic, see > > > > crbug.com/1006162 for more detail. > > > > > > > > Bug: 1048061 > > > > Change-Id: I403b71b5e2bbcb2d461e1ed6c543c76f91d4c652 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036264 > > > > Commit-Queue: Dana Fried <dfried@chromium.org> > > > > Reviewed-by: Peter Boström <pbos@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#738874} > > > > > > TBR=pbos@chromium.org,dfried@chromium.org > > > > > > Change-Id: I731bad118043652a6dbd082c6099ebbd0c697835 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1048061 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041615 > > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#738907} > > > > TBR=pbos@chromium.org,mastiz@chromium.org,dfried@chromium.org > > > > Change-Id: Idb9712d1ffe45bf374af846278e26d61983a44f0 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1048061 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042326 > > Reviewed-by: Dana Fried <dfried@chromium.org> > > Commit-Queue: Dana Fried <dfried@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#742203} > > TBR=pbos@chromium.org,mastiz@chromium.org,dfried@chromium.org > > Change-Id: If65099915ea0efa01de8cc9b0df0a7e9bf03a60b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1048061 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062996 > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742549} TBR=pbos@chromium.org,poromov@chromium.org,mastiz@chromium.org,dfried@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1048061, 1050957, 1053899 Change-Id: I5e709a60ae2bd1331bb48687fa9af68d7833b9a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067639Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#743824}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/93f917a48395..878e5f26c327 git log 93f917a48395..878e5f26c327 --date=short --first-parent --format='%ad %ae %s' 2020-02-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@878e5f26c327 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibd70379ce353879d37f70275432e0ff71631edcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069601Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I926acdcc4a00ff4fdefafc03bc017a5e0b8a46c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067152Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743822}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/86b5a1daaf14..2feb0e216c9a Created with: gclient setdep -r src-internal@2feb0e216c9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifea8fde093e5981f5d1472d5c35b41f39dad58ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069599Reviewed-by:
-
Michael Spang authored
This function is needed for GL/Vulkan interop on Fuchsia. Bug: 766360 Change-Id: I37645fc29fbadd49f48eefbaf4849daa1be82a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069178 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743820}
-
Nico Weber authored
Bug: 1039697 No-Presubmit: true Change-Id: Iad7f37f56377633d0503989f64c954825489a338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068136 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1137a90e6506..86b5a1daaf14 Created with: gclient setdep -r src-internal@86b5a1daaf14 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I2fbf367149b186c225adbe15c12395904924f850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069597Reviewed-by:
-
- 22 Feb, 2020 3 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium f385e383. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia67915c254a9ddfab4a877bacbf5a3e39dacc2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069517Reviewed-by:
-
Mehran Mahmoudi authored
The native implementation of UnguessableToken does not keep a reference of its Java counter-part. Therefore, having a Java equals() method comes in handy. Among other things, hashCode() enables UnguessableToken to be used as a key in HashMap. Change-Id: I062d462298990b23da22c87028a5b0520791c00d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067670 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#743816}
-
Jann Horn authored
Interpret BTN_SIDE and BTN_EXTRA as "back" and "forward" commands. BTN_BACK and BTN_FORWARD are already supported for triggering navigation; however, mouse side buttons for navigation trigger BTN_SIDE ("back" button) and BTN_EXTRA ("forward" button). Add support for these, so that these buttons work the same way they did under X11. This also matches how Android interprets these events: https://source.android.com/devices/input/touch-devices#buttons See also https://www.spinics.net/lists/linux-input/msg60756.html , which says: > In practice on most mice which have more then 3 buttons, usage 4 is > used for the back(ward) button and usage 5 for the forward button. > > This means that these buttons generate an input_event code of > 0x113 resp. 0x114, which looking at the old defines maps to > BTN_SIDE and BTN_EXTRA. > > Under X these are mapped to buttons 8 resp. 9; and under wayland > the input_event code is passed through unmodified. > Apps, e.g. Firefox both when running as Wayland client under > GNOME3 and when running under Xorg, correctly interpret these as > back and forward. > > So we've back and forward buttons generating BTN_SIDE and BTN_EXTRA, > which the apps then interpret as BTN_BACK and BTN_FORWARD, rather > then as BTN_SIDE and BTN_EXTRA (which have no clear meaning). Test: manual: run with wayland, navigate, and press back/forward Change-Id: Ibf4c9112c859f6daa3cb0635f8bc1d532d1c917c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069537 Commit-Queue: Jann Horn <jannh@google.com> Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:Michael Spang <spang@chromium.org> Auto-Submit: Jann Horn <jannh@google.com> Cr-Commit-Position: refs/heads/master@{#743815}
-
