- 27 Oct, 2020 40 commits
-
-
Keishi Hattori authored
This reverts commit 77307244. Reason for revert: collected crash dumps so we can turn it back to DCHECK Original change's description: > [PartitionAlloc] Temporarily use CHECK in SetFreelistHead > > Temporarily use CHECK in SetFreelistHead to debug a crash. > Should be reverted after a Canary release. > > Bug: 1137799 > Change-Id: I9e01a5cdfafb7da2af76997f8c42716394ac4cd3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491724 > Reviewed-by: Benoit L <lizeb@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819797} TBR=yukishiino@chromium.org,tasak@google.com,haraken@chromium.org,keishi@chromium.org,lizeb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1137799 Change-Id: I645119e34f6767b9e6a6d1fc739efb0e2c85aff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500387Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821094}
-
Xianzhu Wang authored
Bug: 1101002 Change-Id: I326d9949765f6f821502e439f0b2bfc7156023c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496186Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821093}
-
Kent Tamura authored
They referred to the container of the fieldset incorrectly. Bug: 1140595 Change-Id: Ib70048c4e5e59bfd96f44b04ae0c23271e47e840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497945 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#821092}
-
David Dorwin authored
These unit tests have their own CMX files that enable running hermetically with run-test-component. As discussed in the bug, these don't need security review, and renaming them avoids the presubmit check when maintaining them. Also remove OWNERS rules that applied only to the renamed files. Bug: 1132878 Change-Id: I3f211584d164e99455e98c3837ec3cea80c50910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482028Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Auto-Submit: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821091}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=caseq@chromium.org Bug: 1142671 Change-Id: I2a5d18034d8ec6279ba8330d54e2f093b45fbb64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500607 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#821090}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=avi@chromium.org Bug: 1142671 Change-Id: Ic9abe2e32995cdd2f1e50ae5b86d8980fc167e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501121 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821089}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=caseq@chromium.org Bug: 1142671 Change-Id: Iade09088b5a7da8fb5bc0604facb2e0f9cb63218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500496 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
Bug: 908955, 997108, 997109, 990868 Change-Id: Ieb98aa1b22a8b16c45a41a523b562d7b091d01dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500447Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#821087}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8d0801430595..160e3844d960 2020-10-27 soxia@microsoft.com Roll-deps and generate protocol resources. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I757e9fd3b79f6bb051e5b0c5bfb7b99aa565ceec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500253Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821086}
-
Lukasz Anforowicz authored
Fixed: 1133097 Change-Id: I7f3da3d24bd21797719ad7b5980d2d5d8def7511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493661 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#821085}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=avi@chromium.org Bug: 1142671 Change-Id: I5c57953a34cbab3cdafb0ce371a75297bfc7abde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500571 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
Shakti Sahu authored
This CL updates the field trial testing config for the launch group, and removes the non-launch groups for query tiles experiment. Bug: None Change-Id: Ie3a61d3d61df175bb815818ac351be4471bede1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495871Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821083}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=falken@chromium.org Bug: 1142671 Change-Id: Ie6c1889b3eff87c5c7edb4071f31767be2c8a1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500614 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#821082}
-
Takashi Sakamoto authored
Bug: 1086388 Change-Id: I6d10c4f8289cc6555f5d71a664fbc3d3d677ca7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498023Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#821081}
-
Jason Lin authored
We are making the permissions persistent across chrome restarts, so we have to change the way the permissions are stored (currently, they are stored as member variables initialized to false). Note that this CL still resets the prefs values to false in `PluginVmManagerImpl::OnPrimaryUserProfilePrepared()` because the required permission indicators/notifications are not ready yet, so the behavior for now is actually going to be the same. This CL also fixes the bug that pressing <esc> key on the relaunch dialog does not recover the toggle state. This CL also simplfies the code by: * removing <plugin-vm-permission-dialog> --- it is simpler to use <cr-dialog> directly. * replacing `wouldPermissionChangeRequireRelaunch()` with `isRelaunchNeededForNewPermissions()` --- The toggle is the only way the user can change the value, so there is no need for the c++ code to check whether the values are actually different. Bug: b/167491603 Change-Id: I423e1d03db6e4d2b52fefc052c22eb4f27733425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488262 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#821080}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib58ad8f95c2e33f5765c878d25f47ff52a035e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500908Reviewed-by:
-
Rachel Carpenter authored
This launched successfully in M86, and removing the feature will allow us to clean up the code paths and make suggestion chip logic cleaner. Also add an OWNERS file for release_notes seeing as our team owns this code now. Bug: b/171516802 Change-Id: Ic23d531548fce8c68ab481c49bbdf760db7de747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493740Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#821078}
-
David Bokan authored
Looks like this file was created in https://crrev.com/7e604982ddd8d0c400 and accidentally included the old-style license header as well as the new. Bug: 536305 Change-Id: I3ebc8d5ddafba52c5cdf1fb168d880bd2868919d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500866 Auto-Submit: David Bokan <bokan@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#821077}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: If9e50e0e4d33509c0758f8e16e43fa464ffa1264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500364Reviewed-by:
-
Koji Ishii authored
Currently the infinite rewind loop does not frequently occur, but it exists, and recent issues indicated that minor changes may hit it. This patch enables the rewind-loop detector added for DCHECK-builds in r696740 crrev.com/c/1801474 for non- DCHECK-builds. When it hits, it fires |NOTREACHED| and end the line breaker. This patch also fixes the detector not to misfire when rewinding to index 0 by using |Optional|. Bug: 1132811 Change-Id: Idc4a8de5484b8f2df90b7f8525139ae99be6b9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498983Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#821075}
-
Kunihiko Sakamoto authored
This reverts commit f6a05301. Reason for revert: virtual/layout-ng-grid/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-*.html are failing in multiple bots. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/75331 https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/9841 https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/17342 Original change's description: > [GridNG] Implement alignment within grid-areas. > > This patch implements alignment within a grid-item's grid-area. > When creating the GridItemData we read of the containers, and > grid-item's style, or determine its alignment axis-edge, and if it > should be stretched, saving this information on the GridItemData. > > When placing the grid-item it will use this to adjust the offset. > > This doesn't implement baseline alignment which requires a secondary > pass to correctly determine the baseline for the column/row. > > The other TODO relates to the constraint-space API, and how grid will > need a slightly new concept in order to do block-axis stretching > easily. By default non-replaced grid-items will stretch to the available > space. A new bit on the space can indicate that we should stretch to > the available space (if possible), this is similar to the shrink-to-fit > bit we have today. > > This adds a self-start/self-end test as after implementing this now new > tests passed immediately, and I don't believe we had good test > coverage for inflow content with these keywords. > > Bug: 1045599 > Change-Id: I8c9cc51381c3d75519e52b32472b58ec96a6a85a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492176 > Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#821043} TBR=cbiesinger@chromium.org,ikilpatrick@chromium.org,kschmi@microsoft.com,ansollan@microsoft.com Change-Id: I0a9398ce4bf339a632c3baed7374754f3c664496 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500969Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#821074}
-
Martin Kreichgauer authored
When processing a MakeCredential request with ResidentKeyRequirement "preferred", authenticators can fail creation of the discoverable credential with CTAP2_ERR_KEY_STORE_FULL if their internal storage is exhausted. Chrome will then try to make a non-discoverable credential; however both of these requests will consume a user presence touch. This change plumbs the authenticatorGetInfo response remainingDiscoverableCredentials field into MakeCredentialRequestHandler, so that we can first check whether internal storage is exhausted and only request a non-discoverable credential in that case, reducing the number of required touches to one. Because remainingDiscoverableCredentials is only supported in CTAP 2.1, those authenticators can still fail with CTAP2_ERR_KEY_STORE_FULL, and users will have to tap them twice. Bug: 1117630 Change-Id: I5c5b432e3cce80c20654fa2588cf72ffaceeca61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493782 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#821073}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=ksakamoto@chromium.org Bug: 1142671 Change-Id: I58ff750aed0569b77cac8e1001fa1672437eb1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501127 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
Bo Majewski authored
Use modules to load main class and browser proxy. Actually calls browser proxy. Bug: 1113981 Change-Id: Ia5df25c26c8e2131cab9663382680156e1304b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497901 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#821071}
-
Noel Gordon authored
Create the element content the way we do with the <bread-crumb> custom element (which came latter). No change in behavior: covered by FilesMessage unittest. Bug: code-health Change-Id: Id568aa6b5644a712db88ba5f4fa8d3d13f323b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500685 Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#821070}
-
Meilin Wang authored
This CL fixes the bottom padding of the quick action view when there are no continue browsing chips shown below. Screenshots: https://screenshot.googleplex.com/3L2rq3Z2WPYhNgN.png (before) https://screenshot.googleplex.com/8TxuihZsi4TZobu.png (after) BUG=1106937,1126208 Change-Id: I8cfd9d60d72951ef1341f69e910f4b4e46285297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495676 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#821069}
-
Kunihiko Sakamoto authored
Bug: 1142682 Tbr: weili@chromium.org Change-Id: I94bd69c6f92713cf4db529e385c28067413f4d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500965Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 1142671 Change-Id: Idf1a6a3c792f968c39a3f22eea057d58b35f6c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501126 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#821067}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 88-4280.20-1603104419-benchmark-88.0.4300.0-r1 to 88-4280.20-1603104419-benchmark-88.0.4303.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Icb778adc45b65f1a07df0a63b1a593276303dc27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500365Reviewed-by:
-
Avi Drissman authored
As promised, the policy to allow popups during page unload is being removed for Chromium 88. Bug: 937569 Change-Id: I1064da7d5debc640c6179b87775afa20d92d74be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491120 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#821065}
-
Victor Costan authored
Change-Id: I1a94ca367a960989747bbf611558b1b1efc295a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344655 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#821064}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=tapted@chromium.org Bug: 1142671 Change-Id: I28c30536bc396847389eb4a3ad7b6c3f6d93529d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500560 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
Minoru Chikamune authored
Context: For MBI, per-AgentSchedulingGroup task runners should be used where appropriate. What this CL does: Use per-AgentSchedulingGroup task runners for AgentSchedulingGroup's mojo interfaces instead of per-thread task runners. Bug: 1105403 Change-Id: I67b6e21e353808ea2b922a1bb1480f62f73feae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497868Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#821062}
-
Kent Tamura authored
This CL ports LayoutTextControlSingleLine::UpdateLayout() to LayoutNG by * Adding "-internal-align-self-block" CSS property * Implementing centering behavior in NGBlockLayoutAlgorithm * Apply the property to text field's InnerEditor boxes and decoration container boxes "-internal-align-self-block" will be applied to button's anonymous block and slider's track box too. This CL has no behavior changes for now, but it fixes dozens of web test failures with LayoutNGTextFields flag. Bug: 1040826, 1131352 Change-Id: Iaa75fdd53ce428c90b12fd695f49752da0ea9247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491766Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Ken Rockot authored
Application code may call mojom structs' generated Serialize() method to produce a local array of bytes representing the serialized object. These methods ultimately use the same message serialization logic that applies to IPC messages. Soft size limit checks are done during the serialization process, and so manual Serialize calls can still trigger crash dumps when serializing very large objects. Since the intent of the checks is to reveal oversized IPC messages for performance reasons, there's no reason to apply them on these Serialize calls. This CL modifies the common path used by all generated Serialize() methods to ensure that the size checks are bypassed. Bug: 1141987 Change-Id: I936ba58cf682c4b63310f746cd19a933c82a70b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495835Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#821060}
-
Kenichi Ishibashi authored
Bug: 1055677 Change-Id: I3d91b8a72ef19c3577663d0dd84c0579b7f33fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500963 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821059}
-
Kenichi Ishibashi authored
We removed AppCache dependencies from service worker as of crrev.com/c/2452029. Remove unused includes. Bug: 1117369 Change-Id: If5133261a88ae47229d37826d14816a46b35e7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500386 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Noel Gordon authored
Add new test Option for media_swa and use it in enable and load SWA in test from file_manager_browsertest_base.cc. Remove the SWAsFilesAppBrowserTest fixture: move its media SWA test to the FileManagerBrowserTest fixture. Bug: 1122379 Change-Id: Ifbe75220777d0115a8e81c61ff2bb7fea447dcf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500683Reviewed-by:
-
John Palmer authored
This reverts commit d2fd3739. Reason for revert: Changing this to a private API as it is only going to be for private usage as part of a core chrome OS feature. Original change's description: > Add JS API for chrome.input.ime.autocorrect > > BUG=1138092, 1111135 > > Change-Id: I35366c90794f9e26917360464ec3553798073a65 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483719 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Keith Lee <keithlee@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Commit-Queue: John Palmer <jopalmer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820993} TBR=xiyuan@chromium.org,mpearson@chromium.org,mlippautz@chromium.org,tranbaoduy@chromium.org,keithlee@chromium.org,jopalmer@chromium.org Change-Id: I77c44b870eeca0cee4f23c04d806bb985d300c1e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1138092 Bug: 1111135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500682 Auto-Submit: John Palmer <jopalmer@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#821056}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6b0ecd8197ff..8d0801430595 2020-10-26 changhaohan@chromium.org Angle component style fixes 2020-10-26 anthonyxie64@gmail.com Fix search index for JSON sources when no match found If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1126178,chromium:838311 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5fb39ed304aa03dd0dbfc518faeecd7f3a42bffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500549Reviewed-by:
-
