- 28 Jan, 2020 40 commits
-
-
behdad authored
Unittests are added to test the functionalities of representative perf test scripts. Bug: chromium:1029952 Change-Id: Ie3ab5d1a976d9511fbde6a401fc544ead3e50091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017163 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#736014}
-
Daniel Libby authored
This CL implements percent-based scrolling for Windows. This makes mousewheel initiated scrolls be interpreted as a percentage of the size of the intended scroller, instead of being translated directly into pixels. This is done as a part of the effort to port Edge-style scrolling into Chromium. The deltas reported by the wheel event are unchanged in order to maximize compatibility with the web. Bug: 1009735 Change-Id: I4987cb6916fe5961cdb479018ccd7a464d574ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776898 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#736013}
-
Mingjing Zhang authored
Histogram History.DomainCountQueryTime is now emitted with SCOPED_UMA_HISTOGRAM_TIMER instead of an explicitly maintained timer; Typos and other minor nits in HistoryService unittests are also fixed. Change-Id: Idbd3ff3fb676a00ae21db1ef126d67afe947a161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023233 Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#736012}
-
Sylvain Defresne authored
Change remoting code to only link with MaterialComponents.framework if the code is compiled as a framework (this will allow removing the fake targets that exists in ios/third_party/material_components_ios/BUILD.gn). If using MaterialComponents.framework, then bundle it with the app. This is a reland of https://crrev.com/c/2020960 with a fix for the compilation of ios_remoting_unittests when building a framework for MaterialComponents (which is the default on the internal builder and why the original CL was reverted). Bug: 1040871 Change-Id: I77bb04480bc6b7b1a01133a795f73bc5860b7686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023888Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#736011}
-
Daniel Murphy authored
IndexedDB doesn't need to know the file path for V8 File objects, as these work just fine being hooked up to a mojo blob handle. This CL removes all usages of external file paths in IndexedDB, and removes them from even being serialized from the renderer. Bug: 1036415 Change-Id: I6e074c5fe11654faaf2afb56d8fe290ded4f408e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978848 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#736010}
-
Matt Menke authored
The DNS cache is now a per-NetworkContext cache, instead of a global, so clearing the cache when closing incognito is no longer useful - destroying the incognito profile will destroy its own DNS cache. This CL also updates the network::mojom::HostResolver API to allow stale DNS lookups. I'm adding a lot of tests for DNS cache isolation, and this option is needed to avoid tests racily failing due to DNS cache eviction, particularly on slower bots. This option was already supported by the HostResolver; it just wasn't being exposed outside the network service. Bug: 1042354 Change-Id: I8cd4332f6d28b5cc783b256550f720807cfb9c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023507Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#736009}
-
Gavin Williams authored
-Add a property to cr-searchable-dropdown so we can track whether the user's current text input in the dropdown matches the previously saved value. This flag will be used to disable certain user actions if the dropdown is invalid. Bug: 950887 Change-Id: I578086632568dc0e76ec8bb2726dd002158392dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016334Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#736008}
-
Toni Barzic authored
If no buttons are shown in the shelf navigation widget, we should hide the widget background, too. BUG=1012814 Change-Id: I6763c6719d256b2b07b74c06948af96074ae4851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025636Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#736007}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/260c788d77ca..8c52e8a2efb0 git log 260c788d77ca..8c52e8a2efb0 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 philipp.hancke@googlemail.com remove mention of prebuilt libraries from docs/ Created with: gclient setdep -r src/third_party/webrtc@8c52e8a2efb0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib410cf244d99986c8e1df7aa5a309057ca7d9624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025322Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736006}
-
Mike Wittman authored
Removes the underscore suffix from the struct field. TBR=gab@chromium.org Bug: 1034758 Change-Id: If333f144770d35753f5d5418071009e7cd9d7575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024690Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#736005}
-
Trevor Perrier authored
This CL makes it so that all locales are used during resource_packaging It looks like previously resource_packaging was only called for apk builds. But now that it is also used for bundle builds the locales for Android bundles should be included as well. Before this change all language splits for the 27 + 9 new languages recently added to Clank were about half the size as older languages in monochrome_public_bundle.apks After this change the new languages and old languages are about the same size in monochrome_public_bundle.apks. Example Before (af,as, az, be, bn, and bs are new languages): 158921 2001-01-01 00:00 splits/base-af.apk 424765 2001-01-01 00:00 splits/base-am.apk 432527 2001-01-01 00:00 splits/base-ar.apk 226815 2001-01-01 00:00 splits/base-as.apk 165763 2001-01-01 00:00 splits/base-az.apk 203683 2001-01-01 00:00 splits/base-be.apk 473236 2001-01-01 00:00 splits/base-bg.apk 234710 2001-01-01 00:00 splits/base-bn.apk 163986 2001-01-01 00:00 splits/base-bs.apk Example After: 305787 2001-01-01 00:00 splits/base-af.apk 424765 2001-01-01 00:00 splits/base-am.apk 432527 2001-01-01 00:00 splits/base-ar.apk 569512 2001-01-01 00:00 splits/base-as.apk 325961 2001-01-01 00:00 splits/base-az.apk 468522 2001-01-01 00:00 splits/base-be.apk 473236 2001-01-01 00:00 splits/base-bg.apk 577862 2001-01-01 00:00 splits/base-bn.apk 324504 2001-01-01 00:00 splits/base-bs.apk Bug: 1035665 Change-Id: I31d3bddba38148931212e6bccb63155376b82bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024159Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#736004}
-
Yi Gu authored
SnapAfterLayout is ready to ship in M81 since blocking bugs are fixed. Bug: 866127 Change-Id: I77447e74547f670ecba11cb56696821e294821e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025321Reviewed-by:
-
Vladislav Kuzkokov authored
Bug: None Change-Id: I101957f747559b074fc6dd6fb58f2b544303501a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025368 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#736002}
-
Alexander Hendrich authored
This CL adds the bottom status indicator depending on the OobeDialogState. When the extension UI is visible, the bottom status indicator will be hidden. Bug: 1042944 Change-Id: I572c7c022ae0d58e1618a2e2e7cb9add37b036f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023657Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#736001}
-
Theodore Olsauskas-Warren authored
Previously within the GetAllSites handler encapsulation was broken by reaching directly into ContentSettingsType::PERMISSION_AUTOBLOCKER_DATA raw data to determine which sites were under embargo. As part of the privacy settings redesign, additional handlers will be interested in this information. This CL extends the permission_decision_auto_blocker to provide this functionality itself and refactors the GetAllSites handler to use it. Bug: 1032584 Change-Id: I57632a4272896ad98079bede96d660578bf1a179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013118Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#736000}
-
Richard Knoll authored
Extract MockSharingDeviceSource, MockSharingMessageHandler and MockSharingMessageSender as they were implemented 3 times each in our tests already. This makes it easier to refactor these base classes in future. Bug: None Change-Id: I5cbcfebe55c2d41f66c91487039ab066db8b55e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023832Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#735999}
-
Moe Ahmadi authored
http://screenshot/d4Noo0ggQW3 http://screenshot/XMXnBaPDYDi Bug: 1041124 Change-Id: I4ede6366fc8f639f14208e4f4cb7fc86ab16f58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017931 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#735998}
-
Li Lin authored
Histogram similar to other clicks (with result type NoResult) recorded to understand user clicks when result is not available: * QuickAnswers.Click (enum="QuickAnswersResultType") * QuickAnswers.Click.Duration - Aggregated duration across result types * QuickAnswers.Click.Duration.NoResult - Duration for each result type The duration logged is: * Clicks before fetch finish: 0ms * Clicks after fetch finish: duration between fetch finish and clicks Bug: 1044413 Test: Manual Change-Id: I30a697775147e9b5d642fbac9e4c5dd2fe0ad3f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023989Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735997}
-
Yi Gu authored
The tests external/wpt/pointerevents/* timeout on both Linux and Win: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVygwELEgVGbGFrZSJ4Y2hyb21pdW1AYmxpbmtfd2ViX3Rlc3RzQGV4dGVybmFsL3dwdC9wb2ludGVyZXZlbnRzL3BvaW50ZXJldmVudF90b3VjaC1hY3Rpb24taW5oZXJpdF9jaGlsZC1wYW4teC1jaGlsZC1wYW4teF90b3VjaC5odG1sDA Sample report: https://test-results.appspot.com/data/layout_results/linux-rel/294631/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html TBR=nzolghadr@chromium.org Bug: 1044715 Change-Id: If376ddf830465b2a930bbcab91d258b05da890d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025489Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735996}
-
Scott Violet authored
User expectations on Android is that if the browser goes into the background and is killed by the OS, and the user switches back to the app state is restored (Chrome does this now). This is true even of incognito data. To limit the potential of leaking private information when incognito this patch adds encryption of the tab/navigation stack. Chrome on Android does this as well. The key used for encryption is randomly generated and stored by the system. This way, if the system doesn't provide the data (because the system has determined the app shouldn't restore state), WebLayer won't be able to decrypt the data. This means restoring state of incognito data has a different lifetime then non-incognito data, but that is by design. Again, this logic matches that of Chrome on Android. BUG=1033924 TEST=weblayer_support_instrumentation_test_apk BrowserFragmentLifecycleTest.restoresPreviousSession Change-Id: Iaeb721ae942efa1db19ee8366d1cfbf30747cd43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018482 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#735995}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 210 histograms that show frequent access in the past 90 days. These are the 88% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-07-26. Change-Id: I637145347866ae7d4453875f0e842fff9beb0082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025407 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#735994}
-
Aga Wronska authored
App activity data are used for Per-App Time Limits feature. Bug: 1015656 Test: ChildStatusCollectorTest Change-Id: I75f27bf409db7d2a0ef941cad7e8f9a3e97b70eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020530 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#735993}
-
Toni Barzic authored
Makes shelf control buttons (home, back, overview) show up regardless of kHideShelfControlsInTabletMode if they're needed for accessibiltiy reasons - i.e. if one of the accessibility features is enabled: * spoken feedback * autoclick * switch access BUG=1012814 Change-Id: I83925d201e8551a694a444a8cbc1f69d71892a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024034 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
By introducing an |Update| method, users of the AutofillClient can push updated suggestions to an open popup. It's currently only supported on Desktop platforms. Two smaller methods support this Update case as well: * AnnounceUpdate which prepares the client that an update is planned and * GetSuggestions which returns a const span over the current suggestions TBR=vasilii@chromium.org TBR Reason: API change for autofill client. Bug: 1043963 Change-Id: I375596684af01acf6e3cfbbeb363b8541baca42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019135Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#735991}
-
bttk authored
Bug: 1046181 Change-Id: Iab825c9fe39eb3f2a62696e18326fb0207139446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019476Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Ender <ender@google.com> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#735990}
-
Sophie Chang authored
Given that we do not recreate a new batch update hints fetcher each time we fetch under that context, we need to allow for the hints fetcher to transition to multiple states so that we can simulate failure -> success test cases. The alternative is to recreate a batch update hints fetcher each time, but then that will go out of scope if a request has not finished yet and that is a bigger change that will cause issues in the actual code. Bug: 10463110 Change-Id: Iaf9950e2035f439a4a9da55ddeaa0bededec6abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025572Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#735989}
-
Sammie Quon authored
Also in ps1 moves code from overview controller to splitview controller since it is more of a splitview feature. The toast does not show up anymore when there are no windows in the MRU. Test: manual, added tests Fixed: 1046133 Change-Id: I9b9086d62d41990e79e34e8c781f05c021a176da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024447Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#735988}
-
Xida Chen authored
This CL improves an existing gpu pixel test, to exercise more canvas API calls, such as resetTransform. Bug: None Change-Id: I4870e3fed726dfb4d8e6b2d8e9631d444b9cc3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005813Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#735987}
-
Rodney Ding authored
Bug: 998694 Change-Id: I9e7d10b68f4f28311ecb6bfce325c7389b31d148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017927Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Rodney Ding <rodneyding@google.com> Cr-Commit-Position: refs/heads/master@{#735986}
-
Mohamed Amir Yosef authored
This CL is one of many refactoring CLs that would split the ManagePasswordsBubbleModel into different controllers one per view. Bug: 1044034 Change-Id: I89e5ebd4b8a7acdda5f0042d69309a5598426292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020944Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f1dc5730d8ef..b52c8dc280ff Created with: gclient setdep -r src-internal@b52c8dc280ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022512 Tbr: jbudorick@google.com Change-Id: Idabab4d9725cd992cbb9c67211017731afd6976a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025318Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735984}
-
Dominic Mazzoni authored
In Dark Mode, we use DarkModeFilter::ElementRole to distinguish between text, foreground, and background objects being drawn. List item markers are functionally playing the role of text, but the actual drawing commands like DrawOval are assumed to be background by default. Introduce a mechanism to allow ListMarkerPainter to override the DarkModeFilter::ElementRole for the subsequent drawing operation. That approach should be flexible enough that we could use it in other places and doesn't require adding a bunch of additional parameters to GraphicsContext APIs. Bug: 1030457 Change-Id: Ic147feababeea5cd210896497fd49087a5bcc11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948449Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Aran Gilman <gilmanmh@google.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#735983}
-
Henrique Nakashima authored
Current API is to create a caching method and a checking method for each feature. It requires a SharedPrefs key to be generated. New API does not require new methods to be created and generates a SharedPrefs key automatically. Bug: 1012975 Change-Id: I8ad89355e2cac8e713b63a36ccec3114f4f1e176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006264Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#735982}
-
Wenbin Zhang authored
Windows has a limit of 32767 on a command line. When testing with field trails, the command to launch chrome.exe may exceed the limit if there're too many field trial configs passed as parameters. This was causing the chrome perf waterfall to completely fail on Windows. This CL added a presubmit check to see whether the configs under Windows will exceed the limit of 31000. Bug: chromium:1045530 Change-Id: I9d181783f1bdad58eeba802583c052bfd0321c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021468 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Ian Prest authored
This reverts commit 0885c956. Reason for revert: Unfortunately, this change results in the notification of page-load-complete happening much later than it did previously. Since a11y events aren't fired when |user_is_navigating_away_|, the result is that some events that occur early in a page's lifetime are not emitted. This is most visible for programmatic 'focus' changes; if they're not emitted, any connected AT doesn't know the focus has changed. Original change's description: > Notify BrowserAccessibilityManager via WebContentsObserver > > This is the last of a series of CLs that remove manual notifications > BrowserAccessibilityManager, now that it implements WebContentsObserver. > This CL removes manual BAM::Navigation{Succeeded,Failed} notifications > in favor of WCO::DidFinishNavigation, and BAM::UserIsNavigatingAway in > favor of WCO::DidStartLoading. > > Bug: 981271 > Change-Id: Ieca6ce0b97f2a0267fd7f2582ab1e333deb11b95 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938489 > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dominic Farolino <dom@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720102} TBR=falken@chromium.org,dmazzoni@chromium.org,dom@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 981271 Change-Id: I41d68985b964792083aa5b6628bb3bc0972c9790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024154Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#735980}
-
Thomas Guilbert authored
This CL moves the video.requestAnimationFrame tests to a new directory in the web platform tests, and makes small updates to resources used. Bug: 1044796 Change-Id: I0f07391695ef36b0631bd3e4986a69086bf16a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024036Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#735979}
-
Sahel Sharify authored
This is a Desktop only change to ensure that the "add card" button is shown in payment method window only when the "basic card" method is supported. Change-Id: Ibfc31141cf45595c0db216d017b5c8c484094424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024923 Commit-Queue: Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735978}
-
Avi Drissman authored
BUG=1044828 Change-Id: Ia2755553d937c547e458f3a7bb424485ce1b0ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020183Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#735977}
-
Yuchen Liu authored
Support spatial rendering check for MediaCapabilities API. Bug: 139027108 Test: On device Change-Id: I796ad613b3513db88ee685bdbb0ab911b6c2fd0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024417 Auto-Submit: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735976}
-
Yi Gu authored
The test is also flaky on Linux TSAN and Win10: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWQsSBUZsYWtlIk5jaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BDb21tYW5kbGluZVN0YXJ0dXBUcmFjaW5nVGVzdC5UZXN0U3RhcnR1cFRyYWNpbmcM TBR=eseckler@chromium.org Bug: 1041392 Change-Id: Ifb9ee371de789ed8c0bab6eb5b87c728d91d9bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025487Reviewed-by:
-
