GitLab

BUG=519022

Review URL: https://codereview.chromium.org/1417873007

Cr-Commit-Position: refs/heads/master@{#357027}

This patch adds an additional consumeIdent helper function to the new
CSSPropertyParser, which takes a list of CSSValueIDs as a template
argument to accept.

BUG=499780

Review URL: https://codereview.chromium.org/1430603003

Cr-Commit-Position: refs/heads/master@{#357026}

BUG=547958
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/1402353013

Cr-Commit-Position: refs/heads/master@{#357025}

Used copy_ex to copy assets and fixed some wrong dependence

This patch is a subset of a large patch which made bots
flaky, the flaky can't reproduced by trybot and cq dryrun.
So, split the large patch to two small ones, this is the
first one, another one does renaming v8 data file.

it also added the code (in ApkAssets.java and copy_ex.py) to dump
the information once bot failed.

The original patch
https://codereview.chromium.org/1422793004/

BUG=540788, 547235
TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org

Review URL: https://codereview.chromium.org/1424983004

Cr-Commit-Position: refs/heads/master@{#357024}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ad696d95..dce364cc

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1413773008

Cr-Commit-Position: refs/heads/master@{#357023}

  In order to roll GN adf2cc60..e35662dd (r354085:r356963) and pick up
  the following changes:

  784ffb68 Fix GN unittests on windows broken by abs-path change
  987f4a55 [GN] Allow spaces in output names and other substitutions.
  5b6813c0 Make sure abs-path gn labels have separate target_gen_dirs
  1c010e5f Make GN --as=output relative to the root build directory.
  a2d721a9 Handle Mozilla license blocks in the GN header checker.

TBR=brettw@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel

Review URL: https://codereview.chromium.org/1406983009

Cr-Commit-Position: refs/heads/master@{#357022}

Move text-shadow/box-shadow properties from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780

Review URL: https://codereview.chromium.org/1419223002

Cr-Commit-Position: refs/heads/master@{#357021}

Fix regression: background artifact for origin glyphs of the '.security-property-unknown' persuasion.

BUG=548973

Review URL: https://codereview.chromium.org/1412093008

Cr-Commit-Position: refs/heads/master@{#357020}

*This is a reland of https://codereview.chromium.org/1415133005/ which
was reverted because it failed on Mac 10.6

Mac 10.8, 10.9, 10.10 did pass the unittest:
https://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/10427/steps/telemetry_unittests/logs/stdio
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/10607/steps/telemetry_unittests/logs/stdio
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/3569/steps/telemetry_unittests/logs/stdio

This patch include the original patch + logic to disable unittest on Mac 10.5, 10.6, 10.7.

BUG=369490

Review URL: https://codereview.chromium.org/1425163003

Cr-Commit-Position: refs/heads/master@{#357019}

Load decision is made inside didReceiveAuthenticationChallenge: and
for recoverable errors cached user decision is read from CertPolicyCache.
That method is called for good and bad certs as long as request is not
served from caches. This method allows accepting bad certs.

SSL Interstitial is presented inside didFailProvisionalNavigation: which
is called when top level frame has bad ssl cert and default behavior
was not overridden inside didReceiveAuthenticationChallenge.

CertStatus is evaluated inside didReceiveAuthenticationChallenge and
its status is cached so it can be reused inside
didFailProvisionalNavigation. It is not possible to re-evaluate cert
inside didFailProvisionalNavigation because that callback does not
provide complete cert chain.

BUG=462427

Review URL: https://codereview.chromium.org/1357773002

Cr-Commit-Position: refs/heads/master@{#357018}

This configuration got moved to the chromium_android.py config in the chromium_tests recipe module, since that's where this config seems to be for the chromium.linux Android Tests (dbg) builder.

base_unittests (along with several other unit tests) required --isolate-file-path <isolate-file> to know what to push to the device. We could either revise //testing/scripts/android_gtest_test.py (which is used for exactly one suite on the main Android bots), use gtest_tests and adapt the test generator on the recipe_module side to do what we need it to, or do what the main Android bots do.

We've opted for the latter with this CL & the matching one on the infra side, but I don't have a strong opinion one way or another.

BUG=

Review URL: https://codereview.chromium.org/1405253008

Cr-Commit-Position: refs/heads/master@{#357017}

Currently, a focused input text field in a cross-process subframe
doesn't have a blinking caret as expected.  The root cause of this is
that FrameSelection::scheduleVisualUpdate wasn't working correctly for
frames with WebFrameWidgets.  This CL fixes that by passing in the
local frame root to page->animator().scheduleVisualUpdate().

BUG=530663
TEST=Click on <input> text field in an OOP frame, observe blinking caret.

Review URL: https://codereview.chromium.org/1405373004

Cr-Commit-Position: refs/heads/master@{#357016}

The patch adds Stylus mode to the "lazy" cm-modes. This means the mode
will not be bundled with chrome; instead, it will be loaded from the
cloud if client needs it.

BUG=428657
R=dgozman@chromium.org, dgozman, pfeldman
NOTRY=true

Review URL: https://codereview.chromium.org/1430753002 .

Cr-Commit-Position: refs/heads/master@{#357015}

iOS throws an exception (which leads to a crash) if didReceiveAuthenticationChallenge:
completion handler is deallocated but never called. Crash was happening
because CertVerifierBlockAdapter did not call its completion handler
if CertVerifierAdapter was destroyed during cert verification (may
happen when Tab is closed during the load).

Changed CertVerifierBlockAdapter to always call its Verify completion
handler by making net::CertVerifier::Request non-cancelable, so each
verification request will complete.

This change does not extend a lifetime of WKWebView (retaining its completion handler
does not retain WKWebView itself).

BUG=541484

Review URL: https://codereview.chromium.org/1392143003

Cr-Commit-Position: refs/heads/master@{#357014}

VC++ up to VS 2015 RTM does not require explicit storage allocation for
static const integers declared in classes. VS 2015 Update 1 requires
these storage definitions in some cases. It's unclear exactly what
cases - simple tests work with and without the explicit storage
allocation.

Many previous versions of VC++ have theoretically *allowed* a
definition to supply storage, but tests on VC++ 2013 show that this
doesn't actually work correctly - it leads to duplicate definition
errors. So, the change is scoped to VS 2015 only.

This changed was landed in the upstream protobuf repo:
https://github.com/google/protobuf/commit/a74e912a8be1274

With this change the chrome target builds with the latest VS 2015.

R=scottmg@chromium.org, pdr@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/1422453005

Cr-Commit-Position: refs/heads/master@{#357013}

Adding the stack trace of screenshot failure will make it's harder for perf
sherrifs to diagnore issue. Switch this to log the exception object instead.

BUG=549326

Review URL: https://codereview.chromium.org/1408063008

Cr-Commit-Position: refs/heads/master@{#357012}

Previously, keyboard events were always routed to the top frame's
RenderWidgetHost.  With OOPIF, the top frame then forwarded the event
to an appropriate subframe renderer if needed.  The extra hop is
inefficient and leaks information; moreover, the forwarding broke when
mouse event hit-testing in the browser process was introduced.

This CL adds logic to send keyboard events directly to the right
RenderWidgetHost in the browser process, using the currently focused
frame which is already tracked in each FrameTree.  This should be
supported for Aura, Mac, and Android.

BUG=530663, 339659

Review URL: https://codereview.chromium.org/1405293002

Cr-Commit-Position: refs/heads/master@{#357011}

BUG=
TBR=agl@chromium.org

Review URL: https://codereview.chromium.org/1406923011

Cr-Commit-Position: refs/heads/master@{#357010}

Also add UMA values for some extra extensions.

BUG=547908

Review URL: https://codereview.chromium.org/1429523002

Cr-Commit-Position: refs/heads/master@{#357009}

Ephemeral apps were cached when downloaded. The ephemeral app service
managed this cache, uninstalling old apps when the cache got full etc.
It also disabled ephemeral apps when they weren't running.

This change removes most of the ephemeral app service, and replaces it
with a simple implementation that deletes all cached apps at startup.
Some code to disable after they are stopped is left to keep the existing
tests passing.

Once the code to delete all cached ephemeral apps has been in stable
for a milestone, the remaining bits of the ephemeral app system will be
removed.

BUG=517735

Review URL: https://codereview.chromium.org/1415863002

Cr-Commit-Position: refs/heads/master@{#357008}

- Simplify ancestor marking of needsRepaint flags, because we have
  synchronzied whole layer-tree cleaning of the flags after painting.
  This removes the dependency of needs repaint flag to self-painting
  flag.

- Don't output subsequence for non-self-painting layers. Previously
  we output subsequence for non-self-painting layers which has
  self-painting descendants. This reduces number of subsequences.

- Don't output subsequences when printing because they are no use.

- Don't output subsequence when painting overlay scrollbars to avoid
  duplicated display item ids and another tree of subsequences which
  just enclose overlay scrollbars.

Covered by existing tests when synchronized painting is enabled.

BUG=536999

Review URL: https://codereview.chromium.org/1424933004

Cr-Commit-Position: refs/heads/master@{#357007}

BUG=510485

Review URL: https://codereview.chromium.org/1415223005

Cr-Commit-Position: refs/heads/master@{#357006}

BUG=547833
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1412143003

Cr-Commit-Position: refs/heads/master@{#357005}

This was a silly typo in the original change (https://codereview.chromium.org/1421423005)

Found by running the CSSWG test suite. Adding the test that found it until we import the
full suite.

R=leviw@chromium.org
BUG=546034

Review URL: https://codereview.chromium.org/1420283011

Cr-Commit-Position: refs/heads/master@{#357004}

Moved MediaRouterEnabled() from chrome_switches to media_router_feature.
For desktop, the new function will use a FeatureSwitch integrated with
an experiment "EnableMediaRouter" to determine whether media
router should be enabled.

Properly wrap MediaRouterEnabled() calls with #if define()s.

The FeatureSwitch use the regular switch ("enable-media-router") first,
then use experiment if switch is not present. The default behavior
is to disable media router. (See feature_switch.h for details on
precedence).

BUG=541315

Review URL: https://codereview.chromium.org/1415333002

Cr-Commit-Position: refs/heads/master@{#357003}

1024 is the original value (see https://codereview.chromium.org/924433002, and https://codereview.chromium.org/197031)

BUG=513693
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1431493002

Cr-Commit-Position: refs/heads/master@{#357002}

To be used by BluetoothDispatcherHost in: http://crrev.com/1317933003

BUG=549327

Review URL: https://codereview.chromium.org/1418743006

Cr-Commit-Position: refs/heads/master@{#357001}

I need to constrain sizes more, but this is a good start.
Also, it looks like resizing doesn't actually work. I suspect that is
a bug in NativeWidgetMus (or WindowTreeHostMojo). Will figure that out
separately.

This adds the new test suite, but no bots are running it yet. I'll
update the build files separately.

BUG=548420
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1416453005

Cr-Commit-Position: refs/heads/master@{#357000}

- add missing file to compile
- fix final build directory (and make --output work)

BUG=none
R=dpranke@chromium.org,tfarina@chromium.org

Review URL: https://codereview.chromium.org/1411303008

Cr-Commit-Position: refs/heads/master@{#356999}

RenderPasses are very rare. Hash map is way overkill. We already have
a vector, just use that and delete the hash map.

R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1413053004

Cr-Commit-Position: refs/heads/master@{#356998}

A webkit unit test will crash in chromium code if a scrollbar using
native theme is painted, because the required resources are not loaded
in webkit unit tests.

Synchronized painting would cause some unit tests previously didn't
crash to crash.

Use mocked scrollbar for these unit tests.

BUG=536999

Review URL: https://codereview.chromium.org/1413513009

Cr-Commit-Position: refs/heads/master@{#356997}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9a78ccb6..ad696d95

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1411183005

Cr-Commit-Position: refs/heads/master@{#356996}

This fixes the find bar view. I don't know what other, if any, UI
surfaces are affected.

Before this patch both the current and the MD findbar always use the
system theme, but this looks broken because the find bar is part of
the top browser Chrome. With this patch, the findbar will only use
the system theme if the whole browser is in GTK theme mode.

BUG=512443

Review URL: https://codereview.chromium.org/1427803004

Cr-Commit-Position: refs/heads/master@{#356995}

As of http://crrev.com/1374753004, ChromeOS is able to use the monotonic
clock and still have its trace event timestamps match timestamps from
ftrace.

BUG=541692

Review URL: https://codereview.chromium.org/1424323002

Cr-Commit-Position: refs/heads/master@{#356994}

This patch adds the dependencies that //components/crash that were
missing that was making `gn check` upset and, in at least one case,
causing us to actually miscompile things because the public_configs
were not being propagated from content properly.

R=rsesek@chromium.org, jam@chromium.org, pkotwicz@chromium.org
BUG=547635

Review URL: https://codereview.chromium.org/1423043002

Cr-Commit-Position: refs/heads/master@{#356993}

1. Only dequeue pending tasks when no other tasks are running.
2. Use the running tasks list to accept or reject a foreground task.

BUG=549305

Review URL: https://codereview.chromium.org/1419473005

Cr-Commit-Position: refs/heads/master@{#356992}

Review URL: https://codereview.chromium.org/1416673007

Cr-Commit-Position: refs/heads/master@{#356991}

When gathering savable resources from the whole page, each resource
could have come from a different frame and therefore could have had a
different referrer associated with it - back then it made sense to send
a vector of referrers (potentially a different one for each savable
resource).  Now (after crrev.com/1308113008) we gather savable resources
per frame and therefore can simplify the IPCs and send only a single
referrer for the whole frame.

Note that for the main frame, the browser already knows the referrer ...

  render_frame_host_impl->frame_tree_node()
                        ->navigator()
                        ->GetController()
                        ->GetLastCommittedEntry()
                        ->GetReferrer()

... but this CL keeps communicating the referrer over IPC, because 1) it
covers all the frames and 2) the renderer seems like a simpler, single,
race-free, more authoratitative source of the referrer information.

This CL is to some extent a reply to a CR feedback at
crrev.com/1413103003/#msg6 that pointed out general undesirability of
sending over IPC a struct-of-vectors (as opposed to a
vector-of-structs).

This CL improves upon crrev.com/10387090 which introduced sending of
referrer information during save-page-as operation, but initially kept
sending only default, rather than actual referrers.

BUG=526786

Review URL: https://codereview.chromium.org/1425013004

Cr-Commit-Position: refs/heads/master@{#356990}

This allows ::ScheduleEnforceMemoryPolicy() to be called on
a worker thread without a message loop.

BUG=549274
TEST=content_unittests --gtest_filter=HostDiscardableSharedMemoryManagerScheduleEnforceMemoryPolicyTest.SetMemoryLimitOnSimpleThread

Review URL: https://codereview.chromium.org/1430743002

Cr-Commit-Position: refs/heads/master@{#356989}

I think we were mistakenly using delegate_execute to relaunch even on
Win10. Possibly some DEx changes, or possibly some shortcut changes
eventually broke this, so just launch directly like we do on <= 7.

R=grt@chromium.org, gab@chromium.org
BUG=548965

Review URL: https://codereview.chromium.org/1419223006

Cr-Commit-Position: refs/heads/master@{#356988}