- 22 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2a7215287df2..4a3f1fe4eec5 git log 2a7215287df2..4a3f1fe4eec5 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 efe061bd4f9d..df066e9cded2 (1 commits) Created with: gclient setdep -r src/third_party/skia@4a3f1fe4eec5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I70cab1c24b1bef9e399d8eb6db3f95e2a6f764c2 Reviewed-on: https://chromium-review.googlesource.com/c/1348572Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610476}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3a12ff5e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/fullscreen hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ica9bcf2f660389e32f3a8222401068379a59c83d Reviewed-on: https://chromium-review.googlesource.com/c/1348256 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610475}
-
Fredrik Söderquist authored
This function has a very generic name, but not a wide enough use case to match. Move it to FilterOperationResolver, where its only two callers are. Rename to something less generic. Change-Id: Ibe6eaf68fbeddd86464d508cba3d6b235117f780 Reviewed-on: https://chromium-review.googlesource.com/c/1348096Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#610474}
-
Kevin McNee authored
We use NDEBUG for the condition to enable DCHECKs related to scroll event sequence validity, but this doesn't consider that DCHECKs could be enabled in release builds with dcheck_always_on. Bug: 897791 Change-Id: I8bf894b9fcfd56d5c8256bafa4d00b3e1eb37ed2 Reviewed-on: https://chromium-review.googlesource.com/c/1348253Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#610473}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7e6714e3c66b..f0144caadbe5 Created with: gclient setdep -r src-internal@f0144caadbe5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9d7a3880543da7bcc979a15a0f0bd42926ec51f9 Reviewed-on: https://chromium-review.googlesource.com/c/1348570Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610472}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/af228ee761e1..f25907800923 git log af228ee761e1..f25907800923 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 magjed@webrtc.org Use cropping aligning in video quality analysis tool 2018-11-22 danilchap@webrtc.org Fix setting max reordering threshold in ReceiveStatistics 2018-11-22 magjed@webrtc.org Add tool for aligning cropped region of video files 2018-11-22 mbonadei@webrtc.org Remove cricket::UdpTransport. 2018-11-22 mbonadei@webrtc.org Remove cricket::BundleFilter. 2018-11-22 terelius@webrtc.org Cleanup AimdRateController and remove RateControlRegion enum. 2018-11-22 artit@webrtc.org Increase test timeouts in TCPChannelClientTest 2018-11-22 hta@webrtc.org Remove superfluous constructor from dltsTransport 2018-11-22 danilchap@webrtc.org Cleanup rtcp StreamStatistician::OnRtpPacket Created with: gclient setdep -r src/third_party/webrtc@f25907800923 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:b/38179459,chromium:none,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idc2f3e6a1bbd4df155d5e2bc37ff04dba29895d8 Reviewed-on: https://chromium-review.googlesource.com/c/1348295Reviewed-by:
-
Xi Cheng authored
Change-Id: Ie122cdd92aff2bdadddf1106018fc994fae81fdc Reviewed-on: https://chromium-review.googlesource.com/c/1347099Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#610470}
-
Benjamin Shaya authored
Bug: 117433735 Test: On device Change-Id: I2dc2c4aca15640262fc51114910fd77300e03d17 Reviewed-on: https://chromium-review.googlesource.com/c/1311495 Commit-Queue: Benjamin Shaya <bshaya@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#610469}
-
Ned Nguyen authored
This also update test expectation linter to error out on lines with mutual exclusive specifiers The Expectation files are updated using the script in https://chromium-review.googlesource.com/c/chromium/src/+/1336387 This is the first part of the plan to migrate WebkitLayout test expectations to the new format. Bug: 807751 Change-Id: Iad2296a99804fb16d9b474229b68c0d47d3fe1eb Reviewed-on: https://chromium-review.googlesource.com/c/1336439 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#610468}
-
Nico Weber authored
Also remove no-longer-needed debug logging. TBR=hans Bug: 899438 Change-Id: I1759e7e2f6ee8ece3fcdddeeb286754c1cf6b60a Reviewed-on: https://chromium-review.googlesource.com/c/1348310Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610467}
-
Nicolás Peña Moreno authored
This reverts commit c19f615e. Reason for revert: looks like the cause of compile failure in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3760 Original change's description: > [Autofill Assistant] Attempt to recover pre-interrupt state. > > When an interrupt script is run, it can modify anything, which makes the > main script with allow_interrupt=true hard to write. This change propose > to reset some state automatically after an interrupt to make this > easier. > > It recovers the status message and attempts to set a reasonable scroll > position. It sets it to either the element WaitForDom was waiting for, > for a successful WaitForDom. For an unsuccessful WaitForDom, it scrolls > to the last element focused on (if it still exists.) > > Change-Id: Ie9c0022eebc10e0711c82d83b943e0de152af1fd > Reviewed-on: https://chromium-review.googlesource.com/c/1346451 > Commit-Queue: Stephane Zermatten <szermatt@chromium.org> > Reviewed-by: Mathias Carlen <mcarlen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610412} TBR=mcarlen@chromium.org,szermatt@chromium.org Change-Id: I035b9b699fda14b5d3a1b87ee84d5715638c0f83 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1348631Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610466}
-
Sergio Villar Senin authored
It was using both SigninManager and ProfileOAuth2TokenService fakes to seed primary&secondary account info and update their refresh tokens. Replaced them by the correspondent identity API calls via an IdentityTestEnvironmentProfileAdaptor which is also used to create the testing profile. Bug: 905247 Change-Id: I8cdca4c9ade423cf9e431fd0420f6db5411935b3 Reviewed-on: https://chromium-review.googlesource.com/c/1346094 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#610465}
-
Dave Tapuska authored
Use appropriate types instead of size_t. BUG=879657 Change-Id: I5372e622570dbfed1628e6a1c70882ed85a17b51 Reviewed-on: https://chromium-review.googlesource.com/c/1347431Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#610464}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eec675da4cad..7e6714e3c66b Created with: gclient setdep -r src-internal@7e6714e3c66b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia8d226a43750d231a67ca2dfda3ffbb56e97b476 Reviewed-on: https://chromium-review.googlesource.com/c/1348293Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/efe061bd4f9d..df066e9cded2 git log efe061bd4f9d..df066e9cded2 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 syoussefi@chromium.org Vulkan: Remove vk::ShaderType Created with: gclient setdep -r src/third_party/angle@df066e9cded2 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ic1e977bc2e80c2f674d9c7c271011d0dcb337249 Reviewed-on: https://chromium-review.googlesource.com/c/1348294Reviewed-by:
-
Emircan Uysaler authored
Bug: webrtc:9376 Change-Id: I6b51d34cbbe217fe950d7a85a7d9ebd9e812111e Reviewed-on: https://chromium-review.googlesource.com/c/1347216Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#610461}
-
Uladzimir Miniailau authored
See an explanation at https://chromium-review.googlesource.com/c/chromium/src/+/1306497/6/chrome/renderer/autofill/password_autofill_agent_browsertest.cc#3682. Short version of the explanation: it's a bad practice to use public inheritance and put public methods of the base class to the private section of the derived class. Bug: 898109 Change-Id: Ie9ceed5e860593490ec39788c6a0c353bfdd6947 Reviewed-on: https://chromium-review.googlesource.com/c/1347361Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Cr-Commit-Position: refs/heads/master@{#610460}
-
Lukasz Anforowicz authored
The code assumes that URLLoaderFactory is guaranteed to outlive URLLoader (i.e. this is why URLLoader::factory_params_ is a raw pointer). This CL makes sure this assumption holds for the factory and loaders owned by CORSURLLoaderFactory: |loaders_| need to be destroyed *before* destroying |network_loader_factory_|. Bug: 906305 Change-Id: I61195be425c8b21a725676de4d44b1611f443410 Reviewed-on: https://chromium-review.googlesource.com/c/1343282Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#610459}
-
Suman Nelson Kancherla authored
This fix ensures that the inline poses are disabled for the orientation device in addition to the GVR-based device while in the VR headset. This includes sessions created outside the headset as well. Bug: 882684, 904882, 905339 Change-Id: I67681867479d5ac666576fb3474366becb8203ce Reviewed-on: https://chromium-review.googlesource.com/c/1321256 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#610458}
-
Jeremy Roman authored
Bug: 834780 Change-Id: Id4075554850a5f63cf40087072091503335da41e Reviewed-on: https://chromium-review.googlesource.com/c/1347430Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Christopher Grant authored
This is a reland of 50ab16b8 Original change's description: > Introduce bundle-specific native libraries > > This will allow native code to be stripped out of the main library > when it moves to a Dynamic Feature Module. For now, the libraries will > be identical. > > BUG=874584 > > Change-Id: I8a54e6402a3686939dd14b509c614da99b0ff913 > Reviewed-on: https://chromium-review.googlesource.com/c/1332248 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: David Turner <digit@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608519} Bug: 874584 Change-Id: I197543b47e1613f93164ebd6f9a4c9d84743e284 Reviewed-on: https://chromium-review.googlesource.com/c/1344875 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610456}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0d55bcab63be..b67f5e7a75c7 git log 0d55bcab63be..b67f5e7a75c7 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@b67f5e7a75c7 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Idb903bce767f1f78a80c722e62ba8aa820df03a2 Reviewed-on: https://chromium-review.googlesource.com/c/1348291Reviewed-by:
-
Dave Tapuska authored
Use appropriate types in loader code. BUG=879657 Change-Id: I43da64c50b4dcdb2cd47a4b6ed45ecd7d87d15fb Reviewed-on: https://chromium-review.googlesource.com/c/1330352Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#610454}
-
Dan Elphick authored
Bug: v8:7289, v8:8238 Change-Id: I3f33797b4f93b162c7d218d2941ef9bdced98755 Reviewed-on: https://chromium-review.googlesource.com/c/1343113Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a0ca639a. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I8aac24ddc1673d98af8dadb54447942637b37c79 Reviewed-on: https://chromium-review.googlesource.com/c/1347026 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Marc Treib authored
This are the tests corresponding to https://crrev.com/c/1343369 Bug: 906609 Change-Id: Ib57c12b77cba6242292edb34750a756e1c191341 Reviewed-on: https://chromium-review.googlesource.com/c/1348063 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#610451}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4176781039b6..4ed4737007d8 git log 4176781039b6..4ed4737007d8 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 agrieve@chromium.org adb_wrapper.py: Fix crash when timeout=None Created with: gclient setdep -r src/third_party/catapult@4ed4737007d8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7a39dede267a04b948cac4ec3dc33298d911d3e5 Reviewed-on: https://chromium-review.googlesource.com/c/1348231Reviewed-by:
-
Mohamed Amir Yosef authored
The test org.chromium.chrome.browser.sync.BookmarksTest#testUploadMovedBookmark has been disabled for long time due to flakiness. This CL does the following: 1- Adds an assert() that's missing from the test start up. 2- Enables the test. The plan is to enable it again to get measurements for how long it takes to fail and pass to rule out a time-out problem. The flakiness dashboard has been replaced with a newer one since the reporting of the attached bug. TBR=mastiz@chromium.org Bug: 823484 Change-Id: I827ff84ad953c56f01619b4aa07643714d0ffc6f Reviewed-on: https://chromium-review.googlesource.com/c/1348116 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#610449}
-
Jan Krcal authored
This CL moves the construction of the sync controller for device info directly into ProfileSyncService that owns the DeviceInfoSyncBridge. This (a) heavily simplifies how the controller gets access to its delegate (removing the accessor from SyncClients) and (b) allows to use the forwarding delegate instead of the proxy delegate. This CL is a preparation for using the simpler forwarding delegate for all sync types that run on the UI sequence. This CL also resolves a TODO by making it clear that DEVICE_INFO cannot get disabled via the command-line switch. Bug: 867801 Change-Id: Iea84d818613476f40d89eebd73266aa24d028fb6 Reviewed-on: https://chromium-review.googlesource.com/c/1348092 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#610448}
-
Jonathan Backer authored
performDeferredCleanup may issue GL calls. This was causing GL_INVALID_OPERATION errors with a passthrough decoder prototype because (a) with passthrough, GL contexts may be in different service side share groups and (b) a GLES2 passthrough decoder may have just been made current before ScheduleGrContextCleanup had run No need to merge on branch because (a) this change code wouldn't do anything unless we're using OOP-R or SkRenderer&SkDDL and (b) it's only necessary for platforms using passthrough (Windows), which are not currently using OOP-R or SkRenderer. Bug: 829435 Change-Id: I13802f7a5532bdebb07e1a05a9209d6c6730e4fa Reviewed-on: https://chromium-review.googlesource.com/c/1348189Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#610447}
-
Mathias Carlen authored
This patch introduces a cookie experiment which when enabled, sets a cookie to determine when a script may be executed on a site with modified state. The new logic is handled in the controller and controlled via an experiment parameter. In a follow up change this information will be hooked up to the script executor. Bug: 806868 Change-Id: I7a6354611646e36986208a70a09b376ad4e2f2c0 Reviewed-on: https://chromium-review.googlesource.com/c/1344099 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#610446}
-
Vaclav Brozek authored
The libphonenumber routine used in autofill's ParsePhoneNumber expects input which is: * valid Unicode * avoids noncharacters [1] * avoids nonprintable ASCII This CL checks the input passed to libphonenumber for these criteria and aborts ParsePhoneNumber if they are not met. As a side effect, this also decreases log spam seen in autofill_phone_number_i18n_fuzzer, because libphonenumber has been complaining about interchange-invalid UTF8. [1] http://www.unicode.org/faq/private_use.html#nonchar1 Bug: 906817 Change-Id: I451272d2f838bd266ad3a043f556610b8007ae1a Reviewed-on: https://chromium-review.googlesource.com/c/1343004 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
Christopher Grant authored
And, add GN best-practices link alongside. BUG= TBR=jochen@chromium.org Change-Id: I34641ad5693942d69a6f418c6dbf562ed7375095 Reviewed-on: https://chromium-review.googlesource.com/c/1348289 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
-
Mikel Astiz authored
Analogous to https://chromium-review.googlesource.com/c/1329142 but with the subset of datatypes that are relevant on iOS. Bug: 870624 Change-Id: Id10165cd3baca9d0b17c451804b65c87cfa4e29e Reviewed-on: https://chromium-review.googlesource.com/c/1347273Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610443}
-
Randy Rossi authored
These IPC extension messages are identical between chrome/chromecast. Moving up to extensions/common Bug: 837773 Test: Deploy ChromeOs manually (tidus) Change-Id: I8884ea9726b69efb40c71614de11889bf01a2bb4 Reviewed-on: https://chromium-review.googlesource.com/c/1261976Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610442}
-
Sergio Villar Senin authored
Replaced the usage of SinginManager API by the correspondent IdentityManager API. Bug: 903860 Change-Id: I5f4df0e9956c4b4ae055f15b80fddac9009e61d0 Reviewed-on: https://chromium-review.googlesource.com/c/1347281Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4bff78e57c54..2a7215287df2 git log 4bff78e57c54..2a7215287df2 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 dc65c5bd8452..efe061bd4f9d (2 commits) 2018-11-22 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-11-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@2a7215287df2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I084304ed729d276eac390347e232af56d5b8bb82 Reviewed-on: https://chromium-review.googlesource.com/c/1348010Reviewed-by:
-
Michael Thiessen authored
Many (most?) mobile sites disable focus outlines, which means that spatial navigation gives no indication of which element is focused, making it unusable. When this new experimental flag is enabled, we prevent the site from overriding the useragent style for focus rings. This also has the side-effect of forcing an outline on spat-nav-focused option elements even when the new flag is not enabled. (Note that spat-nav itself is still behind a flag) Bug: 906640 Change-Id: I2e68b4ea898f5c504bd272895caeea91a2bfc757 Reviewed-on: https://chromium-review.googlesource.com/c/1344252Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#610439}
-
Marc Treib authored
plus a lot of now-dead code :) Many tests explicitly disabled the feature. Some of those could be adapted, some other simply don't apply anymore and were deleted. Bug: 905636, 905639 Change-Id: Ife7cf5227b929bab5221b856d85ba572f89e537e Reviewed-on: https://chromium-review.googlesource.com/c/1346308 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#610438}
-
Jungshik Shin authored
Date-related wtf functions are for JavaScriptCore in WebKit. For the obvious reason, Blink does not need them except for parsing Date in HTTP header (last modified). For that, switch to ICU and use the same algorithm as specified in the latest Ecma 262 spec. The need for this CL was identified while working on https://chromium-review.googlesource.com/1111818 , but it hasn't been made a CL until now. Bug: None Change-Id: I69f04e13744fdc914f58fca6d0a88993173a58e4 Reviewed-on: https://chromium-review.googlesource.com/c/1103675Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610437}
-
