GitLab

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/900793008

Cr-Commit-Position: refs/heads/master@{#314957}

This adds a new distallable type (mobile-friendly distillable) and adds
a histogram for tracking what types of pages are actually distilled.

BUG=444160

Review URL: https://codereview.chromium.org/900963003

Cr-Commit-Position: refs/heads/master@{#314956}

Review URL: https://codereview.chromium.org/905653002

Cr-Commit-Position: refs/heads/master@{#314955}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dc9973e..66fcf2e

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/898143004

Cr-Commit-Position: refs/heads/master@{#314954}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/900183004

Cr-Commit-Position: refs/heads/master@{#314953}

In old implementation, 'audio/aac' is not supported when using
IsSupportedMediaMimeType to check. That will block aac audio to play.

Review URL: https://codereview.chromium.org/895523002

Cr-Commit-Position: refs/heads/master@{#314952}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/900613004

Cr-Commit-Position: refs/heads/master@{#314951}

Revert of Roll Clang 223108:228129 (patchset #5 id:80001 of https://codereview.chromium.org/881763003/)

Reason for revert:
compiler crash in http://build.chromium.org/p/chromium/builders/Mac/builds/33226

Assertion failed: (Offset <= PieceOffset && "overlapping or duplicate pieces"), function emitLocPieces, file /work/chromium/src/third_party/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp, line 1676.

0.	Program arguments: /Volumes/data/b/build/slave/Mac/build/src/third_party/llvm-build/Release+Asserts/bin/clang -cc1 -triple x86_64-apple-macosx10.6.0 /* snip */ -x c ../../third_party/mesa/src/src/mesa/program/prog_opt_constant_fold.c
1.	<eof> parser at end of file
2.	Code generation
clang:error: unable to execute command: Illegal instruction: 4
clang:error: clang frontend command failed due to signal (use -v to see invocation)
clang version 3.7.0 (trunk 228129)
Target: x86_64-apple-darwin13.4.0

Original issue's description:
> Roll Clang 223108:228129
>
> Also introduce a build number in the package name, stop versioning
> the Blink GC plugin, and remove repackage.sh.
>
> BUG=444089
>
> Committed: https://crrev.com/d30327adf468b78f79819a69bca12b64b7cb70ae
> Cr-Commit-Position: refs/heads/master@{#314946}

TBR=thakis@chromium.org,jln@chromium.org,jbauman@chromium.org,hans@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=444089

Review URL: https://codereview.chromium.org/898713004

Cr-Commit-Position: refs/heads/master@{#314950}

Revert of Linux MSan: enable swarming/sharding for browser_tests. (patchset #1 id:1 of https://codereview.chromium.org/899283003/)

Reason for revert:
broke browser_tests

Original issue's description:
> Linux MSan: enable swarming/sharding for browser_tests.
>
> Also, try enabling swarming for base_unittests on CrOS MSan.
>
> BUG=454828
> TBR=phajdan.jr@chromium.org
>
> Committed: https://crrev.com/0f7445a90f7a8e2aa54a812d2c96654cefbd8eaf
> Cr-Commit-Position: refs/heads/master@{#314892}

TBR=phajdan.jr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=454828

Review URL: https://codereview.chromium.org/898083003

Cr-Commit-Position: refs/heads/master@{#314949}

Show only the eTLD+1 instead of the full URL.

BUG=453170

Review URL: https://codereview.chromium.org/898183002

Cr-Commit-Position: refs/heads/master@{#314948}

* Add keypress JS event handler
* Change some keycode->name conversions to match what we get from NaCl

This CL also bumps the version number since I've already pushed v1.0 to CWS.

Review URL: https://codereview.chromium.org/882063007

Cr-Commit-Position: refs/heads/master@{#314947}

Also introduce a build number in the package name, stop versioning
the Blink GC plugin, and remove repackage.sh.

BUG=444089

Review URL: https://codereview.chromium.org/881763003

Cr-Commit-Position: refs/heads/master@{#314946}

The change only handles files moved/renamed withing the same
BUILD.gn file. If files are moved beyond the same BUILD.gn file,
the affected BUILD.gn files should be fixed manually.

BUG=404616
TEST=1) rename files with git mv
     2) run tools/git/mass-rename.sh
     3) confirm that BUILD.gn is updated as expected

Review URL: https://codereview.chromium.org/894973002

Cr-Commit-Position: refs/heads/master@{#314945}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/905463005

Cr-Commit-Position: refs/heads/master@{#314944}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463

Review URL: https://codereview.chromium.org/898173002

Cr-Commit-Position: refs/heads/master@{#314943}

This adds a new widget, ButtonCompat, which is a Material-styled button.
On pre-L devices, the widget approximates the Material style, but
doesn't have ripples or shadows. The color of ButtonCompat can be easily
changed using setButtonColor().

This also adds a style ButtomBorderlessCompat than can be applied to
Buttons to make them look like borderless Material buttons.

BUG=442690

Review URL: https://codereview.chromium.org/902893004

Cr-Commit-Position: refs/heads/master@{#314942}

Allow building in parallel. It may be a runtime dependency
but it's not a build-time dependency.

Happened to notice the serialization in the graph:
http://chromium-build-stats.appspot.com/ninja_log/2015/02/05/build48-m1/ninja_log.build48-m1.chrome-bot.20150205-093049.13303.gz/trace.html

BUG=none

Review URL: https://codereview.chromium.org/902033002

Cr-Commit-Position: refs/heads/master@{#314941}

BUG=431686

Review URL: https://codereview.chromium.org/902013002

Cr-Commit-Position: refs/heads/master@{#314940}

Currently we notify the guest of StartFind events but not StopFinding.

BUG=455079

Review URL: https://codereview.chromium.org/901833002

Cr-Commit-Position: refs/heads/master@{#314939}

This includes commit 6d97ebda:

    Update fancy_urllib to more recent version. This includes a fix for
    Python 2.7.7, which removed the HTTPSConnection._set_hostport
    function.

BUG=410545
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/901493006

Cr-Commit-Position: refs/heads/master@{#314938}

R=jam@chromium.org,erickung@chromium.org
BUG=444930

Review URL: https://codereview.chromium.org/894173002

Cr-Commit-Position: refs/heads/master@{#314937}

Internally, it slices the StringPiece instead of erasing pieces of the
string, so we have 0 copies of these JSON strings. This is possible now
that JSONStringValueSerializer takes a StringPiece.

BUG=455068

Review URL: https://codereview.chromium.org/894033006

Cr-Commit-Position: refs/heads/master@{#314936}

    Added code to disable save button if no text is present in name or number field

    Currently if some text is first typed in any of the fields then save button
    gets enabled. But when all text is deleted from field, save button is not
    disabled.
    Added code to enable/disable properly.

    BUG=446760

    Review URL: https://codereview.chromium.org/837613003

It created a new bug, http://crbug.com/453568, and the original issue it solved is not worth fixing.

BUG=453568,446760

Review URL: https://codereview.chromium.org/895433005

Cr-Commit-Position: refs/heads/master@{#314935}

Looks like RenderFrameDeleted() wasn't called if a RenderView
crashes, which results in the WebContents having some lingering
power save blockers and media player entries.

BUG=455943
TEST=new unittest. DCHECK() no longer fires.

Review URL: https://codereview.chromium.org/886603009

Cr-Commit-Position: refs/heads/master@{#314934}

media: Support simultaneous permission requests from multiple WebContents in ProtectedMediaIdentifierPermissionContext.

ProtectedMediaIdentifierPermissionContext is shared by multiple WebContents.
Even though we don't support multiple permission requests from the same page
(WebContents), we should support permission requests from multiple WebContents.

Test step:
1. Make sure no allowed or blocked exception in content settings.
2. Open a tab/extension, navigate to a page that requests permission. A prompt
should appear. Don't do anything.
3. Open another tab/extension, navigate to a page that requests permission. A
prompt should also appear.
4. Play with allow/block/dismiss and see whether permission status is as
expected and whether content settings are updated correctly.

BUG=446263
TEST=See above.

Review URL: https://codereview.chromium.org/903873002

Cr-Commit-Position: refs/heads/master@{#314933}

Currently smoothness action (e.g. scrolling) starts when the
document.readyState = interactive or complete. It is noticed that when
the readyState = interactive, the page can still be loading resources
so there would be contention on the main thread between resources loading
and input handling, which could have impact on the smoothness metrics.

It is to our interests in actually solving the contention issues so we
don't want to artificially delay the action start just to avoid the
contention. But I do see the benefit in running an experiment on just
wikipedia with delayed action start so as to understand to which degree
this contention is affecting our metrics.

So this CL makes a duplicate of the Wikipedia page in the
key_mobile_sites_smooth and running that particular page with
starting scrolling on readyState = complete.

BUG=455277

Review URL: https://codereview.chromium.org/901563003

Cr-Commit-Position: refs/heads/master@{#314932}

BUG=455533

Review URL: https://codereview.chromium.org/886933008

Cr-Commit-Position: refs/heads/master@{#314931}

This CL introduces MojoHandleAttachment, a MessageAttachment subclass.
With this and ChannelMojo, we are able to send Mojo MessagePipes
over IPC.

There is also MojoMessageHelper which provides some static member functions
that reads and writes MessagePipes from/to a Message. In coming changes,
we'll add ParamTraits for MessagePipe based on this.

R=agl@chromium.org, viettrungluu@chromium.org
TEST=IPCChannelMojoTest.SendMessagePipe, IPCChannelMojoTest.SendPlatformHandleAndPipe
BUG=448190

Review URL: https://codereview.chromium.org/866223005

Cr-Commit-Position: refs/heads/master@{#314930}

1. Using a GDI bitmap -- switch to SkSurface instead

2. Lazily loading a font. This breaks for two different reasons.
The first is a DCHECK for doing IO on the Compositor thread. This
could have been just ignored in general since it's only for debug
usage, the drawbacks of minor jank are limited.

However, once lockdown is on, the font load hard fails from the
renderer. So, load the typeface before lockdown and pass it into
CC and the hud via LayerTreeSettings.

R=danakj@chromium.org
BUG=453731,455104
TEST=run chrome with --enable-win32k-renderer-lockdown --show-fps-counter --ui-show-fps-counter on Win8

Review URL: https://codereview.chromium.org/900063002

Cr-Commit-Position: refs/heads/master@{#314929}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f71b4c1..27f398f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/899893003

Cr-Commit-Position: refs/heads/master@{#314928}

Use DCHECK to validate the ThreadChecker results in RendererScheduler.

Also add a WARN_UNUSED_RESULT modifier to
ThreadChecker::CalledOnValidThread.

Review URL: https://codereview.chromium.org/904593002

Cr-Commit-Position: refs/heads/master@{#314927}

The UseSkiaGpuBackend is false always and not queried anywhere. I
left this behind when I removed the Ganesh-in-GLRenderer thing we
had before.

The ExpandedViewport is slightly more mysterious but also not queried
anywhere, so I guess leftover from refactorings.

R=enne, vmpstr

Review URL: https://codereview.chromium.org/883353009

Cr-Commit-Position: refs/heads/master@{#314926}

Pinch zoom is done by the renderer process now. Note that this leaves
the PreHandleGestureEvent in place, as most if not all instances of it
preventing gesture events are still desirable with the new pinch zoom
behavior.

BUG=451559

Review URL: https://codereview.chromium.org/899283004

Cr-Commit-Position: refs/heads/master@{#314925}

This is a follow-up CL of r314351.

Currently this is invoked from PermissionContextBase. Since this is for
protected media identifier only, it's better to put it in
ProtectedMediaIdentifierPermissionContext.

Also included in this fix:
- Pass |requesting_origin| to PlatformVerificationDialog::ShowDialog().
  Currently we are using the origin of the GetLastCommittedURL(), which is
  wrong.
- Add ProtectedMediaIdentifierPermissionContext::CancelPermissionRequest() so
  that we can cancel the prompt and drop the callback properly. Otherwise, this
  will cause a DCHECK in PermissionServiceImp when closing the browser while the
  prompt is shown.

BUG=446263
TEST=Manually tested various cases.

Review URL: https://codereview.chromium.org/881983003

Cr-Commit-Position: refs/heads/master@{#314924}

Keying off of the driver manufacturer name doesn't work on some systems, so use SetupAPI to enumerate all installed display adapters to check if both an AMD and Intel display adapter are installed.

BUG=455046,451420
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/893993006

Cr-Commit-Position: refs/heads/master@{#314923}

Also fix WebView resource config to not try to include OWNERS files from
resource directories in its APK, as the regular Android build does.

BUG=None

Review URL: https://codereview.chromium.org/894153004

Cr-Commit-Position: refs/heads/master@{#314922}

Historically, the OSX Keychain has been misconfigured on some perf bots, which
has caused Telemtry tests to stall. This CL adds checks to emit warnings if the
Keychain is misconfigured.

I added checks for three common misconfigurations:
  - Is the default Keychain locked.
  - Is the default Keychain configured to automatically lock after a period of
  time.
  - Are the ACLs of a commonly accessed key in the default keychain
  misconfigured for the perf bots.

The first and third checks are performed by short C programs since the
information is easily available through the Security framework, but not from
the security CLI.

BUG=443340

Review URL: https://codereview.chromium.org/809473004

Cr-Commit-Position: refs/heads/master@{#314921}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d953d07..dc9973e

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/886643004

Cr-Commit-Position: refs/heads/master@{#314920}

It is not used only when toolkit_views is enabled. This fixes some
unresolved reference errors that will break the linux_ecs_ozone trybot
once we enable -Wl,-z,defs.

This dependency is already unconditional in the GN build.

BUG=445627
TEST=linux_ecs_ozone tryjob

Review URL: https://codereview.chromium.org/874163004

Cr-Commit-Position: refs/heads/master@{#314919}

This is a vestige of old UpdateDrawProperties and instead should go
directly to the target_id on the transform node.  Also, the root node
was setting the target_id incorrectly because its transform_node_index
was not set before being referenced.

This is a fix contributing towards getting property trees to entirely
replace UpdateDrawProperties on the main thread.

Review URL: https://codereview.chromium.org/897373002

Cr-Commit-Position: refs/heads/master@{#314918}