- 07 Jun, 2019 40 commits
-
-
Piotr Bialecki authored
This change adds PendingRequestSessionQuery class to encapsulate outstanding `requestSession()` calls. It will automatically record UKM entries when the request is resolved or rejected. Rename PendingSessionQuery to PendingSupportsSessionQuery. Bug: 968622 Change-Id: Id33524182eb555802d1ef02fc78741b4276ec290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648788Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#667364}
-
Cathy Li authored
Also add missing OWNER files for test directories. Bug: 970355 Change-Id: Ibb239b3412bac5dfd1417516e19054a11d153075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644013 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#667363}
-
Mohamed Heikal authored
GCM token used to be plumbed from native to java and back so that it is stored in the job scheduler across browser restarts. This is no longer required as now, the GCM token is stored in prefs on native's side. This cl removes all the unneeded plumbing code. Bug: 972218 Change-Id: I6e2b91140760c197ee872fc4c761cd6637451ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649341 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#667362}
-
Xing Liu authored
This CL moves ClientState::DebugPrint() to test util file. Bug: 930968 Change-Id: Ieb4455612be866a5aa394a5fdb75895bfb5030ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647147Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#667361}
-
Piotr Bialecki authored
`surface_destroyed_callback_` can potentially be null when `ArCoreJavaUtils::OnDrawingSurfaceDestroyed` gets called. Bug: 966984 Change-Id: I878ede8a419f95cd6bc083863f369f4054ce039b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648891 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#667360}
-
dpapad authored
Add a new js_html_template() rule to inline HTML content within JS files during build time. Having HTML in JS is a requirement of Polymer3. This GN rule allows HTML development to still happen within HTML files which eliminates any inconvenience of that constraint during development. Moreover, js_html_template() is capable of extracting HTML content from existing Polymer2 HTML files, such that HTML is not duplicated across v2 and v3 element implementations during a potential migration. Bug: 965770 Change-Id: I05fdc1a30968f9793eb6ecb59601afc1c11bfb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648811 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#667359}
-
Alexei Filippov authored
The recording depends on the Finch experiment setting. The sampling rate can be controlled with a parameter. BUG=972231 Change-Id: I560de9328b561ef11b474af6a1261534104f56c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650138Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#667358}
-
Xianzhu Wang authored
In pre-CompositeAfterPaint, we may squash one layer into another, but the squashing layer may create more effect nodes not for real effects, causing squashed layer's effect to escape the squashing layer's effect. It's hard for compositor-before-paint to avoid this because it doesn't know if PaintPropertyTreeBuilder will create such effect nodes. In https://chromium-review.googlesource.com/c/1484671, I changed I changed 'break' to 'return' for chunk-effect-escaping-layer-effect, which prevented the chunk effect from being applied. For the case we can continue because the extra effects are noop. Bug: 971558 Change-Id: Ic009092ea9b371f79e30c4cdb2801d1c2319e4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649411Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#667357}
-
Alex Moshchuk authored
This CL strenthens security checks in FileSystemEntryURLLoader to block requests for filesystem: URLs if the requested URL is not commitable in the current process. When site isolation is on, this will prevent one origin from fetching filesystem resources belonging to another origin. Note that this will also block web sites from requesting arbitrary extension filesystem URLs that lead to downloads, which is an intentional change discussed on 964245. An existing test in ProcessManagerBrowserTest is updated accordingly. Bug: 964245 Change-Id: I09023cc884278efef0bb4d16e584b2c5f1a5fd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635876Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#667356}
-
Eugene But authored
CHROME_EG_ASSERT_NO_ERROR is unnecessary anymore, because helpes can assert with correct file name and line number. This CL was prepared with automated script. TBR=rohitrao@chromium.org Bug: 963613 Change-Id: Ic63ed8c679f5282ecf84072c96c13617ad88ee43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649343Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#667355}
-
Ian Swett authored
Roll src/net/third_party/quiche/src/ 028931750..292b75cd1 (9 commits) https://quiche.googlesource.com/quiche.git/+log/028931750c1a..292b75cd1b53 $ git log 028931750..292b75cd1 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 wub gfe-relnote: (n/a) Remove unused function QuicConnection::EnableSavingCryptoPackets. Not protected. 2019-06-07 bnc Split cookies along ';' instead of '\0' in ValueSplittingHeaderList. 2019-06-07 dschinazi Make dispatcher VN client CID test work for all flag values 2019-06-06 danzh gfe-relnote: (n/a) code cleanup. Fix envoy compile errors. 2019-06-06 fayang Automated g4 rollback of changelist 250877268. 2019-06-06 wub gfe-relnote: Remove num_stateless_rejects_received_ from QuicClientBase. Cleanup only, not protected. 2019-06-06 fayang Automated g4 rollback of changelist 251711909. 2019-06-06 wub gfe-relnote: Remove the use of QUIC_CRYPTO_HANDSHAKE_STATELESS_REJECT. 2019-06-05 vasilvv gfe-relnote: Replace QuicIpAddress with a standalone implementation. No functional change, not flag protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=rch@chromium.org Change-Id: Ide151307d4e3f0c8123cf65d8f839464dd288025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649310 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#667354}
-
Jian Li authored
Setting it will skip the auto detection of response encoding. Bug: 966094 Change-Id: I601bbc99339a94ec314f52af4d38236cdd457017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650086Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#667353}
-
Brian Sheedy authored
Increases the delay after sending an intent to the VR settings service from 500 milliseconds to 3 seconds. Apparently it's possible for the service to take multiple seconds to actually apply the requested settings, in which case the test would run without the proper settings actually being applied. Most commonly, this resulted in the DON flow being skipped when we expected it to be present. TBR=billorr@chromium.org Bug: 972153 Change-Id: Iba9265c67cac5e5aee55a2dd85b2d2b0ab1170ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650087Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#667352}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/139ad7226949..62a919b508a7 git log 139ad7226949..62a919b508a7 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 manojgupta@google.com chromeos_config: Stop SimpleChrome testing on ASan/UBSan bots. Created with: gclient setdep -r src/third_party/chromite@62a919b508a7 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ice382628c5c8f2b609c8baa29f7ebdbeb9ea8425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650394Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667351}
-
Regan Hsu authored
Remove all browser language settings. Hide OS specific language settings in Browser settings. This CL doesn't decouple the language list and ordering shared between OS and Browser (i.e. adding a language or changing its ordering will be reflected in both lists). This will be addressed in a later CL. Bug: 950007 Change-Id: I7c0869f982d20eb9472bb7acb8413a7d20b1f8ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628030 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#667350}
-
James Cook authored
For now the OS settings page has similar behavior with respect to chrome://os-settings/search=<query> URL, so copy over the browser settings for that functionality. Bug: 967876 Test: browser_tests Change-Id: I95836c3f74f7f9f61fd9548cca15a2d0e1be94b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648909Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#667349}
-
Sven Zheng authored
Test fails https://ci.chromium.org/p/chromium/builders/ci/win-pixel-builder-rel/49 MBErr: Builder name "win-pixel-builder-rel" not found under masters[chromium.fyi] in "C:\b\s\w\ir\cache\builder\src\tools\mb\mb_config.pyl" Bug: 965769 Change-Id: I047eb2478ec73c66bc9c1db546931f77b5154e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648748Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#667348}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/76904e283cfb..a4f7ea8a065a Created with: gclient setdep -r src-internal@a4f7ea8a065a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=thomasanderson@google.com,huangs@google.com,harrisjay@google.com,armax@google.com Change-Id: I36c86f93bd12c66f7a03e22829c69406f7504a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650364Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667347}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1e364a244234..fad1e47feb22 git log 1e364a244234..fad1e47feb22 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 metzman@chromium.org Enable XFA in LPM fuzzer 2019-06-07 tsepez@chromium.org Remove FXFT_Face typedef. 2019-06-07 asweintraub@google.com Fix lint issue introduced in commit 84cf0b20. 2019-06-07 thestig@chromium.org Make GetShadingSteps() return a std::array. 2019-06-07 thestig@chromium.org Implement PDF417HighLevelEncoderTest.EncodeHighLevel. 2019-06-07 thestig@chromium.org Change DrawTextPath() call stack to pass matrix by reference. Created with: gclient setdep -r src/third_party/pdfium@fad1e47feb22 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:969811 TBR=pdfium-deps-rolls@chromium.org Change-Id: I2573a4fe15de001708a956a4eb90758cd09fb41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650395Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7301d427d5df..2ce284bd86cb git log 7301d427d5df..2ce284bd86cb --date=short --no-merges --format='%ad %ae %s' 2019-06-07 simonhatch@chromium.org Pinpoint - Bump up io timeout to match perf waterfall. Created with: gclient setdep -r src/third_party/catapult@2ce284bd86cb The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:971675 TBR=oysteine@google.com Change-Id: I73e2afb8a0ede69e22a121584ad947e00635bc3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650391Reviewed-by:
-
Mohamed Heikal authored
There is no guarantee that if chrome is in full browser mode that it is able to get a GCM token before scheduling a PrefetchBackgroundTask. This cl caches the prefetch gcm token in PrefService across browser restarts to help in that scenario. Bug: 968320 Change-Id: If88ef3d393daa998fae1d7681999921e9142ae2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638622 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 967793 Change-Id: I67cef5afc4cabc111be9163e895623e09c0c05f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645149Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2b82eb290220..7eb6be186be6 git log 2b82eb290220..7eb6be186be6 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 idanr@google.com dawn_native: Indirect draw/dispatch 2019-06-07 brandon1.jones@intel.com D3D12: Batch Usage Transitions For Render Pass Created with: gclient setdep -r src/third_party/dawn@7eb6be186be6 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I04fdf1fd520163d287c871e8a20a30c033e238e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650365Reviewed-by:
-
Ehsan Karamad authored
Many MimeHandlerView browser tests were failing on ChromeOS debug bots most likely due to the old network path (kNetworkService disabled). This CL enables all those tests on ChromeOS. Bug: 949565 Change-Id: I3d9ca747fea2f54d71a88484f72e7b6b55df4a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650041Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#667341}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/452f5badf421..80de3a4af4b8 git log 452f5badf421..80de3a4af4b8 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@80de3a4af4b8 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ifde52a8a611cb550359eb6a575ca1a316a5cfb5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650366Reviewed-by:
-
Carlos Caballero authored
Use ScopedTaskEnvironment instead of MessageLoop in /chrome/browser/chromeos/extensions/file_manager MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=joelhockey@chromium.org Change-Id: Ie1df92f584a7ee5cce3f3fd2b91db6bd00fa709c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649678 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#667339}
-
Wez authored
Content is typically rendered into a surface by the GPU process, and displayed into a window owned by the Browser process. In the Scenic Ozone platform this was implemented using import/export Nodes connecting the GPU & Browser. Content rendered to a ScenicSurface by the GPU process is now exported for display by a ScenicWindow via a nested View. Bug: WEB-50 Test: Manually verified that web content still renders. :D Change-Id: I3ba58c8fe509a2595ce0dd10e496701b0ebc2b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649181 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#667338}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a8ae579f7a8f..208d3132e6e8 git log a8ae579f7a8f..208d3132e6e8 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 stevenperron@google.com Cast __LINE__ to size_t (#2661) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@208d3132e6e8 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: Iba460d820d42dc863a00a8136f45d664902eb403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648882Reviewed-by:
-
Jeffrey Kardatzke authored
This is a reland of 869062d9 The prior CL failed in the MSAN tests, so this updates dummy_histogram.cc so that it sets the passed in values so they do not end up uninitialized. Original change's description: > Add browsertest for complete process of sending feedback report > > This adds a new browsertest which adds a hook into the feedback uploader > to catch it right before it does the actual report upload. This ensures > that clicking on the button to send a feedback report actually results > in the report getting queued to be sent. This covers a regression case > which is in crbug.com/954563. > > Bug: 955039, 954563 > Test: Browser tests pass, fail if prior regression was put back > Change-Id: I92762c1b6741ad057e78c8cafeb924f93995b249 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632534 > Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666036} Bug: 955039, 954563 Change-Id: I8291ece23b01299677924a680de8877cc4675ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649304Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#667336}
-
Siddhartha S authored
IPC messages sometimes show up under wrong bucket since the original task that posted is empty. This will ensure that we can differentiate between messages sent by the channel itself, vs the messages sent by untracked tasks. Change-Id: I6b6410959c2040b55e519f5c26b8081d61fa22c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641807Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#667335}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/acf7d24d0187..3c76b8aa36fa git log acf7d24d0187..3c76b8aa36fa --date=short --no-merges --format='%ad %ae %s' 2019-06-07 zoddicus@users.noreply.github.com Re-introduce SetShaderModel for backwards compatibility (#675) 2019-06-07 zoddicus@users.noreply.github.com Refactor dup'd arg handling functions into a single location (#660) 2019-06-07 zoddicus@users.noreply.github.com Update Dockerfile to use Python 3 (#668) 2019-06-07 zoddicus@users.noreply.github.com Add details of spvc to README.md (#661) 2019-06-07 zoddicus@users.noreply.github.com Change TODO(name) to TODO(bug issue#) for spvc files (#658) 2019-06-07 riko_ophorst@hotmail.com Fixing duplicate absolute install paths when using Visual Studio generators (#639) 2019-06-07 zoddicus@users.noreply.github.com Add in missing flags to pass more of the spirv-cross tests (#664) Created with: gclient setdep -r src/third_party/shaderc/src@3c76b8aa36fa The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: Idaf4a038c82ee89b347c322295aa1e51e61e4e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650363Reviewed-by:
-
Aleks Totic authored
This one is tough to reproduce, I could not come up with a simple case that fails in content_shell. It depends on not setting NeedsLayout for the entire document. Bug has the simplest reproducible case I could come up with attached. In the debugger, I was able to reproduce the bug. The root cause was that after rotating the device, abspos element ytp-large-play-button got its position from NGBlockNode::Layout, which ran NGBlockNode::RunLegacyLayout, which incorrectly got the layout_result out of the cache. The fix is to make RunLegacyLayout OOF aware. Bug: 970171 Change-Id: Ic799bb93cf99c7fc908db81a09c7dc0788bd741f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649086Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#667333}
-
Alison Maher authored
This change adds support for the forced-colors media query and adds forced colors to settings. The logic for updating forced colors from its default state based on the OS has not yet been implemented. Spec: https://drafts.csswg.org/mediaqueries-5/#forced-colors Bug: 970285 Change-Id: I634b4abeec22f2d166648948f290fff8f4229478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643650Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#667332}
-
Dan Beam authored
This changes the implementation around how dark mode is queried in CSS. Bug: 965811 Change-Id: I6d45507907364cdccdeeb4273562e4f81664f74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626350 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Oystein Eftevaag authored
R=ssid@chromium.org Change-Id: Idff267c6a5a3e2534a5d0ffab9676aa64e78fa3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644783 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#667330}
-
sczs authored
I've created the directory and have been involved in every contribution to it so far. Bug: 911864 Change-Id: I6a40424094d7f73eab46c48f20423da8614db46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648910Reviewed-by:
-
Pavol Marko authored
Wait for network policy application to actually finish before signaling that it's done. Network policy application is only finished when the changes sent to shill have been pulled back from shill and are now reflected in NetworkState objects. This is important because code evaluating e.g. the OnlyAllowPolicyNetworksToAutoConnect policy uses NetworkState objects to decide whether a network is policy-managed or not. Bug: 936677, 943102 Test: browsertest will be added in a follow-up CL to keep this small. Change-Id: I734bc75eb8422e934b20cb592ca3fc5c211779b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539839 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
-
Mandy Chen authored
Accessibility strings in front_end/accessibility/AccessibilityStrings.js are not localized. They are displayed in Elements pane -> Accessiblity pane -> Computed Properties. See https://imgur.com/HtE1ZhP. I wrap them in ls`` and add them to accessibility_strings.grdp file with descriptions. Description of a 'name' string: Accessibility attribute name that appears under the Computed Properties section in the Accessibility pane of the Elements pane Description of a 'description' string: Tooltip text that appears when hovering over the '<name>' attribute name under the Computed Properties section in the Accessibility pane of the Elements pane Bug: 941561 Change-Id: I655760c02ee31ef4e22385c9dc003fd4152c93c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648332 Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Reviewed-by:
-
Philip Rogers authored
There are two dirty bits for whether TransformTree::UpdateLocalTransform needs to be called: TransformNode::needs_local_transform_update, and TransformTree::needs_update. If the transform tree does not need an update, we skip calling TransformTree::UpdateLocalTransform. This patch DCHECKS that no transform node needs an update if we are skipping TransformTree::UpdateLocalTransform due to the tree not needing an update. Bug: 864567 Change-Id: Ib43ce23d8715c1cf802aaefb8e4068ce24fd07b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650120 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#667326}
-
Etienne Pierre-doray authored
This CL replaces ScopedNestableTaskAllower with kNestableTasksAllowed passed as argument to the RunLoop involved if any. Only native nested loops should use ScopedNestableTaskAllower (soon to be deprecated). For more details, see: https://cs.chromium.org/chromium/src/base/message_loop/message_loop_current.h?sq=package:chromium&dr=CSs&g=0&l=159 A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1635819 Please CQ if LGTY! This CL was uploaded by git cl split. R=dcheng@chromium.org Bug: 766678 Change-Id: I59de40f915421970b5da834ac2240c733581d8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636057 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#667325}
-
