GitLab

This logs:
a boolean telling the AudioInputController is getting the recording data after an input stream was started.

This is symmetric to AudioOutputControllerPlaybackStartupSuccess on the output side.

NOTRY=true
BUG=357501

Review URL: https://codereview.chromium.org/271093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269589 0039d316-1c4b-4281-b951-d872f2087c98

Spinoff of patch https://codereview.chromium.org/250143002/

For trivial change in chrome/utility/media_galleries/media_metadata_parser.cc:
TBR=vandebo

BUG=304290

Review URL: https://codereview.chromium.org/270873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269588 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359299
TEST=valgrind unittests
TBR=zork@chromium.org

Review URL: https://codereview.chromium.org/273623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269587 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/273303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269586 0039d316-1c4b-4281-b951-d872f2087c98

Managing observer lists is needed by all the tests that end up calling
DownloadItem::AddObserver. This CL adds real observers to
MockDownloadItem so that tests don't need to mock this behavior.

BUG=367311

Review URL: https://codereview.chromium.org/248713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269585 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269584 0039d316-1c4b-4281-b951-d872f2087c98

If a user blacklists or unblacklists a site in a separate tab, we need
to correctly update every other tab's state (consider the unlikely case
of logging into the same site 8 times at the same time in separate tabs,
or the slightly less unlikely case of changing status in
chrome://settings/passwords while a login page is visible). This CL updates
the observer logic to account for blacklist entries being added and removed
from the PasswordStore, and updates the UI accordingly.

---------------------------------------------------------------------------
This is a reland of r269244, which was reverted due to LSAN breakage.
Original review at https://codereview.chromium.org/276683003/
---------------------------------------------------------------------------

BUG=261628
TBR=vabr@chromium.org

Review URL: https://codereview.chromium.org/276583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269583 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=72&start=14665
TBR=
BUG=

Review URL: https://codereview.chromium.org/274103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361809

Review URL: https://codereview.chromium.org/278593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269581 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tdresser@chromium.org
BUG=372143
TEST=waterfall

Review URL: https://codereview.chromium.org/278173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269580 0039d316-1c4b-4281-b951-d872f2087c98

The atomic number of rubidium.
The normal human body temperature in degrees Celsius.
A television channel reserved for radioastronomy in the United States.
+37 was the international dialing code of the German Democratic Republic (aka East Germany).

R=kareng@google.com

Review URL: https://codereview.chromium.org/272273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269579 0039d316-1c4b-4281-b951-d872f2087c98

This removes the use of a static initializer and makes it possible
for clients to pass a key without owning the memory where the
key is stored (as would be the case if passed to a static const char*).

BUG=371626, 371204

Review URL: https://codereview.chromium.org/279633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269578 0039d316-1c4b-4281-b951-d872f2087c98

This makes it so the buttons can be seen against the dark background.

TBR=oshima
BUG=339558

Review URL: https://codereview.chromium.org/274013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269577 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367198

Review URL: https://codereview.chromium.org/270823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269576 0039d316-1c4b-4281-b951-d872f2087c98

ContentViewCore.java:
Before: real 1m25.705s
After: real 0m0.257s

There was a few overly cautious "non-greedy" terminations, and a few optional
matches outside their respective optional blocks.

BUG=371520

Review URL: https://codereview.chromium.org/277753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269575 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup change to the createImageCHROMIUM api to follow up https://codereview.chromium.org/255713008/

BUG=

Review URL: https://codereview.chromium.org/278453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269574 0039d316-1c4b-4281-b951-d872f2087c98

- Uses ScopedTempDir to remove dependency on TestingProfile.
- Uses test::TestBookmarkClient to remove dependency on MessageLoop,
  BookmarkModelFactory, TestingProfile, TestBrowserThreadBundle

BUG=367836

Review URL: https://codereview.chromium.org/273663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269573 0039d316-1c4b-4281-b951-d872f2087c98

The reason to provide default implementations for these methods
is that so an embedder that wants to use bookmarks and doesn't need/want
favicons or omnibox-related methods doesn't even have to think about what
to provide as implementations for them.

BUG=367707

Review URL: https://codereview.chromium.org/274063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269572 0039d316-1c4b-4281-b951-d872f2087c98

This patch enables WebContentsObserver::OnMessageReceived to receive
a reference to RenderFrameHost that received the message.

This allows passing of JavaBridgeDispatcherHostManager ownership from
WebContentsImpl to ContentViewCore and removing of some redundant
initialization code in JavaBridgeDispatcherHostManager, fixing
a long-standing TODO.

This patch also includes a fix for "Search Google for this image"
discovered shorly after the original patch has been landed.

BUG=371296
TBR=jam@chromium.org,benm@chromium.org,yoz@chromium.org,bauerb@chromium.org,fsamuel@chromium.org

Review URL: https://codereview.chromium.org/275873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269571 0039d316-1c4b-4281-b951-d872f2087c98

Instead of bundling up the ozone stuff into the larger gfx.gyp:gfx target,
split up the ozone-related code into a smaller gfx_ozone target with a
small dependency (base, skia). This allows ozone-platforms to implement
the ozone interface without bringing along the rest of gfx.

BUG=361137
R=rjkroege@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/271303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269570 0039d316-1c4b-4281-b951-d872f2087c98

The world_id is now always zero.

BUG=none
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/275453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269569 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True

the win_chromium_rel failure must be a flake, since my CL only edits mac-only files.

the mac gpu failure is unrelated to this CL

Review URL: https://codereview.chromium.org/248113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269568 0039d316-1c4b-4281-b951-d872f2087c98

Because Declarative Web Request lacks an active owner at the moment, this CL adds a warning notice to the API's documentation site:
"this API is currently on hold, without concrete plans to move to stable"

Staged at https://chrome-apps-doc.appspot.com/_patch/276483005/extensions/declarativeWebRequest, but http://crbug.com/371402. Screenshots in my GDrive: https://drive.google.com/a/google.com/folderview?id=0Bx9cneu-k1RNeUZnRk5NWERObE0&usp=sharing (Google only, but let me know if you come from outside and need them).

Original at https://developer.chrome.com/extensions/declarativeWebRequest

BUG=112155

Review URL: https://codereview.chromium.org/276483005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269567 0039d316-1c4b-4281-b951-d872f2087c98

Navigating directly to chrome://settings/syncSetup in guest mode is causing a DCHECK() failure, since the ProfileSyncService is NULL in the guest mode.

This patch adds a NULL check on ProfileSyncService to fix the crash
and also terminates the sync setup if the service is NULL.

BUG=370861

Review URL: https://codereview.chromium.org/277433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269566 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364141, 330264

Review URL: https://codereview.chromium.org/261013005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269565 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371148

Review URL: https://codereview.chromium.org/278853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269564 0039d316-1c4b-4281-b951-d872f2087c98

Snapping which is intended to snap to existing scale during pinch
is not working. That is, because the snap ratio constant is wrong,
snapping logic do not work and might make extra tiling during pinch.

BUG=368203

Review URL: https://codereview.chromium.org/256343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269563 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/277893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269562 0039d316-1c4b-4281-b951-d872f2087c98

A recent refactoring accidentally removed the code that turns on vsync
for synthetic gestures. This causes the gesture to never start if
nothing else happens to turn on vsync at the same time.

BUG=370967
TEST=tools/perf/run_benchmark rasterize_and_record_micro.key_silk_cases
--browser=android-chrome --page-filter=slide_drawer

Review URL: https://codereview.chromium.org/269343013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269561 0039d316-1c4b-4281-b951-d872f2087c98

Replace DCHECK with conditions and set the connection status as
unencrypted, if the security_style is unknown / HTTPS without a
certificate / not HTTPS.

BUG=344891

Review URL: https://codereview.chromium.org/172173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269560 0039d316-1c4b-4281-b951-d872f2087c98

Under current implementation, extension part of entry name (after the last '.') is not focused even when users rename directories.
For directories, whole entry name should always be focused.

BUG=371676
TEST=manually tested

Review URL: https://codereview.chromium.org/279753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269559 0039d316-1c4b-4281-b951-d872f2087c98

Also revert the temporary change for the sandbox test framework,
which allows fork() with threads.

https://codereview.chromium.org/242383003

TEST=nacl_loader_unittests, components_unittests, and trybots
BUG=364751

Review URL: https://codereview.chromium.org/273623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269558 0039d316-1c4b-4281-b951-d872f2087c98

We don't offer the flag on non-Aura platforms, but it's certainly possible
for a user to enter the CLI flag manually. We'd prefer not to crash in
that case.

BUG=261628

Review URL: https://codereview.chromium.org/276523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269557 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the app list would be centered only when the virtual
keyboard is enabled. Now it is centered whenever the virtual keyboard
might be enabled, with the following new cases:
- If --ash-enable-touch-view-testing is on.
- If any accelerometer data is detected (as this can trigger virtual
keyboard).

BUG=369382
TEST=Run ChromeOS with --ash-enable-touch-view-testing. App launcher
should be centered and landscape.

Review URL: https://codereview.chromium.org/264523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269556 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/274473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269555 0039d316-1c4b-4281-b951-d872f2087c98

This test assumed that the ExtensionDownloader schedules its fetchers
in the order that StartUpdateCheck() is called, when downloading more
than one ManifestFetchData. However, the ExtensionDownloader was updated
in http://crrev.com/171540 to use a RequestQueue, which schedules the
fetchers using a heap.

That heap sorts the requests by time to the next retry, which is 0
for all requests initially. The test didn't break before because
std::push_heap and std::pop_heap in all STL implementations used
happen to keep the same order when all requests have the same
priority (!). This assumption broke under TSAN/MSAN builds because
they use libc++, whose std::pop_heap changes the order of the
execution of the fetches.

This fix makes the test support its fetches in any order.

BUG=358712

Review URL: https://codereview.chromium.org/271873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269554 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Update DomDistillerJsUpdater and Roll DomDistillerJs (https://codereview.chromium.org/277563002/)

Reason for revert:
check_licenses failure: http://build.chromium.org/p/chromium/builders/Linux/builds/49667

Original issue's description:
> Update DomDistillerJsUpdater and Roll DomDistillerJs
> 
> The update script should build `ant package` and copy the entire
> out/package directory.
> 
> This moves the path to domdistiller.js to .../package/js so update
> that reference.
> 
> The old (non-proto) API is still supported, so this keeps using that.
> 
> Picked up changes:
> fdb023d Fix Proto module's path
> 44e9366 This adds two simple protoc plugins.
> 
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269485

TBR=yfriedman@chromium.org,cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/278143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269553 0039d316-1c4b-4281-b951-d872f2087c98

They're only used as a synchronous signal to start/stop the audio sink.

BUG=144683

Review URL: https://codereview.chromium.org/275673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269552 0039d316-1c4b-4281-b951-d872f2087c98

In RTL languages, entry names (file names, directory names, volume names,...) look strange around the neutral characters (' ', '.', ')'...).
This can be avoided by keeping base direction of bidi algorithm 'ltr' consistently and it is same behavior as Windows 8.

BUG=371232
TEST=manually tested

Review URL: https://codereview.chromium.org/273983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269551 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes an issue with the experimental app launcher's buttons being laid
out above the app grid due to the contents view being re-added on profile
switch. This has been fixed by ensuring the contents view is always added to
the same position.

BUG=371695

Review URL: https://codereview.chromium.org/272923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269550 0039d316-1c4b-4281-b951-d872f2087c98