- 20 Dec, 2018 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9fbd2ad38c75..e4beab79cd67 git log 9fbd2ad38c75..e4beab79cd67 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 egdaniel@google.com Disable vulkan specific code in GrAHardwareBufferImageGenerator when not building vulkan. 2018-12-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-12-20 herb@google.com Remove PackedID from the strike call chain 2018-12-20 brianosman@google.com Add wide color support to stroke rect op and default GP 2018-12-20 reed@google.com remove some dead debugger command types 2018-12-20 herb@google.com Make and use a ctor for GrGlyph Created with: gclient setdep -r src/third_party/skia@e4beab79cd67 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: I6c880e82e9110a81924db38eeb5a2fe07ab0135b Reviewed-on: https://chromium-review.googlesource.com/c/1387825Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618355}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b903bc0f5428..82c17e7b8d31 Created with: gclient setdep -r src-internal@82c17e7b8d31 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibd8616a82847ab0b4da8f9d6cd73219f2ff5346b Reviewed-on: https://chromium-review.googlesource.com/c/1387824Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618354}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/44d98b424db4..4626e207e285 git log 44d98b424db4..4626e207e285 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 tsepez@chromium.org Remove CFX_FloatRect::Reset(). 2018-12-20 tsepez@chromium.org Remove CFX_RectF::Reset(). 2018-12-20 thestig@chromium.org Fix a crash in FPDFPage_TransFormWithClip(). 2018-12-20 thestig@chromium.org Change FPDFPage_TransFormWithClip() to take const pointers. 2018-12-20 thestig@chromium.org Implement CFXMatrixFromFSMatrix(). 2018-12-20 thestig@chromium.org Reorder cpdfsdk_helpers.cpp to match its header. 2018-12-20 tsepez@chromium.org Pass matrix to CPDF_ClipPath::Transform() by const-ref. Created with: gclient setdep -r src/third_party/pdfium@4626e207e285 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5b2457adb2149a3650839d3b099ffb29da93216a Reviewed-on: https://chromium-review.googlesource.com/c/1387648Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618353}
-
Nico Weber authored
1. Don't create a temporary zip list just for element-wise comparison. 2. Only enter the streams loop if we don't end up throwing away all computation in it. On my machine, reduces runtime on a synthetic benchmark (comparing base_unittests and all deps between a release and a debug component build) from 37s to 20s. Bug: 314403 Change-Id: Id425c3fbab99981391ec9de8887defc00d0da0af Reviewed-on: https://chromium-review.googlesource.com/c/1387609Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#618352}
-
Vladimir Levin authored
This patch changes the display locking update() function to not paint. The reason for this is that update cannot release the lock on its own and painted information is not needed for any information that script might want. Note that this updates the budget to actually check if any work is required since we cannot reliably wait for any lifecycle phase. Previously we waited for paint which was always guaranteed to happen. Note that this updates the budget API to have NeedsLifecycleUpdates instead of DidFinishLifecycleUpdates, which now checks the dirty bits for any phases that might need updating. It might be nice to implement co-operative painting that stashes the paint for later use, but at this point it is only doing extra work. R=chrishtr@chromium.org Bug: 882663 Change-Id: Ie426dc75ea036b6f2e16b1b592763267957685ce Reviewed-on: https://chromium-review.googlesource.com/c/1383324 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#618351}
-
Kristi Park authored
NTP thumbnails have been deprecated as of M69. As such, data stored in TopSitesDatabase for thumbnails/forced sites is unused. Refactor TopSitesDatabase to not return forced sites/thumbnail data. If a database entry is updated, the entry's thumbnail data will be overridden and discarded. New entries will not contain thumbnail data, and forced sites will no longer be stored. Bug: 893362 Change-Id: I6fc0bd8b7c04c7451bfe7ec1a072a7ac66df7c52 Reviewed-on: https://chromium-review.googlesource.com/c/1368778 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#618350}
-
Robert Flack authored
Blink animations, which make up the majority of cc::Animations, always set ElementId on the KeyframeModel. In the longterm this will be the case for all animations. Optimize for this case to address the branch performance cost in issue 909054. Bug: 909054 Change-Id: I4e34607dc3c17040afa3199bc8a675d5d84cd520 Reviewed-on: https://chromium-review.googlesource.com/c/1378585Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#618349}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3a190c23ddf1..9310cd73f7e0 git log 3a190c23ddf1..9310cd73f7e0 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 benjhayden@chromium.org Replace RelatedHistogramMap with RelatedNameMap+Breakdown in EQT metric. Created with: gclient setdep -r src/third_party/catapult@9310cd73f7e0 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib756da3f7280b3c64e02262442833c6f70d6c13a Reviewed-on: https://chromium-review.googlesource.com/c/1387649Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618348}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bcb7890895d2..2b35654dcf74 git log bcb7890895d2..2b35654dcf74 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 jmadill@chromium.org compiler: Fix const non-square matrix component mult. Created with: gclient setdep -r src/third_party/angle@2b35654dcf74 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:912505,chromium:912508 TBR=geofflang@chromium.org Change-Id: Id6e88b1d8abbf8987fa7829d93616a745ab469fb Reviewed-on: https://chromium-review.googlesource.com/c/1387291Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618347}
-
Joshua Peraza authored
Change-Id: Ic5f842a837be9f9b258acec94707a15882656aa3 Reviewed-on: https://chromium-review.googlesource.com/c/1387668Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#618346}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c8bf89ddf03e..21ed12045bb6 git log c8bf89ddf03e..21ed12045bb6 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 shaobo.yan@intel.com Guard header files in utils with #ifdef and #endif Created with: gclient setdep -r src/third_party/dawn@21ed12045bb6 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I4838e8ec901e7be5ecf637e8f42a10a65b3c7b06 Reviewed-on: https://chromium-review.googlesource.com/c/1387290Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618345}
-
sebsg authored
Original change's description: > Revert "[AF] Move the IsDeletable... function from PDM to card/address classes." > > This reverts commit 7f17ed45. > > Reason for revert: CreditCardTest.IsDeletable failed on failing on chromium.linux/Linux Tests > > Bug: 915976 > > Original change's description: > > [AF] Move the IsDeletable... function from PDM to card/address classes. > > > > Bug: 913941 > > Change-Id: I89667e635b362cc33629d8d2a9873d70e881423d > > Reviewed-on: https://chromium-review.googlesource.com/c/1381138 > > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#617297} > > TBR=rogerm@chromium.org,sebsg@chromium.org > > Change-Id: I1fa83824773a734810eed12c0bd5960aedae5f66 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 913941 > Reviewed-on: https://chromium-review.googlesource.com/c/1381392 > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#617332} TBR=horo@chromium.org,rogerm@chromium.org,sebsg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 915976, 913941 Change-Id: I7c024efbf74116eb66dbc73c9a02668baf3b74b4 Reviewed-on: https://chromium-review.googlesource.com/c/1384647Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#618344}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c2013e248bb0..5e19d3febca6 git log c2013e248bb0..5e19d3febca6 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 stevenperron@google.com Add custom target to wrap around custom commands. (#2198) 2018-12-20 stevenperron@google.com Process moer options when processing options file. (#2251) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@5e19d3febca6 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie14ff9f8e9f231a62210bcc3b0f6398a9ebeeef8 Reviewed-on: https://chromium-review.googlesource.com/c/1387646Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618343}
-
Fan Yang authored
R=rch@chromium.org Bug: 913821 Change-Id: I2ad66cf2740c89fa2aec6ad23614373ccc160866 Reviewed-on: https://chromium-review.googlesource.com/c/1378406Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#618342}
-
chrome://crashesLeonard Grey authored
This causes confusion in bug reports, since the local ID isn't actionable for us. Bug: 646455 Change-Id: I342893cc1f42a5a6cc011d97d5b20fd278a925f0 Reviewed-on: https://chromium-review.googlesource.com/c/1387046Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#618341}
-
Xiaoqian Dai authored
If a tab-dragged browser window is merged into another browser window after the drag ends, we need to make sure the divider bar is placed properly on top. Otherwise, it may not receive events properly. Bug: 917068 Change-Id: I1f19d9e7a94427e47b91a9c8b5b037dda3e2f1b8 Reviewed-on: https://chromium-review.googlesource.com/c/1387468 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#618340}
-
Cary Clark authored
Skia SkPath::isConvex() is faster and more robust, and marks paths correctly as convex that were marked as concave. This causes a few tests to have different pixel results; the convex renderers are generally faster and use different rendering techniques. Also, remove a legacy Skia flag; SkPath::pathRefIsValid() has been removed. R=fmalita@chromium.org Bug: 899689,913930 Change-Id: Ic11a04e853e2c88444388d27f2894be287aa349d Reviewed-on: https://chromium-review.googlesource.com/c/1379276 Commit-Queue: Cary Clark <caryclark@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#618339}
-
Tomasz Wiszkowski authored
Bug: 871798 Change-Id: If3c9199ec66ef48db305f3cd09d6eec619ed4921 Reviewed-on: https://chromium-review.googlesource.com/c/1383437 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#618338}
-
Tao Bai authored
Bug: 917112 Change-Id: Idcfac659688b33f48d4dede027cf56173a1e4414 Reviewed-on: https://chromium-review.googlesource.com/c/1387665Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#618337}
-
Lukasz Anforowicz authored
LoadDataWithBaseURL should be avoided in browser tests, because 1. It doesn't fully, correctly simulate navigating to a real website. 2. It is only used in production in Android WebView and in GuestView (both of which don't run with site-per-process, which is the default mode on desktop platforms). Cleaning up test usage of LoadDataWithBaseURL will help proceed with enforcement of CanCommit origin checks - LoadDataWithBaseURL is problematic because it commits https://foo.com origin in a SiteInstance associated with data: site URL. Bug: 770239 Change-Id: Ic68697be28cace0d8ff8abc0951e12cb5f81ac68 Reviewed-on: https://chromium-review.googlesource.com/c/1385471Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#618336}
-
Tom Anderson authored
This is needed to enable in-tree libc++ on Android. Otherwise, we'll see errors that look like this: FAILED: libwebviewchromium.so libwebviewchromium.so.TOC lib.unstripped/libwebviewchromium.so ld.lld: error: undefined symbol: __cxa_guard_acquire >>> referenced by aw_contents.cc:122 (../../android_webview/browser/aw_contents.cc:122) >>> obj/android_webview/common/aw_contents.o:(android_webview::(anonymous namespace)::g_locale()) The issue is that libc++abi is not a dependency of libc++ in asan builds -- instead it's exported from executables to prevent multiple definitions of libc++abi symbols. -Wl,-z,-defs is normally added only for non-sanitizer builds [1] on Linux, Android, and Fuchsia. But the Android-specific config adds -Wl,--no-undefined (which is identical to -Wl,-z,-defs) all the time. The solution is to simply remove the Android-specific -Wl,--no-undefined and rely on the -Wl,-z,defs added by //build/config/compiler:compiler. [1] https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?rcl=c6dd1fda26ff8dddd92ba7830e8696afe3b031f5&l=398 BUG=916962 R=thakis Change-Id: If6887c96a0eaeeac3c831511e3e4519dac3532b5 Reviewed-on: https://chromium-review.googlesource.com/c/1387399Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#618335}
-
Sophie Chang authored
This is redundant for me since I'm on breve-team-reviews@chromium.org and do not need this to personally cc me. Change-Id: I5d330ce512b813c6803efbbf2b5b7f0724c3db2d Reviewed-on: https://chromium-review.googlesource.com/c/1387835Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#618334}
-
Henrik Boström authored
Previously, associated media streams were only updated on the "addition" and "removal" of a track. But MSIDs can change for active receivers as well. In this CL, we always update the associated media streams based on the state of the webrtc-layer receiver. Bug: webrtc:10083 Change-Id: I54bb00a5077a0b7b78964faf13882055c8101427 Reviewed-on: https://chromium-review.googlesource.com/c/1384257 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#618333}
-
Min Qin authored
Resuming an offline page download will construct OfflineContentAffregatorNotificationBridgeUiFactory. That class uses the browser profile, which is not available for service manager only mode. This CL excludes offline page download from service manager only mode. BUG=916393 Change-Id: I1ac9185adc2890568d7eaf5304550644ab7c3d89 Reviewed-on: https://chromium-review.googlesource.com/c/1387544Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#618332}
-
Tomasz Wiszkowski authored
Change-Id: Id25261aac8f8f5228bf69ff46a6ee8763f96169e Bug: 871798 Reviewed-on: https://chromium-review.googlesource.com/c/1380958Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#618331}
-
Piotr Bialecki authored
Remove ARCore SDK 1.1 now that we are switching to newer version. android-binary-size trybot was complaining about growth of APK - this is suppressed by adding "Binary-Size" explanation in the footer. The size impact is 300369 additional bytes - it should be acceptable since it only affects canary & dev channels (not present on stable). Additionally, the AR support will be deployed as a DFM when we release it, so the impact on on base APK size should be way smaller than what is currently reported by trybots. is currently only packaged for dev, canary and default channels. Bug: 887669 Change-Id: I56a2230f31b4e17925ddb4e2d2b20266e55c1091 Binary-Size: Increase is due to packaging ARCore into the APK. ARCore Reviewed-on: https://chromium-review.googlesource.com/c/1357349Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#618330}
-
Mathieu Perreault authored
Feature has been on by default for a while. TBR=rkaplow Bug: 906135 Change-Id: Ib44fe4d5cc728c622d33b2e4a9eeb5c0415b6aae Reviewed-on: https://chromium-review.googlesource.com/c/1387153 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#618329}
-
Xida Chen authored
This CL is a re-land of: https://chromium-review.googlesource.com/c/chromium/src/+/1281702 Previous CL depends on the usage of default hash traits implementation of enum, which could crash. In this CL, instead of keeping two hash maps: 1. HashMap<CSSPropertyID, String> native_values_ 2. HashMap<String, String> custom_values_ We keep one hash map only: HashMap<String, String> values_ Because we guarantee that CSS native and custom property name will never conflict, this is safe. PS#1 is the original CL so that we can easily see the diffs. TBR=pdr@chromium.org Bug: 884698 Change-Id: Ifc74a13ba67fa74ff1a3dd9dbca628675b42c777 Reviewed-on: https://chromium-review.googlesource.com/c/1386648 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#618328}
-
Richard Knoll authored
We use two nested |BoxLayout|s to layout the notification header. This CL uses the shiny new |FlexLayout| which is already in use by the |ToolbarView| to prevent very long URLs from moving the control buttons off the side. Also set the correct text elide behaviour to trim URLs from the start to see the TLDs. Bug: 915224 Change-Id: I662eb4e7f71356e8d441229c2e01b7b2da0caa95 Reviewed-on: https://chromium-review.googlesource.com/c/1384372 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#618327}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2cc6e2553669..7b72af28fb84 git log 2cc6e2553669..7b72af28fb84 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@7b72af28fb84 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I6b85769d91926eeca77ec05f6acf5e8b6defa40b Reviewed-on: https://chromium-review.googlesource.com/c/1387289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618326}
-
Lei Zhang authored
Also delete an unused placeholder exception. Change-Id: Ice6cff86ec75c32d950a5f0dec87f0ea34a71b4d Reviewed-on: https://chromium-review.googlesource.com/c/1385455 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#618325}
-
Maks Orlovich authored
They were disabled when Windows was not supported by the backend at all, but now it is used for things like CacheStorage on the platform, and there is support for renames of open files. Change-Id: I69d353041a6920cfd6ec7d312026a3cc650ec3b4 Reviewed-on: https://chromium-review.googlesource.com/c/1387685 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#618324}
-
Lei Zhang authored
Use early returns and ternary operators. Change-Id: I6eb8154736e8bbe9f740cb2887b2ae44d610ea00 Reviewed-on: https://chromium-review.googlesource.com/c/1385857 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#618323}
-
Richard Knoll authored
Move UpdateControlButtonsVisibility up to |MessageView| and removing unused code. This is a preparation to fix the |NotificationHeaderView|. Note: |ArcNotificationView| is now the only class overriding this. Bug: 915224 Change-Id: Ide72668c7bb88c63148c43e756061bbdb9ff13eb Reviewed-on: https://chromium-review.googlesource.com/c/1386624 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#618322}
-
Xiyuan Xia authored
Until test infra code is updated similar to content_browsertests to use Window Service. Bug: 916180 Change-Id: Ic348c81874cae60258ebfe20cd6f4223a2ec7e4a Reviewed-on: https://chromium-review.googlesource.com/c/1385468Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#618321}
-
Vikas Soni authored
1. Implemented Vulkan backed skia representation of SharedImageBackingAHB. 2. Added synchronisation between gl backed and Vk backed representations. Bug: 891060 Change-Id: I46ba32dea62569cd67d6f3b24559f4ef28307168 Reviewed-on: https://chromium-review.googlesource.com/c/1370471Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#618320}
-
edchin authored
A prior fix early exited the observer method |didDetachWebState| if the WebStateList is nil. We also logged a histogram to see how often we see that WebStateList is nil. The histogram shows that the WebStateList is never nil at that point. However, we are still seeing these real world crashes in a free function one frame lower in the call stack. This CL adds an early exit and histogram log to the free function, which is where the crash has always been occurring. Bug: 877792 Change-Id: Icd099af3e399a748fa744674cc6756cfac09cf4e Reviewed-on: https://chromium-review.googlesource.com/c/1384791 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#618319}
-
Ryan Sleevi authored
Retire Net.CertificateTransparency.[MainFrameValidSCTCount,SCTsPerConnection] and Net.OCSPResponseStapled The first two histograms were related to the policies around and the rollout of Certificate Transparency, and as the ecosystem has matured and evolved, provide less direct value. The latter is related to our policies around OCSP and OCSP stapling, and as those have evolved, is no longer a priority for measurement and assessment, as there is no longer a need to assess the webcompat impact. Bug: 898016, 842976 Change-Id: I1c87eb73635f92b6a52bc6b8cebd69660db3d2e5 Reviewed-on: https://chromium-review.googlesource.com/c/1385549 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#618318}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3793bb447ae5..7f57788ab7e2 git log 3793bb447ae5..7f57788ab7e2 --date=short --no-merges --format='%ad %ae %s' 2018-12-20 srte@webrtc.org Removes trial to enable BBR congestion controller. 2018-12-20 crodbro@webrtc.org Make pacing buffer send interval configurable. 2018-12-20 ssilkin@webrtc.org Propagate spatial index to EncodedImage. 2018-12-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bdf260ef..5397835a (617896:618202) Created with: gclient setdep -r src/third_party/webrtc@7f57788ab7e2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If8beb51c490e84b00aa662aafaeb380d09cb738d Reviewed-on: https://chromium-review.googlesource.com/c/1386990Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618317}
-
Xianzhu Wang authored
For pre-CompositeAfterPaint, we call InvalidateChromeClient() when an object is invalidated in a view referenced from a plugin or an svg-image. Now let the path also work for CompositeAfterPaint. This fixes several web plugin tests for CompositeAfterPaint. Bug: 524134 Change-Id: Ia4c3ccba4632ddcdfdfdfec299fb7a68440a1419 Reviewed-on: https://chromium-review.googlesource.com/c/1385112Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#618316}
-