- 11 Jun, 2018 40 commits
-
-
Sylvain Defresne authored
With https://crrev.com/c/1070158, base::Bind() supports block via base::RetainBlock(). Converts uses of the now deprecated base::BindBlock(). Bug: 701275 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I103584b54f656f10e17c8e2439e0520c7690dbfe Reviewed-on: https://chromium-review.googlesource.com/1090912Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#565956}
-
Tim Schumann authored
This reverts commit 9ec0dfc9. Reason for revert: CrostiniInstallerViewBrowserTest.ErrorThenCancel is flaky. See https://bugs.chromium.org/p/chromium/issues/detail?id=851253 Original change's description: > Fixes a crash when the user's install flow fails and we press Cancel. > > Verified fix using a BrowserTest. > > Verifying the fix properly meant fleshing out FakeConciergeClient with > settable response protos for all methods. > > Found an invalid DCHECK of |state_| in CrostiniInstallerView when testing. > > Guard CrostiniRestarterService::Abort. > There used to be a DCHECK, but it shouldn't be. It is a legitimate possibility > to cancel the install flow right when the the container startup was complete. > > Bug: 850281 > Change-Id: I0cf6bcef1f4f043d9c7e40f3a8baa458fb6f6ba7 > Reviewed-on: https://chromium-review.googlesource.com/1089600 > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Timothy Loh <timloh@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565603} TBR=hashimoto@chromium.org,stevenjb@chromium.org,timloh@chromium.org,nverne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 850281 Change-Id: Ica8ccaf48e9b0624930a8d35f11cdd0dff01734a Reviewed-on: https://chromium-review.googlesource.com/1095134Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#565955}
-
Tim Schumann authored
This test is flaky on Mac. BUG=851252 TBR=rdevlin.cronin@chromium.org Change-Id: I365c4ebd53fd83fe32e6c1719870a1350911c540 Reviewed-on: https://chromium-review.googlesource.com/1095076Reviewed-by:
-
Makoto Shimazu authored
In the current implementation, ServiceWorkerNewScriptLoader assume that OnScriptLoadingResponseBody() is called before OnComplete(). However, MojoAsyncResourceHandler doesn't call it when response body is empty. This CL is to adopt that based on discussion at crbug.com/826868. Bug: 848606, 826868 Change-Id: I46646fc2d48c51aa89e02d63c057ef42e74ebb7d Reviewed-on: https://chromium-review.googlesource.com/1088463 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#565953}
-
Javier Ernesto Flores Robles authored
Removes the dependency in showcase and move the files to the autofill folders. Renames |manual_fill| to |manualfill| for consistency with |autofill|. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibdab6d8044681e370726e7111225e16432158b1f Reviewed-on: https://chromium-review.googlesource.com/1082396 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565952}
-
David 'Digit' Turner authored
Some constants and methods related to extracted native libraries from the Chrome APK into a private application data directory are moved from the ResourceExtractor.java class to LibraryLoader.java instead. This is a more logical place, since ResourceExtractor.java is going to be moved out of //base and into //ui/base/ since it is now mostly related to UI resources. See referring bug for more context. BUG=846633 R=agrieve@chromium.org, pasko@chromium.org Change-Id: I7ff442930ee80dfe9230021ce8e099393d51beca Reviewed-on: https://chromium-review.googlesource.com/1090926 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#565951}
-
Olivier Robin authored
Monitor the source of the input and change events. If the last value was set programmatically, allow to overwrite the value by autofill. This is the ios version of https://chromium-review.googlesource.com/c/chromium/src/+/1069226 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1b05f02bc93d9e77ce3de9fc939936766a659d87 Reviewed-on: https://chromium-review.googlesource.com/1092858 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Niels Möller authored
This drops the gyp dependency from vs_toolchain.py. Setting of other GYP_MSVS_* environment variables left unchanged. Bug: 826218 Change-Id: I86e20065e95e17f85566440009df40eaf27069ac Reviewed-on: https://chromium-review.googlesource.com/1063611Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#565949}
-
Sylvain Defresne authored
With https://crrev.com/c/1070158, base::Bind() supports block via base::RetainBlock(). Converts uses of the now deprecated base::BindBlock(). Bug: 701275 Change-Id: I1c0111c6b073c83c3e2638717b0cec1ade13731e Reviewed-on: https://chromium-review.googlesource.com/1092690Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#565948}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/92206a4..153d3ba git log 92206a4..153d3ba --date=short --no-merges --format='%ad %ae %s' 2018-06-11 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@153d3ba The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: Ia486e1e41f324e142cb6a6a65a6aa886f0878be3 Reviewed-on: https://chromium-review.googlesource.com/1094975Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565947}
-
Tsuyoshi Horo authored
Bug: 851363 TBR: kouhei@chromium.org Change-Id: Iffe66136447f801375716c7541940b7febb22304 Reviewed-on: https://chromium-review.googlesource.com/1094847Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#565946}
-
Hayato Ito authored
This reverts commit e9fcce49. Reason for revert: Findit identified the culprit r565609 with confidence 70.0%. See https://bugs.chromium.org/p/chromium/issues/detail?id=851232 Original change's description: > predictor: Switch to WebContentsObserver to observe resource loads. > > This CL is needed to make the preconnect predictor work with the Network > Service. The CL removes the LoadingPredictorObserver class that has been > notified by the ChromeResourceDispatcherHostDelegate and introduces instead the > LoadingPredictorTabHelper which implements the WebContentsObserver to notify > the predictor about resource loads. > > All uses of the net::URLRequest and predictors::URLRequestSummary was replaced > by using the predictors::NavigationID or the content::mojom::ResourceLoadInfo. > > The WebContentsObserver::ResourceLoadComplete() should work with and > without the Network Service, so we don't have to keep the old path. > > Bug: 809583 > Change-Id: I05c0aa97cfab1d773285633e6c5c3ef6a91367ca > Reviewed-on: https://chromium-review.googlesource.com/1039526 > Commit-Queue: Alexandr Ilin <alexilin@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565609} TBR=msw@chromium.org,thestig@chromium.org,mmenke@chromium.org,lizeb@chromium.org,alexilin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 809583 Change-Id: If1bf3e4b6e98fbd716b9b994b0ee0c69cafc7036 Reviewed-on: https://chromium-review.googlesource.com/1094955Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#565945}
-
Hayato Ito authored
NOTRY=true TBR=alph@chromium.org BUG=848398 Change-Id: Ib35a8b041f31aa55597f9711d72f9368cd213010 Reviewed-on: https://chromium-review.googlesource.com/1095055Reviewed-by:
-
Ramin Halavati authored
Extension Function dispatcher is updated to allow access to incogntio information, if incognito mode is enabled and extension can cross incognito mode (is running in spanning mode). Bug: 845845 Change-Id: I922ae4e5a8b6c08797ae71be464d2d6aa01b6aff Reviewed-on: https://chromium-review.googlesource.com/1088609Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#565943}
-
vitaliii authored
If kSyncUserConsentSeparateType feature is enabled (as well as emitting consents in general), then emit user consents through a separate datatype instead of user events. This CL is a part of a series to split user consents from user events into a separate datatype. Bug: 840357 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2a8c4423ba71cb8d31740fb9395f431149414610 Reviewed-on: https://chromium-review.googlesource.com/1084835Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#565942}
-
Ramin Halavati authored
Download function of Extensions Downloads API used incognito downnload manager, if available, even if the request was from regular profile. This is changed to using the download manager of current profile. Bug: 845845 Change-Id: I751a06850f0c9d6ac288ec9ff83bc592012fc3f5 Reviewed-on: https://chromium-review.googlesource.com/1087963 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ben Hayden <benjhayden@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#565941}
-
Hiroshige Hayashizaki authored
Bug: 811315 Change-Id: Id6b17e608e493d4ae1d5353cbb79e95de170751d Reviewed-on: https://chromium-review.googlesource.com/1091697 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Ramin Halavati authored
remoting/client and remoting/host are added to the list of required build targets for network traffic annotation FYI tests. Bug: 844014 Change-Id: Ief45946affe3343866e047498e0fe71a31677e11 TBR: dpranke@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1094874Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#565939}
-
Simon Zünd authored
Due to recent changes in the behavior of Array.p.sort, it seems that some devtools layout tests became flaky. Making the timestamp sorting stable seems (emperically) to fix or at least improve the flakiness. Change-Id: Ife60b893d0bcb230301dce01f504b46eff9d43cf Reviewed-on: https://chromium-review.googlesource.com/1092470Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#565938}
-
oscarjohansson authored
In Jumbo builds the namespace declarations such as "keys", "helpers" and others conflict. The are named the same in multiple files since they have the same purpose, but with Jumbo this is no longer appropriate. The declarations that conflict are removed. Bug: 850484 Change-Id: I62246ebe303f1cdcabb2c21312eef4c6d4a7d92a Reviewed-on: https://chromium-review.googlesource.com/1090916Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#565937}
-
Yoichi Osato authored
The test confirms right click on element should create a selection. That was introduced 11 years ago: https://chromium.googlesource.com/chromium/src/+/563113d2b16713e83a7507637a28973c8cf7db82 However, the feature was removed at some point and no platform expects that. Currently the test only confirms right click on element doesn't create selection unlike its description and right click behavior is tested at another tests well, e.g. LayoutTests/editing/selection/context-menu-text-selection.html Then this patch removes the test. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 708452 Change-Id: I2886aeb05728df9f84bb10ee87e062362f1fd0ce Reviewed-on: https://chromium-review.googlesource.com/1092552Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#565936}
-
Yuta Kitamura authored
The function is only used in a test, and no production code does not rely on it. So it can be removed entirely. This simplifies the implementation of each subclass of WebThreadBase. Bug: 826203 Change-Id: I746a61b324d63fd189b8b8b6cbe496760dedad0e Reviewed-on: https://chromium-review.googlesource.com/1092221Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#565935}
-
Chong Zhang authored
Disable due to consistent failings on Mojo Linux Perf. First Failing Build: https://ci.chromium.org/buildbot/chromium.perf.fyi/Mojo%20Linux%20Perf/6286 Bug: 851171 Change-Id: I467bc517561c98dd04d1cdf0b8f7f2b356308cb2 Reviewed-on: https://chromium-review.googlesource.com/1093979Reviewed-by:
-
Kent Tamura authored
The feature was reached to the stable channel, and we have had no significant bug reports. Change-Id: I19292f6f807cd380854a0c82b09cca9b6254b33f Reviewed-on: https://chromium-review.googlesource.com/1092406Reviewed-by:
-
Jeremy Roman authored
Use base/sys_byteorder.h instead. Change-Id: I4c7a12b43e7546dcaa9e1ce4c6a49f7cfa01fd03 Reviewed-on: https://chromium-review.googlesource.com/1093259 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#565932}
-
Hayato Ito authored
This reverts commit 23069352. Reason for revert: Consistent failures on Win7 Tests (1) [18 out of the last 18 builds have failed]. external/wpt/html/dom/documents/resource-metadata-management/document-lastModified-01.html https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=external%2Fwpt%2Fhtml%2Fdom%2Fdocuments%2Fresource-metadata-management%2Fdocument-lastModified-01.html&testType=webkit_layout_tests e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/80749 Original change's description: > Roll ICU to 172d33141 > > This roll has just one change to fix the timezone > detection on Japanese/Korean and other non-English > Windows. > > https://chromium-review.googlesource.com/1094322 > > TBR=gsathya@chromium.org > > Bug: 849724 > Test: Set the timezone to Tokyo on Japanese Windows > Test: In JS console, 'new Date()' outputs 'Japan Standard Time' in parens. > Change-Id: I0bddf33e1490b2b795504002d975252347e9d568 > Reviewed-on: https://chromium-review.googlesource.com/1094327 > Reviewed-by: Jungshik Shin <jshin@chromium.org> > Commit-Queue: Jungshik Shin <jshin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565906} TBR=jshin@chromium.org,gsathya@chromium.org Change-Id: I4b9e37bbe93fea628e2d2a94eabd3d983d9b551d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 849724 Reviewed-on: https://chromium-review.googlesource.com/1094856Reviewed-by:
-
Koji Ishii authored
This patch adds a minimum support of background properties in ::first-line pseudo elements. This patch uses the option 3 of the [design doc]. During the tree building, an anonymous inline box is inserted to wrap the whole inline formatting context if ::first-line has background properties set. The anonymous inline box should have the first-line style with the background inherited from the ::first-line styles, but for FirstLineStyle() of the box to return the synthesized style did not go straightforward. Instead, because the current paint system supports different styles to represent background properties and geometries, NGPhysicalBoxFragment::StyleForBackground() returns a seprate style for the background properties. The support in paint code is still minimum. It probably does not work for other than background color, and may not work when padding/borders are set. But as the initial implementation, we can support other scenarios on top of this. [design doc]: https://docs.google.com/document/d/1KWktACD_ar1ZmNViKPU1i6hTuEyX3rcfSQi_rztlkTM/edit?usp=sharing Bug: 636993 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I683803e4163d9d373772183d68c77ab2104c8b11 Reviewed-on: https://chromium-review.googlesource.com/999080Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#565930}
-
Istiaque Ahmed authored
Extension event dispatch code currently assumes that there will always be an active service worker that it can "Start" and then dispatch events. This isn't true if the extension's service worker is still installing. Consider registration's installing_version() as well to avoid the race. This CL renames ServiceWorkerContext's StartActiveWorkerForPattern to StartWorkerForPattern and changes its behavior to also consider ServiceWorkerRegistration::installing_version(). If there isn't any waiting or active worker in the registration, the change would attempt to start/run the installing worker. This change should improve test failures that see ServiceWorkerTaskQueue::DidStartActiveWorkerFail in this scenario. Subsequent CLs will also exercise early event dispatch to make this CL a necessary fix. Bug: 850792 Change-Id: If73c36f0f13a3a6a19ae510d4d06b1f602185175 Reviewed-on: https://chromium-review.googlesource.com/1088306Reviewed-by:
-
Tatsuhisa Yamaguchi authored
This change only affects the system update notification that is generated when UnifiedSystemTray feature is enabled. Tapping the main part of the notification links to the about://chrome in the Settings app. There is also notification button to "restart to update" directly from the notification when applicable. Bug: 845809 TEST: manual (--enable-features=SystemTrayUnified) Change-Id: Ic04971ee2796d46f4a6b448e419d4cdb908d0c01 Reviewed-on: https://chromium-review.googlesource.com/1073352Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565928}
-
Michael Lippautz authored
Bug: chromium:840789 Change-Id: I303ab87bf929f0b9384b20333aea00abeef21fda Reviewed-on: https://chromium-review.googlesource.com/1094757Reviewed-by:
-
Dominic Farolino authored
This CL cleans up some unused code that would otherwise be used if we were exposing `importance` as a readonly attribute on the Request interface, but we are not right now. This also replaces a RuntimeEnabledFeatures check for Priority Hints with a DCHECK since we already check the flag earlier than the location this CL touches. R=kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org, yoav@yoav.ws Bug: 821464 Change-Id: Ic1d2fe3ddabf4eeec46b5298cc4a914001cd2d32 Reviewed-on: https://chromium-review.googlesource.com/1092243Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Chris Harrelson authored
* Compute all triggers except kComboSquashableReasons, kComboCompositedDescendants and kComboAllCompositedScrollingDeterminedReasons in either style update or CompositingInputsUpdater. * Determine composited scrolling (but not the compositing trigger bit) in CompositingInputsUpdater. * Cache these results on PaintLayer. This achieves the following goals: - Separates composited scrolling and awkward LCD text decisions from the CompositingRequirementsUpdater step. - Caches more triggers, leading to faster compositing updates in some cases - Unblocks CL 1072155 Summary of implementation approach: 1. Dirty compositing inputs for all triggers computed there. 2. Compute, and cache on PaintLayer, kComboAllDirectNonStyleDeterminedReasons during CompositingInputsUpdater. 3. Compute and cache a new DescendantHasDirectCompositingReason dirty bit on PaintLayer. 4. Update composited scrolling in PaintLayerScrollableArea during CompositingInputsUpdater. This includes the root layer, which uses DescendantHasDirectCompositingReason as one of its triggers. Bug:814439,782991 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I21095762cbf806008395c2cf79f4ee038c39cb5f Reviewed-on: https://chromium-review.googlesource.com/1087791 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#565925}
-
Yoichi Osato authored
This patch fixes: fast/text/selection/selection-with-inline-padding.html paint/invalidation/selection/selection-rl.html This patch rebases image failures that NG paints 1px taller than old. This is by-product but got lgtm at the previous patch: crrev.com/c/1080442 ([LayoutNG] Fill selection paint line gap.) Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 708452 Change-Id: Iba5a07531f2cabf70707e6a9dfaed51fdc653e53 Reviewed-on: https://chromium-review.googlesource.com/1092567Reviewed-by:
-
jchen10 authored
--webgl-antialiasing-mode is used to specify AA method: "none" -- no AA. "explicit" -- MSAA with explicit resolve. "implicit" -- MSAA with implicit resolve. "screenspace" -- screen space AA(CMAA). --webgl-msaa-sample-count is used to specify the default sample count if MSAA is currently enabled. Bug: 849941 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia20ca291c120124f4801b08e01624c6fc28af078 Reviewed-on: https://chromium-review.googlesource.com/1075167 Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565923}
-
Hirokazu Honda authored
This reverts commit 37a2e00b. Reason for revert: This CL breaks ARC++ video playback. Original change's description: > simplify VaapiPictureFactory::Create() method and VaapiPicture members > > This CL moves part of the logic of VaapiPicture creation from VaVDA to > VaapiPictureFactory, passing the PictureBuffer wholesale since we use > most of it anyway. The net result is less lines of code. > > VaapiPicture and derived classes hold on to a |texture_id_| and a > |client_texture_id_|, the latter only used with |bind_image_cb_|: > - |texture_id_| cannot be zero, either in the tests or in reality, because > is a GL texture id; this CL enforces this via a DCHECK() in ctor. That > simplifies the body a few methods. > - |client_texture_id_| can be zero, and is always zero in the v_d_a_unittests, > but it doesn't matter because |bind_image_cb_| is dummy for tests ([1]), > so there's no point of enforcing it to be non zero. Moreover, since > it's a client-side texture id, it can be any number, so let's skip > the confusing checks. > > Sprinkled a couple of consts and also, there's no need to do > !callback.is_null() because CallbackBase provides bool(), so > s/!callback.is_null()/callback/ > > [1] https://cs.chromium.org/chromium/src/media/gpu/video_decode_accelerator_unittest.cc?sq=package:chromium&dr&g=0&l=452 > > Bug: 822346 > Test: compiled+run simplechrome, v_d_a_unittests on eve. media_unittests. > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I5610ea4abf87df26a85e909aebfbbaa6bb964163 > Reviewed-on: https://chromium-review.googlesource.com/1079834 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564178} TBR=mcasas@chromium.org,dcastagna@chromium.org,hoegsberg@chromium.org,andrescj@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 822346, b:109906289 Change-Id: I58b4968468d99c3f0e4e6b56c1ecd89645550f73 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1094814 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#565922}
-
Hirokazu Honda authored
This reverts commit 6873824c. Reason for revert: crrev.com/c/1079834 breaks ARC++ video playback. This CL has dependency of the CL. Original change's description: > VaapiPicture*: add missing DCHECK()s > > This CL adds 3 missing DCHECK()s that I forgot after [1] > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/1079834/13/media/gpu/vaapi/vaapi_picture_factory.cc#50 > > TBR=dcastagna@chromium.org > > Bug: 717265 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Ibfc9797bda93dd7660cc64317ab21794dbda6e10 > Reviewed-on: https://chromium-review.googlesource.com/1086131 > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564289} TBR=mcasas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 717265, b:109906289 Change-Id: Ibc20bee25cdfa127d0b646bc1a03a7e53a6129e4 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1094794 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Scott Violet authored
The actual rename. BUG=none TEST=none TBR=jamescook@chromium.org Change-Id: I66d90858482beb8f7f19aab710d313caaa5cce67 Reviewed-on: https://chromium-review.googlesource.com/1094206Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#565920}
-
Matt Falkenhagen authored
Skip ServiceWorkerNavigationPreloadTest.CanceledByInterceptor. This test is about ResourceDispatcherHost interceptors and doesn't apply to the NetworkService world. Bug: 715640 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I6a33bff304c2add06a06f80882ba7fe695b946b7 Reviewed-on: https://chromium-review.googlesource.com/1092613Reviewed-by:
-
Hajime Hoshi authored
Change-Id: I56b5b7fde0ba9ec7a20e5598fce3a040aa713f9b Reviewed-on: https://chromium-review.googlesource.com/1092556Reviewed-by:
-
Tetsui Ohkubo authored
This CL modifies style of detailed view header by following UnifiedSystemTray UI spec. UnifiedSystemTray shares code of detailed view with old SystemTray, so this CL took the following steps to make the change: * Move corresponding methods to DetailedViewDelegate * Move old SystemTray styling code to SystemTrayItemDetailedViewDelegate * Implement UnifiedSystemTray styling code in UnifiedDetailedViewDelegate Screenshot: http://screen/xT96aUrp5O9 TEST=manual BUG=850396 Change-Id: I00f8dbccf3dec3ef918d3aa2cd9aacdbb77676bb Reviewed-on: https://chromium-review.googlesource.com/1092401 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#565917}
-
