- 12 Oct, 2020 40 commits
-
-
Mohamed Amir Yosef authored
Before this CL, each part of the badged icon was a views, however, this wasn't necessary since they were never placed using layout manager and users were never supposed to interact with them. This CL should introduce only minor visual difference. It however uses ImageSkiaOperations which: 1- Eliminates the need for 2 custom views. 2- Allows to use a more standard way for creating badged images by using gfx::ImageSkiaOperations::CreateIconWithBadge(). Bug: 1100814 Change-Id: Iaf84b61c4bae1d7130ae58513c9b287ba8eb55d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466276 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#816204}
-
Eric Willigers authored
Remove #include from source files that do not use ScopedFeatureList. Bug: 1137231 Change-Id: I2513187d4585930e0ac2a82a45cd15f0ffe2645a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463021 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816203}
-
Moe Ahmadi authored
Fixed: 1136654 Change-Id: I55f7cb4ca34332a33d81421a9a21475279e6fa08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463335Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816202}
-
Victor Hugo Vianna Silva authored
Following crrev.com/c/2465744, the last usage of this class (in DataTypeController::GetStatusCounters() and similar methods) is unused in production code, so this CL removes the class. As for the methods, some are removed, while others are converted into *ForTest methods that don't make use of the class, in case they are still used in test expectations and there's no other good way of verifying those. The CL also removes the unimplemented method DataTypeDebugInfoEmitter::EmitStatusCountersUpdate(), so that there's no reference to the concept of StatusCounters in the sync codebase anymore. Bug: 1102849 Change-Id: I47dc92b6ce6f1631cc3762834770c54e3d47ea12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463611 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#816201}
-
Antonio Gomes authored
This is step 1.2 on the design document [1]. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/edit BUG=1113900 R=jamescook@chromium.org, sky@chromium.org Change-Id: Ic625b887b00538d758260a3f35426c346bcdbabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458768 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#816200}
-
Kurt Catti-Schmidt (SCHMIDT) authored
This is a speculative fix, as I haven't been able to reproduce this overflow. There also is not a unit test, because I haven't been able to reproduce this overflow by tweaking the unit test from https://chromium-review.googlesource.com/c/chromium/src/+/2426490 However, this is still causing crashes, even after the CL 2426490 has gone in. And all of the overflows that I've seen after that CL loop forever in the kMoveRight scenario, so I am confident that this change will provide the complete mitigation. Bug: 1124394 Change-Id: Ife9293f2fa26a34c17d1aace03b38b3592f387d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464003Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#816199}
-
Rushan Suleymanov authored
This is the first patch in chain which starts removing one of mocking classes: RecordingModelTypeChangeProcessor. This class will be replaced by MockModelTypeChangeProcessor. This CL introduces the mock_processor in typed url sync bridge tests and changes first two tests to use only mock_processor. Bug: 791939 Change-Id: I162e56587e9f2765b8d2ebcc8f021a140d99ae9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466099 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
Avi Drissman authored
Users might not like the URL display on the touchbar in fullscreen. This CL makes the fullscreen touchbar customizable. Right now, that means that the user can add or remove the single item in it (the URL display) but that should help for the case in the bug. Fixed: 1135102 Change-Id: I99e3ca0d4d9d6575a0ec79ab3329e54613475e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464080 Commit-Queue: Leonard Grey <lgrey@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#816197}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fb0f797b07aa..d185008d04b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC gab@google.com,amraboelkher@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: gab@google.com,amraboelkher@google.com Change-Id: Ibcd0140d4bda02e4478ff5d552c21f8c0abf355e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465770Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816196}
-
Alexander Dunaev authored
Historically, there were a few discrepancies in behaviour of file drag and drop on different platforms. With introduction of Ozone and implementation of X11 platform it became so complicated that a few tests had been disabled. The core difference between Linux and non-Linux was in how string and URI contents are handled together. Various Linux file managers pass both string and URI together, for which there was a workaround in the X11 implementation but not in Wayland one. Another difference was that drags started in the renderer did not take files (due to security reasons) but the non-backed data provider used in ChromeOS and Wayland didn't recognise this scenario. This CL unifies the behaviour on Linux platforms and makes the non-backed data provider aware of drags originated from renderer, and enables the tests that validate this behaviour. Bug: 1121928, 1070483 Change-Id: If64857c60df295b37f1f5d4abe11338912134f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461372Reviewed-by:
-
David Tseng authored
R=dmazzoni@chromium.org Test: run through all Tts Debug tests; manually using Eve/Hana; word callbacks; continuous read on large blocks; trigger lots of interruptions; start/end callback testing. Change-Id: I7ebc43620adbd5adc9de23ead8af12bde9f4bf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465564Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 87-4265.0-1601890590-benchmark-87.0.4280.15-r1 to 87-4265.0-1601890590-benchmark-87.0.4280.16-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8f3f3c00ae6b359a4edc2555b39e49221bfdb7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465649Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816193}
-
Paula Vidas authored
Since |committer_id| is a bit ambiguous, it's renamed to |committer_invalidator_client_id|. Change-Id: I3403b9eba366c51af328df16b859d53b5582759f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462265 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/07055b5e25a2..ceb6214a556a 2020-10-12 ethannicholas@google.com moved SkSL InlineMarker and UnresolvedFunction data into IRNode 2020-10-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 952149303d06 to e72c6099f946 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I01428e4b6fdb4e6978849d1031ebeb89714ab24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465772Reviewed-by:
-
Dan McArdle authored
This CL contains a tentative fix for a crash that was uncovered when we enabled the control domain wildcard [1] for the INTEGRITY experiment. Currently, all INTEGRITY responses get the error OK, regardless of their contents. This OK error can overpower the actual errors of A or AAAA responses in HostCache::Entry::MergeEntries. As a result, the TransportConnectJob assumes that the address results are nonempty, and unconditionally dereferences the front of the |AddressList::endpoints_| vector [2]. [1]: See net::features::kDnsHttpssvcControlDomainWildcard [2]: See net::TransportConnectJob::DoTransportConnect() Bug: 1136661 Change-Id: I5d7534c3244cddcf7029c38577d649870ed92bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463598 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#816190}
-
Alexander Surkov authored
Bug: 1133330 Change-Id: I3669a7aa774a2b58ccd05142b7f874e14c3ae451 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461235Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#816189}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/84bd221ed748..4fe1d403a22d 2020-10-12 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-10 yueherngl@google.com volteer: add firmware-volteer-13521.B branch builder 2020-10-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-09 saklein@chromium.org deploy: Refactor SplitCPV to parse. 2020-10-09 saklein@chromium.org portage_testables: Refactor SplitCPV to parse. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ic1f9dfa0cf653d9757b324b8b73335de7629aac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465206Reviewed-by:
Keigo Oka <oka@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816188}
-
David Tseng authored
This event gets fired by ARC++, so it's likely been a no-op in automation ever since the event generator changes, since ARC++ doesn't set any of the *scroll* int attributes. chrome/browser/chromeos/arc/accessibility/arc_accessibility_util.cc It does get fired by Blink as well at the moment third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc so this patch changes those event sites to generic events. Finally, re-introducing this event seems to have triggered Error: Error in event handler for scrollPositionChanged during phase 1: TypeError: Cannot read property 'start' of null at Output.range_ (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromevox/chromeVoxChromeBackgroundScript.js:1246:77) at Output.render_ (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromevox/chromeVoxChromeBackgroundScript.js:1183:83) at Output.withLocation (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromevox/chromeVoxChromeBackgroundScript.js:1148:107) at DesktopAutomationHandler.onScrollPositionChanged (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromevox/chromeVoxChromeBackgroundScript.js:2232:140) at DesktopAutomationHandler.<anonymous> (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromevox/chromeVoxChromeBackgroundScript.js:1824:1) which we can check for explicitly. What looks to be happening is the target of the scroll position changed is detached. R=dmazzoni@chromium.org, hirokisato@chromium.org Change-Id: If3008218d8e0565428bd18cf8642eb106d83fdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451974Reviewed-by: -
Polina Bondarenko authored
Add an auto-login to Managed Guest Session / public account to start ARC snapshot creation. Block auto-login flow even if specified by policy. Wait for ArcDataSnapshotdManager successfully generates a key pair and auto-login to MGS once it is ready. BUG=b:161221001 TEST=components_unittests TEST=browser_tests Change-Id: Ib7895f49f9295b3959226cde3e304c9c78614e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440872Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#816186}
-
David Maunder authored
Where appropriate and available we display the price of an offer on a shopping website in the card in the tab grid switcher. The backend is not ready yet but the integration is in place and unit tested. The feature is behind a flag and will be able to be turned on via the flag UI when the backend is ready. Bug: 1129203 Change-Id: I7c1cad74d769e2c3286f209dc20509e80ad045f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419632 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#816185}
-
Nektarios Paisios authored
This is a speculative fix which I wasn't able to test, but which will hopefully resolved the attached bug. Retrieving the document markers for an AXInlineTextBox requires access to the flattened representation of the DOM tree. To get this representation, all slots in related shadow DOM subtrees need to be filled in, A.K.A. Document::UpdateDistributionForFlatTreeTraversal() needs to be called. In fact, if accessibility doesn't call this method, it is automatically called by the DOM Position class when accessibility requests for a DOM Position to be converted to the equivalent position in flat tree. To prevent a potential infinite loop, we return early when slots in the shadow DOM are dirty. An infinite loop might occur because updating the distribution for the flat tree could in turn update the accessibility tree which could in turn call GetDocumentMarkers again. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1124683 Change-Id: I5f373459f2a4879df4b9754f64c465e7f2b6536d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464910 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#816184}
-
Maksim Moskvitin authored
Verifier profile is a bad way to specify tests expectations and its usages should be avoided. This CL replaces all usages in dictionary tests with actual checks of dictionary state. Side change: AddDifferentToEach test is removed, because it was a subset of Sanity test. Bug: 1033848 Change-Id: Icd6a3aa25bafd7bd375c0c7daa45cf3cb413fbef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465906 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Bailey Berro authored
This change introduces the SystemRoutineController class that connects to the cros_healthd DiagnosticsService. Subsequent CLs will declare and implement a SystemRoutineController mojo interface. Bug: 1128204 Change-Id: Ic510e1f90efedbbcba42827ca843323f04803e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457807Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#816182}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010120700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/tdIYOywbT-7Ua5VwVKvfLfPLbfSGfLAQ2PzHie1qBhsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/162270429 Tbr: media-app@grotations.appspotmail.com Change-Id: I15869f4d646a0e20003430bf68b9ff5280c83f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466156Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/109c355900d1..7c7b98f06001 2020-10-12 hjd@google.com perfetto_cmd: Fix statsd based triggers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3d46f1b7c18c2b04f7b873ee99a9f636d5ef7f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465935Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/66b5d4eb..896ca12d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9e76118eb412128a06abcb6968ccc488d6c3300c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461573Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816179}
-
James Cook authored
A subsequent CL needs this information early in startup to provide device enrollment status for UMA stability metrics. Bug: 1134341 Change-Id: I4537c1866b262b2c4f7560bf01712e7dd42ffc41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461049Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#816178}
-
Ian Kilpatrick authored
There should be no behaviour change. Bug: 1091797 Change-Id: I9de49338c43f71e85f9d227a8000c5edd4894f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465222Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#816177}
-
Hans Wennborg authored
Newer Clang versions will perform "scalar replacement of aggregates" optimization on the 'sentinels' array, breaking the test. Leak the address of the array with debug::Alias to prevent that. Bug: 1135294 Change-Id: I834b8406c0f91954207177294976250ac9c773f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462273Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#816176}
-
Claude van der Merwe authored
Wifi Sync depends on Chrome Sync. This CL disables the Wifi Sync feature toggle and updates the feature description with a prompt to enable Chrome Sync if it is disabled. The following changes are made: 1. Add translation strings for the Wifi Sync when Chrome Sync is disabled, along with translations for the accessibility labels. 2. Adds a new polymer component for the feature summary when Chrome sync is disabled. 3. Add a new polymer component to encapsulate the logic that checks whether the prerequisite Chrome Sync setting is enabled. 4. Added a 'localized-link' slot to multidevice for the feature summary so that the special case Wifi Sync string can be used. 5. Added browser tests for the new polymer components. The new localized-string component is similar to settings-localized-link, but it contains two links (settings-localized-link limits the number of links to one) that have accessibility labels assigned manually. Bug: 1117619 Change-Id: Iab5dbe553ad3433c4b4208d61d2aafd697143860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432675 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#816175}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ie8767ab952dda79a999b52881e42243c65a09423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464907Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#816174}
-
Paula Vidas authored
StopListeningPermanently() gets called during sign-out. The FCM token needs to be cleared so that the change can be propagated to device info. Empty token in device info signals that the device is not listening to invalidations. Change-Id: I6d0a4e2007af6d7457cafed265877ec9810cb4f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465844 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#816173}
-
Nohemi Fernandez authored
Moves the Sync errors item out of Google Services into the Sync settings page for the MICE experiment. Bug: 1125631 Change-Id: I4f373a14e967e76d55f7d0aa7b8ed02a53c495df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461266 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816172}
-
Egor Pasko authored
At least one bot (see crbug.com/1137405) started failing after crrev.com/814863 with a message: 'unrecognized arguments: --avd-config=...' Since a few related changes landed on top, I'm not comfortable reverting it. Rather making the check pass with this configuration. Tested locally by providing the same command line arguments as on the bot. Tbr: dpranke@google.com,agrieve@chromium.org,pkotwicz@chromium.org Bug: 1137405, 1115604 Change-Id: I28c9e3179fdbbc36ec515ed6aba8ce12f78a9417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464270Reviewed-by:Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#816171}
-
Marc Treib authored
TypeStartCallback was misnamed; it's not used as a callback. This CL renames it to MarkDataTypeAssociationDone which is closer to what it does/means. It also removes an unreachable branch within the method (replaced by DCHECKs). Bug: 647505 Change-Id: I43e041c20ff14a71260c85c4717d8c2e62ed0708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466098Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#816170}
-
David Jean authored
Bug: 1108395,1108433 Change-Id: Id936266c054b84e038e2a6dacfb12a7f646bceb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450075 Auto-Submit: David Jean <djean@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#816169}
-
Renato Silva authored
Generate an additional metric that combines data from all countries for the Chromebook marketing opt-in. Fixed: 1136816 Change-Id: I521824b2b5f7d5c06402dad5ccbe1719dd1c197d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463613 Commit-Queue: Renato Silva <rrsilva@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#816168}
-
Stepan Khapugin authored
Adds an identifier for EGTests to each window. This will allow matching specific windows in tests. Bug: none Change-Id: I9d04ee645ec1658181d5580a8f4c2060b6927940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463565 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2531de9926d1..07055b5e25a2 2020-10-12 mattleibow@live.com Parse out the orientation in the SubIFD of EXIF 2020-10-12 robertphillips@google.com Revert "[svg] Add svg_tool" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I7d7453b9173734ed59b3e37a0e02f021c9ed5722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465932Reviewed-by:
-
harrisonsean authored
Update the isUpToDate util function to use userdefaults update status instead of verifying off version and version discrepancy. Move userdefault update status recording to Omaha as regular update checks will never record an up to date status. Bug: 1078782 Change-Id: Ibe2692b573efb3180ef0f255530545d75ab3248b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462256 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#816165}
-
