- 07 Apr, 2017 40 commits
-
-
jamescook authored
It takes a couple seconds per file, so when you're renaming hundreds of files it can look broken. Format is: [1/234] Moving: my_file.cc BUG=none TEST=manual, run it after a git mv Review-Url: https://codereview.chromium.org/2807813002 Cr-Commit-Position: refs/heads/master@{#463035}
-
paulmiller authored
BUG=709208 Review-Url: https://codereview.chromium.org/2806023003 Cr-Commit-Position: refs/heads/master@{#463034}
-
asvitkine authored
Prior to this change, when we fetched the variations seed from Java could, it was not using the correct restrict param in the URL. This change plumbs it through. See bug for more details. BUG=708713 Review-Url: https://codereview.chromium.org/2804043002 Cr-Commit-Position: refs/heads/master@{#463033}
-
dgozman authored
We used to handle that through GlassPane, which has problems with multiple layers of SoftContextMenus. Now we have a single listener on bubble, and cancel all menus at that point. BUG=709350 Review-Url: https://codereview.chromium.org/2801373002 Cr-Commit-Position: refs/heads/master@{#463032}
-
hcarmona authored
BUG=620517 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2801753003 Cr-Commit-Position: refs/heads/master@{#463031}
-
msw authored
Remove CLC::id_to_item_controller_map_; rely on ShelfModel instead. Skip removing shelf items in CLC destruction; rely on ~ShelfModel instead. Remove CLC::[Get|Set]ShelfItemDelegate helpers; inline ShelfModel calls. Remove moot ShelfModelObserver::OnSetShelfItemDelegate. Rename CLC::LauncherItemClosed -> RemoveShelfItem. Rename test helper GetAppLaunchers -> GetPinnedAppIds. Inline ShelfModel::RemoveShelfItemDelegate helper function. Avoid GetItemIndexForType, use GetShelfIDForAppID instead. Use ItemTypeIsPinned helper function. BUG=557406 TEST=Automated; no Chrome OS shelf behavior changes. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2798173002 Cr-Commit-Position: refs/heads/master@{#463030}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ef8c92ef..7752f76e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2799413003 Cr-Commit-Position: refs/heads/master@{#463029}
-
ben authored
R=sky@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2795883002 Cr-Commit-Position: refs/heads/master@{#463028}
-
allada authored
This patch releases network blocking. R=dgozman,pfeldman BUG=709108 Review-Url: https://codereview.chromium.org/2804053002 Cr-Commit-Position: refs/heads/master@{#463027}
-
Quinten Yearsley authored
Using wpt-import in Chromium 1c9b66ff. Not including changes in content-security-policy and service-workers, to avoid squashing any non-exported changes. TBR=tkent@chromium.org NOEXPORT=true Change-Id: Iebb22ed36397fa5b2b6f3be058a3da244ae1a5e8 Reviewed-on: https://chromium-review.googlesource.com/471167Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#463026}
-
chcunningham authored
This CL does a number of things to cleanup MediaClient's implementation and usage. This clears the way for an expanded role in describing MediaCapabilities. Remove CastMediaClient. Merge methods into CastContentRenderClient. ContentRenderClient is now the one-stop-shop for embedder customization. I initially explored giving each embedder its own MediaClient, but this ended up splitting media customization between ContentRenderClient and MediaClient (some customization is too high level to move to MediaClient). The current route is also less code. Remove all Chrome specific logic from RenderMediaClient. RenderMediaClient is now the plumbing for *all* content embedder customizations to be visible in media/. Chrome is just one of many embedders and much of the chrome specific code was stale anyway. Remove KeySystemNameForUMA from MediaClient interface Decentralizing this logic was overly complicated. Now centralized to key_systems.cc. Other little cleanups Centralize all media/ Rappor usage in MediaLog. Move cast key_systems_cast into chromecast/renderer/media. Simplify key_systems_unittest.cc BUG=695264 Review-Url: https://codereview.chromium.org/2712983004 Cr-Commit-Position: refs/heads/master@{#463025}
-
sky authored
Code is changed to use aura directly. BUG=687656 TEST=covered by tests R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2799993003 Cr-Commit-Position: refs/heads/master@{#463024}
-
zhongyi authored
for each QuicStreamFactory::Job created. BUG=702411 Review-Url: https://codereview.chromium.org/2800023002 Cr-Commit-Position: refs/heads/master@{#463023}
-
trchen authored
This CL extends PictureLayerTiling to support tiles rasterized with scale and translation. Tilings still use only the scale factor as their key. It is an error to have tilings with the same scale but a different translation in the same PictureLayerTilingSet. This CL implements a policy to evict old tiling when syncing from a tiling set with a slot conflict. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2566613002 Cr-Commit-Position: refs/heads/master@{#463022}
-
Alexei Svitkine authored
This reverts commit dbce02f6. Reason for revert: Breaking cq presubmit step Original issue's description: > Update third_party/checkstyle to 7.6.1 > > This CL updates third_party/checkstyle to 7.6.1 so checkstyle would > work with Java 8 lambda features. > > BUG=703238 > > Review-Url: https://codereview.chromium.org/2799303003 > Cr-Commit-Position: refs/heads/master@{#462968} > Committed: https://chromium.googlesource.com/chromium/src/+/dbce02f63421f7d446d6ef317b456f6ae911f63b TBR=agrieve@chromium.org,nyquist@chromium.org,jbudorick@chromium.org,klobag@chromium.org,jbudorick@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=703238 Review-Url: https://codereview.chromium.org/2807753003 . Cr-Commit-Position: refs/heads/master@{#463021}
-
minch authored
Move UpdateCheckMark() from anonymous namespace of tray_accessibility.cc to tray_popup_utils.h Then, it can be reused by AudioDetailedView and CommonPaletteTool. BUG=707851 Review-Url: https://codereview.chromium.org/2803893002 Cr-Commit-Position: refs/heads/master@{#463020}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/4e3abc1ad5f0..149e42ed194e $ git log 4e3abc1ad..149e42ed1 --date=short --no-merges --format='%ad %ae %s' 2017-04-07 mtklein make SkAutoTMalloc self-move safe 2017-04-07 halcanary SkTypeface:: populate_glyph_to_unicode uniformly across platforms 2017-04-07 mtklein jumper, byte_tables + byte_tables_rgb Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I145bc055173785a462a0141cccfd079b0d74d83a Reviewed-on: https://chromium-review.googlesource.com/471926Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#463019}
-
mattm authored
BUG=none Review-Url: https://codereview.chromium.org/2804463002 Cr-Commit-Position: refs/heads/master@{#463018}
-
Nghia Nguyen authored
This is the 2nd CL in our 3-sided patches to rename 'ignore_swarming_task_failure' to 'ignore_task_failure' BUG=709324 Change-Id: I52efa1bbfd57585e5e28abc6876acbf6ca88af41 Reviewed-on: https://chromium-review.googlesource.com/471046Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#463017}
-
juliatuttle authored
Reporting is a spec for delivering out-of-band reports from various other parts of the browser. See http://wicg.github.io/reporting/ for the spec, or https://goo.gl/pygX5I for details of the planned implementation in Chromium. The browsing data remover removes reports and/or endpoints that match an (optional) origin filter, or all reports and/or endpoints. It will be called from Chromium's browsing_data_remover, potentially among other places. BUG=704259 Review-Url: https://codereview.chromium.org/2752523005 Cr-Commit-Position: refs/heads/master@{#463016}
-
emircan authored
This CL does a refactor taking each encoder implementation into its own file. Additionally, CanEncodeAlphaChannelForTesting() is removed as it is no longer necessary. BUG=700433 Review-Url: https://codereview.chromium.org/2793303003 Cr-Commit-Position: refs/heads/master@{#463015}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/6a5c20cd0874..1835a6fb9828 $ git log 6a5c20cd0..1835a6fb9 --date=short --no-merges --format='%ad %ae %s' 2017-04-07 tsepez Tweak CFDF_Font::AppendChar() Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2804363002 Cr-Commit-Position: refs/heads/master@{#463014}
-
adithyas authored
The function doesn't appear to be used anywhere, and adds an unnecessary dependency to ExecutionContext in ScriptState. BUG=682322 Review-Url: https://codereview.chromium.org/2800173002 Cr-Commit-Position: refs/heads/master@{#463013}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=finnur@chromium.org Review-Url: https://codereview.chromium.org/2672623006 Cr-Original-Commit-Position: refs/heads/master@{#451473} Committed: https://chromium.googlesource.com/chromium/src/+/8a07a9568d954e17452e678852692838a613f3c1 Review-Url: https://codereview.chromium.org/2672623006 Cr-Commit-Position: refs/heads/master@{#463012}
-
spqchan authored
BUG=696557 Review-Url: https://codereview.chromium.org/2796303007 Cr-Commit-Position: refs/heads/master@{#463011}
-
tsunghung authored
Before we have the chance to fully implement the function, we need a quick fix for (E)AC3. No ATV we know of that supports (E)AC3 decoder, so it relies on the audio sink device. BUG=Internal b/36896359 Review-Url: https://codereview.chromium.org/2798263006 Cr-Commit-Position: refs/heads/master@{#463010}
-
servolk authored
1. Rename max_cll and max_fall to max_content_light_level and max_frame_average_light level. 2. Use gfx::PointF instead of a pair of floats for specifying primaries and white point chromaticity. Review-Url: https://codereview.chromium.org/2803563007 Cr-Commit-Position: refs/heads/master@{#463009}
-
jbauman authored
The --enable-direct-composition-layers flag will force chrome to use DirectComposition layers for hardware-decoded video (assuming DirectComposition is actually supported on the system). BUG=704389 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2805173002 Cr-Commit-Position: refs/heads/master@{#463008}
-
Jeff Carpenter authored
This step is in preparation for running the WPT linter as part of Chromium PRESUBMIT. Lint errors make up the majority of cases when and upstream WPT PR fails Travis CI, so running the same lint check in PRESUBMIT will help curb a large number of stuck PRs. Bug: 686927 Change-Id: Ic54d73368db2bcc0a5ea09411c674681bbaa6972 Reviewed-on: https://chromium-review.googlesource.com/471787 Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#463007}
-
avallee authored
When advancing focus into an iframe, allow the frame to focus itself after deciding which element will be focused. This prevents sending a focus event to the previous element in that frame only to blur it immediately. Non-oopifs simply fire a focus event to the new element, the previously focused element in that frame received a blur event when another frame was focused. The test ensures a consistent state when mixing tab and clicking navigation. In specific cases, focus would early out when the element to advance to was previously focused, and never cleared when the mouse is clicked in another frame. BUG=702330 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2796533002 Cr-Commit-Position: refs/heads/master@{#463006}
-
hbos authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/05fb319..4b544de $ git log 05fb319..4b544de --date=short --no-merges --format=%ad %ae %s 2017-04-07 alessiob@webrtc.org MultiEndCall::CheckTiming() verifies that a set of audio tracks and timing information is valid to simulate conversational speech. Unordered turns are rejected. Self cross-talk and cross-talk with 3 or more speakers are not permitted since it would require mixing at the simulation step. 2017-04-07 zhihuang@webrtc.org Added the GetSources() to the RtpReceiverInterface and implemented it for the AudioRtpReceiver. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2804353002 Cr-Commit-Position: refs/heads/master@{#463005}
-
thestig authored
BUG=537099 Review-Url: https://codereview.chromium.org/2800153002 Cr-Commit-Position: refs/heads/master@{#463004}
-
mike authored
The Web Platform Tests project includes equivalent versions of these tests. - `extendable-event-async-waituntil.html` - the version in WPT has been extended with additional assertions, rendering the Chromium version obsolete. - `extendable-event-waituntil.html` - the version in WPT has been extended to support (but not require) more rigorous compliance with the specification. Update that test to be more precise and document the expected failure in the Chromium infrastructure. BUG=688116, 709591 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2789003002 Cr-Commit-Position: refs/heads/master@{#463003}
-
dpranke authored
This CL updates the OWNERS information for //third_party/WebKit/Tools and //blink/tools to be current (including adding TEAM and COMPONENT info), and also adds a preparatory OWNER stub for //blink and tweaks a few lines in //third_party/WebKit. This CL removes jochen@, peter@, and tony@ as owners, as they haven't committed anything to the tools code in some time, and adds the current contributors. I should probably remove myself as an owner as well, but I'll let that go for a few more months. This CL also removes the wildcard "*" owner from Tools/Scripts, as there's no needd for that to be a wildcard these days, and the blink infra folks should review all changes. R=qyearsley@chromium.org, jeffcarp@chromium.org, tansell@chromium.org, wangxianzhu@chromium.org, tkent@chromium.org, jochen@chromium.org, peter@chromium.org Review-Url: https://codereview.chromium.org/2800863004 Cr-Commit-Position: refs/heads/master@{#463002}
-
chengx authored
BUG=103737 Review-Url: https://codereview.chromium.org/2803563008 Cr-Commit-Position: refs/heads/master@{#463001}
-
gangwu authored
After sync, the test did not install pending apps on the synced client. BUG=689662 Review-Url: https://codereview.chromium.org/2799783007 Cr-Commit-Position: refs/heads/master@{#463000}
-
mcasas authored
cp third_party/WebKit/Source/modules/shapedetection/OWNERS services/shape_detection/ BUG=659138 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2801893006 Cr-Commit-Position: refs/heads/master@{#462999}
-
lukasza authored
Revert of [reland] Do not block in SimpleThread::Start(). (patchset #1 id:1 of https://codereview.chromium.org/2801073005/ ) Reason for revert: Speculatively reverting hoping to resolve lots of random failures on 2 bots, starting with the builds below: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/24574 https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/40019 Original issue's description: > [reland] Do not block in SimpleThread::Start(). > > This CL is identical to https://codereview.chromium.org/2664953004. > The race condition that it highlighted in a TaskScheduler test the > first time that it landed was fixed by > https://codereview.chromium.org/2798373002/ > > There is no good reason to block in SimpleThread::Start(). > In addition to introducing unnecessary latency, blocking in > Start() prevents a non-joinable DelegateSimpleThread from > being deleted from Run() without external synchronization > (it is wrong to delete SimpleThread while Start() is waiting > on the |event_| member). > > BUG= > TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2801073005 > Cr-Commit-Position: refs/heads/master@{#462912} > Committed: https://chromium.googlesource.com/chromium/src/+/d5acadb2d99dfbbde0cbe251173b566ceb5d3441 TBR=gab@chromium.org,jam@chromium.org,henrika@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2804393002 Cr-Commit-Position: refs/heads/master@{#462998}
-
jonross authored
ActiveProfilePrefService attempts to bind connections to the active profile. However Incognito profiles do not register with the preference service. This was leading to ServiceManagerConnectionImpl rejecting the connection, as there was no registered service. This change switches to using the original profile for the connection. Incognito profile is backed by a base ProfileImpl. All ProfileImpl properly register as a service. This change also reenables the ash::shell connection to the pref service. This change also reverts https://codereview.chromium.org/2795413002 which was landed to deal with possible race condition of request handlers. However this was not the root cause. TESTING=device actually boots now, ash::shell receives its connection to prefs. User can login. BUG=707321 Review-Url: https://codereview.chromium.org/2802093005 Cr-Commit-Position: refs/heads/master@{#462997}
-
Tommy Nyquist authored
The Android MockDownloadController was added in: https://codereview.chromium.org/1217223006 However, it seems to have been incorrectly added to our prod target instead of something only for tests. This is unnecessary since it is never used in prod. This CL moves it to //chrome/browser:test_support, which is already depsed in for the target that the single unit test that uses it (DownloadResourceThrottleTest) is part of. BUG=None Change-Id: I70e7c06e603d38f858aadcffb47ac9bbd256e656 Reviewed-on: https://chromium-review.googlesource.com/471927Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#462996}
-