GitLab

The test causes problems for mojo-ified SessionStorage. Remove the test
to unblock the effort. The purpose of the test is to exercise a scenario
that includes webcontents swap-in, which does not happen in the field
any more (unless forced by a user with about:flags - this ability is
going away soon).

Bug: 755921
Change-Id: I489be7ece2b7d163448126e6b95a00b5a11126d5
Reviewed-on: https://chromium-review.googlesource.com/1073286
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561907}

State is stored when starting certain ThreadableLoaderClients, to be
used when the DocumentThreadableLoader is constructed. In any case
where a DocumentThreadableLoader begins a fetch, WillSendRequest() will
be called, so perfrom this work in WillSendRequest() and reduce the
number of calls to InspectorNetworkAgent

Change-Id: Ia8a5e130df73b0022755ddcde9bcbb754ceaca3c
Reviewed-on: https://chromium-review.googlesource.com/1070617Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561906}

Bug: 792546
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib2ed466f5b99ac4c6000eb2c4012e7feef186a31
Reviewed-on: https://chromium-review.googlesource.com/1033535
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561905}

There are 3 changes make in absolute-position-behind-scrollbar:

1. update tests to use testharness.js
2. call rAFs before start input
3. use promise_test and gpuBenchmarking events

This should fix the (absolute/fixed)-position-behind-scrollbar.html
flaky on virtual/threaded test suites.

Bug: 841567, 846424
Change-Id: I3744198054fdf7351ffc769ebfafea11044baf4c
Reviewed-on: https://chromium-review.googlesource.com/1072270
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561904}

There is no particular reason for this code to be part of the delegate.
This allows the code to run in Mash and Mus modes.

Bug: 665064
Change-Id: I0c9a7b1872f82b3487aa51412294b5baeea33b9b
Reviewed-on: https://chromium-review.googlesource.com/1071873
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561903}

It is failing, for unclear reasons. Disable to unblock the
CQ until someone can make it work again.

TBR=sandersd@chromium.org
NOTRY=true

Bug: 846729
Change-Id: I5bb455036799fbce53ae302ff5c3761d2da2a27e
Reviewed-on: https://chromium-review.googlesource.com/1072451Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561902}

Adds more tracing calls in ChromeActivity and other related startup code. Also
fixes two presubmit warnings.

Change-Id: Ida5d6ac0024dfa42a7e9c4aa3179bd7b55c4363f
Reviewed-on: https://chromium-review.googlesource.com/1072409
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561901}

This class handles connection failures specific to BLE listener.
Because listener roles wait until a connection occurs, this class only
encounters a fatal error when the remote device is invalid.

Bug: 824568, 752273
Change-Id: I2bc162549572aab1b9e9b5e1bfb16cb5e54e8073
Reviewed-on: https://chromium-review.googlesource.com/1072952Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561900}

Makes the location bar not show any icon on NTP. Adds a new offline
icon and uses it for offline pages.

Bug: 821804, 845956
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icd8aba94af4fcabed9c35f3e322312624cb24835
Reviewed-on: https://chromium-review.googlesource.com/1071511
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561899}

Migrates Service Manager away from the EDK invitation API and over to
the new public API.

Mostly a PoC CL for porting the old stuff to the new stuff, but this
also means that Service Manager now only depends on EDK for
initialization.

Bug: 844763,844764
Change-Id: I10e40a95fdd4760cabd537b2a4ac4c56fb4e33e1
Reviewed-on: https://chromium-review.googlesource.com/1070533
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561898}

Bug: 844764
Change-Id: I73023a683708249f2b3bb139e616e2bef1df1b1e
Reviewed-on: https://chromium-review.googlesource.com/1067749Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561897}

https://pdfium.googlesource.com/pdfium.git/+log/97db69faaeb4..be0f656a8e61

$ git log 97db69faa..be0f656a8 --date=short --no-merges --format='%ad %ae %s'
2018-05-25 dsinclair Add code to display XFA JS log messages

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ie444a6902b3c16cff23cbfd815b5963ae517fe1a
Reviewed-on: https://chromium-review.googlesource.com/1073399
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561896}

It's a layout-related gizmo. Take this opportunity to forward-declare
IntrinsicSizingInfo and only include where used.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I39750738147dbfce05ac1e77042fecfc02b2a92d
Reviewed-on: https://chromium-review.googlesource.com/1070374Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#561895}

This test-only class is a utility which will be used in the upcoming CL
which adds ActiveConnectionManager.

Bug: 824568, 752273
Change-Id: I41a8fb1a63965b8160e4f2f70852cbefe038a531
Reviewed-on: https://chromium-review.googlesource.com/1072569
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561894}

Ideally, copy_cdb_to_output should depend on the files it's copying. But
since those live outside Chromium that's not really practical. Depending
on vs_toolchain.py is probably good enough; the important part is this
will force copy_cdb_to_output to run whenever the VS version changes.

Bug: 846313
Change-Id: Ie0596fb820ba71c40b65325d663f95c2bffe30a4
Reviewed-on: https://chromium-review.googlesource.com/1073451
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561893}

https://chromium.googlesource.com/angle/angle.git/+log/04796cdada00..5f9482f4c52b

$ git log 04796cdad..5f9482f4c --date=short --no-merges --format='%ad %ae %s'
2018-05-18 jiawei.shao ES31: Implement FramebufferTextureEXT entry point

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: Ia8bdc8d4cdcaf572675857e6d4820a3b28b075c3
Reviewed-on: https://chromium-review.googlesource.com/1073392
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561892}

This CL adds JS injection to support interacting with forms. To be used
to get the content of the current field, and set values on the fields.

Bug: 845472
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I860ebf4e2181f53658c0e519c5b3290ec86ac46f
Reviewed-on: https://chromium-review.googlesource.com/1073407
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561891}

A device that is enrolled pre-M68 may not be able to obtain an
enrollment certificate until it is wiped, but can request a computation
of its EID immediately and upload that to the management servers.

BUG=chromium:840496
TEST=unit_tests

Change-Id: Ib1c4d2652110c49d1370fcc0dfbcfddb336c2de9
Reviewed-on: https://chromium-review.googlesource.com/1069599Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Darren Krahn <dkrahn@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Yves Arrouye <drcrash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561890}

This change removes the icon from the Picture-in-Picture interstitial.
The text is also moved to the top left of the interstitial and styled
to play well with the modern media controls, e.g. Play/Pause button
will no longer cover the interstitial content.

BUG: 844357
Change-Id: I3eed46bece9f9b26257a4d2ed4b7a0b6cb3818b8
Reviewed-on: https://chromium-review.googlesource.com/1071231
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561889}

Change-Id: I8c18f3a248de8b1176171f0a5ef800666a9583f7
Reviewed-on: https://chromium-review.googlesource.com/1071885Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561888}

The test fails pretty consistently on Android M

TBR=mdjones@chromium.org

Bug: 837809
Change-Id: I1a1ac99ce0f501afa310f339431673bbc607efa5
Reviewed-on: https://chromium-review.googlesource.com/1072472Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561887}

This change makes mru_window_tracker.cc a SessionObserver and
moves the initial focus logic there.

Bug: 665064
Change-Id: I5c125e0bbe62b9d2c8d809d519d3ccfeade76f8f
Reviewed-on: https://chromium-review.googlesource.com/1070854
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561886}

Creates a service that uses SimpleURLLoader to asynchronously request
wallpaper collections from the Backdrop service, and makes them
available to the Local NTP in a javascript variable.

Bug: 839152
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4c1c8e1d0a3c12eecf3db27f4fd92e79470fcc34
Reviewed-on: https://chromium-review.googlesource.com/1066850
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561885}

This CL adds the logic required to override (via Finch) the LanguageModel
and Triggering logic for Translate in India on English pages.

Bug: 840367
Change-Id: Id4e6e4af4359e8a880a53ce6b4a5915a11ee2ce3
Reviewed-on: https://chromium-review.googlesource.com/1068624
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561884}

TBR=jbudorick@chromium.org

Bug: 845139
Change-Id: I293032217af574b8980defb5142e2b21c1a1517f
Reviewed-on: https://chromium-review.googlesource.com/1073390Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#561883}

This removes the entry in runtime_enabled_features.json5 along with the
two remaining uses of it in LocalFrameView.

Bug: 823365
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic220dc9dc67c658900619f7f89f83ffce226e4dd
Reviewed-on: https://chromium-review.googlesource.com/1073387
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561882}

This reverts commit 216e6d16.

Reason for revert: culrpit CL was reverted 

BUG:chromium:846313

Original change's description:
> Disable core.stacktrace_unittest.TabStackTraceTest.testValidDump on win
> 
> TBR=kbr@chromium.org
> NOTRY=true  # net_unittests flake
> 
> Bug: 846289
> Change-Id: I7fa42786ebdb448fd424e37a7c777e60df6b3c36
> Reviewed-on: https://chromium-review.googlesource.com/1071868
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#561594}

TBR=nednguyen@google.com

Change-Id: Ibf328d3ea480b094e47c5037a7498f198ef94e62
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 846289
Reviewed-on: https://chromium-review.googlesource.com/1073091
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#561881}

clip-path-svg-content/clip-path-clip-rule-008.svg:
  Add missing reference (reference/clip-path-clip-rule-004-ref.svg).

clip-path-svg-content/clip-path-css-transform-002.svg:
  Adjust translation to match reference.

clip-path-svg-content/clip-path-dom-href.svg:
  Do setAttribute(...) on the correct <g>.

clip-path/clip-path-element-userSpaceOnUse-002.html:
  Shrink the clip-path so that it clips out the border, to match the
  reference.

clip-path/clip-path-ellipse-002.html:
clip-path/clip-path-ellipse-003.html:
clip-path/clip-path-ellipse-004.html:
clip-path/clip-path-ellipse-005.html:
  Adjust the description text so that it matches the reference.

clip-path/clip-path-ellipse-006.html:
  Use a different reference (reference/clip-path-ellipse-ref.html), and
  adjust the target <div> such that it matches the reference (replacing
  the red border with a margin.)

clip-path/clip-path-ellipse-007.html:
clip-path/clip-path-ellipse-008.html:
  Replace red border with a margin.

clip-path/clip-path-polygon-001.html:
clip-path/clip-path-polygon-002.html:
clip-path/clip-path-polygon-003.html:
  Adjust the description text so that it matches the reference.

clip-path/clip-path-polygon-004.html:
  Fix typo in assertion.

clip-path/clip-path-polygon-005.html:
  Adjust the description text so that it matches the reference.

Bug: 626703, 843084
Change-Id: I09c37cbe80ca3b82478bdd994ae027e9a72f280c
Reviewed-on: https://chromium-review.googlesource.com/1071529Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#561880}

TBR=bokan@chromium.org

Bug: 846726
Change-Id: I133dc56138d303ea0e1891270a3264ed278a0fb7
Reviewed-on: https://chromium-review.googlesource.com/1073397Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561879}

GbmBuffer used to have it implemented [1] but it's empty now [2]
and is returning nullptr elsewhere.

[1] https://codereview.chromium.org/365193003/diff/60001/ui/ozone/platform/dri/gbm_buffer.cc
[2] https://cs.chromium.org/chromium/src/ui/ozone/platform/drm/gpu/gbm_buffer.cc?q=gbmbuffer&sq=package:chromium&dr=CSs&l=331

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I98d017c5dbbef27cf24454cd44ee519749639507
Reviewed-on: https://chromium-review.googlesource.com/1071947Reviewed-by: Julien Isorce <julien.isorce@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561878}

The test doesn't seem to timeout. It was marked so due to flakes during
an import.

TBR=rtoy

Bug: 846188
Change-Id: I06cdd58043005394fd39a4237dd4f5b6db237733
Reviewed-on: https://chromium-review.googlesource.com/1072905Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561877}

BUG=829628

Change-Id: I054c8a40cf065d0c2f42bd8de9e5de6fed3fb9e9
Reviewed-on: https://chromium-review.googlesource.com/1059155
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561876}

TBR=sky@chromium.org

Bug: 845389
Change-Id: I694cf9a8c2f0dc8f82d163cc6f96b9752742a295
Reviewed-on: https://chromium-review.googlesource.com/1073051Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561875}

Bug: 846478
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Id24c9d4e9123b888a2228cdf0043e51e2850e97b
Reviewed-on: https://chromium-review.googlesource.com/1073189Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561874}

This reverts commit 864136ef.

Reason for revert:
While it seems this did trigger the cdb failures in crbug.com/846313,
it was not the root cause and reverting it didn't actually help.

Original change's description:
> Revert "Fixed SDK lookup for non C:\ Windows installation."
> 
> This reverts commit 57fd44c7.
> 
> Reason for revert: suspect for messing up symbols on Win7 bot
>                    @ crbug.com/846313
> 
> Original change's description:
> > Fixed SDK lookup for non C:\ Windows installation.
> >
> > Bug: None
> > Change-Id: Ia0aa186d1d39b1beac8ce0152683f774ad5d2eaf
> > Reviewed-on: https://chromium-review.googlesource.com/1066065
> > Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> > Commit-Queue: Jochen Eisinger <jochen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#561063}
> 
> TBR=jochen@chromium.org,yura.yaroshevich@gmail.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 846313
> Change-Id: Id93a965aea5555961c539d47e05e79410894eff8
> Reviewed-on: https://chromium-review.googlesource.com/1072307
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561609}

TBR=gab@chromium.org,jochen@chromium.org,yura.yaroshevich@gmail.com

Bug: 846313
Change-Id: I9955a47bbe8a81a0dcf7befebfc422560f8a1cc4
Reviewed-on: https://chromium-review.googlesource.com/1073314Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561873}

Today, there's already a race when registering a preference
through the mojo preference service: the asynchronous
registration call might be slower than starting sync. As
more services are being implemented, those scenarios are
getting more likely -- especially as services could be
started at arbitrary times.

Before this path, the synced preferences implementation did
not support this scenario. This patch changes the synced
preference implementation to receive and persist remote
data for preferences before they get registered. Currently,
this only applies for a whitelisted set of preferences.
More details about the approach can be found in the design
doc linked from the crbug/840332.

Bug: 840332
Change-Id: I90f046d7b59098a303e7b92350cc29e5de9cc244
Reviewed-on: https://chromium-review.googlesource.com/1064750
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561872}

blink::ResetPluginCache, called by content/, currently tries to refresh
the browser plugin cache as well, but content/ also blocks this from
happening. We can simplify by simply not making this call in that case.

Change-Id: Ib61db31ab03a481ea9b7c485df03af384e177637
Bug: 846722
Reviewed-on: https://chromium-review.googlesource.com/1072499
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561871}

When a credential is used for the first time, we upload a FIRST_USE
crowdsourcing vote, voting the fields as USERNAME and PASSWORD, even if
the use results in a new password value being saved. This was to be
resilient against cases where the password manager saves the wrong
password in the original form. However, it is semantically incorrect,
both in the above case and also when applied to change-password forms.

We change the vote so that we don't upload a vote for the password
field.

This does not apply to usernames, because a new username is treated as
a new credential. In the case where we add a username to an old
credential, we keep setting the KNOWN_VALUE flag, because this event
only happens as a correction and doesn't say something different about
the field. Also, the fact that the user accepted the prompt is a strong
indication that the field contains a proper username.

Bug: 840384
Change-Id: Iff20a022abc50a4dab2f32f46e13e33621eb6129
Reviewed-on: https://chromium-review.googlesource.com/1071523
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561870}

cdb is currently broken. Make the test pass by skipping the cdb invocation
until it's fixed.

TBR=mkwst

Bug: 846313
Change-Id: I2db6460b72d4cf5e81b0c9e590ab10ea5b9241a0
Reviewed-on: https://chromium-review.googlesource.com/1072648
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561869}

This reverts commit 82e2a47a.

Reason for revert: Suspected of causing OAuth2Test.SetInvalidTokenStatus failure in https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5838

Original change's description:
> [signin] Remove usage of AuthErrorProvider from tests (2)
> 
> Going forward the default API for interacting with authentication error
> should be the token service rather than the SigninErrorController.
> This CL updates tests to use the token service instead of
> AuthErrorProvider to set authentication errors.
> 
> Bug: 836212
> Change-Id: I9b5629bad7b17b6cab70978cc23bbc828bf62d61
> Reviewed-on: https://chromium-review.googlesource.com/1016904
> Commit-Queue: David Roger <droger@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561830}

TBR=stevenjb@chromium.org,droger@chromium.org,msarda@chromium.org

Change-Id: I5fe286175add827a626413ea1bee442fbfd4f258
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 836212
Reviewed-on: https://chromium-review.googlesource.com/1073457Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561868}