- 19 Oct, 2020 40 commits
-
-
Rohit Agarwal authored
Incognito CCT. Ephemeral tabs or Preview tabs were using primary OTR profile to open the bottomsheet and to render the WebContents in the Incognito CCT. This CL ensures that we use non-primary OTR profile to open preview tabs in Incognito CCT. Bug: 1138948, 1060940 Change-Id: Iec093e7039e7d5c1b5e5729044af965d9eed0104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476281Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#818399}
-
Victor Hugo Vianna Silva authored
One problem with the old MOCK_METHODN/MOCK_CONST_METHODN gmock macros is that they never specify whether the mocked method is an override or not. The consequence is that sometimes, methods are removed from sync interfaces but remain in the mock implementations. Worse, they can even even remain in test code if the test checks something of the form EXPECT_CALL().Times(0). This CL uses a script to migrate all the sync code to the modern MOCK_METHOD macro. For convenience, patchset 1 is a pure application of the script, marking every method as 'override'. Patchset 2 fixes compilation errors, i.e. either removes leftover methods, or removes the override annotation if the method was indeed intended not be an override. Bug: 1139379 Change-Id: Ic5178057afed6d809d52a0d9c8c5d881acfe20ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480762 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#818398}
-
chrome://quota-internalsdpapad authored
This is in preparation of migrating chrome://quota-internals to use JS modules. - Replace calls to CallJavascriptFunctionUnsafe with FireWebUIListener. - Replace event handlers on unnecessary custom EventTarget instances with cr.addWebUIListener() calls. Bug: 1028829 Change-Id: Id5a97d5e81a4e920dfe116a4b93cbacbf5ce55fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478847Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#818397}
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: Iecd8d1083631e612382908050f0b67cb9a29bf0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470281 Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#818396}
-
Yuki Shiino authored
In order to route the property access to the platform objects to the embedding objects, HTMLEmbedElement and HTMLObjectElement are (ab)using the named properties, hence the regular definition of [[DefineOwnProperty]] of named properties shouldn't be applied. (By the way, the situation is similar to CSS properties.) This patch makes NamedPropertyDefinerCallback noop in case of HTMLEmbedElement and HTMLObjectElement. Bug: 1139312, 839389 Change-Id: I5089965ad766440920e4cc2d3308a2e2fae4250b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481163Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#818395}
-
Peter E Conn authored
This means that downstream can depend on the empty module and we can then move the code into the module with causing downstream to break. Change-Id: I604020a6493523e4ed5d5d99c12b32c1cba708a2 Bug: 1104817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479172Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#818394}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2be35682cd67..c69ef8bf34ca 2020-10-19 jiajia.qin@intel.com Add the ES31 status on d3d11 document. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I049e172ae0fe8ce0e633425ebef956b76bde3def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483773Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818393}
-
Luciano Pacheco authored
This is a preparation to migrate to JS modules. Bug: 1133186 Change-Id: I456cfc1de0c8fee0dd0a036e00da634c9c49c5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469921 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#818392}
-
Koji Ishii authored
The cause of the failure is not clear, but this test did not skip when dictionaries are not available. This patch adds the same condition as other tests in |HyphenationTest|. Bug: 851413 Change-Id: I627290f090a433cd481adeba2c00484231bfee19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483544Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#818391}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99f4c7607c8c..8216043b1fc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC finnur@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1136999 Tbr: finnur@google.com Change-Id: I01a8e20d0272a5ad0fa4981056df013126fb5389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484325Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818390}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1040826 Change-Id: I47587f710cb55ef59c4f4e2e42bb53390b52001b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483950 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#818389}
-
Mikel Astiz authored
After careful consideration, there is no obvious solution to revert back to SyncApiComponentFactory without a big amount of refactoring that doesn't seem justified because of this small TODO. Change-Id: I3e1d6fbe473c07b492fbdb2ce4e15ec3706aa53e Fixed: 915154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480084 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603064915-3fa327824899e1fa6f9fcc538942d9b17661b83b.profdata to chrome-mac-master-1603087080-138c0bc7a94d51e9caaa7300e866d8f7233b285e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iea019f3c1b4fa8ebbe80948b01f07135bcacbde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483777Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603064915-c9f8d0200bc967fb7a01c85287c3d990be09cab2.profdata to chrome-linux-master-1603087080-212b8c940037ae1d78d2bd42956b635be6add59e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib2bab8d4cad3003a7bbd8fc38ebe272d39a986d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483776Reviewed-by:
-
Luciano Pacheco authored
When the CSS is in-lined in the JS as part of generating the JS module the "\" escaping doesn't work. To workaround this problem we replace the escaping unicode code with the actual UTF-8 char. Note that the code "\00a0" is actually a non-break space and it was replaced with a normal blank space, however the style used doesn't break and this is an old style used in pre-GM2. Note 2: The problem only affects styles in the HTML for Polymer elements, but for consistency, I'm replacing in all files. Bug: 1133186, 1130413 Change-Id: I69fc315a6f4e8b96564b2250b2f8510fed55e307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470037 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/87dd38763359..91f276e903b3 2020-10-19 jleconte@google.com Fix pop up statement when triaging with an existing bug. 2020-10-19 jleconte@google.com Move Monorail projects list from Python to Javascript. 2020-10-19 dberris@chromium.org pinpoint: Handle potentially missing timestamps 2020-10-19 dberris@chromium.org pinpoint: Fix handling of Monorail issue response If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1133649,chromium:1134978 Tbr: wenbinzhang@google.com Change-Id: I9da365cf89b5ad387d845b088b4cd51c5a9c0418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483772Reviewed-by:
-
Omer Katz authored
Using just the suffix results in applying the clang plugin to Oilpan source code if the chromium checkout resides (transitively) under a directory named "test". In such cases, chromium fails to build. Bug: 1137252 Change-Id: I6a0e7fb5e175c9f33fe7c79ca7f5790b69eb34ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480569Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818383}
-
Keishi Hattori authored
Detects invalid freelist_head by seeing if the super page matches. Bug: 1137799 Change-Id: If6f2fb0736a426a14f4f098e0f75eaa6b920fe5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476876Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#818382}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1400dda5de60..260029435baa 2020-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 17855e1b to cb9deed9 (555 revisions) 2020-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b4fb7cc9ec8f to 2be35682cd67 (25 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Test: Test: Test: Free Fire MECTest: Test: GLES31/functional_android_extension_pack_extensions_ext_texture_srgb_decodeTest: Test: GLES31/functional_debug_negative_coverage_*_srgb_decode_*Test: Test: GLES31/functional_state_query_sampler_*_srgb_decode_*Test: Test: GLES31/functional_state_query_texture_*_srgb_decode_*Test: Test: PUBG MECTest: Test: angle_end2end_testsTest: Test: angle_end2end_tests --gtest_filter=SRGBTextureTest.*Vulkan*Test: Test: dEQP.GLES31/functional_srgb_texture_decode_skip_decode_* Change-Id: Ia38ca4128f1de8bb0679a3d8d7174b59ac3051ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484304Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/64d02136b235..c7e96aec1132 2020-10-19 annaagoha@gmail.com fix uneven outline and padding issue If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1137347 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib3952714f1a331146ed997de5bf1ed5a30a0ba5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483890Reviewed-by:
-
Melissa Zhang authored
This reverts commit f524b7f0. Reason for revert: I will add a simple fix. Original change's description: > Revert "Change ButtonPressed overrides to callbacks: c/b/ui/views/sharesheet/" > > This reverts commit 1ac9a1da. > > Reason for revert: Breaking UI > > Original change's description: > > Change ButtonPressed overrides to callbacks: c/b/ui/views/sharesheet/ > > > > This allows converting |targets_| from a member to a parameter that's > > passed around. I also did some other cleanup while there. > > > > Bug: 772945 > > Change-Id: Iaa7f70594ba109d1598da3566856e90c8b09629d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481246 > > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > > Reviewed-by: Melissa Zhang <melzhang@chromium.org> > > Auto-Submit: Peter Kasting <pkasting@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#818324} > > TBR=pkasting@chromium.org,melzhang@chromium.org > > Change-Id: Ief930a27f44caef219bf782a7534ef8bc76d83ef > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 772945 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483745 > Reviewed-by: Melissa Zhang <melzhang@chromium.org> > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818357} TBR=pkasting@chromium.org,melzhang@chromium.org # Not skipping CQ checks because this is a reland. Bug: 772945 Change-Id: I00d7acd3d7c812dfde8b584c2e53b6b2e1c237a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483987Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#818379}
-
Daniel Ng authored
This object allows us to queue up events to be run once we observe that the borealis vm has started (or until a specified timeout). Tests: Built and ran tests. Bug: b/162562622 Change-Id: Ieaee96af72bc7fc41b90a48111ef8998af6cdf97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473781Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#818378}
-
Tomasz Tylenda authored
We use base::RepeatingClosure and base::Bindepeating for attempt_user_exit_callback_. In other locations we convert Bind to BindOnce, because callers require OnceCallback. BUG=764795 TESTED=build Change-Id: I35172b00c4ccb37383b2adb55d44e8569b129dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483547Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/master@{#818377}
-
David Jean authored
Add enum histogram for ios multi-window configuration recording. Each minute one bucket from the enum will be increased by 1. Code is in: https://chromium-review.googlesource.com/c/chromium/src/+/2445415 Bug: 1134568 Change-Id: I418120cc33c8f866b1dea4c2800493160179fcb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445491Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#818376}
-
Jiewei Qian authored
This is a cleanup after BMO is launched. Bug: 1065748 Change-Id: Ib5af0334ca9f9a9f11419fc774d0cd1adfc4307f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467040 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#818375}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b74a39b2dc30..99f4c7607c8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aboxhall@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: aboxhall@google.com Change-Id: I2114e33a156d7c88738f71d1fa41bcc0cd88246d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483888Reviewed-by:
-
sandromaggi authored
This CL adds reporting for which web-action failed. This is useful for actions that execute in multiple steps, e.g. |ClickAction|: * WaitForDocumentToBecomeInteractive * ScrollIntoView * ClickOrTap Bug: b/169924567 Change-Id: I644178737fc21039767670ffcb5853d794ab754b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475115 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#818373}
-
Jimmy Gong authored
- Crash was due to attempting to remove an previously removed notification. - The fix is to verify that the notification_id is a valid id to remove. Bug: 1139561, 1106937 Test: chromeos_components_unittests, ash_unittests Change-Id: Ia606df1dfec13beba9ccc14c2618ec4f6fda7129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482428Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#818372}
-
Kent Tamura authored
- Introduce helper functions to share common code - Use TextControlElement instead of HTMLInputElement This will help testing LayoutTextControlMultiLine. - Fix camelCase variable names This CL has no behavior changes. Bug: 1040826 Change-Id: I4287125d4531151573d839363d182ee2d8d1409e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483741Reviewed-by:
-
Koji Ishii authored
This patch enables the Minikin hyphenation engine on all platforms except Mac. Mac keeps using the engine in the OS. Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/sIRXYKA4jGE/m/44YfDTNkAwAJ Test expectation changes are: * Linux/Win support `hyphens: auto` as a valid CSS. * Unskip tests that require `hyphens: auto` on Linux/Win. * Some Mac-only failures now fail on all platforms. * Triaged 1 new failure on Linux and 2 on Windows. The causes are existing ones, but results vary by platform as tests rely on fonts and dictionaries. I'll review existing issues. Note, |web_tests| and |content_shell| use the dictionaries in the repository (r818216 crrev.com/c/2478122), while in Chromium, the [component updater] downloads the dictionaries (r816137 crrev.com/c/2437314) and passes to the engine when they become ready (r817902 crrev.com/c/2462893). [component updater]: https://chromium.googlesource.com/chromium/src/+/master/components/component_updater/README.md Bug: 652964 Change-Id: I82e3df40ea59256aa61de24bce4be39870e85adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315564Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#818370}
-
Kent Tamura authored
The only callsite of CommitPendingEndOverhang() is NGLineBreaker::HandleText(), and it is called for NGInlineItem::kControl for a TAB character as well as NGInlineItem::kText. So, CommitPendingEndOverhang() should take care of NGInlineItem::kControl. This CL updates CommitPendingEndOverhang() so that a ruby annotation text doesn't hang over a TAB character. This CL also adds a stream printer for blink::NGLineInfo. Bug: 1138943 Change-Id: I478e93086f449b8e4cda4c8828d34f4111d80ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483739 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/958dc6267f2d..8ecad5261a1f 2020-10-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I27ba5cd0ef6c0a82951ee3c6c827dbd410c604ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483532Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bd239eff..93ed90e6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4ef4af28db36b9f97e0a9bda805ad312f0b934da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484282Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818367}
-
Hiroshige Hayashizaki authored
This CL migrates most of import maps resolution tests by observing the resolution results by intercepting module script requests by a service worker. This CL also introduces `useInternalMethods` flag to clarify the tests still requiring internal methods. Bug: 1026809 Change-Id: I16c2a87bb67b530dc97b1631f6968b2d3bafdac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457526 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#818366}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2f56cfe7fc9e..1105ef875a93 2020-10-19 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Catapult from 0de987471899 to 89eeef5150cb (76 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ie72b91ed5d6924a01e99fd12dfffcd7aa3b3c918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483886Reviewed-by:
-
Alan Cutter authored
This CL updates AppBannerManager methods: - ShouldDeferToRelatedApplication => ShouldDeferToRelatedNonWebApp - IsSupportedAppPlatform => IsSupportedNonWebAppPlatform - IsRelatedAppInstalled => IsRelatedNonWebAppInstalled to be more clear that they're checking for related non-web apps. This distinction is important now that we have the chromeos_play platform which is used to list web apps on the Play store. Change-Id: I0014b4977078ee46a97b11777b442506b5b2d566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483712 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#818364}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a5e8f6b40233..1400dda5de60 2020-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 04bd4d8e4ece to df17a76102df (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I994be689013cf27e166a8ca605546651df3cb81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483529Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/89eeef5150cb..87dd38763359 2020-10-19 dberris@chromium.org chromeperf: Remove Mac testing from presubmit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1132884 Tbr: wenbinzhang@google.com Change-Id: I8edece296ed84952c990c0023305050704df2dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483527Reviewed-by:
-
Jérémie Boulic authored
Tests crrev.com/c/2423448. Bug: chromium:912236 Test: browser_tests --gtest_filter=FileManagerJsTest.FileTasks Change-Id: Iefca4742d6fb154c5c1a392d0da14af796a792a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467162Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#818361}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a9da93c46a90..64d02136b235 2020-10-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib348125d88c8c2a951dba18b491af12b0bad1625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484126Reviewed-by:
-
