- 17 Oct, 2019 40 commits
-
-
Brian Sheedy authored
This reverts commit 8e751655. Reason for revert: There are apparently more conversions required in third_party/webrtc Original change's description: > Switch WebRTC browser perf tests to histograms > > Switches uses of PrintResult in the WebRTC browser perf tests to > PerfResultReporter and whitelists browser_tests for conversion to > histograms before uploading to the perf dashboard. > > Bug: 923564 > Change-Id: I7ff090bcdeaf3906491b85993456f07313cd4a52 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856825 > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706699} TBR=miu@chromium.org,phoglund@chromium.org,bsheedy@chromium.org Change-Id: I80e804f4b38699adaa6cce33b48a57769a2a6db5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866627Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#706985}
-
John Abd-El-Malek authored
They've been running on Android Mojo FYI bot with no flakiness. Change-Id: Ic6c7b1bbc20c2d54c7a023a371e586a1e9047215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864358 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#706984}
-
Chandani Shrestha authored
Screen-reader accessibility: Each palette is assigned a role button so, when user navigates to each palette it reads e.g. 'Color #3F51B5 button' This change was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1687564 which has been broken down 1. Make swatches in color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1817344 2. Make swatches screen reader accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816875 3. Make shades of a color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816873 4. Make close button keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816874 Gif showing keyboard navigation which has been split out from this change https://imgur.com/m3iVkOj Bug: 963183 Change-Id: I244edc0cabf5aa5d6df51d3cf31efa00f64a666c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816875 Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706983}
-
Haiyang Pan authored
Bug: 1001643 Change-Id: I46058d98b3f83810033c8074f2f9ad9965b2be71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861105Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#706982}
-
Gyuyoung Kim authored
This CL applies new Mojo types to VideoCaptureService interface. - Replace MakeStrongBinding with MakeSelfOwnedReceiver. - Convert FooRequest to mojo::PendingReceiver. - Convert FooPtr to mojo::PendingRemote. Bug: 955171 Change-Id: I7a3f1663168d2bd954d17e8ce5cfddd56028b5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862920Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Luke Sorenson <lasoren@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#706981}
-
Lan Wei authored
This reverts commit 8e1e2bb6. Reason for revert: <INSERT REASONING HERE> ../../third_party/blink/renderer/core/page/scrolling/text_fragment_anchor_test.cc(8,10): fatal error: 'third_party/blink/renderer/bindings/core/v8/usv_string_or_trusted_url.h' file not found #include "third_party/blink/renderer/bindings/core/v8/usv_string_or_trusted_url.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > Highlight text fragment directives on page reload > > Fix the behavior where fragment anchors were only kept alive if a scroll > was needed, as is the behavior of element fragment anchors. This caused > text fragment anchors not to be kept alive and we didn't highlight on > reload. > > Note that *sometimes* we would highlight on reload, due to a race > condition with fragment anchors, where we process the fragment before > restoring scroll position (which is where should_scroll becomes false), > see crbug/839292. This change makes it so we highlight on reload > independent of whether a scroll is needed. > > Bug: 932551 > Change-Id: I38cc82c4920255d8bcae9f8b55ac80f24d1465da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864714 > Commit-Queue: David Bokan <bokan@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706847} TBR=bokan@chromium.org,nburris@chromium.org Change-Id: Ifa4ea6a04c62662a1ec0a7b611247ed16d9d979b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 932551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866623Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#706980}
-
Lan Wei authored
This reverts commit 005483fe. Reason for revert: <INSERT REASONING HERE> ../../third_party/blink/renderer/core/page/scrolling/text_fragment_anchor_test.cc(8,10): fatal error: 'third_party/blink/renderer/bindings/core/v8/usv_string_or_trusted_url.h' file not found #include "third_party/blink/renderer/bindings/core/v8/usv_string_or_trusted_url.h" Original change's description: > [Trusted Types] Remove TrustedURL. > > The current Trusted Types spec no longer supports TrustedURL. This CL adapts > to the spec. > > Bug: 1002555 > Change-Id: I35c6d8a257046558f155b9f38289457b14dcb1d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834142 > Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706886} TBR=vogelheim@chromium.org,mkwst@chromium.org Change-Id: I9012ad7c3f9f01389ab1aa7a90d5beb7873eab2c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1002555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866974Reviewed-by:
-
Clark DuVall authored
Loading pak files was not quite working right in weblayer, since we were not loading locale paks. This caused text on e.g. submit buttons to not show up in some configurations like loading from monochrome. This change makes weblayer load pak assets similar to webview, and uses the webview pak deps for the weblayer support APK, since those should be sufficient for weblayer. As an added bonus this also allows l10n to work, so switching the default language of the device will show buttons and labels in that language. Change-Id: I1a2b47009e7bb74f1ea3c16dc6f52451e2b78066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865015Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#706978}
-
Chandani Shrestha authored
Close button in color picker appears when user presses button rightmost arrow button to launch palette panel. This change updates focus from palette panel to close button. This is because earlier user had to press extra tab to reach to control. This change handles close button on ENTER, SPACEBAR and ESC key events. ESC key is for user to escape from the palette panel and return back to earlier state. Earlier, pressing ENTER would close the color picker this change handles it by consuming the event. Gif showing the change https://imgur.com/vt2saeT This change was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1687564 has been broken down 1. Make swatches in color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1817344 2. Make swatches screen reader accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816875 3. Make shades of a color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816873 4. Make close button keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816874 Bug: 963183 Change-Id: I573e74a0e6adb5130f524f34016760233e14f5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816874 Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts URLLoaderFactory from //chrome and //extensions to new Mojo types using PendingRemote and Remote. Bug: 955171 Change-Id: I0379f56d1069252e482f3fd3d15d3ec2087344a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859971 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#706976}
-
Raphael Kubo da Costa authored
This implements https://github.com/w3c/wake-lock/pull/242. WakeLockEvent just duplicates functionality that is available in Event itself, so just emit Events instead. ev.lock can be accessed via ev.target, which comes from Event itself. Bug: 1015320 Change-Id: Iadb4d48629520605bdb4332bb02a62d022fab16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865347 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#706975}
-
Daniel Cheng authored
This appears to be unused, undefined, and obsolete. Change-Id: If5e431f77db6c0392662ff76cee2adcd856c07ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865809Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#706974}
-
Daniel Libby authored
First in a series of changes to get rid of the DisableCompositingQueryAsserts in PaintLayerPainter::Paint. kPaintLayerUncachedClipRects is only used to determine whether a paint layer should create a subsequence (for potential benefits of caching/ reusing the subsequence). However, it is currently only set if kGlobalPaintFlattenCompositingLayers is set (either manually in data_transfer.cc or via the code in PaintLayerPainter::Paint). If that global flag is set ShouldCreateSubsequence always returns false, so the kPaintLayerUncachedClipRects flag is unnecessary. Removing this code gets rid of 1 out of 3 compositing queries in this codepath. Bug: 1007989 Change-Id: I59cddc51a65c9acd8e134845d7c9c4b6320fc4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864414Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706973}
-
Daniel Libby authored
From the comment and linked bug history, this was introduced so that scroll code could identify main thread scrolling reasons. These have since moved to the scroll property tree, and no further compositing queries exist on this codepath (or at least are not hit by tests - this one is a pretty high-level disablement). Bug: 1007989, 625676 Change-Id: I86ee8d1ab864fe6334ba4c7c7aa35e07cdc937cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865424 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
-
Joe DeBlasio authored
Change-Id: Ib0eb67560ac8b5d070ad85d8d5d4e6b2faf90d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866875 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#706971}
-
Takumi Fujimoto authored
Enable the feature flag for the native DIAL MediaRouteProvider by default. Bug: 956621 Change-Id: Ied8686c0accfe46397b97890c9778f5876276484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864013Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#706970}
-
Lan Wei authored
This reverts commit 2000b5b1. Reason for revert: <INSERT REASONING HERE> inspector-protocol/accessibility/accessibility-getFullAXTree-display-locked.js is keeping failing on WebKit Linux MSAN. Original change's description: > DL: Fix flaky getFullAXTree & wrongly updated accessibility tests > > A devtoools display locking a11y test was marked as failing in MSAN bots > and is also flaky when tested locally, this CL updates that test and > fixes the cause of the failure (getFullAXTree might be called when > style/layout is dirty, which caused failing DCHECKs). > > Some other display locking a11y tests were not updated correctly, and is > updated in this CL as well. > > Bug: 996625 > Change-Id: I32eac1385c54eb07b1e6dab800620a2485158437 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846618 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706834} TBR=vmpstr@chromium.org,aboxhall@chromium.org,rakina@chromium.org Change-Id: I11a6bbc935ec0b88d9f72af37cc729cc28257766 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866620Reviewed-by:
-
Robert Ogden authored
Adds a new method, GetLastVisitToOrigin, to the history stack which gets the last visit to any page on an origin within a time range. This call is successful if there were no previous visits to that origin but reports a null base::Time. Bug: 995437 Change-Id: I56b421161c85076f5b81c61fcf1e31ef08abfe81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860733 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#706968}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/989bc351863d..b594247e39a4 git log 989bc351863d..b594247e39a4 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 ehmaldonado@chromium.org Reland "depot_tools: Run recipe scripts using vpython." Created with: gclient setdep -r src/third_party/depot_tools@b594247e39a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: I2e064ac8c7e012aa945ede3840763abe37c133a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866737Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706967}
-
Denis Kuznetsov authored
Previously OOBE UI Dialog size was controlled from JS code. This CL changes implementation so that dialog size is set according to UI specifications in C++ code, and web-based ui should just fully fit into given dialog. Note that code in ash/wm/lock_layout_manager / lock_window_state propagates bounds changes only to full-screen children, so OobeUIDialogDelegate will create full-screen Widget that will host WebUI dialog, receive all bound-changed events and update hosted dialog size according to specs. Bug: 1007294, 1007861 Change-Id: Ib81ec7f886cd406df98838de5af8401083de0b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841953Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#706966}
-
Mitsuru Oshima authored
1) getAppWindowInfo to retrieve the list of application windows with ids. 2) setAppWindowState to set the window state using the id. 3) closeAppWindow to close the window. Bug: 1010671 Test: Covered by unit test except for close. It'll be covered in next CL. Change-Id: Iaa71764a58663713ac5d745b550bfa7b46bb383b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857603 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706965}
-
chrome://device-emulatordpapad authored
This is in preparation of migrating this page to Polymer3. Bug: 1015241 Change-Id: Id8533d89043f288fee6aaa45fcbde5ef48bda51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865266Reviewed-by:
-
Owen Min authored
Change MachineLevelUserCloudPolicyController to ChromeBrowserCloudManagementController Change MachineLevelUserCloudPolicyEnrollmentMetrics to ChromeBrowserCloudManagementEnrollmentMetrics IsMachineLevelUserCloudPolicyEnabled rename will be in the next CL. Bug: 1010704 Change-Id: I4e28f1e690237e7d310be42341d3b5f0ba47135f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865674 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#706963}
-
Denis Kuznetsov authored
Bug: 1000606 Change-Id: I35cb734412924fa0a315063c5ca80556f6bb40fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863094 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Maksim Sisov authored
By accident, we didn't pass the icon further to the XWindow from the PlatformWindowProperties. This CL fixes that. Based on the patch provided by mail@maciej.szmigiero.name. Bug: 1007996 Change-Id: I3718f5f1698438ed07c5f453cdb445cd50a48219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864803Reviewed-by:
-
Sebastien Marchand authored
Also rename some of the existing params while I'm here to make them more explicit. Bug: 1014976 Change-Id: I6fade2127172343f22084b762a500309a418920b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865599 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#706960}
-
Daniel Vogelheim authored
The current Trusted Types spec no longer supports TrustedURL. This CL adapts to the spec. Reland after revert (crrev.com/c/1866406) Bug: 1002555 Change-Id: Ia683ad3ff4e7390ba59bf7313fd605c976cea3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834142 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#706886} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864798 Cr-Commit-Position: refs/heads/master@{#706959}
-
Jan Wilken Dörrie authored
This change adds a check to TouchToFillController that allows disabling Touch To Fill for secure frames. This check queries a Field Trial Parameter which can be set on the server side. Bug: 1014042 Change-Id: I0ef9cf016b9057a8c2c3e97fbe356d7e49ffd28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863932Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#706958}
-
Evan Stade authored
Bug: 268984 Change-Id: Ie8b843cbebedf8a4c881e6e275ca8f734af70331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856851 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706957}
-
Steven Bingler authored
Add metric to track SameSite cookies sent which cross schemes http-to-https and https-to-http, as seen from site-for-cookies to request, and are Lax or Strict. Add metric to track SameSite cookies sent with Lax or Strict. These metrics will be used to assess potential breakages if http://site.example and https://site.example were to be treated as cross site instead of same site as they currently are. Change-Id: I3a9e2831bba98d85cf0dd607e158b2bf4f8ed8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863349Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#706956}
-
Eric Stevenson authored
Currently, trying to use proxy natives in an APK target will result in multiple copies of GEN_JNI.class being added to the final jar since: * The jni_processor creates a GEN_JNI for the library target it runs on * The java_library_impl inside the APK target also adds a GEN_JNI to the output .jar because the final JNI step is a srcjar_dep APK targets now support the annotation_processor_deps and processor_args_javac args and must provide "org.chromium.chrome.skipGenJni" to use proxy natives. This CL also converts chromium_linker_test_apk__apk to use annotation_processor_deps directly instead of the workaround added in http://crrev.com/c/1758655. Bug: 1001595 Change-Id: Ifb31b7c52327b2793540142eb013d0c39cb6435e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842297Reviewed-by:Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#706955}
-
zhaoyangli authored
This is the major change for autofill automation EG2 migration. - Separated test and app side code in former automation_egtest.mm by creating private helper function and app interface for app side calls. |NSString*| and |NSError*| are communicated between test and app. App interface code is mostly migrated from automation_egtest.mm with minor changes: - |GREYAssert|s are changed to |NSError*| to be sent back to test. - Moved some instance variable and methods to static variable and functions. - Overrode |launchAppForTestMethod| in |AutofillAutomationTestCase| to start app with needed features. - Created eg2test target and eg_app_support+eg2 target in automation BUILD.gn. Created new eg2tests_module and included new eg2test target in earlgrey2 BUILD.gn. - Removed unused headers in code and unused deps from build file. Bug: 987646, 1003605 Change-Id: I22ae675848bd1b08df9cdb375a6dcfb2f42b8c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850739 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#706954}
-
Cathy Li authored
[ExploreSites]: Do not set height in the dense tile views to allow text to overflow when text size increases Bug: 1009093 Change-Id: Ia4cf81bf699f4fd392ff98e3212d62b77bf7b134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830170 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#706953}
-
Nicolás Peña Moreno authored
This CL adds a test where FCP must be equal to LCP for a website that has a single contentful element: a <p>. It is currently flaky in Chrome. Bug: 1015130 Change-Id: I0da2d7b15ac72fe2f0964043f01c49b089d201a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865540 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#706952}
-
Lan Wei authored
Browser tests ProfileMenuClickTest_WithUnconsentedPrimaryAccount is keeping failing on Mac 10.12. Disable it. Builder: Mac10.12 Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests TBR=tangltom@chromium.org Bug: 1015429 Change-Id: Ib617d534d2ea7eb3b294b456837a5025ecc6698d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865145Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0544d1e26010..45f9f6cebc3a git log 0544d1e26010..45f9f6cebc3a --date=short --no-merges --format='%ad %ae %s' 2019-10-17 treehugger-gerrit@google.com Merge "processor: Add foundations for modularization of proto trace parsing" 2019-10-17 primiano@google.com Merge changes I24d0f3b6,I0e78257d 2019-10-17 treehugger-gerrit@google.com Merge "protos: Update comments on TrackEvent protos" Created with: gclient setdep -r src/third_party/perfetto@45f9f6cebc3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I5e3c8dc8e0ecf2a28c476e281bb522b9034bb1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866733Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5f01bf6c8b78..c06aef2ad1b3 git log 5f01bf6c8b78..c06aef2ad1b3 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 sprang@webrtc.org Reland "Use just a lookup map of RTP modules in PacketRouter" 2019-10-17 mbonadei@webrtc.org Update DEPS to download the checked-in JDK. 2019-10-17 mbonadei@webrtc.org Use symbol_level=1 also for MSVC dbg bots. 2019-10-17 sprang@webrtc.org Revert "Use just a lookup map of RTP modules in PacketRouter" 2019-10-17 sprang@webrtc.org Use just a lookup map of RTP modules in PacketRouter 2019-10-17 henrik.lundin@webrtc.org Avoid reading outside of memory in WebRtcVad_FindMinimum 2019-10-17 gustaf@webrtc.org Avoid running NullAudioPoller without receiving streams Created with: gclient setdep -r src/third_party/webrtc@c06aef2ad1b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:b/142775365 Change-Id: I00413a82f84457d4efea64837516eae8619aa05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866735Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e62dfe9064db..1b3fb455bf18 git log e62dfe9064db..1b3fb455bf18 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 perezju@chromium.org [Telemetry] Remove some dead code in story_run_unittest Created with: gclient setdep -r src/third_party/catapult@1b3fb455bf18 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:921000 Change-Id: Id41221d7be64891f834043ba7957a32373b51542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866734Reviewed-by:
-
Bailey Berro authored
This change switches to calling sync's ReportUnrecoverableError function rather that DumpWithoutCrash. This reduces the number of crash reports that are uploaded with this signature. Change-Id: I46cf634bbfa4dcd460dae89dd4b91a412678fa7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862246 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#706947}
-
Miyoung Shin authored
This CL converts MediaControllerManager{Ptr, Request} in chromeos, content and services to the new Mojo type. Bug: 955171 Change-Id: Ic346dcdeac6e2dc59dc99a953345abd61f9d2c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849735 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#706946}
-
