GitLab

Bug: 1129215
Change-Id: Ifc454d94a79feb7b16d257219279e4f58344547f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414702Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#807939}

Before this CL, MainController calls startUpChromeUI on the scene on iOS
12.

With this CL, this exceptional call is removed. Instead, the call now
always happens in SceneController. The follow-up call to
startUpAfterFirstWindowCreated in MainController is now triggered
through the appState:firstSceneActivated: observer callback in both old
and new startup sequences.

This requires a few minor changes:
* AppState now observes SceneWillConnect and immediately adds itself
as a SceneState observer. The UISceneDidActivateNotification observation
is now replaced with sceneState:transitionedToActivationLevel:, which
is available on both iOS 12 and 13.
* SceneController now becomes an AppStateObserver immediately on init,
instead of waiting to initializeUI.

Minor win: SceneControllerGuts are no longer necessary.

Bug: 1012697
Change-Id: Id82e6a10c5825e34f53f076fef19a1e6bf9e7908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398505
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807938}

This is a reland of 37dea4b3
Wasn't actually the culprit of failing tests.

Original change's description:
> Update message in permission dialog overlay warning
>
> The current overlay warning message does not directly address the
> typical case: when dialer or chat bubble is displayed on the screen.
>
> One change in behavior is that "Cancel" button of overlay warning dialog
> dismisses both overlay warning and permission dialog.
>
> BUG=1127455
> R=twellington@chromium.org
>
> Change-Id: I9d5c13a6c7d4e52a3fa73b3193d1ef463272ab64
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406148
> Reviewed-by: Theresa  <twellington@chromium.org>
> Reviewed-by: Andy Paicu <andypaicu@chromium.org>
> Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807089}

Bug: 1127455
Change-Id: Ia973a989f70d4a094b0d620b4ae4970482d21fc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414672Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Auto-Submit: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#807937}

Bug: 1041619
Change-Id: Ifab7a7de001c3193f031b1fa437b851cf7cc1c6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415276Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#807936}

This reverts commit d777f5d0.

Reason for revert: Lots of test failures here:
https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/14202

Original change's description:
> Reland "[Empties] Enable the IllustratedEmptyStates field trial testing config."
> 
> This is a reland of 74b8ec6f
> 
> Original change's description:
> > [Empties] Enable the IllustratedEmptyStates field trial testing config.
> > 
> > Change-Id: I664fa63b5b69369cb69fb4b87463ba3bb4cfc94d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386295
> > Reviewed-by: Sergio Collazos <sczs@chromium.org>
> > Reviewed-by: Steven Holte <holte@chromium.org>
> > Commit-Queue: sebsg <sebsg@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#805136}
> 
> Change-Id: Ieb3e461efb4c55e7ef601417819cc4470e8fe4cc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401398
> Commit-Queue: sebsg <sebsg@chromium.org>
> Reviewed-by: Sergio Collazos <sczs@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Auto-Submit: sebsg <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807867}

TBR=isherman@chromium.org,sebsg@chromium.org,sczs@chromium.org

Change-Id: I69b15363426ecabb9712f182e617166d148566e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416874Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807935}

This adds identifiers to the ProgressBar icons and adds a
new path of updating the step using that reference.

This also adds a new way to define the progress bar as complete,
independent of which progress bar is being used.

Bug: b/168611883
Change-Id: Iabf3fa02d2904b3a0819561f00aab50f32be6b6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412338
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#807934}

This roll was done by
ios_internal/google_internal/frameworks/roll_frameworks.py
after changes in the following CL:
https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/3200150

This CL creates appropriate directories, which are required by
new roll_frameworks.py code

Bug: 1112956
Change-Id: I8ba15b15ef40d539b51d17dc16bbea1ec3eeb72a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337541Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807933}

Bug: 748410
Change-Id: I6ab9e1eabb776796342fdb94237d837fb309efd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414777
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807932}

* Add `GetNodeIdByElement` to webView
* Add `ExecuteGetComputedLabel` to Element

Bug: chromedriver:3507
Change-Id: I53c558d73c57b588e27a8cc20c270619121d7fb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410392Reviewed-by: Shengfa Lin <shengfa@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Maksim Sadym <sadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807931}

the system window server

On macOS, overlay backings (IOSurface) can be still used by the system
window server, after overlays are replaces by a new frame. So it is not
safe to return overlay resources to client without checking them against
the system window server. This CL addresses the issue by send released
overlay mailboxes back to SkiaRenderer with SwapBuffersCompleteParams,
and then return overlay resources when they are not used by the system
window server anymore.

This CL also turns on overlay render pass.

Bug: 1100728
Change-Id: I0a844f0b2542cb1f776ceda2ac2d5250916b697e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404077Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807930}

This improves chrome://policy page readability.

Screenshot of new chrome://policy page UI:
https://screenshot.googleplex.com/3W4hzapHNNCqttn

Bug: 1121478
Change-Id: Iee2d059d35cc00057bf5f3bfed9fa352ba8a7d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414257
Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807929}

This reverts commit 2346288a.

Reason for revert: Suspected cause of failures of password related tests (testSelectedStoredPasswordIndexIsSameAsInShowPasswordEntryEditingView) on android-marshmallow-x86-rel and others:

https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1349

Original change's description:
> Add field trial testing config for password and safety check
> 
> Make sure that tests which were not meant for Safety Check explicitly
> disable the feature.
> 
> Bug: 1070620, 1092444
> Change-Id: I83ba782b73cff33f6b4b6f5afa0df9d9e4db2fd6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410866
> Auto-Submit: Ioana Pandele <ioanap@chromium.org>
> Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Commit-Queue: Ioana Pandele <ioanap@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807803}

TBR=mpearson@chromium.org,ioanap@chromium.org,chouinard@chromium.org

Change-Id: Ia51936bc2889d9fc9a8423f8d3c3186358fb045d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1070620
Bug: 1092444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416930Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807928}

This reverts commit 9d75cd80.

Reason for revert: Suspect this causes AXPlatformNodeAuraLinuxTest.TestAtkPopupWindowActive failures on Linux Ozone Tester bots.

Original change's description:
> Enhances editing event intents by surfacing the input event type from Blink
> 
> For every editing operation in Blink, this patch exposes to the browser and to automation clients
> the "type" property of its input event from Blink.
> 
> The enumeration listing event intents was too long, and it included
> intents such as paste, type and replace.
> To make using intents simpler, the list of commands is now trimmed down to a few
> generic ones, such as insert, delete, format and SetSelection.
> For intents attached to text changed and text attributes changed events, more information
> is now provided in the intent's input_type member.
> Values are provided by a new enumeration that uses the same members as the
> W3C Input Events Specification.
> This makes the information more detailed, accurate, as well as standard's based.
> 
> The TextBoundary and MoveDirection enums were also modified to add the "kNone" member
> so that event intents such as "kClearSelection"  that have no boundary information and no directionality
> need not use them.
> 
> Finally, the equivalent struct that is used by WebKit for event intents on Mac was added, as well as a conversion function.
> 
> AX-Relnotes: n/a.
> 
> R=​dmazzoni@chromium.org, aleventhal@chromium.org, dtseng@chromium.org
> 
> Change-Id: Ifa2a94451596980cf36ecc13bb073ca7062e9587
> Bug: 989156
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401028
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Commit-Queue: Nektarios Paisios <nektar@chromium.org>
> Auto-Submit: Nektarios Paisios <nektar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807909}

TBR=dmazzoni@chromium.org,dtseng@chromium.org,nektar@chromium.org,rsesek@chromium.org,aleventhal@chromium.org

Change-Id: I86623c1259ab81890e4982d1de300f6642c7ceed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 989156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416814Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807927}

The input target receiver should be reset during Close. The widget is
GC'd so it can live longer but we shouldn't receive any messages after
the WidgetBase has been destroyed. This matches the lifecycle of the
receiver_.

BUG=1129309

Change-Id: I4c3a3076e6d03890e59255d471c73d0e59ffe056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416391Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807926}

Bug: None
Test: git cl format
Change-Id: I08b4db32c18a7d8dd88058f834bf66448f84b284
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413712
Auto-Submit: Hiroki Sato <hirokisato@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807925}

Move the last widget in //chrome/android/.../widgets/ to //components/
and delete the old directory.

BUG=1003941

Change-Id: I407f883ec4bf03e15d87c5753565567d8f9b9f27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410672Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807924}

Adds new tests for Schemeful Same-Site along with a virtual test suite
which enables the SchemefulSameSite feature.

Because Schemeful Same-Site only modifies the definition of "same-site"
it's adequate to test only a few cases that confirm the expected
same-siteness rather than try to thoroughly test all possible
`SameSite` situations.


Bug: 1127348
Change-Id: I9b914dd425bfb8cda6fc1ddc9f3606940f0b9a1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412907
Commit-Queue: Steven Bingler <bingler@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807923}

Screenshot: http://dr/file/d/1h746Ii3uaCombcXItnabwo-BQ6N7TSrv/view

Bug: 1124799, 1120093
Change-Id: I669745db424fd55b2453fe6def3aa6a72a1c9c51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414922Reviewed-by: Tanya Gupta <tgupta@chromium.org>
Commit-Queue: Sophey Dong <sophey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807922}

This will help ensure we have local access to the Google Sans although
the bots only verify this on Pixel devices, not on OEM devices which
retrieve Google Sans from GMScore. Currently there is only manual
verification for the latter.

Bug: 1115064
Change-Id: Ie3a2233e1dc972a10aaa4229a6d06ac2220607ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404852Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807921}

  * Convert gRPC keyboard events to ui::KeyEvents and dispatch
  * Add support for creating synthetic keyboard events to the
    test client.

(Note: Due to issues with webview focus I haven't been able to confirm
that  the events dispatch correctly, but the logic mirrors other input
events.)

Bug: internal b/161811385
Test: manual
Change-Id: I75f8b237cbde4f28c69f1a4d7257c4e8fe06d34d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416570Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807920}

Remove SpdyNetworkTransactionTest.ResponseHeadersVary because it brings
little value over already existing cache layer tests and HTTP/2 header
tests.

Add status line test SpdyNetworkTransactionTest.ResponseHeaders.

Remove :path from response (because it's a request pseudo-header)
in InvalidResponseHeaders.

Use SCOPED_TRACE(i) in both ResponseHeaders and InvalidResponseHeaders.

Change-Id: I3e638194ae0128b9a13389ffea82634a8f57c656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405698
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Auto-Submit: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807919}

This reverts commit 4b5732c0.

Reason for revert: Breaks linux-rel trybot. These files need to be is_chromeos as well:

https://source.chromium.org/chromium/chromium/src/+/master:chrome/test/data/webui/BUILD.gn;l=225?q=chrome%2Ftest%2Fdata%2Fwebui%2FBUILD.gn

Original change's description:
> Nearby Share: Update build files to limit to CrOS only.
> 
> For now Nearby Share is only planned to ship on CrOS and supporting
> multi-platform builds is quite costly.
> 
> Bug: none
> Test: none
> Change-Id: If879641d0d5b766f384f184078015eeabbf2215f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415135
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Reviewed-by: Richard Knoll <knollr@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Commit-Queue: James Hawkins <jhawkins@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807903}

TBR=jhawkins@chromium.org,khorimoto@chromium.org,gab@chromium.org,thestig@chromium.org,rockot@google.com,reillyg@chromium.org,msarda@chromium.org,emaxx@chromium.org,knollr@chromium.org,vecore@google.com

Change-Id: Ia362800da9ea21f994e38dcbc0dad4397fff81f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416891Reviewed-by: James Hawkins <jhawkins@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807918}

This test was disabled because it was flaky on Mac.

Testing indicates it's not flaky on any other platform
and is only flaky on the mac_chromium_10.12_rel_ng bot.

Bug: 988934
Change-Id: Iaa028f7792906db6ef7554f4a824f1810f706a1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393007Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807917}

Passing an async function to async_test will soon be disallowed in WPT,
as any asserts thrown will be turned into unhandled promise rejections
and the test will timeout. If a test needs async functions it should use
promise_test instead - however in this case the tests don't actually
need async functions (they don't use await or rely on promises).

Bug: https://github.com/web-platform-tests/wpt/pull/25540
Change-Id: I9be1f0b89350b611ed7db260e9ec5b79def03305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414758Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807916}

Change NVME to NVMe.

Bug: b:168687888
Change-Id: Ibc660ececc5d2fdf31eea3ed91c44a41172266c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410042Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Reviewed-by: Oleh Lamzin <lamzin@google.com>
Commit-Queue: Laurențiu Olteanu <lolteanu@google.com>
Cr-Commit-Position: refs/heads/master@{#807915}

This flag/feature is expired and unused.

Bug: 1110706
Change-Id: I64e3d44eb13572bff53421492fcaba8eaad91222
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415219Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807914}

The sync row in main settings page should launch sign-in screen when
there is no sync consent account in chrome. On the other hand when there
is an account present it should launch ManageSyncSettings page.

This cl adds a OnPreferenceClickListener for the sync row. Also the sync
row is always shown if there is a signed-in account present.

Bug: 1125464
Change-Id: I97fb6c3cca04654fde148e5c70b211fa3fc3bc27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398682
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807913}

Roll Chrome Win32 PGO profile from chrome-win32-master-1600171148-2256b3d9ffc2b53c8daccc3d78ab79199aeff8aa.profdata to chrome-win32-master-1600300188-843ccc7f4981299b9d59bff076f7994d3bf42fe8.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I3ca5c1dc348eb4d2a20890ecd8a817f1450ccdae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415735Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807912}

This CL is a small refactoring of the class IdentityDiscController.

Bug: 1127886
Change-Id: I00cca9a945c5fab454a4b0c4678173b9874ff57e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410490
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807911}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8e25d6ac..dbc042b1

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6f9cd32972748d838b18fd0925468778ef2bdff6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416252Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807910}

For every editing operation in Blink, this patch exposes to the browser and to automation clients
the "type" property of its input event from Blink.

The enumeration listing event intents was too long, and it included
intents such as paste, type and replace.
To make using intents simpler, the list of commands is now trimmed down to a few
generic ones, such as insert, delete, format and SetSelection.
For intents attached to text changed and text attributes changed events, more information
is now provided in the intent's input_type member.
Values are provided by a new enumeration that uses the same members as the
W3C Input Events Specification.
This makes the information more detailed, accurate, as well as standard's based.

The TextBoundary and MoveDirection enums were also modified to add the "kNone" member
so that event intents such as "kClearSelection"  that have no boundary information and no directionality
need not use them.

Finally, the equivalent struct that is used by WebKit for event intents on Mac was added, as well as a conversion function.

AX-Relnotes: n/a.

R=dmazzoni@chromium.org, aleventhal@chromium.org, dtseng@chromium.org

Change-Id: Ifa2a94451596980cf36ecc13bb073ca7062e9587
Bug: 989156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401028Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Auto-Submit: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807909}

Passing an async function to async_test will soon be disallowed in WPT,
as any asserts thrown will be turned into unhandled promise rejections
and the test will timeout. If a test needs async functions it should use
promise_test instead.

(The naming conflict is a sad historical legacy; WPT had async_test long
before EcmaScript spec'd promises!)

Bug: https://github.com/web-platform-tests/wpt/issues/21435
Change-Id: I6082d03b6821781ed62d274dc0ca0b2741d2d285
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414675Reviewed-by: Alex Turner <alexmt@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807908}

This is a reland of 0e23bba9

Make web_preferences.cc include v8_cache_options.mojom.h
instead of v8_cache_options.mojom-blink.h.

Bug: 919392, 1128983

Original change's description:
> Use mojom::V8CacheOptions instead of blink::V8CacheOptions
>
> Now we can use mojom::V8CacheOptiosn directly in Blink. So,
> this CL replaces all uses of blink::V8CacheOptions, then
> remove it.
>
> Change-Id: I636e0259d0b7da692bf693c3ec13f99dba9cd410
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409665
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#807427}

Change-Id: I9205469dcb039f3e8220a169d540a2af885a1312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413685Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#807907}

In preparation for the full launch of the Windows native spell checker
integration, this change enables the WinUseBrowserSpellChecker feature
by default.

Also fixes a few tests that were making assumptions about the code path
that was used inside the spellcheck provider, which no longer hold true
when the native spell checker integration is enabled by default.

Bug: 978460
Change-Id: I0cac4a5ab8384c03485fb827308e40598f0828b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413038Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/master@{#807906}

This test is now passing again. A skia change was rolled in that had
depended on a spirv-cross change, which has now also been rolled in.

Bug: 1126617
Change-Id: I86c9de10732cc39d7860cbc982186f5695a7e112
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412888
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Auto-Submit: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807905}

The warning is benign (warn about an empty block protected by an if)
but cause Xcode 12.0+ to consider the build as a failure (as soon as
the output contains the string "error", Xcode consider the build as
a failure).

Silence the warning until the dependency can be rolled (currently
blocked by the fact that mirroring from github is misconfigured).

Bug: 1129390, 1129393
Change-Id: I170de8cac0fa88612bac157737f7abd2fbfa4989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416273
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807904}

For now Nearby Share is only planned to ship on CrOS and supporting
multi-platform builds is quite costly.

Bug: none
Test: none
Change-Id: If879641d0d5b766f384f184078015eeabbf2215f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415135Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807903}

The test has non-deterministic output and cannot be rebaselined.

TBR=smcgruer

No-Try: True
Bug: 1129420
Change-Id: I36bebe78bb3b12e82a024175e9b298998177ca5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416392Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807902}

A misplaced underscore in a variable name breaks gn gen with enable_bazel_desugar=false,
thus remove the misplaced underscore.

BUG=1067278

Change-Id: I51948879637bf7e7b7dae471561c46564be1197e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416073Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807901}

This is a reland of a359d11d
This time, leave the force-off on non-tot bots in place unchanged,
and add a block to force-on on tot bots, and add a somewhat detailed
comment for why. Third time's the charm?

Original change's description:
> clang tot bots: Force-enable memoryssa-based dse
>
> Now that the flag is off-by-default again upstream, let's force it on
> on the tot bots to see if things work with it on.
>
> TBR=akhuang
>
> Bug: 1127713
> Change-Id: Ib9267b5123472b1c28280d858da7229b140a3b7e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415222
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807727}

TBR=akhuang

Bug: 1127713
Change-Id: I154cb9f12c2500e715fe9215bd87e96cc03c5040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416768Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807900}