- 31 Aug, 2020 40 commits
-
-
Mohamed Amir Yosef authored
... 1- SavedPasswordsPresenter 2- CompromisedCredentialsManager Bug: 1108422 Change-Id: I5beccb92538186d3d0958866110d64f3693386cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385276 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#803122}
-
Antonio Sartori authored
This CL implements the part computing the intersection of two sources of the Content Security Policy: Embedded Enforcement subsumption algorithm following https://w3c.github.io/webappsec-cspee/#intersection-source-expressions in the services/network Content Security Policy module. This is part of a series of CL implementing the whole subsumption algorithm according to that spec. Bug: 1094909 Change-Id: I835c42632cacfd884321ee43a2f2a06c31abab8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315687Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#803121}
-
Benoit Lize authored
We get the process creation time on Linux by reading /proc/PID/stat. On Android, this is allowed if PID == "self". Make the code allow that. Change-Id: Ib2d41f3c361c3d632cae450e79c1e3d6bcafa60a Bug: 691874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379743Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#803120}
-
adamta authored
Adds UMA histograms for any action taken in the Discover feed header menu. Bug: 1085419, 1122672 Change-Id: Ic9d4612af10b975a084bbb5b8416e23f048f747e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380413Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#803119}
-
Aaron Leventhal authored
TBR=dmazzoni@chromium.org NOTRY=true Bug: None Change-Id: Ic4a13ac76e42a2813d2c476c4bd552eb6b46b3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383690Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#803118}
-
adamta authored
Refactors infinite feed triggering by moving the conditional logic in the VC. Logs an action when user reached the bottom of the current feed, requesting a new set of articles. Bug: 1085419, 1122409 Change-Id: I99c734aaa5912e1d82e2330ec200593648fa8153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363219Reviewed-by:
-
Ewann authored
This CL adds the following actions to the ReadingList Context Menu: - Mark As Read - Mark As Unread - View Offline Version in New Tab Bug: 1093302 Change-Id: Ie17e58417738cbc5cc2c3a345c281464339170b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366799Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#803116}
-
Liquan (Max) Gu authored
Change: * Move calculateWhetherShouldSkipShowingPaymentRequestUi() and mShouldSkipShowingPaymentRequestUi into PaymentUIsManager because they are UI logic. Bug: 1102522 Change-Id: I0f91e56298fb211c55eff1efc5c33871173a5f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382653Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#803115}
-
Peter Kasting authored
Bug: 1123344, 1123345 Change-Id: Id0433c3defeadc07aaf35d81de1b37f965e0d8aa Tbr: jdonnelly Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385240 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#803114}
-
Sundoo Kim authored
Fix swapping argument to FromVectorIcon() in location bar. Bug: 1123344 Change-Id: Ib2ddcd50b5095d349f9d996f750e9b61f6c52860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385478Reviewed-by:
-
Martin Kreichgauer authored
WebAuthn Level 2 adds an enum-valued |resident_key| property to AuthenticatorSelectionCriteria. When making a credential, the existing boolean |require_resident_key| property indicates whether the browser should create a client-side discoverable (resident) credential. The new enum-valued alternative adds a middle value ("preferred") that yields a resident credential if the user's authenticator supports it, and a non-resident credential otherwise. Web-facing changes in this CL, i.e. the addition of the ResidentKeyRequirement enum as well as the resident_key property in AuthenticatorSelectionCriteria, are guarded by a new Blink feature flag (WebAuthenticationResidentKeyRequirement). Bug: 1117630 Change-Id: I89656a10a977023a4ca60b59ad1de5cd03800f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376570Reviewed-by:Matthias Körber <koerber@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#803112}
-
Scott Violet authored
The crash is happening because setTranslationY is being called when the InfoBarContainerView's tab is no longer active. This is problematic as when the tab is not active getBrowser().getViewController() returns null. Two fixs: . make SwipableOverlayView cancel the animation when removed. . make InfoBarContainerView handle this situation better. The latter is necessary as setTranslationY() is a public method, and may be called at any time. BUG=1121393 TEST=none (at the moment it's a bit hard to trigger this code path from tests). Change-Id: I95cd82f13efc07f81bec3a00b6c7513472bdbaea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382680Reviewed-by:Dominick Ng <dominickn@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#803111}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I97c18726ba379e806047cbb09e33f2bcf14f7a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382756 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#803110}
-
Peter Kotwicz authored
This CL updates the docs with function rename in https://chromium-review.googlesource.com/c/chromium/src/+/2350234 Change-Id: Ia08ca3ef4d8b9bafa5b78889a1571bd0ccadce79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384650 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#803109}
-
Kushagra Sinha authored
This is related to https://crrev.com/c/1903365 - with the additional check that |g_browser_process| may be abnormally shutting down without |chrome::IsAttemptingShutdown| being true - which happens only for a clean, user attempted shutdown. Bug: 1121894 Change-Id: I6d4aa7de8998ad0c621f0fc17a17853924cfd342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385437Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#803108}
-
Dylan Cutler authored
- Moves instrumentation to a separate function in an anonymous namespace. - Uses <initializer_list> library and for-range loops to reduce repeated code. Bug: 973801 Change-Id: Icf6df079e351e154ca8fd6f8872488993d6fc97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381135Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#803107}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8480e43b27e64c014641a55bcbe6288e4bb94a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803106}
-
Jinsuk Kim authored
Overscroll release without preceding pull requests causes null pointer deference in its scene layer when attempting to obtain resource manager instance. This CL prevents the crash by checking such incidence. Bug: 1119713 Change-Id: I83f4376aa2672c166c8ea693a8a4057b17bb44f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382994Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Auto-Submit: Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#803105}
-
chromium-autoroll authored
This is a reland of a0522042 Original change's description: > Roll DevTools Frontend from b6f22fe80638 to f36682af28e2 (1 revision) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b6f22fe80638..f36682af28e2 > > 2020-08-31 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: I36dc0e3b5f615bdce8a95973f1fbfd7ac8c61611 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384520 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#803028} Bug: None Change-Id: Ice6795e1cc4663a7b3c4dcfe8f9aa3b92c66fd1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385076 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#803104}
-
Hoch Hochkeppel authored
Adding a stub implementation of the mojom ShareService. Currently only for the Windows build, but intended to be useable as the central file from which OS-specific implementations can be connected (e.g. a future share_service_imple_win for the Windows-specific implementation). To exercise this code, enable the Web Share flag in chrome://flags, navigate to https://w3c.github.io/web-share/demos/share-files.html, and attempt to Share content. With this change, calls to navigator.share are completed with a cancellation error, rather than crashing the process. Bug: 1035527 Change-Id: Id01c2a49646fc9e64401f34fe886b2527866ebda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378144Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#803103}
-
Victor Hugo Vianna Silva authored
There was a spike in the flakiness of these tests following 2020-08-03. https://findit-for-me.appspot.com/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyagsSBUZsYWtlIl9jaHJvbWl1bUBzeW5jX2ludGVncmF0aW9uX3Rlc3RzQEVuYWJsZURpc2FibGVTaW5nbGVDbGllbnRUZXN0LkZhc3RFbmFibGVEaXNhYmxlRW5hYmxlT25lQXRBVGltZQw&show_all_occurrences=1 https://findit-for-me.appspot.com/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyZAsSBUZsYWtlIlljaHJvbWl1bUBzeW5jX2ludGVncmF0aW9uX3Rlc3RzQEVuYWJsZURpc2FibGVTaW5nbGVDbGllbnRUZXN0LkZhc3RFbmFibGVEaXNhYmxlT25lQXRBVGltZQw&show_all_occurrences=1 Bug: 1111227 Change-Id: Icdb31b999c89c5796bba63330816c44dc6d23a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383024Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#803102}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ic06815193acc870c4639a700f4726f2cd21e2699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385435Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803101}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Icb54c2f9e02ca7efc89d5674d22daed4ac1f971a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383022Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Iecad2dc339be6d352c3cf420a50b3f9c58cbe68f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382594 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#803099}
-
Andrey Zaytsev authored
Bug: 1123075, 1070620 Change-Id: Id3e1a4c13532a846332935c70cdc02059881ccb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385335 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#803098}
-
Maksim Ivanov authored
Drop std::move() call that has no effect and only triggers the "bugprone-use-after-move" clang-tidy warning. Bug: 1122844 Change-Id: I04d191a6a73964dbd58b61bce722d5885b140c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383021 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#803097}
-
Brandon Jones authored
These were accidentally left over from a removed change in a previous CL Bug: 1121762 Change-Id: Iff01ecbd0c78a96535cc0193d03e18eb04d98042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382115 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#803096}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I0af5f12d7e856ec1f128cbe7d5fd08035de6fe72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383654 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#803095}
-
Andrey Zaytsev authored
Bug: 1099233 Change-Id: I9a6a500c706d2a0bb48fdd8e844e2fce4b859da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382860 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
-
Peter Marshall authored
Change-Id: I06732b384f760a235f42078899e54c80123d4e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369312Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b4c90eee2f9f..6ec0b23923e9 2020-08-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from af56d31487bb to 0e98e894a84c (2 revisions) 2020-08-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 84714fcf to 1ca2f943 (3121 revisions) 2020-08-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 08291a3a9e22 to f428aa39ca2b (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I197ebed960b18ee6a853b971befd6a0cdf0a9218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384857Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/79257bae3c9a..19157ee4a2fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0c759755e080e359c4a3b847031e6445949fae86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385236Reviewed-by:
-
Peter Kasting authored
Instead of requiring consumers to use this, have them pass in a callback, and call it with the correct URL directly. This will facilitate further cleanups/simplifications later, e.g. the replacement of StyledLabelListener with setting a callback directly. Bug: none Change-Id: Ia45310b19b6df915739d5a3c9c5567afff029d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384078 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#803090}
-
Henrik Boström authored
Prior to this CL, it was the last event to fire before SLD/SRD's promise resolving. With this CL it fires according to spec, that is after processing all the state changes but before firing any other events. WPT test coverage added. Bug: chromium:1122561 Change-Id: Ie2558a214899814fe6dcdf29d6a628df5e42f171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379753 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#803089}
-
Alexander Surkov authored
DumpAccTree testsuite: utf16 to utf8 conversion, get rid of utf16 version of AccessibilityTreeFormatterBase::WriteAttribute Bug: 1115489 Change-Id: Ieeb4bcda323cdcc27e6a645ac3ab9742dc6e41f4 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364018Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#803088}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I987800bb2b59f29899c308125594d45b4d409a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382759Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803087}
-
Rob Buis authored
Introduce LayoutNGMathMLBlockFlow to mark the block flow as a MathML layout class, currently only used for operators (mo). A follow-up CL will introduce an UpdateFromElement method on it to deal with operator attribute changes. This CL does not yet introduce an operator layout algorithm (which will allow things like stretching) and falls back to the block layout algorithm for operators. Bug: 6606 Change-Id: I5ed10f7e27bdd08be2eb576d297067ac790241bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382601 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#803086}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45c7cc03636d..be19a45481cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kolos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kolos@google.com Change-Id: Ie8193db2cbc16ec72b9327c8fc1ae346b6d5ab88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384853Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803085}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e3e2618b1b05..c2cc4d305a7c 2020-08-31 ilnik@webrtc.org [adaptation] Expose target pixels and max framerate in VideoAdapter 2020-08-31 mbonadei@webrtc.org Move ABSL_MUST_USE_RESULT at the beginning of the method decl. 2020-08-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4bf6d398..a50ca66b (802598:802712) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1116430,chromium:1122891 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib9b42743db058e452398d48bb87b59ce8eb603ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384856Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit cd8566c8. Reason for revert: this CL didn't cause the problem. The root cause was a tricky infra problem. sorry for wrong revert. Original change's description: > Revert "OOR-CORS: Remove BlinkCORS related tests" > > This reverts commit 7d2bed26. > > Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190 > > Original change's description: > > OOR-CORS: Remove BlinkCORS related tests > > > > This patch removes network::features::kOutOfBlinkCors and > > network::features::ShouldEnableOutOfBlinkCorsForTesting() references > > from existing tests as now BlinkCors was deprecated, and we already > > turned down CORS fyi bots. > > > > This is part of the work to remove the kOutOfBlinkCors feature. > > > > Bug: 1053866 > > Change-Id: I4ba14005fd3fb310cbd246e6c0bd6cc18bd005d8 > > TBR: mkwst@chromium.org > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377633 > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#803029} > > TBR=falken@chromium.org,toyoshim@chromium.org,lukasza@chromium.org,karandeepb@chromium.org,mkwst@chromium.org > > Change-Id: I96044df30b8694433c6bad6e9eb719b949f6413e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1053866 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385075 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803044} TBR=falken@chromium.org,toyoshim@chromium.org,lukasza@chromium.org,kolos@chromium.org,karandeepb@chromium.org,mkwst@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1053866 Change-Id: Ic35fa6950fc52873ad3650ce836a015b2a274cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382761Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
