- 28 Oct, 2019 40 commits
-
-
David Benjamin authored
These are equivalent to window.screen[XY], which were measured in https://chromium-review.googlesource.com/c/chromium/src/+/1384047. Bug: 915620, 1016935 Change-Id: Iddfee602c9ffd4a360fa5bbca8a0366382c579d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874594 Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#709990}
-
Adithya Srinivasan authored
Couple of issues dealt with by this CL: 1) We should be starting the gesture from near the bottom of the page instead from the top (as it moves upwards) 2) In TouchInputTransferAcrossReactivation, we might get some scrolling in the main page before the first activation. We should be checking to see if it has scrolled more than that amount after reactivation Bug: 1010675 Change-Id: I6289549f1326a80896c8b78e6a66a724ac6dbeff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880077Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#709989}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f9d7f08e..32c0b43e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8e3cb4789c75874e444377cda0a35eabf3fe0cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884090Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709988}
-
Etienne Bergeron authored
This CL is replacing the hardcoded list of parens with a call to the ICU API to get the codepoints attributes. Splitting a run on brackets has the side-effect to ensures each bracket (matching bracket) is rendered with the same font. This avoid visual mismatch. The code to split text runs on brackets was introduced to fix this: https://bugs.chromium.org/p/chromium/issues/detail?id=396776 Unittests are added with some codepoints that were not included as brackets and should have been. Bug: 995789 Change-Id: I268cc62604d755d61da2c87dd597aabfc57b7ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881723Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#709987}
-
Joanmarie Diggs authored
* Create ax::mojom::Role::kCode, kEmphasis, and kStrong * Map to accessibility APIs as defined in Core-AAM specification Because it is up to content authors and toolkits/frameworks to style these roles as they see fit, font and format information will be exposed based on authoring. We cannot assume (and thus should not automatically expose) bold for the strong role or italics for the emphasis role. Bug: 1017195 Change-Id: I4fa6d300de27b01abd6c72742c4cf1ac90f63c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875520Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#709986}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c2493796361f..a78528cc1f2b git log c2493796361f..a78528cc1f2b --date=short --no-merges --format='%ad %ae %s' 2019-10-28 eseckler@google.com Merge "processor: Fix chrome build & legacy arg export" Created with: gclient setdep -r src/third_party/perfetto@a78528cc1f2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I78531682ebb6642c42d9ee2fce45a130acabe430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709985}
-
Mohamed Abdelhalim authored
It was the case that if ResetForCrossDocumentRestart is called before committing, OnCommitTimeout was called which crashed when trying to get the current RenderFrameHost. The introduced test failed with the same stack trace in the related bug before resetting commit timeout. Bug: 1006677 Change-Id: Ia1d08f792cbd9c3692533d69519cb6da7e21d102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879913 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#709984}
-
Anupam Snigdha authored
This reverts commit f87359ae. Reason for revert: https://crbug.com/1017694 Some legacy IMEs (ex: Yahoo Chinese IME) are broken with this change. Bug: 1017694 Change-Id: I0dceabbd5ee712c74aab113e912a3e629f79785a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880597Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#709983}
-
Roman Aleksandrov authored
Change behavior of auth error bubble and smart lock info bubble to make them appear on the right and left side. Make bubbles adjust to the height of virtual keyboard and tray. Bug: 888696 Change-Id: I882832b892e762db69708a65f4f2dd6063d0ef59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863093 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709982}
-
Yue Zhang authored
http://crrev.com/c/1815988 makes the PopupWindow focusable so that we can focus on EditText within TabGridDialog. However, there seems to be some inconsistent behavior when clicking back press in a focused PopupWindow among different Android APIs. This CL fixes this issue and adds a regression test. Bug: 1013974 Change-Id: I07575bb493d8627c6af2e7a64eb47acd08876ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874461 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709981}
-
Koji Ishii authored
This is a re-reland of crrev.com/c/1882249 because the path names of some -expected.png were too long on non-default Windows bots. Making this type of errors to be predictable is filed as crbug.com/1018801. * 3 crashes in native-file-system. * Mostly image rebaselines where scrollbar buttons became grayed when the scroll position is at begin/end. Probably someone fixed this. * A few pixel differences in rendering fonts, for vertical flow and "AM" in the date picker. TBR=ikilpatrick@chromium.org Bug: 1018587, 1018731, 1018749 Change-Id: Ib9bbcb4079b387c961ff01619218ecc56f9aca38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884390Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709980}
-
Luis Sanchez Padilla authored
prevent rubber banding. Rubber banding, or spring effect, often happens when recent point data evaluation generates a considerable deceleration producing velocity direction opposite to the current direction. This could happen because of noise in the input pipeline or a sudden stop by the input pointer. In order to mitigate this side effect, the current velocity vector is compared with the future velocity vector by computing the dot product between these two. If the result of the product is zero or less, it means that they have opposing directions and the prediction is cut off. Change-Id: I8a863475021f8531a7f2946325d458cad6d1138c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860329Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Luis Sanchez Padilla <lusanpad@microsoft.com> Cr-Commit-Position: refs/heads/master@{#709979}
-
Wez authored
Bug: fuchsia:27339, 821951 Change-Id: If685fd9817f8dae8671634f3798a655ddb2ba392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863774 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#709978}
-
Max Li authored
Bug: 923594 Change-Id: I1d2bfdb8b7067a7bf524e1e99cc90e2bda3429a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876735 Commit-Queue: Max Li <themaxli@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#709977}
-
Evan Stade authored
Bug: 268984 Change-Id: Ied766d3006009fbd5534eca799bf095bf48dbc28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876083 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#709976}
-
Peter Kotwicz authored
This CL re-enables TrustedWebActivityTest#testStatusBarColorCertificateError() TrustedWebActivityTest#testToolbarVisibleCertificateError() - It modifies the tests to use different origins for "pages without a certificate error" and "pages with a certificate error". This is now necessary due to http://crrev.com/c/1872423 - Uses host-resolver-rules command line flag in order to use multiple origins in tests. The command line flag has the side effect of causing "redirected-urls" to throw a certificate error when navigated to - It also fixes a bug with the testStatusBarColorCertificateError() test on Lollipop BUG=1016743,1016746 Change-Id: I20bbfdd7828c243af991e62f9c7d9a173d326c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876872Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#709975}
-
Robert Liao authored
Upward ancestor traversal by class name is not a common pattern used in Views clients. BUG= Change-Id: If0aefc9084836526225441a4d8f15131b7c1f3fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881888 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#709974}
-
Clark DuVall authored
The PrefetchURLLoader's lifetime is managed using mojo::MakeStrongBinding, which means it may live until after the BrowserContext is destroyed. Instead of keeping the browser context around to check if signed exchange is allowed, we check in the constructor and cache the value. Bug: 1016373 Change-Id: Ia6722ed37a8213078be856b11b9dde70ef230e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881379 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#709973}
-
Steven Bingler authored
This changed modified the test fixture, CookieSettingsTest, to both add a feature-list and disable kSameSiteByDefaultCookies. This prevents tests from breaking when cookies become SameSite-by-Default. Bug: 1016512 Change-Id: I4a31ae48467f79883b58fa275478a5e5a58e61ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877253 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#709972}
-
Albert Chaulk authored
The embedder implementation assumes that channels are persistent and set up ahead of time, so now we track RenderFrameHosts for our WebContents and dispatch channel events to every frame Bug: b/141864193 Test: on device with weather Change-Id: I74182d226fae7d6d63b618aa92f60fadb9516d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881671Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#709971}
-
Simon Que authored
These entries were added in: https://chromium-review.googlesource.com/c/chromium/src/+/1875857 They were incorrectly labeled. Bug: 950413 Change-Id: I033401f51da5bb420b7af5a6590f51d649ca8180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884391 Auto-Submit: Simon Que <sque@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#709970}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::MhtmlFileWriter with replacing AssociatedBinding and MhtmlFileWriterAssociatedRequest with AssociatedReceiver and PendingAssociatedReceiver. Bug: 955171 Change-Id: I55f3209dcddbaa734e029ec34b881015bd5a2d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880207 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#709969}
-
Peter Kasting authored
Bug: 82078 Change-Id: Ie0f4f0c7a5a78eb8a5086721b6146c00401034ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879996 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#709968}
-
Sergio Villar Senin authored
In order to remove the WebContextMenuData dependency from chrome/browser we need to extract all the data types used in c/b from web_context_menu_data.h and move them to different files under third_party/blink/public/common. WebContextMenuData::EditFlags is moved to a different file under public/common so that chrome/browser does not depend on public/web. This is the last step of the web_context_menu_data.h dependency removal from chrome/browser so we're safe to remove it from DEPS file. Bug: 1014517 Change-Id: I32bc847b596de9558607700288b650bd557b9318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878252 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Manu Cornet authored
Also add a test. Bug: 1018363 Change-Id: I99b2a24b7cd292ac1ec3963d0ebdb343591a5a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881231 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#709966}
-
Andrew Xu authored
There is a loophole in scrollable shelf's code: if the incoming gesture event is not handled by neither scrollable shelf nor shelf view, the scroll status is not reset. Because resetting the scroll status relies on the gesture end event while the scrollable shelf view will not receive the gesture end event if it is not the correct event handler. This CL fixes such an issue. Bug: 1012888 Change-Id: I98927dd068b6dd75008936eb8bee9f5249091f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882560Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLStyleElement> and DynamicTo<HTMLStyleElement> as new downcast helper 2. Use IsA<HTMLStyleElement>(element) in place of IsHTMLStyleElement(element) Bug: 891908 Change-Id: I6c41fe0a6b0efd5f00580b154cb740e1070b513b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880997 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#709964}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d6f6ff7083d1..d039ea0c1799 git log d6f6ff7083d1..d039ea0c1799 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 khokhlov@google.com [tracing/ui] Truncate long thread names instead of showing ellipsis 2019-10-28 simonhatch@chromium.org Dashboard - Add a cron job to update sheriffs Created with: gclient setdep -r src/third_party/catapult@d039ea0c1799 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1014544,chromium:1006252 Change-Id: I6509bdf1aef35ed64adce52d1299ecbccc4b6a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883779Reviewed-by:
-
Anastasia Helfinstein authored
The deps/externs for various files got out of sync with what was actually being used. This brings those back to sync. Bug: None Change-Id: I1c1bf99abf3825e4e2acca7945a482cf98021bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877147Reviewed-by:
Chris Hall <chrishall@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#709962}
-
Peter Kasting authored
Also shortens/cleans up some existing code (no functional change). Bug: 82078 Change-Id: I4d3ee878d6c4f6e301dcaaa19e5fc7877bb1b5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881696 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#709961}
-
Caroline Rising authored
Bug: 1013958 Change-Id: Ic653e7febf1161b23ed1ccc0e2f2b4fecc1f7817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880584 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#709960}
-
Changwan Ryu authored
When you click a node, it takes some time before the node can be focused. This was not properly considered and caused the flakiness. Test: tried 100+ times on Pixel 2 XL. 50% flakiness --> 0%. Bug: 990209 Change-Id: I6e209495931b51381c04230cd49ac080674206fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880371Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709959}
-
Juan Antonio Navarro Perez authored
Had written these, but forgot to upload before landing: https://chromium-review.googlesource.com/c/chromium/src/+/1879207 TBR=crouleau@chromium.org Bug: 1001038 Change-Id: I8794343b81129e18736277bad88c23088e3b18fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883722Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#709958}
-
Peter Wen authored
Since //components/sync/driver:resources has been broken out of //components/resources as a separate target and separate pak file, it needs to be added back into the iOS app bundle. This fixes the missing iOS dependencies from: https://crrev.com/c/1864564 Bug: 1016465 Change-Id: I0274f5575fd02e0e344fc48619dd05cfda37e51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883119Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709957}
-
Adam Ettenberger authored
AXPlatformNodeBase::UpdateComputedHypertext was using an expensive path to navigate unignored children. Replacing use of |ChildAtIndex| with |GetFirstChild| and |GetNextSibling| when iterating unignored children. Now instead of having to walk over all children up to the Nth unignored child for each iteration, it will find the first unignored child, then chain finding each unignored sibling. For the scenario I was measuring, this CL reduced the overall amount of time spent in AXTree::Unserialize by ~77%, and time spent in AXPlatformNodeBase::UpdateComputedHypertext by ~90%! I crafted a document where loading the document resulted in Unserialize having to process ~40k AXNodeData items in one AXTreeUpdate. I used "UI for ETW" to capture perf traces, and WPA to view the data. Before : * Weight in callstack of AXTree::Unserialize : 6424 * Weight in callstack of UpdateComputedHypertext : 5449 After : * Weight in callstack of AXTree::Unserialize : 1457 * Weight in callstack of UpdateComputedHypertext : 447 Bug: 1017829 Change-Id: I0edd29f4bba4811942a96c4f65fa96401dd10cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879767Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#709956}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5cb7807a3692..cff20c2615d8 git log 5cb7807a3692..cff20c2615d8 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 sprang@webrtc.org Adds protected bitrate helper methods to RtpRtcpImpl 2019-10-28 hbos@webrtc.org Reland "[PeerConnection] Use an OperationsChain in PeerConnection for async ops." 2019-10-28 brandtr@webrtc.org Add .clangd to .gitignore Created with: gclient setdep -r src/third_party/webrtc@cff20c2615d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ia38756d59f194fa460075ec01c534f6bb712f1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883780Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/225301d6dc53..0964988b77ab git log 225301d6dc53..0964988b77ab --date=short --no-merges --format='%ad %ae %s' 2019-10-28 jmadill@chromium.org Fixups to ANGLE_get_image boilerplate. Created with: gclient setdep -r src/third_party/angle@0964988b77ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: Id68127d55be33b570e48139be1ea903d987ff894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882813Reviewed-by:
-
Aidan Beggs authored
This CL ensures that all safety tip heuristics are always run, in lieu of the previous short-circuiting behavior, in preparation for recording metrics. This CL also refactors the reputation check results out into a wrapper struct, to cut down on the number of variables that need to be passed down the call chain. Finally, this CL fixes a few miscellaneous typos. Bug: 1014598 Change-Id: Ibeda24f817f46d8d36f23fab60f30615821e544f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881126 Commit-Queue: Aidan Beggs <beggs@google.com> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#709953}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/91527d03092e..3c3f17f3c2e1 Created with: gclient setdep -r src-internal@3c3f17f3c2e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ifb6c7cb14773711de118fed190f98c045b095cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882030Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709952}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/428b5de64a08..18f5b1a6dd77 git log 428b5de64a08..18f5b1a6dd77 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 rmistry@google.com [Android compile bots] Add comment to CL when both nopatch and withpatch builds fail Created with: gclient setdep -r src/third_party/skia@18f5b1a6dd77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: None Change-Id: Iac5e0d82476d9d05b74ae08ccf53905ef6d6c6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883776Reviewed-by:
-
