GitLab

descendants.

When <foreignObject> was made a stacking context, it also had the side-effect of
painting it at the same time as positioned elements. This is a change to painting
order and caused a regression. Instead, implement a new mechanism by which a
"replaced normal-flow stacking" element paints during the foreground phase
of the LayoutObject paint tree walk.

This is used for now just for <foreignObject>, but may be applied to other
replaced elements such as iframes or embedded objects in the future.

Bug:842668

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I450944986abfb6610084444abf2724e7406145cf
Reviewed-on: https://chromium-review.googlesource.com/1060333
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559401}

R=mmoroz@chromium.org,liaoyuke@chromium.org

Bug: 843183
Change-Id: I194ad5ccfa7f6145beccc1f4b4c0e083e4f5c681
Reviewed-on: https://chromium-review.googlesource.com/1063120
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559400}

Add a new MediaLog level so that we don't have to abuse MEDIALOG_ERROR,
which could end up in MediaError.message and should be carefully used.

Also update documentation on MediaLog levels.

Also use MEDIALOG_WARNING in audio_timestamp_validator.cc for non-fatal
issues.

Bug: 843808
Test: Manually tested and verified in about://media-internals
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I20350d305b3f55d1f59e6d2324cc3be7452bcbbe
Reviewed-on: https://chromium-review.googlesource.com/1063009Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559399}

https://chromium.googlesource.com/catapult.git/+log/07bcf9fc1678..78fd93090e2f

$ git log 07bcf9fc1..78fd93090 --date=short --no-merges --format='%ad %ae %s'
2018-05-16 sullivan Implement gerrit_service.PostChangeComment

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I877559f12f54994c3fe6e4f05ec5e664474e0733
Reviewed-on: https://chromium-review.googlesource.com/1063175Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559398}

Previously, when a Textfield instance changed its text direction, no
change was made to its horizontal alignment. Now,
ChangeTextDirectionAndLayoutAlignment() calls
SetHorizontalAlignment() with the correct alignment based on
text direction.

Text direction   Horizontal alignment
Right-to-left -> Aligned right
Left-to-right -> Aligned left

This fixes a bug where toggling RTL in a Textfield did not change the
text writing direction.

A unit test was also added to test
ChangeTextDirectionAndLayoutAlignment(). This test checks that a call
to the method properly updates the textfield's text direction and
horizontal alignment.

Bug: 841123
Change-Id: I8dadc1272a3474dc72ae9470bdc7d9949e8fd854
Reviewed-on: https://chromium-review.googlesource.com/1060626
Commit-Queue: Tessa Nijssen <tnijssen@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559397}

This is an obvious coding error, the wrong variable was used for
checking if an iterator was empty. Depending upon if a specific bit was
set in that random memory location, then we'd get the right/wrong
behavior.

Bug: 842196
Test: Icons load (although they usually did before)
Change-Id: Ie52747f0b03e82ba2915df3f8ce9198a9a22452f
Reviewed-on: https://chromium-review.googlesource.com/1062199Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#559396}

This change adds more descriptive mount errors in order to display more
detailed reasons for a failed mount to the user.

Bug: chromium:757625
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I11d46ca74d40d77276bce6839899ac723b3b77c6
Reviewed-on: https://chromium-review.googlesource.com/1060428
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559395}

BindingManager.java is not in use by the target defined in Chrome
build any more. This CL removes the corresponding DEPS exception rule.

Bug: 617324
Change-Id: I1c0a35d6f950d237b72b33c2dad69847d5bfc50c
Reviewed-on: https://chromium-review.googlesource.com/1060719Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559394}

This CL fixes the review nits in
https://chromium-review.googlesource.com/c/chromium/src/+/1049126

Bug: 788051
Change-Id: Ie05dfc59896f528408ef305c9f56cadfafa587d0
Reviewed-on: https://chromium-review.googlesource.com/1058737Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559393}

Some native functions don't have names in their toString, so now
we use the identifier the user typed in as a fallback.

Change-Id: I79ad4e630a39ff23a109485ea5afded9d660d54e
Reviewed-on: https://chromium-review.googlesource.com/1063037Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559392}

R=dpapad@chromium.org
BUG=843736

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I900160ee6481b1b7d034e5b105afb6087c317a31
Reviewed-on: https://chromium-review.googlesource.com/1063042Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559391}

Bug: 826213
Change-Id: I11392bd9b865a4026470caa0dd613a860ade48ed
Reviewed-on: https://chromium-review.googlesource.com/1063006Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559390}

|handleInterceptLoadurl| defined in OverlayContentDelegate seems to
have ended up not being overriden at all, and always return false.
This CL deletes the interface and simplifies the callsite.

Change-Id: I880634cb284376742602836699f7dc862a9ce60d
Reviewed-on: https://chromium-review.googlesource.com/1060774Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559389}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f6054012..5cc09ffc

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ife3c47dccaeaea4bde12bdabc6cf0e8c1925603b
Reviewed-on: https://chromium-review.googlesource.com/1062125Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559388}

https://swiftshader.googlesource.com/SwiftShader.git/+log/2a0def7..c8403ec

BUG=chromium:841296

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel

Change-Id: I3e6d72c823a849eca2b4f46cd28599c4d585a174
Reviewed-on: https://chromium-review.googlesource.com/1062287
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559387}

SetCurrent stack trace crash key shows that we set a null context in
ReleaseCurrent in SetDrawRectangle. Remove the debugging code there, and
add explicit CHECKs before and afer SetDrawRectangle. Also alias surface
handles associated with the surface because a logic error there could
cause MakeCurrent to be skipped.

Bug: 724999
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I91a0bd0f410690e7f8b1b2e6429d52c223ab851f
Reviewed-on: https://chromium-review.googlesource.com/1050880
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559386}

linux_chromium_asan_rel_ng used -j150 in buildbots.
https://chromium-review.googlesource.com/c/chromium/tools/build/+/860278

Change-Id: Ia087d08bd9bea25b1a076a0e55378a9bbf7de074
Reviewed-on: https://chromium-review.googlesource.com/1060940Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559385}

Activating windows allows popunders, and is disallowed in Chromium.
Ensure that we do not activate a window when we show a chooser
bubble.

BUG=838314

Change-Id: I052adb7b4bc37a439961059ab95670edcf85cd69
Reviewed-on: https://chromium-review.googlesource.com/1059451
Commit-Queue: Ben Wells <benwells@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559384}

Patch is as small as possible for merging.

Bug: 842990
Change-Id: I9968ffee1bf3279e61e1ec13e4d541f713caf12f
Reviewed-on: https://chromium-review.googlesource.com/1062935
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559383}

Replaces our use of cros_vm directly. Needed because going through
cros_run_vm_test.py gives us smarter VM-bootup logic. cros_vm.py lacks
this is and is rather dumb.

Also bump timeout of cros-vm bot's timeout on telemetry unittests by a
few min. (Added in this CL 'cause all of this is aimed at getting
telemetry_perf_unittests stable.)

Bug: 839187
Change-Id: I3fe6a8ec52d4a6f47b8b1ef475390346aa920ec3
Reviewed-on: https://chromium-review.googlesource.com/1062590Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559382}

https://chromium.googlesource.com/angle/angle.git/+log/21386a349acc..0e1c158ed0e6

$ git log 21386a349..0e1c158ed --date=short --no-merges --format='%ad %ae %s'
2018-05-16 ynovikov Log error of RegisterClassA in DisplayWGL::initialize
2018-05-16 ynovikov Revert "Don't double-terminate a display."
2018-05-14 lucferron Vulkan: Implement copyImage and enable all tests for it
2018-05-14 lucferron Vulkan: Finish implementation of the copySubImage
2018-05-14 lucferron Vulkan: Implement PACK_STATE dirty bit and remove warning

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I6cf729cc19105c4b6c06f9cd02858c77b25028fd
Reviewed-on: https://chromium-review.googlesource.com/1063020Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559381}

Actually cover the code which reads luci-milo.cfg.

Bug: 843842
No-Try: True
Change-Id: Icd0fcaa2b6037c1ae3560a8ddb6e6ba777b3ac80
Tbr: thakis@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1063270
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559380}

What the logic does:
- Gets favicons for every cell
Todos:
- Cancel favicon requests for cells that leave the page
- Refactor FaviconLoader to use LargeIconService and NSCache
- Cancel all pending requests when the user leaves the Recent Tabs Page
- Prefetching
- give "Show full history" cell it's own cell. Currently clashes by implementing with UrlCell

Screenshot: https://drive.google.com/open?id=1LD70rytXsaKoK0aJp0OhqBZOerq-FY5o

Doc: https://docs.google.com/document/d/1-c4YEmRta2qcg2HC9VzQZoeI9CBG3yccfN3GBITU910/edit#

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic5515194dd3040ec48857a69f73222fb4aaa6e97
Reviewed-on: https://chromium-review.googlesource.com/1025311Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559379}

Currently, there is a edge case where we may lose the context_provider
before we have set the callback to reset the frame sink. This change
guards against that, but in the future, we want to move
|frame_sink_destroyed_callback_|'s initialization to VideoFrameSubmitter's
construction time.

Bug: 842432
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1437d2b91f416ff5f2f310530d6443f8f8014213
Reviewed-on: https://chromium-review.googlesource.com/1058341Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559378}

|is_protected_video| is added to the GL command buffer function interface of glScheduleDCLayer and
the DCRendererLayerParams structure. The default is false for now and will be used later for
Windows to support protected video decoding.

When is_protected_video is true, the video content should be protected by hardware until it is displayed.

BUG=843814

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib441af24c3be32d8ae41944d3a410364f804dd25
Reviewed-on: https://chromium-review.googlesource.com/1056629Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559377}

Similar to how we dismiss the app list when launching a Crostini app or
terminal from the main list of apps, we should also dismiss it when
launching from search or the recently used app list.

Bug: 839207
Change-Id: I2968e827c6feacb7e58660a0784463d091bf90e4
Reviewed-on: https://chromium-review.googlesource.com/1060834Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559376}

This CL moves top/bottom bar control updating to a separate
UpdateControls method in RenderWidgetHostViewAndroid. If surface sync
is on then it gets called in DidUpdateVisualProperties, and if surface
sync is off it continues to get called in OnFrameMetadataUpdated.

Change-Id: Ieb4926a4393686db05afd153ec243b72a85c45c7
Bug: 672962
Reviewed-on: https://chromium-review.googlesource.com/1062084
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559375}

We'll enable to see if it they still flake or not.

Bug: 715632
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I2a305db1120d98b1a1bb632bb4c2e1315a2571b2
Reviewed-on: https://chromium-review.googlesource.com/1063105Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559374}

This adds master mixins for:
* chromium
* chromium.chromedriver
* chromium.lkgr
* chromium.swarm

Bug: 840631
Change-Id: Ia615d68243c114bc61b44ec2179e1b5830ea02d5
Reviewed-on: https://chromium-review.googlesource.com/1063167Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559373}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/4c1562dfdeef..966fe62677b1

$ git log 4c1562dfd..966fe6267 --date=short --no-merges --format='%ad %ae %s'
2018-05-14 ayatane sysmon: Add ignored metric to prod manifest
2018-05-16 bmgordon build_stages: Handle exceptions in snapshot commands
2018-05-16 manojgupta cros_fuzz_test_env: Fix cleanup option.
2018-04-27 dgarrett remote_try: Rename to request_build.
2018-04-27 dgarrett remote_try: Rearrange a little.
2018-04-26 dgarrett cros_tryjob: Move tryjob specific logic into cros tryjob.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:None,chromium:843441,chromium:843627,chromium:824550,chromium:824550,chromium:824550


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ibd98b2152ec46624b2c80e06bb60514e17ca9e2a
Reviewed-on: https://chromium-review.googlesource.com/1063030
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559372}

Adds content::AuraWindowVideoCaptureDevice, which provides screen
capture of aura::Windows that have compositor frame sinks associated
with them. Then, for Chrome OS browser window capture, where a CFS is
not available, use a fall-back window capturer impl instead. The
intention is for the LameWindowCapturerChromeOS to be a temporary
solution until more work is complete on services/ui/ws (the new Window
Service).

Note: This change does not activate the new impl yet. A follow-up
change will switch from the legacy impl to the new impl.

Bug: 806366
Change-Id: Ia6aa81e4addde603b120a6ab61c5e35a0041b418
Reviewed-on: https://chromium-review.googlesource.com/1006366
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Adam Parker <amp@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559371}

This increases stability of chunk ids under subsequences to reduce
full chunk invalidation because of chunk id changes. This especially
improves chunk id stability that was reduced by crrev.com/c/1027209.

This also helps to stabilize composited layer ids for SPv2, though
I need some more work for it (crbug.com/842356).

An example:
  Paint N-1:
  {
    ScopedPaintChunkProperties properties1(id1, same_properties);
    PaintBackground();
  }
  {
    ScopedPaintChunkProperties properties2(id2, same_properties);
    PaintForeground();
  }

  Paint N:
  {
    ScopedPaintChunkProperties properties2(id2, same_properties);
    PaintForeground();
  }

Previously, in Paint N-1, we combined both background and foreground
in chunk(id1), and in Paint N, we painted forground in chunk(id2).
Because the paint invalidator saw that chunk(id1) disappeared and
chunk(id2) appeared, it issued full chunk invalidation for
chunk(id1) and chunk(id2).

With this CL we'll force chunk for background and foreground, so
we'll issue chunk invalidation for the background only.

Measurements:
For all compositing and paint layout tests, this increases total
number of chunks from 3390 to 3676. (For comparison,
crrev.com/c/1027209 reduced the number from 4055 to 3390.)

Bug: 838456,842356
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4e9809fee46364189845b293706ff70554f562ba
Reviewed-on: https://chromium-review.googlesource.com/1040876
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559370}

Implementing custom caption bar as there will likely be motion specs
requiring unique animation.

Close button not currently wired up.
Demo in bug.

Also fixed a height issue with DialogPlate.

Bug: b:79440488
Change-Id: I6eecff9c48c231e1b1d8aaea026baca09979b7ca
Reviewed-on: https://chromium-review.googlesource.com/1062185Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#559369}

This reuses a lot of the existing code for shapes located within
core/layout/shape.

As a result of this after we perform a layout on a float, we need to
copy some additional shape data back into the existing tree so that the
ShapeOutsideInfo is up to date.

Devtools currently requires the ShapeOutsideInfo object to be up to
date for the appropriate LayoutBox object. (This is used to draw the
"shape area" when hovering on an element within devtools).

In the future (once everything has a NGLayoutResult) we'll likely be
able to remove the ShapeOutsideInfo object, and replace it with just a
"computed shape" living off the NGLayoutResult.

The majority of the work is done within ng_layout_opportunity.cc which
calculates a new line-layout-opportunity based on the shape area.

The rebaselines in this patch:
spec-examples/shape-outside-{010..019}-expected.txt
... are for "change detector tests". We do pass them in LayoutNG but
"better". (We place things closer to the shape typically). One LayoutNG
has been switched on we can fix/change these tests.

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I029b1503be74b4a17e0a634ec93c644ff4352358
Reviewed-on: https://chromium-review.googlesource.com/1032884
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559368}

Bug: 733662
Bug: 824429
Change-Id: I58b625aac5c07d0d3a0d2bd0a2a40c0d52011cb7
Reviewed-on: https://chromium-review.googlesource.com/1059977
Commit-Queue: Jiaquan He <hejq@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559367}

Rather than plumbing around an int64_t for color, using a magic value to
represent an invalid/null color, just use base::Optional.

This simplifies the code in a number of ways:
- No more magic values
- No need to assume that all non-magic int64_t values fit in a uint32_t
- No more reinterpret_cast<uint32_t&>

The conversion helpers are consolidated into color_helpers.h and shared
as well.

Bug: 836683
Change-Id: I09ac717f3c852c63680a2c1c561ee8e2fed98777
Reviewed-on: https://chromium-review.googlesource.com/1050994
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559366}

Ensure that click-to-script functionality is only applied if the feature
is enabled. This guarantees that users have an escape hatch.

Bug: 841465

Change-Id: Ieaf7aa19af449329f536fc46ec3b4dedf09c66b8
Reviewed-on: https://chromium-review.googlesource.com/1053049Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559365}

https://chromium.googlesource.com/catapult.git/+log/a7e134aa0dbf..07bcf9fc1678

$ git log a7e134aa0..07bcf9fc1 --date=short --no-merges --format='%ad %ae %s'
2018-05-16 szager Add linux support for interval profiling
2018-05-16 benjhayden Add iron-icons to third_party/polymer2.
2018-05-16 simonhatch Histogram - Cache info types

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:839645


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I506c9407ed2cebcdce0ff04dacf5e1e68a849206
Reviewed-on: https://chromium-review.googlesource.com/1062936Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559364}

SignedExchangeDevToolsProxy sends the SignedExchangeHeader and the certificate
information and the error messages to DevTools.
When the user clicks a signed exchange response in Network panel, these
information will be displayed in the Preview panel.

And the network grid view will show “from SignedExchange” in the size column of
the content of the signed exchange like “from disk cache”.

See the doc for more details: https://bit.ly/2HXVbCU

This CL depends on https://crrev.com/c/1029755

Bug: 830505
Change-Id: Ice3743f2e1675b6d604eeaba731ebd8494c2b5a1
Reviewed-on: https://chromium-review.googlesource.com/1004890Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559363}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I7aa131974aa56db2faf380da90b06a015a928f3d
Reviewed-on: https://chromium-review.googlesource.com/1063038Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559362}