- 04 Oct, 2019 40 commits
-
-
Joshua Peraza authored
c87486f5951f android: insert app_process at start of handler argv Bug: chromium:1011145 Change-Id: Iff8d18b6401f2002ac908b02dfb7e0c49d5f8a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842432 Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#703069}
-
Sergey Ulanov authored
FuchsiaDecryptor::CancelDecrypt() was trying to use |audio_decryptor_| even if it wasn't created. Bug: b/141148085 Change-Id: Ib015ba1739cb5b57a5b4174d2732e5ccc3568005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842114 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703068}
-
Matt Wolenetz authored
Long ago, this method could return false if internal buffering detected a problem in the buffer sequence/metadata being appended. With the MseBufferByPts-related cleanup, this method was made to always return true, with a note that it might in future return false if one current CHECK is changed to a DCHECK. This CL asserts that that CHECK is necessary to verify a key assumption hasn't regressed in release builds, and changes the interface to void to match current logic and usage. BUG=580621 Change-Id: Ie81d6f1681b65ca93e6af1f21d6f2289c6c0b7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841237 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#703067}
-
Erik Chen authored
This CL avoid future nullptr dereference in test-only code. The methods SetEditCommandForNextKeyEvent and ClearEditCommands now do nothing if this is a proxy main frame. Bug: 912193 Change-Id: I657854b35f7995bf304ee3b9cbc502390379877b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838256Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703066}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8a859625577b..37c463fe9c3a git log 8a859625577b..37c463fe9c3a --date=short --no-merges --format='%ad %ae %s' 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@37c463fe9c3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ifa4504ebbe747cd19c252ecc0ec856968c5bb819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841500Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703065}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6563c7fb. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" afc509ca "[WPT/common/security-features] Fix typo" df884b61 "[WPT/referrer-policy] Add worker subresource tests" 86ea3d5b "Renaming fetch/metadata web platform tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I176d0f9ba1bf2accbbba1db7da1c40b0ebaa0c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842411Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703064}
-
Peng Huang authored
When GL and Vk interop is not supported, we need copy pixels between GL texture, VkImage and SHM manually. This CL implements SHM to GL texture copy. It is useful for using video element as gl texture. Bug: 1003794,1001616 Change-Id: I5825c6211cf11068426b03b071cdb757eb29e46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838913 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703063}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. FrameInputHandlerImpl only needs the RenderWidget to perform coordinate transforms. This functionality is now exposed on RenderView, and undead RenderWidget will no longer exist in the future. Bug: 912193 Change-Id: Ibc3b0528c1539dd286558de52a7141161d46fe29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838536 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Avery Musbach authored
Change-Id: Ibb8ad64dedea07970ead5d75c9fdb06a6ffc7bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841576Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#703061}
-
Xiaoqian Dai authored
It's a class to temporarily block event targeting for a window. There can be multiple ScopedEventTargetingBlocker placed on the same window and when that happens, the original event targeting policy will only be restored after all ScopedEventTargetingBlockers are removed from the window. No functional change in this CL. This CL will be useful in my another CL for Bug 997885. Bug: 997885 Change-Id: I5f77eb001428be896570d5f3a5b92d98465374a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835279 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#703060}
-
Daniel Hosseinian authored
The new string is a placeholder and the final string will be determined in the near future. Bug: 989978 Change-Id: Ic05143effb26715a241c1dbe3bc3bc3492f78ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841763 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#703059}
-
Fred Mello authored
Moved logic from ModuleInstallerConfig to BuildConfig (template). TBR=fredmello #trivial refactor Bug: 1005802 Change-Id: Iee0a409105c42bebac88d6d92ef227391697ff49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841694 Commit-Queue: Fred Mello <fredmello@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#703058}
-
Matt Mueller authored
It is replaced by two functions: CreateSystemVerifyProc: Creates a verifier that uses the system-provided certificate verification functionality. This function is not defined on platforms that such integration does not exist. CreateBuiltinVerifyProc: Creates a CertVerifyProcBuiltin. This function is not defined on platforms without trust store integration. Bug: 410574 Change-Id: Ic722992c9f260a1160fa441b335f6a789f428d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836603Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#703057}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6b60dfd80e3d..f7ad03aa869b git log 6b60dfd80e3d..f7ad03aa869b --date=short --no-merges --format='%ad %ae %s' 2019-10-04 m.maiya@samsung.com Vulkan: Enable a few polygon offset tests in dEQP 2019-10-04 jmadill@chromium.org Revert "Add export_targets.py to presubmit" 2019-10-04 timvp@google.com Only Enable Pixmap Support for Unix (or compatible) 2019-10-04 bsheedy@chromium.org Add export_targets.py to presubmit 2019-10-04 jdarpinian@chromium.org Enable unfold_short_circuits workaround on Apple. 2019-10-04 cwallez@chromium.org Suppress failure on Linux FYI Ozone 2019-10-04 timvp@google.com Android: Enable dEQP-EGL.functional.query_context.* Created with: gclient setdep -r src/third_party/angle@f7ad03aa869b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: chromium:1003151,chromium:1003151 Change-Id: Icb37e2798f43a699bcdd154a1954cd5332d3ebfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841719Reviewed-by:
-
Lei Zhang authored
Change-Id: Ib3dec0d41e54be005395ebe731dabf4af0e38ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839234Reviewed-by:
-
Yusuke Sato authored
components/arc/ is already organized that way, and this CL does the same for chrome/browser/chromeos/arc/. BUG=b:139752657 TEST=try TBR=sky@chromium.org,jkrcal@chromium.org Change-Id: Ib35b0b5d8c0d27fdb0bc6698f556d98744d2c9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836917 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#703054}
-
edchin authored
Prior to iOS 13, adding a subview to the key UIWindow would place that view above the root view controller in that window. In iOS 13, the UIWindow belongs to a UIWindowScene, and any view added to that window is placed behind the root view controller. Therefore, the hack to prevent the BVC from momentarily appearing before the first run experience fails on iOS 13. To fix, this CL adds the fake launch screen directly to the BVC container, rather than to the window. While this fixes the bug (and works correctly on iOS 12/13 and iPad/iPhone), it violates Law of Demeter or Least Knowledge Principle. The violation is documented in the code and captured in a TODO bug. But this violation is really just an extension of the hack already in place. Bug: 993742 Change-Id: I39eae9030ed77995d3711e5b6c3495490353446a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838261Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703053}
-
Jonathan Freed authored
This makes the default_action_ttl_seconds available to be to specified via Finch. Bug: 1005987 Change-Id: I0b4d4e6edd2b353607ddbb43854daebcc70b48ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838539 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Auto-Submit: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#703052}
-
Xianzhu Wang authored
Most of the original failures seemed just caused by an incomplete rebaseline (which might because the mac10.13 bot was broken). I think other hundreds of "crbug.com/591099 [ Mac10.13 ]" failures should be rebaselined, too. This CL mostly remove the mac10.13 specific results which missed some previous rebaseline. TBR=eae@chromium.org Bug: 591099, 921242 Change-Id: I0b7b0523f848154e644e7d563f9217d7e8567de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838591Reviewed-by:
-
Dave Tapuska authored
This shipped in M77 and can be now removed. BUG=957589 Change-Id: I89ab170207d352377760d60f5f1414c94053c615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807568Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#703050}
-
dpapad authored
Problems with previous logic - Did not accept 'enter' for cr-input instances with type url' (example "add bookmark dialog") - Erroneously accepted 'enter' for cr-input instances with type 'search' (example "add languages dialog") Fixed by iterating on the event's |composedPath()| and looking whether a cr-input exists. Moreover, there was logic to limit <input> elements to the same types supported with <cr-input> which seems unnecessary (we only care about processing cr-input instances). Changed it to not accept <input> elements until the need arises. Fixed: 1010819 Change-Id: I25cf23c088318ee4b8003b65984cb735c8aec1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839032Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#703049}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/405413fcec5d..571177f01598 git log 405413fcec5d..571177f01598 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 robertphillips@google.com Remove kLinesAdjacency and add kPath from/to GrPrimitiveType 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-04 rmistry@google.com Move sheriff handoff doc notes higher up Created with: gclient setdep -r src/third_party/skia@571177f01598 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: Ifa2103d8c976bbdb4db60eedd8c86024b9bf713b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841501Reviewed-by:
-
Xiaohan Wang authored
According to the EME spec, when "Media Data May Contain Encrypted Blocks" [1] and setMediaKeys() is not called, we should run the "Wait for Key" algorithm which will fire the "waitingforkey" event. This CL updates RendererImpl to implement this. Unittests are updated and a new web_test is added. There are potentially other media::Renderer implementations that do not implement this, which will be fixed later. We may also consider moving this logic up to the Pipeline level in the future. [1] https://www.w3.org/TR/encrypted-media/#media-may-contain-encrypted-blocks Bug: 1010543 Test: Existing tests updated and new web test added. Change-Id: I41a7eed8d4693698c14bf132fdc93a14e2c9dc31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837489 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#703047}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/34ff91ec6f44..c0efff9d41d9 git log 34ff91ec6f44..c0efff9d41d9 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 yueherngl@google.com eve-arcvm-mesa-virgl-next: add into build config 2019-10-04 mmortensen@google.com Update controller_util to handle goma_config.chromeos_goma_dir. Created with: gclient setdep -r src/third_party/chromite@c0efff9d41d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I20ad9cd4289a3a0b0abda4de8cd508eaac1ba060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841579Reviewed-by:
-
Cliff Smolinsky authored
This reverts commit a44707ee. Reason for revert: Need to use the legacy tooltips for Win7+DWM off. See https://bugs.chromium.org/p/chromium/issues/detail?id=1007262. Original change's description: > Completely remove tooltip_win. > > Now that Chrome 77 has shipped with aura tooltips on by default, it is > now safe to remove the legacy Windows tooltips. This change removes the > legacy code and the feature flag that controlled the switch. > > Bug: 971686 > Change-Id: Ic6266b261d64a38ab568fd2eb84f9f1fa644396b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802437 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#696591} TBR=sky@chromium.org,cliffsmo@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 971686,1007262 Change-Id: I85c9d585f53e406f48d62f33635a0b602cf1c43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841738 Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Reviewed-by:
Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703045}
-
Gayane Petrosyan authored
Default background previews should be transparent to allow color previews on NTP. Bug: 1009956 Change-Id: Ie4774f61fdc74bc8bcab8a8abf6b6bce643e513b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842271Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#703044}
-
Victor Costan authored
Change-Id: I703db0fadb65533612f3470b876c80fe1c7a2947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782964 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#703043}
-
Matt Menke authored
We have two implementations of HttpServer - one wraps a net::Socket and one wraps a network::mojom::*Socket. They have near identical tests. They have each have one corresponding test that, for some reason, was using a URLFetcher. This CL makes both tests use the infrastructure all other HttpServer tests use instead, for both tests. Also worth noting that the net::Socket version is used only by chromedriver and DevTools. The latter seems like it might be a bug, and the latter could perhaps be switched to the EmbeddedTestServer, which would allow us to remove the net version. Bug: 1010491 Change-Id: Ibb17e3795237cfc9005b409ca3fcec32fedb5448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842015Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#703042}
-
Greg Kerr authored
dtruss analysis of the GPU V2 sandbox shows errors accessing CoreServices directories and dirhelper resources. Bug: 871280 Change-Id: I6c5ff44872c9aedaa1f1cb1950bdc7bfe64f7ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841717 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#703041}
-
Regan Hsu authored
- Rename "Detailed Build Info" to "additional Details" on about page - Remove all extra details except as shown in slide 8 go/aue-settings - Add Build details and link to chrome://version - Ignore the copy button for now - do in M80 - EOL section in "Additional details" at issue 1828130 Screenshots: https://screenshot.googleplex.com/Wz7eQ6gQPBY Bug: 993828 Change-Id: I6cbaf911df55df963d6fb0c6600d8b774e8573dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836631 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#703040}
-
Lei Zhang authored
https://crrev.com/702886 checked in a 64-bit DLL for testing, which does not work on 32-bit bots. Temporarily mark the test 64-bit only, so the 32-bit Windows bots go green. TBR=grt@chromium.org Bug: 1011439 Change-Id: I0a64a10bfa785c4033bb2a626941d7ea42bac526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841657Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#703039}
-
Fred Mello authored
Bug: 1005802 Change-Id: Id999a3dc053e5f1e06ef5056753c06ef44aaca99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841732Reviewed-by:
-
Brett Kilty authored
NonSwitchableAudioRendereSink removes the compat for SwitchAudioOutput, however, it is derived from RestartableAudioRendererSink which allows (when stopped) Initialize and Play to be called again. We need to protect Initialize from multiple calls as AudioOutputDevice cannot be re-initialized. Since we continue to use our valid output device, just noop in this case. Bug: b/141625232 Test: Local build before/after on device testing Change-Id: I336425c83ec8e6178c7dd0d8f44a6aab2bb5a0e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836354 Commit-Queue: Brett Kilty <brettk@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#703037}
-
shrekshao authored
Couldn't reproduce this clusterfuzz bug locally. But make a speculative fix attempt. Bug: 1008300 Change-Id: Iab02f2b3997883ae05cccd1e1ea916a206952b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838547Reviewed-by:
-
Fred Mello authored
Bug: 1005802 Change-Id: I00aa050a18dd76a41600757f3865cf0542fbb8d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841692Reviewed-by:
-
Gauthier Ambard authored
The previous version of the iOS detection of the dino wasn't using the correct way of getting the user agent. Bug: 1008774 Change-Id: I96d92a9f5da837509961cb4238e03c4b0d510a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836497 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#703034}
-
Yue Li authored
Upon UX request(b/141756292), update the strings for context and hotword of Assistant settings. Bug: b/141756292 Test: Manual Test Change-Id: Ic7d64c50fa97bc8e47a3aa112009b313b182e31b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842294Reviewed-by:
-
ssid authored
Download DB requires the db to load in this priority and making the shared one BEST_EFFORT causes delays in downloads. BUG=1006954 Change-Id: I3154b8f3d782b8367b524063e6def1f0b1d322be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839231Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Eric Lawrence [MSFT] <ericlaw@microsoft.com> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#703032}
-
rbpotter authored
Allow multiple HTML _template strings in JS files when running i18n template replacements. This is necessary to correctly replace expressions for bundled JS files generated from Polymer 3 pages, as the bundled files will generally contain many element definitions, each including HTML template string. This will be used when optimized Web UI pages are migrated to use Polymer 3/JS modules (e.g. chrome://extensions). Bug: 1004967 Change-Id: I9b5990fc26daf272980ee8d4f5aac688aceffb27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834846 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#703031}
-
Lei Zhang authored
CreatePrintSettingsDictionary() set some defaults. Do not bother doing that and then setting the same default values again. Change-Id: Ic514885addb55647a1fc4072360ea60c27a67231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838890Reviewed-by:
-
