- 20 Jun, 2018 40 commits
-
-
Florian Mayer authored
This includes a rename perfetto::Service to perfetto::TracingService. Do the corresponding changes in Chrome. Bug: 74331089 Change-Id: I73bb3a15a66ad494a3796cdf9f5e4fd275d8c57d Reviewed-on: https://chromium-review.googlesource.com/1107698 Commit-Queue: Florian Mayer <fmayer@google.com> Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Hector Dearman <hjd@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#568823}
-
Olga Sharonova authored
This reverts commit ec3716fd. Reason for revert: It broke WebRTC performance tests which capture system audio loopback. The reason is unclear, but looks like tests-specific: audio works with manual testing; and the test only changed event timing at the process startup. Reverting for now to have WebRTC audio quality test coverage. Bug:850936 Original change's description: > Changing AudioService experiment field trial to test service launch on startup > > [1] introduced AudioServiceLaunchOnStartup feature which we want to roll out > with a new experiment group. Updating field trial to run the config on bots > first. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/1104681 > > Bug: 851611,853781 > Change-Id: I3796a8ac205a6d37706a86e8647c933ee510f41a > Reviewed-on: https://chromium-review.googlesource.com/1105957 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568485} TBR=rkaplow@chromium.org,olka@chromium.org Change-Id: Ic50b37d434bc75fca78585ead8c964815bcd2cf0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851611, 853781 Reviewed-on: https://chromium-review.googlesource.com/1107957Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#568822}
-
Oskar Sundbom authored
Renaming it to ExperimentalHardwareEchoCancellation2, so that new tokens don't trigger the old behaviour in older versions of Chrome. The runtime flag retains its name, since that's user controlled. Bug: 854577, 846270 Change-Id: I577e37082ed4cd84d4e77dc6f13155a4eba49131 Reviewed-on: https://chromium-review.googlesource.com/1106338Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568821}
-
Scott Violet authored
Into HostContextFactoryPrivate. This also adds a ui::ContextFactory implementation that uses it to services/ui/ws2. I could move the ContextFactory implementation to ui/compositor/host as well, but I kept it where it is used. BUG=837686 TEST=covered by tests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I95f89f9c14ac93560805bf47a9fe074d1ab1c58d Reviewed-on: https://chromium-review.googlesource.com/1105307Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#568820}
-
Sylvain Defresne authored
The overload of PrepareMailtoHandling is no longer overridden in the downstream implementation and not called from upstream code so it can be safely removed. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5bde07b17f1c5293488b0d65d284fa0e0ecea5f6 Reviewed-on: https://chromium-review.googlesource.com/1106164 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568819}
-
Koji Ishii authored
Blink is the only engine that truncates text inside of an inline block for 'text-overflow: ellipsis', and these two tests are for the behavior. The spec says atomic inline is truncated as a whole or not, and all other 3 impls follow that. LayoutNG matches to it. TBR=atotic@chromium.org NOTRY=true Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iae29eaf66f23d3eb120b215606a5b1e5e020bfbf Reviewed-on: https://chromium-review.googlesource.com/1107529 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#568818}
-
Marc Treib authored
Turns out the test was completely out of date and only passing by accident. While we're here, also replace a few EXPECT_CALLs with ON_CALLs. Bug: none Change-Id: Ie2250a7ea58332e6bf08b6df80e33b72eb5a0018 Reviewed-on: https://chromium-review.googlesource.com/1107811Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568817}
-
clamy authored
This CL is part of a serie of CL to remove usage of the deprecated method NavigationController::GetActiveEntry. Bug: 273710 Change-Id: I3c2aefded05884333fd3e20830cf4abfabebbdc1 Reviewed-on: https://chromium-review.googlesource.com/1102458Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568816}
-
Mounir Lamouri authored
This will allow the browser tests to run on all platforms. Bug: 845747 Change-Id: I07eb6fbd8240c5f559ef078538ffc047e7ab784c Reviewed-on: https://chromium-review.googlesource.com/1105073Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#568815}
-
Jeremy Roman authored
It's cleaner and more consistent with Chromium. Change-Id: Ib2e4fa6d55f5e85c48673fb48b3cd90de8b11240 Reviewed-on: https://chromium-review.googlesource.com/1106042Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568814}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f153b902bec3..a2cee4816d7b git log f153b902bec3..a2cee4816d7b --date=short --no-merges --format='%ad %ae %s' 2018-06-20 perezju@chromium.org [Telemetry] Disable flaky tests on mac10.10 Created with: gclient setdep -r src/third_party/catapult@a2cee4816d7b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:853865 TBR=sullivan@chromium.org Change-Id: I658c7b1910c92c4c900861f846404574d1891f85 Reviewed-on: https://chromium-review.googlesource.com/1107599Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568813}
-
Marc Treib authored
Bug: none Change-Id: I25d60383abd1d62124d099bb1e364c32981729af Reviewed-on: https://chromium-review.googlesource.com/1107699 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Martin Šrámek authored
This reverts commit b0314879. Reason for revert: Seems to have broken a number of print browsertests on Win 7 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/69834 Original change's description: > Print Preview Componentization: Fix document title > > Set the document title to the title of the tab being printed, so that > the task manager will show the correct task title. > > Bug: 773928 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: If8f7fec12bd81cca71bdccf3fb9f040ac17bc3f0 > Reviewed-on: https://chromium-review.googlesource.com/1104985 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568487} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: Ibafe5312ce179f07a5342cd512342873ab0687f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773928 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1107897Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#568811}
-
Bernhard Bauer authored
Move most of the logic out of the RecyclerViewAdapter into its newly introduced delegate (which RecyclerViewModelChangeProcessor now implements). Update RecyclerViewModelChangeProcessor to better handle its most common use case, which is to represent a plain list of items. Other, more complicated use cases can be implemented with a custom RecyclerViewAdapter.Delegate implementation (which could go away in the future as we extend the capabilities). Remove getItemCount() from ListObservable in favor of moving it to a new SimpleList<> interface, to better separate accessing items in a list from observing changes to it. Make the ViewBinder interface functional again, by moving ViewHolder creation to its own functional interface, and update clients to use method references. Bug: 805070 Change-Id: I565b2e9888e9cbaf8eb0f3dfc73df4baf197f30a Reviewed-on: https://chromium-review.googlesource.com/1100831Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#568810}
-
jonross authored
More flaking tests on Android in surface_sync_content_browsertests, and viz_content_browsertests. This disables them. TBR=fsamuel@chromium.org TEST=viz_content_browsertests, surface_sync_content_browsertests Bug: 849746 Change-Id: I753452ea85d342fdb6bfc4408fb38817f8252d19 Reviewed-on: https://chromium-review.googlesource.com/1107839Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#568809}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/e5be80532b..bd40a41cc1 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/e5be80532b..bd40a41cc1 Bug: None Change-Id: I6762301da5d5fd011677026fdf055bdda52450a7 Reviewed-on: https://chromium-review.googlesource.com/1107557Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#568808}
-
Matt Menke authored
This moves logic for this case from ChromeNetworkDelegate to NetworkContext's NetworkDelegate, and adds a Mojo parameter to cause requests with bad referrers to fail (enabled by default). Also removes the action Net.URLRequest_StartJob_InvalidReferrer rather than moving it, as it was unowned. Bug: 852871 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9d6d55157ba28e2b12ca7136b78330100a8673aa Reviewed-on: https://chromium-review.googlesource.com/1103119Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Matt Menke authored
Unfortunately, the old patch to set it up in IOThread is still needed, since the in-process NetworkService is leaked when the OOP network service is disabled. Bug=853211 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic216b2d83d703cff776a77aaea6a2244a9eca367 Reviewed-on: https://chromium-review.googlesource.com/1105068Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#568806}
-
Tiger Oakes authored
Removed context#getApplicationContext calls from /chrome/android/java/src/org/chromium/chrome/browser/services/gcm Continuation of work in bug 646094. This CL was uploaded by git cl split. R=peter@chromium.org Bug: 846456 Change-Id: If4634124016982063b17725552585ef08d333a94 Reviewed-on: https://chromium-review.googlesource.com/1095914 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#568805}
-
Greg Kraynov authored
Bug: 783309 Change-Id: I0e32bfa8001ceb6be444b99852ca73f38dec8bbc Reviewed-on: https://chromium-review.googlesource.com/1102682Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#568804}
-
Luke Bjerring authored
Note that this is not a functional change; it just helps authors of idlharness tests identify what's gone wrong if they have incorrect add_objects params. testharness.js drops the stack for thrown errors and prints a (useless) new stack. Change-Id: I6dd90c461f0ab58e57978a28e3e5e9eb366a4827 Reviewed-on: https://chromium-review.googlesource.com/1104311 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#568803}
-
stkhapugin@chromium.org authored
Bug: 852787 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ied16b9651281b7907e8628752938a2d6b42ae9c3 Reviewed-on: https://chromium-review.googlesource.com/1106337 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568802}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 68b65a6c. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" 08784a11 "[Mojo Blob URLs] Make clicking an <a target="blank_"> with a blob URL work correctly." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19932 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source TBR=robertma No-Export: true Change-Id: I6257e3f545b54c38592ac72a01e92028de1b4e18 Reviewed-on: https://chromium-review.googlesource.com/1107640 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#568801}
-
clamy authored
This CL is part of a serie of CLs to remove usage of Navigation::GetVisibleEntry when possible. Instead, we use WebContents::GetVisibleURL or NavigationController::GetLastCommittedEntry when appropriate. Bug: 853705 Change-Id: I97ddfe4712fe68ff730ebc7ff1a6756094d3554d Reviewed-on: https://chromium-review.googlesource.com/1104349Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568800}
-
Johnny(Jianning) Ding authored
The incumbent realm schedules the currently-running callback although it may not correspond to the currently-running function object. The goal for this CL to is check whether the script setting is disabled before invoking JS callback, then checking the context which originally schedules the current-running callback seems to make more sense. Please notice that this CL changes the behavior of the method IsCallbackFunctionRunnable to require the execution context of the incumbent environment to be not empty, not paused and enabled for JavaScript. Bug: 849600,849601,849730,848086,849915,851357 Change-Id: Id8ab0f9f67f9602635b295b414d2d0026c87e4ab Reviewed-on: https://chromium-review.googlesource.com/1087536 Commit-Queue: Johnny Ding <jnd@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568799}
-
Noel Gordon authored
Significant test-time can be shaved by testing one image for now since testing two images (previous code) makes MSAN unhappy. Some better way for testing the gallery-open-select-image case seems possible, and one that could also be fast (that case is being removed in the CL). That may be the focus of a future CL, but here our goal is to make the test suite fast by testing one thing in a fixture, not multiple things (see previous code). Herein, test open-an-image-in-gallery meaning one image only, not two (since two costs us 2 x O(1)secs [1]), which might help to get this test re-enabled on MSAN again (issue 837551). As a reminder to future readers, this FilesApp test fixture only tests opening and closing the Gallery from FileApp and that's all that needs testing here. Refer to GalleryBrowserTest for the integration tests of the Gallery features. [1] The time it takes to decode and draw the JPEG image (~1sec) in the test step is way longer than the time it takes libjpeg_turbo to decode it (at most 10ms). Something else is taking up a lot of time, but I am not sure what it is yet: thumb-nailing? image resizing? ... Bug: 837551 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I9ac3b0433d8f5fbd2f04516af21bf17482eb8401 Reviewed-on: https://chromium-review.googlesource.com/1106178 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568798}
-
Marc Treib authored
Resolving possibly one of the oldest TODOs in our codebase :) Bug: none Change-Id: Ib9bfc4f857b45b80c8bfac89ebf3079e2738ab6a Reviewed-on: https://chromium-review.googlesource.com/1107627 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
When the network service or NetS13nSW is enabled, requests skip service worker loaders entirely when the controller has no fetch event handler. This was broke assumptions in DocumentThreadableLoader, since it expected service worker machinery to return "fallback for CORS" responses for certain requests when there was a controller. Bug: 850839 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I32b058caacb14cba2e53dd8667fe9fc930a776e8 Reviewed-on: https://chromium-review.googlesource.com/1107435Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#568796}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9edff1c2..60f929c0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I3febf555d52efbf5b1467b8555dc0d406aa9d662 Reviewed-on: https://chromium-review.googlesource.com/1107639Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568795}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f04148c810aa..056a68da896d git log f04148c810aa..056a68da896d --date=short --no-merges --format='%ad %ae %s' 2018-06-20 mbonadei@webrtc.org Revert "Enable any address ports by default." 2018-06-20 aleloi@webrtc.org Init GainControlImpl with correct lock. 2018-06-20 asapersson@webrtc.org Add functionality to set min/max bitrate per simulcast layer through RtpEncodingParameters. 2018-06-20 nisse@webrtc.org Delete pre_decode_callback. 2018-06-20 yura.yaroshevich@gmail.com Fixed crash when PCF is destroyed before PC in ObjC Created with: gclient setdep -r src/third_party/webrtc@056a68da896d The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iba9c503fa109f6124c33ff2045a0455df841f35b Reviewed-on: https://chromium-review.googlesource.com/1107598 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568794}
-
stkhapugin@chromium.org authored
Uses proper view controller containment APIs when displaying the popup. Updates layout on screen rotation. Bug: 837006 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie7ff928d68b5cedc526cbe6057e1286cb54bd637 Reviewed-on: https://chromium-review.googlesource.com/1106175Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568793}
-
Vaclav Brozek authored
Specifically, to the component and iOS, based on past areas of work. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8c1254a9a19c956f2a5a18d06e6030c3c137fb54 Reviewed-on: https://chromium-review.googlesource.com/1107701Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568792}
-
Justin Cohen authored
TBR=hinoka@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9f05716edc1ee2b47af96557295cdf4cbd9f43a0 Reviewed-on: https://chromium-review.googlesource.com/1106677 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#568791}
-
cathiechen authored
The inside marker could be a child of anonymous block not LI. When we are finding symbol marker if meet anonymous block we should check its parent. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8127ff9d38b351f97171f7a0cc8c8c3fdd896e6c Reviewed-on: https://chromium-review.googlesource.com/1102296 Commit-Queue: cathie chen <cathiechen@tencent.com> Reviewed-by:
-
Sylvain Defresne authored
The implementation of mailto: handler observes the SyncService so it needs to unregister itself during shutdown. Add a method called during application shutdown to unregister the handler. Bug: 854159 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I99e6de4f488ef6ef0fe7cd7f48deece648051503 Reviewed-on: https://chromium-review.googlesource.com/1106161 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Mikel Astiz authored
Sending the very same tab entity is wasteful: in most cases it will be caught by other layers (which will realize the proto is identical) but let's detect it in early stages, which also avoids unnecessary I/O to disk. Bug: 854493 Change-Id: Ia2ceaa4347bdf4dca1c5d0995b2466d07b41261a Reviewed-on: https://chromium-review.googlesource.com/1107060Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568788}
-
Egor Pasko authored
Sadly dskiba and mariakhomenko are moving on to work on something else. We are scraping really hard to fill the gaps. Updating the docs to the new harsh realities. Bug: None Change-Id: I2e8899ad975ba1279a95ce4f702d20756981ed47 Reviewed-on: https://chromium-review.googlesource.com/1106617 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#568787}
-
Mohamed Amir Yosef authored
Bug: 516866 Change-Id: Iee653b8470c8aabd7eb14ed81ddf48e6411c472f Reviewed-on: https://chromium-review.googlesource.com/1106345 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568786}
-
Mikel Astiz authored
This logically reverts the precaution introduced in https://chromium-review.googlesource.com/843574 which prevented sync IDs from being vended when the browser itself was not running (no tabbed activity/window), effectively resulting in a partial unlaunch session sync for Custom Tabs. The reason to do this was UMA metric Sync.SesssionsDuplicateSyncId reporting many sync ID conflicts, now investigated in depth in crbug.com/843554. The suspicion was that duplicate IDs were produced by a race condition due to using two separate persistence databases (one for sync, one for session restore). We recently reworked the SyncedTabDelegate API to migrate away from sync IDs, which renders the above concern moot and makes it straightforward (as proposed here) to start syncing Custom Tabs even when no tabbed window exists. Bug: 840722,853459 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8a27e68faa79271a6058f00c3dd5355ef635f1a4 Reviewed-on: https://chromium-review.googlesource.com/1092536 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Jeremy Roman authored
This prevents the resolver from being prematurely collected. Bug: 852751 Change-Id: I9516c9cdb84133291008cb045108e41baa956272 Reviewed-on: https://chromium-review.googlesource.com/1106543 Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Reviewed-by:
-
