GitLab

ContainerViewObserver is used by ExternalVideoSurfaceContainer
only, which in turn used by Chromecast/WebView.

Since Chromecast never updates container view in its lifecycle,
it can go without using ContainerViewObserver. And WebView
disabled support for video hole since M52.

With that, ContainerViewObserver is not used any more. This CL
deletes the class.

BUG=624977

Review-Url: https://codereview.chromium.org/2293743002
Cr-Commit-Position: refs/heads/master@{#419403}

https://chromium.googlesource.com/skia.git/+log/5d1110ed4679..e7a7812744c2

$ git log 5d1110ed4..e7a781274 --date=short --no-merges --format='%ad %ae %s'
2016-09-18 rmistry Whitespace change

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=borenet@google.com

Review-Url: https://codereview.chromium.org/2343353002
Cr-Commit-Position: refs/heads/master@{#419402}

Currently DeleteWindow() is (mostly) ignored if the client doesn't own
the root. This change allows the client to call delete on a root and
it's treated as unembedded the client from that root.

BUG=647509
TEST=covered by tests
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2349003002
Cr-Commit-Position: refs/heads/master@{#419401}

After discussion concluded the best way was to delegate the laser pointer out of ash/common. Moved all the laser related files into ash/laser.

LaserPointerController.* replaces LaserPointerMode.* and it inherits from EventHandler to grab the events and propagate them to LaserPointerView/LaserPointerPoints, which remain the same. LaserPointerMode just inherits common palette tool and calls the delegate.

BUG=644804
TEST=ash_unittests --gtest_filter="LaserPointer*"

https://screenshot.googleplex.com/BtwX1GTCpcW

Review-Url: https://codereview.chromium.org/2311393004
Cr-Commit-Position: refs/heads/master@{#419400}

Avoid mash null dcheck/deref with --login-manager.

BUG=647781,647039
TEST=No crash running chrome --mash --login-manager
R=alemate@chromium.org,xiyuan@chromium.org

Review-Url: https://codereview.chromium.org/2345333002
Cr-Commit-Position: refs/heads/master@{#419399}

https://chromium.googlesource.com/skia.git/+log/bdf3e5c03418..5d1110ed4679

$ git log bdf3e5c03..5d1110ed4 --date=short --no-merges --format='%ad %ae %s'
2016-09-18 update-skps Update SKP version

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=borenet@google.com

Review-Url: https://codereview.chromium.org/2348113002
Cr-Commit-Position: refs/heads/master@{#419398}

BUG=631960,648028
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2350593002
Cr-Commit-Position: refs/heads/master@{#419397}

In Desktop OGLs whose version < 4.4, they maybe don't enable srgb conversion
between srgb color format and linear color format. This change can emulate
srgb and do the conversion for machines with these OGL profiles.

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2286593002
Cr-Commit-Position: refs/heads/master@{#419396}

Cr-Commit-Position: refs/heads/master@{#419395}

This cl splits the big CL with changes to net/ folder and
has changes only to net/cert_net according to the
changes to URLRequest API.

What the big cl does:
It modifies net/ clients that use URLRequest API as long as
URLRequest::Read returns int net errors and
URLRequest::Delegate and NetworkDelegate methods
(for example, OnResponseStarted or OnCompleted) have int
net_error in the arguments now.

The reason behind splitting the CL into small one is that
an android bot started to be unstable and unittests became
flaky. It was not possible to locate the problem and the
decision was to split the CL and upload small parts with a
6+ hours interval in order to make it possible to locate
the problematic code.

The big CL is located here -
https://codereview.chromium.org/2265873002/

BUG=423484

Committed: https://crrev.com/a74d3cbc572fa1c85cc2c0434a9f8e2f9cba0cd9
Review-Url: https://codereview.chromium.org/2330863002
Cr-Original-Commit-Position: refs/heads/master@{#418014}
Cr-Commit-Position: refs/heads/master@{#419394}

Cr-Commit-Position: refs/heads/master@{#419393}

This patch adds vrdisplayconnect and vrdisplaydisconnect event support
of google vr sdk for android. It defines 'connect' status as
nativeContext is available and defines 'disconnect' status as
nativeContext is unavailable.

Note that connect event may dispatch before user get vr devices
because devices in connection status could already deliever user some device
info and user could use this event to do some preparing work.

BUG=389343
R=bajones@chromium.org, kenrd@chromium.org, ochang@chromium.org

Review-Url: https://codereview.chromium.org/2317483002
Cr-Commit-Position: refs/heads/master@{#419392}

BUG=647820,641261

Review-Url: https://codereview.chromium.org/2345633007
Cr-Commit-Position: refs/heads/master@{#419391}

Fold uses of:

  CSSPrimitiveValue::create(..., const ComputedStyle&)
  CSSValuePair::create(..., const ComputedStyle&)

into the (few) users. Handle the fall-out.

Review-Url: https://codereview.chromium.org/2345893004
Cr-Commit-Position: refs/heads/master@{#419390}

The new way is simpler and uses the same pattern as PaintLayerCompositor.

BUG=646188
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2342103002
Cr-Commit-Position: refs/heads/master@{#419389}

TBR=rtoy@chromium.org,foolip@chromium.org
BUG=626449,647693

Review-Url: https://codereview.chromium.org/2352463002
Cr-Commit-Position: refs/heads/master@{#419388}

This is a partial revert of the WebViewPlugin changes in
https://crrev.com/8489f1bf78c2c6f296e0df6c529751d29e8a0188

BUG=641028

Review-Url: https://codereview.chromium.org/2349443003
Cr-Commit-Position: refs/heads/master@{#419387}

This cl splits the big CL with changes to net/ folder and
has changes only to net/cert_net according to the
changes to URLRequest API.

What the big cl does:
It modifies net/ clients that use URLRequest API as long as
URLRequest::Read returns int net errors and
URLRequest::Delegate and NetworkDelegate methods
(for example, OnResponseStarted or OnCompleted) have int
net_error in the arguments now.

The reason behind splitting the CL into small one is that
an android bot started to be unstable and unittests became
flaky. It was not possible to locate the problem and the
decision was to split the CL and upload small parts with a
6+ hours interval in order to make it possible to locate
the problematic code.

The big CL is located here -
https://codereview.chromium.org/2265873002/

BUG=423484

Committed: https://crrev.com/a74d3cbc572fa1c85cc2c0434a9f8e2f9cba0cd9
Review-Url: https://codereview.chromium.org/2335513003
Cr-Original-Commit-Position: refs/heads/master@{#418014}
Cr-Commit-Position: refs/heads/master@{#419386}

Revert of Evacuate ComputedStyle references from the CSS*Value hierarchy (patchset #1 id:1 of https://codereview.chromium.org/2345893004/ )

Reason for revert:
Tree is red; this patch fails to compile:

../../third_party/WebKit/Source/core/css/CSSValuePair.h:42:12: error: incomplete result type 'WTF::String' in function definition
    String customCSSText() const

Original issue's description:
> Evacuate ComputedStyle references from the CSS*Value hierarchy
>
> Fold uses of:
>
>   CSSPrimitiveValue::create(..., const ComputedStyle&)
>   CSSValuePair::create(..., const ComputedStyle&)
>
> into the (few) users. Handle the fall-out.
>
> Committed: https://crrev.com/ba9df880383908b052d5a7d00abb32deec94cfc5
> Cr-Commit-Position: refs/heads/master@{#419382}

TBR=sashab@chromium.org,timloh@chromium.org,fs@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2343343002
Cr-Commit-Position: refs/heads/master@{#419385}

This drops includes from CSSValue.h that are not directly used by it.
Downstream dependents are fixed up as needed. Also strip some includes
from StyleImage.h and other places that includes CSSValue.h while
there.

Review-Url: https://codereview.chromium.org/2345223002
Cr-Commit-Position: refs/heads/master@{#419384}

https://chromium.googlesource.com/skia.git/+log/67ac33e1f1a1..bdf3e5c03418

$ git log 67ac33e1f..bdf3e5c03 --date=short --no-merges --format='%ad %ae %s'
2016-09-17 fmalita [SVGDom] Improved DM sizing

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2344423002
Cr-Commit-Position: refs/heads/master@{#419383}

Fold uses of:

  CSSPrimitiveValue::create(..., const ComputedStyle&)
  CSSValuePair::create(..., const ComputedStyle&)

into the (few) users. Handle the fall-out.

Review-Url: https://codereview.chromium.org/2345893004
Cr-Commit-Position: refs/heads/master@{#419382}

The logs are huge when these tests fail, and for no good reason as far
as I can tell. The huge amount of logging might actually be slowing
down the tests.

BUG=638744
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2343063005
Cr-Commit-Position: refs/heads/master@{#419381}

866e60749c1f Add >nul to editbin command to suppress \n in build output
357c7c7b7bbf win: Add some explanation of .com/.exe for crashpad_handler
c6f88d164e44 Have MinidumpMemoryListWriter deal directly in
             SnapshotMinidumpMemoryWriters
5f42313ed5ce Test first integration of UMA plumbing
afc177ee2100 Pull metrics instrumentation out to central file
0c290220902d Update mini_chromium to 7800285e83df
27aeb2c9dacb Upstream Chromium UMA integration
23d31c4fea61 Fix Mac build after 27aeb2c9

Manually update util/BUILD.gn in Chromium tree.

R=mark@chromium.org
BUG=crashpad:100

Review-Url: https://codereview.chromium.org/2349083002
Cr-Commit-Position: refs/heads/master@{#419380}

FF and Edge don't paint a selection on the ellipsis.

BUG=642460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2340533002
Cr-Commit-Position: refs/heads/master@{#419379}

This patch is a followup to [1] where we noticed that viewport settings
were not invalidating the text autosizer. The text autosizer depends on
how the viewport is specified so we need to invalidate it on changes. A
test has been updated to show this works.

[1] https://crrev.com/1229b1414d64c314666d2fb3bf47706f2b5e947b

Review-Url: https://codereview.chromium.org/2341843002
Cr-Commit-Position: refs/heads/master@{#419378}

(Compared to https://codereview.chromium.org/2308313003/, this version
fixes chrome/installer/linux/BUILD.gn by including all required files)

There is nothing really chrome-specific in the process_version()
template, and if we stop always passing some files in chrome/ on every
invocation it is possible to generalize it and move it to build/util
instead (and fix some layering violation comments along the way).

Compared to its previous incarnation, process_version() no longer passes
LASTCHANGE, BRANDING and VERSION automatically to version.py. This makes
it easier for callers to specify their own |sources| with values that
may override those set in those 3 files.

A new wrapper, process_version_rc_template(), was introduced to cater
for callers (generally Windows ones) who need to process a .rc.version
file that requires the values from LASTCHANGE, BRANDING and VERSION. It
always passes those 3 files to process_version() before any optional
additional |sources|, and |template_file| defaults to
chrome_version.rc.version.
Since this template depends on files from //chrome, it lives in the
newly-added //chrome/process_version_rc_template.gni.

R=dpranke@chromium.org,brettw@chromium.org,phajdan.jr@chromium.org,ddorwin@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2341673003
Cr-Commit-Position: refs/heads/master@{#419377}

When orthogonal writing mode roots have floating siblings, its
containing block may still have old or even deleted LayoutObjects.
This occurs when LayoutMultiColumnFlowThread::populate(),
LayoutBoxModelObject::moveChildrenTo() with !fullRemoveInsert,
or more, for the optimization purposes.

This patch clears such objects to be re-created when the containing
block is laid out.

BUG=604095, 633409, 646178

Review-Url: https://codereview.chromium.org/2025543002
Cr-Commit-Position: refs/heads/master@{#419376}

This fixes OOM crashes in the mediaserver process on older devices
by suspending players more frequently and preventing unused players
and SurfaceTextures from ever being created. Both fixes are required
to enable playback on JellyBean devices; independently neither is
sufficient for playback to succeed.

- On low end devices, suspends all idle players immediately upon
  playback of another player.
- On low end devices, if a codec already exists, codec creation is
  deferred until the first Decode() call. Resolves issues with sites
  like vimeo.com that are appending initialization segments to MSE
  but never any further data.
- Once more than 2 players exist on a low end device, every extra
  player will cause immediate idle player collection. Normal devices
  will now do this after 8 players.

A followup CL will set preload=none for all JellyBean devices.

BUG=612909
TEST=manual, new tests.

Review-Url: https://codereview.chromium.org/2333983002
Cr-Commit-Position: refs/heads/master@{#419375}

https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer/+log/96e97b4..eb9b8b0

BUG=539572
TBR=aizatsky@chromium.org, inferno@chromium.org, kcc@chromium.org, ochang@chromium.org

Review-Url: https://codereview.chromium.org/2352453002
Cr-Commit-Position: refs/heads/master@{#419374}

There has been a discrepancy between how the subresource filter and the rest of
Safe Browsing defines the meaning of `redirect urls`. For the redirect chain A
-> B -> C, the SafeBrowsingResourceThrottle considers A as the |original_url|
and [B, C] as |redirect_urls|.  In contrast, the subresource filter expects C
as the resource URL and [A, B] as redirect URLs.

This CL performs the correct transformation on the |redirect_urls| list before
passing it from the SafeBrowsingResourceThrottle to the subresource filter.
Plus, it also avoid calling out to the ContentSubresourceFilterDriverFactory in
case the unsafe resource is not a main frame document.

BUG=646800,609747

Review-Url: https://codereview.chromium.org/2339733003
Cr-Commit-Position: refs/heads/master@{#419373}

This CL modifies the GamepadMappings class to use subclasses
for mappings rather than static methods. The advantage is that
the unknown gamepad mapping can keep state around that allows
it to create heuristic mappings at GamepadDevice constrution
time. This allows stable mappings that don't depend on input
to decide correctly. This also means we aren't doing string
parsing on each gamepad event anymore.

With this change, Moga Pro, Nexus Player (ASUS) Gamepad, and Razer
Serval controllers are working correctly without explict mappings.

Before the change, the D-Pad on Moga, Serval, and ASUS Gamepad were
non-functional. The triggers on the Moga didn't work at all, and the
Serval and ASUS Gamepad's triggers were swapped with the shoulder
buttons.

TEST=http://html5gamepad.com/
BUG=615656

Review-Url: https://codereview.chromium.org/2071223002
Cr-Commit-Position: refs/heads/master@{#419372}

Revert of Show ancestor hierarchy in accessibility panel (patchset #10 id:180001 of https://codereview.chromium.org/2322413003/ )

Reason for revert:
Fails the compile step on Linux ChromiumOS GN (headless_unittests)

Original issue's description:
> Show ancestor hierarchy in accessibility panel
>
> BUG=560525
>
> Committed: https://crrev.com/3558706c1b2a630557929b61fefc74e28975f3a6
> Cr-Commit-Position: refs/heads/master@{#419369}

TBR=dmazzoni@chromium.org,dgozman@chromium.org,pfeldman@chromium.org,aboxhall@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=560525

Review-Url: https://codereview.chromium.org/2351443003
Cr-Commit-Position: refs/heads/master@{#419371}

This patch uses testharness.js asserts to test canvas
on tranlsate reset and transform-translateZ property

BUG=639732

Review-Url: https://codereview.chromium.org/2343793002
Cr-Commit-Position: refs/heads/master@{#419370}

BUG=560525

Review-Url: https://codereview.chromium.org/2322413003
Cr-Commit-Position: refs/heads/master@{#419369}

Removing strings since the feature won't be required anymore.

BUG=NA

Review-Url: https://codereview.chromium.org/2347353002
Cr-Commit-Position: refs/heads/master@{#419368}

Cr-Commit-Position: refs/heads/master@{#419367}

I have verified that vh/vw are resolved by the style system before these
units reach layout, so we don't need to worry about DeviceWidth/DeviceHeight
here.

R=mstensho@opera.com,eae@chromium.org,ikilpatrick@chromium.org
BUG=635619

Review-Url: https://codereview.chromium.org/2344193003
Cr-Commit-Position: refs/heads/master@{#419366}

When playing encrypted media and decrypting stalls due to missing key,
add a message to indicate when a key is added and decryption tries to
start again.

BUG=645304
TEST=checked chrome://media-internals

Review-Url: https://codereview.chromium.org/2334953002
Cr-Commit-Position: refs/heads/master@{#419365}

BUG=647036

Review-Url: https://codereview.chromium.org/2342563003
Cr-Commit-Position: refs/heads/master@{#419364}