- 29 May, 2018 40 commits
 - 
- 
Maksim Sisov authored
This CL is a part of Wayland gpu/ui split effort, which fixes the Ozone/Wayland and makes it functional when the gpu service is running out of the browser process. The patch does not bring any functionality changes, but rather prepares Ozone/Wayland for a dmabuf based approach, which uses ozone/drm code, to be landed in the upstream. In particular, gbm_device.cc/h is moved into a common folder in the ui/ozone/common/linux and renamed to gbm_device_linux.cc/h. What is more, it is refactored in such a way that it can be used by both Wayland with dmabuf approach and ozone/drm. This is only compiled for wayland(downstream now) and drm backends, and does not bring any additional load on other backends. Bug: 820047 Change-Id: I9eb4da474eb24d6d32fe355ff37b6d0806672fde Reviewed-on: https://chromium-review.googlesource.com/1071889 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#562613}
 - 
Bo Liu authored
Bug: 841220 Change-Id: I5eab5af79cc93119e9402abb27e805c3923664ba Reviewed-on: https://chromium-review.googlesource.com/1077090Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#562612}
 - 
Jacob Dufault authored
Bug: 847040 Change-Id: Id32b31abdfa1dff8e8229bfb4eaa610d782d4789 Reviewed-on: https://chromium-review.googlesource.com/1077017Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#562611}
 - 
Ethan Kuefner authored
We have already whitelisted enough benchmarks that we want to flip the flag for all Telemetry benchmarks. system_health was the largest benchmark so we don't expect to encounter request deadline issues on the perf dashboard side. Bug: 744736 Change-Id: I62ce9511a32a56b3eb33bc35bdd6e487f135083f Reviewed-on: https://chromium-review.googlesource.com/1070219 Commit-Queue: Ethan Kuefner <eakuefner@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#562610}
 - 
Fabio Tirelo authored
This prevents the native border to be applied on the widget, so only the border style provided by views will be applied. This has no effect on Windows, but on Mac we get exactly what we need. Screenshots (Googlers only): https://drive.google.com/open?id=17hQlLXo5dk8XMwKU90wLgwigIVOhxPbn Bug: 847473 Change-Id: I5dccdadbae2405b259e3cad30857c0fb413a0338 Reviewed-on: https://chromium-review.googlesource.com/1076312Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#562609}
 - 
Caleb Rouleau authored
Bug: chromedriver:2436 Change-Id: If5ec3d6b6219a7d044ecf62498c6db378de8aba5 Reviewed-on: https://chromium-review.googlesource.com/1077171 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#562608}
 - 
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/36825590ba67..2b08f89076d1 $ git log 36825590b..2b08f8907 --date=short --no-merges --format='%ad %ae %s' 2018-05-25 marpan vp9-realtime: Move frame dropper to after scene detection. 2018-05-28 marpan vp9-svc: Fix to allowed value of max_consec_drop. 2018-05-23 jianj VP8: Fix use-after-free in postproc. Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com BUG=842265 Change-Id: I3accf4ed9e8ce3ad6277c5ba9f34f380d4bb4f76 Reviewed-on: https://chromium-review.googlesource.com/1076899Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#562607}
 - 
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/edb9947..46ef7c4 git log edb9947..46ef7c4 --date=short --no-merges --format='%ad %ae %s' 2018-05-29 sullivan@chromium.org Update the monitoring template with better terminology. Created with: gclient setdep -r src/third_party/catapult@46ef7c4 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I64aedbc8add12d72c5f189c574660bc14f0df8b0 Reviewed-on: https://chromium-review.googlesource.com/1077067Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562606}
 - 
Chromium WPT Sync authored
Using wpt-import in Chromium 57b6b5db. With Chromium commits locally applied on WPT: d78c1e54 "[Resource-Timing] Fix `initiatorType` values" 6534acd9 "[css-grid] Baseline alignment inside the tracks sizing algorithm" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18904 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I5006332f24cac497f9437dca1f1ecd374526cca0 Reviewed-on: https://chromium-review.googlesource.com/1077089 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#562605}
 - 
Robbie McElrath authored
Bug: 802815 Change-Id: Ib69ad4d375648cdd8026b457f274c9a54894c54f Reviewed-on: https://chromium-review.googlesource.com/1075860 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#562604}
 - 
Mathieu Perreault authored
The HTTP-not-secure warning was removed, so removing the supporting code for some of its visual changes (one-line support, bigger text, etc.) Bug: 841772 Change-Id: I7f01bbd9fdcdf3d75b8b4f7c0a46c318cc4c884c Reviewed-on: https://chromium-review.googlesource.com/1075510Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#562603}
 - 
Robbie McElrath authored
Bug: 802815 Change-Id: I043daf9fb62c2a13fa6630173808a089e1c64c50 Reviewed-on: https://chromium-review.googlesource.com/1073947 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#562602}
 - 
Amy Qiu authored
Since the 'action_on_load_complete' attribute is only used by one child class, move it out of the parent class. Bug: 760553 Change-Id: I364794926e8d6b342e5b22402cefd6893dd3b5a2 Reviewed-on: https://chromium-review.googlesource.com/1076976Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Amy Qiu <amyqiu@google.com> Cr-Commit-Position: refs/heads/master@{#562601}
 - 
Justin Novosad authored
This change prepares unit tests for having a new dependency on CanvasResourceProviderHost, which will soon be the owner of the CanvasResourceProvider instance used by 2D canvas. Drive-by refactor: some tests that were formerly implemented in fixture methods (for no good reason) were moved out. BUG=788439 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I68331760a9ecb47efc6d91b185dd4ddc7a38dee8 Reviewed-on: https://chromium-review.googlesource.com/1077068Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#562600}
 - 
Takuto Ikuta authored
When we use relativized include dir, /showIncludes shows relativized path for the files in include dir. This is an effort of removing absolute path from compiling output. Bug: 439949 Change-Id: I056cd8bb08c10f01855ef3bdb56ea1bcce1b769b Reviewed-on: https://chromium-review.googlesource.com/1075947Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#562599}
 - 
dpapad authored
Bug: 847007 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I865f56c836845d11b32aba7f4c12e43cd72a9d1a Reviewed-on: https://chromium-review.googlesource.com/1077073Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#562598}
 - 
inglorion authored
Some test cases in cast_unittests fail with official_build = true, causing bots with that configuration to be red. This change disables these cases. Bug: 612496 Change-Id: I2993729b3e6d3b268d2291b2046e8f189ba92681 Reviewed-on: https://chromium-review.googlesource.com/1074383Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#562597}
 - 
Matt Menke authored
They used to directly add an entry to TransportSecurityState, but now they set up a second test server, and use a response from that to pin a cert. Bug: 844034 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie9efefadc23d1518a0be25e7d8238489275feb3e Reviewed-on: https://chromium-review.googlesource.com/1073195 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#562596}
 - 
Robbie McElrath authored
This migrates all the layout tests in device_orientation/motion to use fake mojo services instead of testRunner.setMockDeviceMotion. Bug: 802815 Change-Id: I2175bd9f463b4a9e0fc69fa83af3d2ff8fb821e2 Reviewed-on: https://chromium-review.googlesource.com/1073920 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#562595}
 - 
David Black authored
UX spec dictates that if not in stylus mode: - Height should be >= 200dip. - Height should grow to match contents. - Height should not shrink until Assistant UI is closed. Note that now UiElementContainerView needs to always be visible so that it can fill the remaining space, even when empty of children. Demo in bug. Bug: b:79432250 Change-Id: I32372467bb8fff2b74885014b34152ce907be1bf Reviewed-on: https://chromium-review.googlesource.com/1074373 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#562594}
 - 
Jennifer Apacible authored
This change adds support for tapping on the Picture-in-Picture window. Previously, the user can only utilise mouse and keyboard input to interact with the controls. Bug: 836389 Change-Id: I1dafe2fae098003196c383fd2f7cd5e270e384d3 Reviewed-on: https://chromium-review.googlesource.com/1075559Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#562593}
 - 
Roger McFarlane authored
This CL adds a unittest to validate that autofill queries expire from the HTTP cache. Bug: 837830 Change-Id: I5f78a9dfffd3c3ec895251f2a1323a28ff828b1e Reviewed-on: https://chromium-review.googlesource.com/1075557 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#562592}
 - 
Oliver Chang authored
Bug: 847388 R=rockot@chromium.org Change-Id: I02a661071e41a7513b4e3aa9bc929e127c78c74f Reviewed-on: https://chromium-review.googlesource.com/1076109Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#562591}
 - 
Wez authored
Bug: 844016 Change-Id: Ida401d3f0dd2b6aa6f82219f4cf3c0ca417762c5 Reviewed-on: https://chromium-review.googlesource.com/1075725Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#562590}
 - 
Chris Mumford authored
Very minor cleanup. Switching to initializing extensions_delegate_ in the class member initialization section instead of the constructor body. Bug: None Change-Id: I439d3ef34832d9c883f0c9cf0d92df8fbc378d0f Reviewed-on: https://chromium-review.googlesource.com/1076685Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#562589}
 - 
Caleb Rouleau authored
Change-Id: I0d25d7a9f1383044d2436d8fcfb81c559d068297 Reviewed-on: https://chromium-review.googlesource.com/1077016Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#562588}
 - 
Ted Choc authored
In multi-window, the non-focused window will have the state of paused even though it is fully visible. So look for resumed only when in non-multi-window, but accept paused when in multi-window. This differs from MultiWindowUtils.isActivityVisible because that only mentions visibility, but I am aiming for visible and not occluded. BUG=845785,844787 Change-Id: Ifcca3784b899a4a19132b3b57efd5227dc2b3e90 Reviewed-on: https://chromium-review.googlesource.com/1076894Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#562587}
 - 
Adithya Srinivasan authored
The test is currently flaky on the Mac trybot. Bug: 847565 Change-Id: Ic40919118fcd7a2bbc0c0d34a33fac9c3c554aea Tbr: falken@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1077198Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#562586}
 - 
Jeffrey Kardatzke authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/f6223168d99e..55139d2ab617 $ git log f6223168d..55139d2ab --date=short --no-merges --format='%ad %ae %s' 2018-05-22 jkardatzke Added constants/proto for vm_cicerone 2018-05-22 baileyberro system_api: Add SmbProvider::ParseNetBiosPacket to DBus 2018-05-18 tbarzic Add demo_session_apps_path to UpgradeArcContainer request 2018-05-22 cmtm arc: Remove StartArcInstance dbus method 2018-05-15 smbarber vm_concierge: add LaunchVshd method 2018-05-21 smbarber vm_concierge: export goprotos as system_api/vm_concierge_proto Created with: roll-dep src/third_party/cros_system_api Change-Id: I794ebf5dd85d21f41b782ed84e5cfe1ac428b0fd Reviewed-on: https://chromium-review.googlesource.com/1076677Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#562585}
 - 
Paul Jensen authored
Bug: 842456 Change-Id: I8f0c17cd50c75987c051e62344ac5e907e1b1133 Reviewed-on: https://chromium-review.googlesource.com/1065463Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#562584}
 - 
Fernando Serboncini authored
This fixes the test, but not the underlying problem. A separate bug has been created to track this TBR=junov Bug: 810437,847594 Change-Id: Id142b936af3378385b4fcc199ed193f5a0fb2241 Reviewed-on: https://chromium-review.googlesource.com/1077098Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#562583}
 - 
Max Moroz authored
https://chromium.googlesource.com/breakpad/breakpad.git/+log/c83fcf647..27c001192 $ git log c83fcf647..27c001192 --date=short --no-merges --format='%ad %ae %s' 2018-05-27 mmoroz@chromium.org Add SEVERITY_CRITICAL to logging, that would help to suppress logs from the fuzz target. 2018-04-13 thestig@chromium.org Read Linux si_code in minidump_processor. Bug: 846721 Change-Id: Ib7d34a0dd393951be8ab6e30d0c5f341fed3389b Reviewed-on: https://chromium-review.googlesource.com/1077078Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#562582}
 - 
Roger McFarlane authored
Bug: 806987 Change-Id: Ib243063242efccf5469223804b2f569f7973bbd5 Reviewed-on: https://chromium-review.googlesource.com/1076321Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#562581}
 - 
Gabriel Charette authored
My regex wasn't complete in https://chromium-review.googlesource.com/1062830 now there are warnings on 180 metrics as desired (182 identified @ https://bugs.chromium.org/p/chromium/issues/detail?id=807615#c19 minus the 2 fixed in initial CL). R=mpearson@chromium.org Bug: 807615 Change-Id: I4ef7ac8cf84b2a7e2222d3cb06d79aeb07de8108 Reviewed-on: https://chromium-review.googlesource.com/1069850Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#562580}
 - 
Anders Hartvoll Ruud authored
All properties are now Ribbonized, so we don't need to generate a massive switch statement anymore. R=futhark@chromium.org another code generated. Note: make_style_builder.py has been kept, because it's actually imported Bug: 751354 Change-Id: I952fc4e30dff3f42ed0e926cd7e4d7ab60705794 Reviewed-on: https://chromium-review.googlesource.com/1076328 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#562579}
 - 
Dominic Mazzoni authored
The problem was that if you call hitTestWithReply on a node in one tree (like the desktop, typically the most logical place to call it), it was storing the callback in a map specific to that try. But then when the hit test result came back via an event on the correct target node, that node might be in a different tree - and that tree had its own map from action IDs to callbacks. Tested by manually calling desktop.hitTestWithReply with coordinates in the middle of the feedback link on the www.chromevox.com homepage. Bug: 818108 Change-Id: I5b995f381f6e260ddcb0f7a1f58a64d0682af949 Reviewed-on: https://chromium-review.googlesource.com/1074490 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#562578}
 - 
Jennifer Apacible authored
This change makes the button a little smaller with less buffer white space around it. Bug: None Change-Id: I6bb7bb6e2ee6f773c7c85019055abbc694a5d312 Reviewed-on: https://chromium-review.googlesource.com/1075852Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#562577}
 - 
Sebastien Marchand authored
Follow up on this comment: https://chromium-review.googlesource.com/c/chromium/src/+/1068665/13/services/resource_coordinator/public/mojom/page_signal.mojom#18 Change-Id: Ib930db9c0326c9fae8cd7c2bf8b771d5a196c164 Reviewed-on: https://chromium-review.googlesource.com/1076897Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#562576}
 - 
Helen Li authored
- Add extra return values to NetworkContext::CreateTCPConnectedSocket, because //extensions depends on the ability to get local address and peer address synchronously. - Add a network::mojom::SSLConfig to UpgradeToTLS() because //extensions depends on the ability to configure max and min tls version. - Add two non-pure virtual methods (SetNoDelay and SetKeepAlive) to net/socket/transport_client_socket.h, so I can mock out those in tests using mock socket data (net::MockClientSocket is a subclass of net::TransportClientSocket). Bug: 721401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I2019d783b29ff0d68dbea95fb7a0f2d5e81a70fd Reviewed-on: https://chromium-review.googlesource.com/1073191Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#562575}
 - 
Anders Hartvoll Ruud authored
This makes custom properties _almost_ normal w.r.t. style building. As long as we DCHECK that the value is not initial/inherit before applying, we can treat it as any other CSSProperty. R=futhark@chromium.org Bug: 751354 Change-Id: I2009320d95e1371df550fd2a55d7d561042d2061 Reviewed-on: https://chromium-review.googlesource.com/1076327 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#562574}
 
 -