- 25 May, 2020 40 commits
-
-
Anders Hartvoll Ruud authored
This is not marked as a surrogate currently, which means that it won't cascade correctly along with text-orientation in some cases. Change-Id: Ieee83f5176b568c9fbb75b4d6044f266a17357c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210354Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#771552}
-
arthursonzogni authored
Compute the sandbox policy of a document in the RenderFrameHost. For now, this is simply used to double check the value computed from the renderer. If this works correctly, the browser process will use it and stop depending on the renderer process. Ideally, this patch must land for M84, in order to get useful reports. This patch is a step in the following direction: ~~ Stop parsing the HTTP CSP sandbox header in blink. Parse it in the network service CSP parser. This allows the browser process to compute the Origin of the new document before loading it. ~~ https://docs.google.com/document/d/1PechV73KKMF8leh7uTlyGkR32kD5qILvu3ZeG8TYGfk/edit?usp=sharing Bug: 1041376 Change-Id: I26d0e3744bc1b5b2d893fd01b6e6ecea35cf47e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190680 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#771551}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b85889d6d5fa..236e0ed83a36 2020-05-25 eshr@google.com Add logging for video restrictions 2020-05-25 danilchap@webrtc.org In media/ and modules/video_coding replace mock macros with unified MOCK_METHOD macro If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0b087ded2cee22fa19d6216869dcac26fa04f688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214992Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771550}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3b84585447f1..da1f4705f664 2020-05-25 changhaohan@chromium.org add style tag's media query rule to media query inspector If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1069467 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id84f512f594513503eab6d90a3b9a61766605848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214991Reviewed-by:
-
Kush Sinha authored
- Point *signin_error_notifier*'s per-file OWNERship to OWNERS of Chrome OS Account Manager. - Add anastasiian@ as an OWNER of Chrome OS Account Manager. Change-Id: Ice2e9d8231c6f8cba2f5f6aad408425478b0550f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214944Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#771548}
-
Alan Cutter authored
Previously HostedAppBrowserController was used for web apps running on the Extension system. Since https://chromium-review.googlesource.com/c/chromium/src/+/2206864 we now use WebAppBrowserController exclusively for all web apps regardless of whether they're running on Extensions or BMO. This CL removes any web app specific logic from HostedAppBrowserController now that it's only used by hosted apps that aren't bookmark apps. Fixed: 1085692 Change-Id: I6bc94615fb8175edca58dafeaf180a084c15b453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214846 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#771547}
-
Nigel Tao authored
Bug: 1070409 Change-Id: I77f1865c891b606f96886c106bb0f0f10e9a0241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212118 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#771546}
-
Saurabh Nijhara authored
Update required screen is only shown after enrolment, hence it is not required for OOBE. This CL also includes some refactoring in the update required screen browsertests to make independent of OOBE flow. Bug: 1085090 Change-Id: I9953ed666710ec6fe0111b6468816c3df29e0318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209220 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7eccfc6933c7..b85889d6d5fa 2020-05-25 danilchap@webrtc.org In p2p/ replace mock macros with unified MOCK_METHOD macro If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I95e0f5fcd6388e4a7069ad07b7a67be35d19462e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214989Reviewed-by:
-
Anders Hartvoll Ruud authored
Bug: 1057072 Change-Id: I1329af49c97d1cd4bec073334c0b8d23645758bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209081 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#771543}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c746ac65e9d6..ef877fb5c549 2020-05-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from b2cfe61366da to 6ff146b0bfce (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Icbd31144e77f78a0698bf5b883979734d8e14389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214986Reviewed-by:
-
sandromaggi authored
We no longer want to rely on the inbuilt |isComplete| check of Autofill objects, instead we want to consistently use the same verifier in the native action as well as the view to prevent scenarios where the action and the UI have different states. Bug: b/154068342 Change-Id: Ibc3572946c50e1d5181642155cedd1c21a42975e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201602Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#771541}
-
Jana Grill authored
Retrieve the value of kCrostiniArcAdbSideloadingUserPref and check its value when deciding whether to enable or disable the adb sideloading toggle in settings managed device and/or account when feature flag is enabled Bug: 1067577 Test: unit tests, passing different policy values using YAPS on a Change-Id: Iaa452b9e5716392600332f6c965b142136990b82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199283Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#771540}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/471dd7ffcd7e..c00a59a215e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC marinaciocea@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: marinaciocea@google.com Change-Id: I1cb94fc5e6f37e4709efba76b50c36713861b560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214985Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771539}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2196ceef. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent" fc4093a6 "Move mouse-pointer-preventdefault.html to wpt" 3304d0fe "Revert "Move mouse-pointer-preventdefault.html to wpt"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I934498f3d1e444962e6a0ac9cfad814b18df931a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213065Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771538}
-
Peter Kasting authored
These can simply be owned by the View hierarchy as normal. However, doing this requires making command unregistration happen before the view is removed from the widget. This is semantically parallel to how command registration already happens after the view is added to the widget, so it makes sense, but requires some plumbing. Finally, does a few small cleanups along the way. Bug: 1044687 Change-Id: Ie5c6988da179b89b3b63632134d4a4258fffd436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210902 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#771537}
-
Maksim Moskvitin authored
SyncEncryptionHandlerImpl is no longer used in production code. This CL removes all UMA_HISTOGRAM*() calls from it. Corresponding histograms are either instrumented in modern codepaths (nigori_sync_bridge_impl.cc, pending_local_nigori_commit.cc) or marked as obsolete. Bug: 1083924 Change-Id: Ia77efce35af460a079a26e0cf31e828d13dff4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209210Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#771536}
-
Oleg Davydov authored
This commit moves expire date of the following histograms: * Extensions.ContentVerification.ComputeHashesOnInstallTime * Extensions.ContentVerification.ComputeHashesOnInstallResult * Extensions.CorruptPolicyExtensionDetected3 Bug: 1084094, 1084095 Change-Id: Ic9bb67f5cd4bc3d99075f7030da639b4e9364d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207227Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#771535}
-
Nigel Tao authored
Bug: 1070409 Change-Id: Ia7308b7a93552e118225d323084af66122a1340d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212193Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#771534}
-
Nigel Tao authored
Bug: 1070409 Change-Id: I40a9b6ccd2d96f4c285119c1cc11fd7f5e57065d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212192Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#771533}
-
Friedrich Horschig authored
This CL adds guard clauses to prevent the use of the manual filling component before initialization or after its destruction. At this point, basically every single public method is prefaced with that which means that we should think of a (long-term) solution that either doesn't even allow accessing the component until the native initialization finished or defers the calls to that component. Bug: 1084196 Change-Id: I9cc17bc34dad666fa542c9be70bc78aee42ec586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209137 Auto-Submit: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#771532}
-
Nigel Tao authored
Bug: 1070409 Change-Id: Ib26b5d5d9a6ddf20da57c9e11be43de9cfb1d7be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212117Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#771531}
-
Anders Hartvoll Ruud authored
Special care had to be taken in order to make border-*-width properties testable: if the corresponding border style is hidden or none, the border-width property computes to zero per spec. Therefore ComputedStyleWithValue is now manually setting the border style to kSolid. Bug: 1057072 Change-Id: I9f226cc46a0bcdadf4ad0e8ba0b35d0cbe14ec52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209075 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
The visible URL isn't relevant. Tbr: arbesser@google.com Bug: 1081389 Change-Id: Ia51578c7bec93e70d5def3acda9b4f1ffbb3fc23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210680 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#771529}
-
Yoshifumi Inoue authored
This patch changes "5065910.html" to utilize |selection_test()| and renames to "typing_style_color.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Icb740c1a60e51d874c54ce553c33671b5e22f3de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212195 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#771528}
-
Nigel Tao authored
Bug: 1070409 Change-Id: I4e20be0704e7943a93a59e437f4126296c650740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212232Reviewed-by:
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. Several tests are updated to use the new API. This CL does NOT change any behavior. Bug: 1060940 Change-Id: I632623a7d718a1d56f01853ecabcb3a34823974e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213562Reviewed-by:
-
nancylingwang@google.com authored
BUG=1068884 Change-Id: I33f31eeec0f520f0a135c2c70f56b96d6e42a9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203787 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771525}
-
Kim-Anh Tran authored
This adds a webtest to check if we can pause execution in a script compiled using streaming compilation. Bug: chromium:1079328 Change-Id: I68756c333a0ff69294f5bf210b0a6004412ee774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202897 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#771524}
-
Matthias Körber authored
Without this addition, the interpretation of the current metric is hard because it is not post-selected on the presence of a valid ADDRESS_HOME_LINE1 field. Change-Id: Ibdd9a34a80c702729d6abbd188d4174161026b46 Bug: 1083867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206653Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#771523}
-
Saurabh Nijhara authored
This is a follow up CL of https://chromium-review.googlesource.com/c/chromium/src/+/2161072 in which it was recommended to convert the |expected_version| member variable from std::string to base::Version. Bug: 1076376 Change-Id: Iaf49b0374aedbe47127e6c794204adc99853f3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207216Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#771522}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I9728063d5b8144d5bef557580d3a97438995ac6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214921 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#771521}
-
Marina Ciocea authored
This reverts commit 769719f1. Reason for revert: Suspect of breaking win-archive-rel: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/14224? Original change's description: > Adding mojolpm fuzzer generators. > > This adds code that generates libprotobuf-mutator based > structure-aware fuzzers as part of the mojom compilation process. > (changes in //mojo). > > This is a cherrypick/split from > https://chromium-review.googlesource.com/c/chromium/src/+/2108507 > > Pragmatic fixes for the remaining missing dependencies. > > Change-Id: I0e0d34a4b99b31f99ee872fb95be993043aef402 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170830 > Commit-Queue: Mark Brand <markbrand@google.com> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#771513} TBR=rockot@google.com,markbrand@google.com Change-Id: I15ea11fbc72b9e2a804ca8c49be12f89d4c465a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213566Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#771520}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590378757-0e86ea9817fe6c644c14c0cd7e1701a48ebcda53.profdata to chrome-mac-master-1590392885-f817e2f6c6f861a55dc86221cdd5b022c49b4b4c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I364be619f6aa2009ae25085338fdbb80a2f00c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214983Reviewed-by:
-
Fredrik Söderqvist authored
Everything that accesses SVGAnimatedEnumeration<Enum> will read the current enum value, so cut directly to the chase instead and drop the unnecessary CurrentValue/BaseValue overloads. Change-Id: Ib7b56ae106ca6531e461e3b47973782112860ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207450Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#771518}
-
Dale Curtis authored
Changing the buffer size when streams are active appears unsafe, so avoid increasing it. Future stream creation will still use a lower buffer size where possible. I'd expect this use case to be rare. R=henrika Bug: 880261 Test: None. Change-Id: I5fb857da5ae31b3d90df90dd784f90c9511264e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208295 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#771517}
-
Morten Stenshorne authored
This is the final missing piece for bug 1053768, which is about adding support for named pages and page orientation, so that an author can specify that certain pages should be rotated clockwise or counter-clockwise, without affecting layout. The effect of the rotation will only be observable in print preview, and when saving the paginated layout to file (typically PDF). The page-orientation descriptor is defined here: https://drafts.csswg.org/css-page-3/#page-orientation-prop Test: third_party/blink/web_tests/printing/page-orientation.html Bug: 1053768 Change-Id: I7f7b67b322592c1e90305c88a2088a567247b044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206633 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#771516}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. The use of the function in c/b/profiles tests is updated. Bug: 1060940 Change-Id: I168e48fac82eec6dc968a15818412c5eceaeb352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213564Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#771515}
-
Alexey Baskakov authored
A callback code may call Write() on `this` database immediately in the callback. Since previous fix was reverted, https://chromium-review.googlesource.com/c/chromium/src/+/2213648 let's start with a more simple synchronous fix. We will investigate that test on Mac separately. TBR=ericwilligers@chromium.org Bug: 1084939 Change-Id: I6561789f226384e724940bc9bf024d6969c719ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213650Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Mark Brand authored
This adds code that generates libprotobuf-mutator based structure-aware fuzzers as part of the mojom compilation process. (changes in //mojo). This is a cherrypick/split from https://chromium-review.googlesource.com/c/chromium/src/+/2108507 Pragmatic fixes for the remaining missing dependencies. Change-Id: I0e0d34a4b99b31f99ee872fb95be993043aef402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170830 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#771513}
-
