- 11 Jan, 2021 40 commits
-
-
Adam Langley authored
At several points in the past we have wanted a Finch-controllable filter. This change attempts to add a fairly generic one that would have met all the previous needs. Change-Id: Iec25677b9bca532c45844933cf7d5d0d95e00764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612051Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#842117}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fff8e7632e28..bdc7f626dbce 2021-01-11 primiano@google.com Merge "ui: Update NodeJS and Wasm toolchain" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3c1785fb63b576631198b1c9484bbde674b753c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621953Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842116}
-
Tarun Bansal authored
Add skip_in_background to field trial testing config Bug: 1032153 Change-Id: Ie9fe3b94ad1b7fce3233a469a2c56ed383de0349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621888Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#842115}
-
Evan Stade authored
Bug: 1158946 Change-Id: I60a2a192977bffabbac9077ff9f3e36d73589bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611228 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842114}
-
Clark DuVall authored
I needed to fix the IsolatedSplitsSynthetic trial to only log for monochrome, and thought it might be useful to have this as well. This will let us filter UMA data by the WebView APK type, and can help us answer the age old question of how many users have standalone WebView on N+. Bug: 1150162 Change-Id: I4cc97632f514b0c54b07e205c33dd1c1d3703071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618625Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#842113}
-
Evan Stade authored
To do this, AddToHomescreenParams is moved to //components. TBR=dtrainor@chromium.org Bug: 1164069 Change-Id: Id84add9db5a9e55b9f494e4f0d1cac79036eef52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617202Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#842112}
-
Ulan Degenbaev authored
This adds WebMemoryAggregator::VisitWorker for handling dedicated worker. It is simpler than the frame case because dedicated workers have the same origin as their parent (frame or worker). Additionally, aggregation never starts from a dedicated worker. Bug: 1085129 Change-Id: If319fce5af3933870822f92bd6f360f524e33c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616705 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#842111}
-
Mark Schillaci authored
This CL addresses a NullPointerException crash on Android. The AccessibilityTabModelAdapter was throwing an NPE during getItemId due to getId being called on a null Tab. We now check for null and return an invalid tab id rather than crash. Bug: 1164544 AX-Relnotes: N/A Change-Id: I6e19dd834271d3ba255d46d26da8284d3ce93bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618681Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#842110}
-
Yao Xiao authored
Why: This is the expected behavior. We should keep calculating and serving the floc even if sync/swaa/nac is disabled. Those bits should only affect event loggings. How: Create the FlocEventLogger class for the sync/swaa/nac permission checks and the loggings. Removed the checks in the floc_id_provider. Given that the sync service is often ready a few moments after the browser start, but the floc may already have been computed before then, for practical purposes, each logging attempt that fails the initial sync-history check will be given a second chance 10 seconds later. For sync_integration_test: Remove the feature list initialization and a test: With the new change, the 1st FLoC event logging will at least happen 10 seconds after the profile initialization, so we no longer have the previous issue that the FLoC event being logged right after sync setup. The removed test is essentially similar to the floc browsertests (e.g. FlocIdProviderWithCustomizedServicesBrowserTest. FlocIdValue_ImmediateComputeOnStartUp), so we don't need to have another test. Bug: 1160317 Change-Id: Iec357579fb179b2fdc3a327b2089c5a321d109ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597014Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#842109}
-
Jonathan Backer authored
https://bugs.chromium.org/p/chromium/issues/detail?id=1079161#c32 SkiaRenderer GL seems to be tickling a driver bug where the driver sometimes reports 32 texture units and other times 96 texture units after a context lost event. This leads to crashes in GPU process context virtualization code. Try restarting GPU process instead to see if that fixes the problem. Bug: 1079161 Change-Id: Ib6a91323b05978193fb7f6e3b26e7dbd850d0509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621873Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#842108}
-
Nancy Wang authored
The parameter id of the function HandleRestoreNotificationClicked is user-after-free on builder "Linux ChromiumOS MSan Tests", because the notification is closed at the beginning of HandleRestoreNotificationClicked, which may cause `id` becomes uninitialized. Move notification_ as the class variable to hold the notitification id in the function HandleRestoreNotificationClicked to resolve the unit tests issue. And enable the disabled unit tests. BUG=1146900 BUG=1164559 Change-Id: Iabf8ad0233944cce071b3c2be1a10ca746ed2a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619409 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842107}
-
Tanmoy Mollik authored
Method OnPrimaryAccountCleared() is deprecated. This cl changes the unified_consent code to use OnPrimaryAccountChanged() instead. Bug: 1158855 Change-Id: I79f04420e957a95972651851b3dd706e7a9eaa05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622373Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#842106}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ccdfc9bed156..6f4e54f003dd 2021-01-11 brgoddar@microsoft.com Limit Datagrid Screen Reader Alerts to Focused Grids 2021-01-11 jacktfranklin@chromium.org [Dark mode]: generate dark styles for cmdevtools.css 2021-01-11 morlovich@chromium.org Custom UA ch editting: fix key behavior on the folder 2021-01-11 machenbach@chromium.org [build] Remove obsolete gn flag If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152736,chromium:1162902,chromium:1164034,chromium:1164276 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iffc9be97d143af1c169691875a847018cb089016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621885Reviewed-by:
-
Trevor David Black authored
Bug: 172489285 Change-Id: I041c4722f630fa615d7727c2767f08e605032e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616980Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#842104}
-
Ziran Sun authored
This leaves flexibiity for other properties referencing corners in the future. Bug: 1155270 Change-Id: I67c7f90c1c8c67f31903a1e3455fb504db21f2ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595033Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#842103}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/eddc7d0df5d1..3bf3659d351a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2059458a568705e11c92c782a25e3e50b9bc0b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622273Reviewed-by:
-
Tomasz Wiszkowski authored
This change addresses the scenario where: - the user is on a website with an input field - the input field (not the Omnibox) is focused, raising keyboard, - the user next presses the overflow menu. In this situation, the keyboard should be dismissed. Bug: 1160617 Change-Id: I84716a264b20c2a57dc6c836325a6d94e14163dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613516Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#842101}
-
Abigail Klein authored
This ensures that the AnnounceTextView is purely an announcement and cannot be navigated to by a screen reader. reader. Bug: 1161047, 1055150 Change-Id: I6ca8157261b2f8fc94978121807de008d59166d4 AX-Relnotes: Announcements in Views are not navigable to by a screen Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617220Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#842100}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/183461f40237..f0cb733b1b1c 2021-01-11 johnstiles@google.com Remove redundant constantPropagate in Swizzle. 2021-01-11 robertphillips@google.com Remove DDLTarget tracking from the GrDrawingManager If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: I5efd1b04eb908e2be0703d65f754e834a5fba76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621875Reviewed-by:
-
Sylvain Defresne authored
A single boolean was used to save whether the UI was showing incognito or regular UI, however with multi-window enabled, each window can be displaying a different UI. This global was read on launch to decide whether incognito UI should be displayed or not. If the window in the foreground when the app was terminated was showing incognito UI, but user start the app by opening a window with no incognito tab, the startup code would consider this an inconsistency, delete all incognito state and switch to regular UI. This behaviour is incorrect when multi-window is enabled and can lead to losing the incognito tabs on app startup. To fix this, convert the bool indicating whether the UI was showing incognito or regular tabs to be per-session (i.e. per window). Also in case of inconsistency (which can still happen if user quit the app while showing the incognito tab switcher after having closed the last incognito tab of the current window), do *not* clear the incognito data (it will only be cleared when the app restart after a crash). Bug: 1163505 Change-Id: I8410acf6f8feadb747d01889a2812e91d5391709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611101 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#842098}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I9fb2c28603eeb7b0c64c61154b8ef87e2cc7f25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621693Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842097}
-
Ian Elliott authored
We've seen a number of flaky failures with Windows7 FYI AMD bots lately (i.e. different tests occasionally fail once). This is taking too much Wrangler attention. This CL should quiet down the flakes. Bug: angleproject:5513 Change-Id: Ic5af13c71da76c1f5a9edb7746201559d455df23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619318Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com> Auto-Submit: Ian Elliott <ianelliott@google.com> Cr-Commit-Position: refs/heads/master@{#842096}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/eddc7d0df5d1..3bf3659d351a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5f0cf03d1b55e98e026403e1cbabb7eedaa7da6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621876Reviewed-by:
-
David Roger authored
See discussions: 1) https://docs.google.com/presentation/d/1Mrt7ZQV_VwJ6IBpmA-GFKk-lVx7RkdAJHo3ADSooIAY/edit?disco=AAAAIzo6kto 2) https://docs.google.com/presentation/d/1Mrt7ZQV_VwJ6IBpmA-GFKk-lVx7RkdAJHo3ADSooIAY/edit?disco=AAAAHlUIHWE Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/88cd55b4bf04fb8e41c5196e0570d72599088733 Change-Id: I921bf31a5a9978c07f8110b23ab2bb4d8f996564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622313Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#842094}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/8144af91b4f9..1d9935cf37fd 2021-01-11 rharrison@chromium.org Revert 3 fuzzing CLs, since they are preventing rolling into Chromium. 2021-01-11 dsinclair@chromium.org Convert ScopeStack over to symbols. 2021-01-11 dneto@google.com spirv-reader: Reject dref sampling with Bias or Grad 2021-01-08 dneto@google.com Roll third party dependencies 2021-01-08 dneto@google.com spirv-reader: rename variable 2021-01-08 rharrison@chromium.org Adding fuzzing for Transforms 2021-01-07 rharrison@chromium.org Add fuzzers for various emission paths 2021-01-07 rharrison@chromium.org Create common utility class for fuzzing 2021-01-07 bclayton@google.com Add tool to check the WGSL spec examples compile If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I57e6941520001e04b1436eb03dc915818e6a6b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621880Reviewed-by:
-
Josh Nohle authored
Currently, if the sum of attachment sizes exceeds 25MB, WebRTC will be disabled regardless of the user's data-usage setting. Because we already provide the user an option to only use unmetered connections, we make changes in this CL to respect the user's setting regardless of attachment size. We also add additional logging of supported mediums. Manually tested that the correct mediums are sent to Nearby Connections; however, there is an outstanding bug in Nearby Connections (b/176432167) that supported medium choices are not respected. Fixed: 1164688 Change-Id: I749ab72aaf48feac7e799561f1ad1bbb961f5e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619319 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#842092}
-
David Roger authored
See discussion here: https://docs.google.com/presentation/d/1Mrt7ZQV_VwJ6IBpmA-GFKk-lVx7RkdAJHo3ADSooIAY/edit?disco=AAAALEzRChg Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/01b5644780ba124b0c8cd95bad41ce935e3e26a2 Change-Id: I7830f13efd02fc1f5619bdd75b9117503fb10065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622172 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
-
Joon Ahn authored
http://screen/4wX4sJuYUhvc3ub Bug: 1125150 Change-Id: I88ab06756737b97c39de9c7d409395b0ef55db53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599425 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#842090}
-
Andrew Grieve authored
I've seen it come in code reviews several times where devs are thinking that android:debuggable="true" should be added. This is caused because the AndroidManifest.xml expecations check will locally tell you to add it if you build without is_official_build=true. There is no risk of this attribute slipping in unnoticed since play store won't allow apps to be uploaded with it set, so this filters it out to remove the annoyance. Bug: None Change-Id: I1459f6af3f78f34f12cc9f6e14157e97fe7d91e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620643 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842089}
-
Maksim Moskvitin authored
If device was successfully registered with unknown epoch/trusted vault key, first DownloadKeys call won't have any key available and incoming keys validation should be skipped. Note: strictly speaking, there is a constant key; but performing validation using it doesn't add any value, while would make future changes harder. Bug: 1113598 Change-Id: Ib978987b4ba1304f40c54414ea79ef08d7ebb6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620262 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Michael Hansen authored
In certain cases the default device name can be generated without the user's given name, e.g. just "Chromebook". This occurs when adding a second user account to a device, where the default device name is generated immediately on completing login but before user details have been downloaded. This updated logic caches the default device name in the NearbyShareLocalDeviceDataManagerImpl rather than storing it in prefs. Fixed: 1151667 Change-Id: Ica79907506624647f630a798f08d9201ea381a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622592Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#842087}
-
Laís Minchillo authored
Add a setProxyOverride method that takes in a boolean for reverse_bypass. This will be exposed via androidx.webkit APIs. Add a new test in proxy_config_service_android_unittest and in AwProxyControllerTest to test the newly added reverse_bypass option. Bug: 1162255 Test: run_net_unittests -f *ProxyConfigServiceAndroidTest* Test: run_webview_instrumentation_test_apk -f *AwProxyControllerTest* Change-Id: Icc82656809b9237d6a8defb125b57727d59777ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544645 Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#842086}
-
Dave Tapuska authored
Add a new interface PepperHungDetectorHost that is used on the renderer's IO thread to inform the browser about a hang of an out of process pepper plugin. BUG=1157519 Change-Id: I98c9fe3ead8544fae697f021456a72724c80b81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618287 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842085}
-
Daniel Nicoara authored
https://chromium-review.googlesource.com/c/chromium/src/+/2613152 updated the NativeDisplayDelegate API. Update the usecase to fix the build. Bug: b:177105618 Test: Build cast_shell internally Change-Id: I9234a35d2dcdb6585dd1df6be8f650254eb7c01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622275 Commit-Queue: Gil Dekel <gildekel@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#842084}
-
Wez authored
Change-Id: I8a9076cc0b392b1efcd411c2f666349af3e0ea2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622112 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#842083}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1f19c9cd819c..04314b1d8edb 2021-01-11 ahassani@chromium.org cros_flash: Remove --install flag for USB flash 2021-01-09 yyanagisawa@chromium.org Make GomaConfig.DEFAULT map to a Goma RBE cros build. 2021-01-09 mmortensen@google.com cros_logging: Improvements for CloudLogging initialization. 2021-01-08 jaredloucks@google.com constants: update skylab package pin from a constant CIPD instance ID to a label which can be moved between instances. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ia867e0298ab617a1e654f58f4895d022720297e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621773Reviewed-by:
-
Gabriel Charette authored
This is a reland of 2ecb8d17 Revert reason seemed unrelated, but FindIt is strangely convinced. The TSAN issue was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2618393 nonetheless. Original change's description: > [base] Fix trace events and blocking types when blocked on modal dialogs > > Sheriff notes: This is expected to artificially reduce IOJank* metrics. > > Modal dialogs launched via GetAppOutputInternal in launch_posix.cc > are guaranteed to block and thus should use WILL_BLOCK semantics > (as opposed to MAY_BLOCK like it did). > > However, Process::WaitForExit can't use WILL_BLOCK semantics because > of an existing workaround for TestLauncher to not use > ScopedBlockingCallWithBaseSyncPrimitives when waiting on processes or > TestLauncher ends up creating or TestLauncher ends up flooding > the pool to 256 workers regardless of --test-launcher-jobs > (it posts each test as a task right off the bat and expects the > pool to cap the parallelism...). > > The best solution to get proper tracing and thread restrictions > right is thus to add custom trace events and keep assertions > that waiting is allowed when launching the process. > > Each platform was doing something slightly different here, this > CL brings all platforms inline with annotations that are visible > in tracing but ignored by IOJank metrics. > > Example broken trace showing up in IOJank slow reports on Linux: > https://goto.google.com/btbzu (SS: https://snipboard.io/7sDO1r.jpg) > > R=fdoray@chromium.org > > Bug: 1064645, 1144161, 899897 > Change-Id: Id087f91df8c2201ca10db5438456c638f9b791e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233299 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Joe Downing <joedow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837874} TBR=fdoray@chromium.org,wez@chromium.org (identical as before) Bug: 1064645 Bug: 1144161 Bug: 899897 Change-Id: I8f4161d9c614db1670648b54d5949fdfe49a6b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621912Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#842081}
-
Sorin Jianu authored
This CL fixes a minor coding style issue. https://google.github.io/styleguide/cppguide.html#Rvalue_references According to the coding style, rvalue refs can only be used in a couple of scenarios, and they do not include returning rvalue references, or passing by rvalue reference, except in a specific case. This CL also fixes a couple of places where const pass by value was used instead of pass by ref to const. Since the initial intention of the code was to use move semantics, that intention has been preserved, especially to allow move semantics here: TagArgsBuilder& WithApp(AppArgs app) { this->inner_.apps.push_back(std::move(app)); return *this; } Due to how the code is used later on, move semantics for the TagArgsBuilder is not really needed but the implementation was retained to make TagArgsBuilder and AppArgsBuilder similar. The CL code is slightly less efficient than the original code but efficiency is not a first order concern in this module. Bug: 1164718 Change-Id: I8b7ff4d225728b1ed00b0b387649672f5553c3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620401Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842080}
-
Avi Drissman authored
Soon, with TargetChannel, an instance of Chrome on the disk might be upgraded to an instance of Chrome of a different channel. Cache the channel information on startup, so that even if it's changed, the channel information of the current running instance is available. This relands aa20f9b8 with a fix. Fixed: 1163159 Change-Id: If1e3da89ff70da765782dd4dbdf0505da67c4e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620839Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842079}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I1be953d59463c72467af4087b8557401568379e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619226Reviewed-by:
-
