GitLab

This re-lands the CL with the fixes to the GYP build.

TBR=brettw@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win8_chromium_gyp_rel,win8_chromium_gyp_dbg;tryserver.chromium.mac:mac_chromium_gyp_rel,mac_chromium_gyp_dbg

Review-Url: https://codereview.chromium.org/2156173003
Cr-Commit-Position: refs/heads/master@{#406165}

NOTRY=true
TBR=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2157263002
Cr-Commit-Position: refs/heads/master@{#406164}

blink::WebFrameOwnerProperties can't be sent over IPC because one of its members
is a WebVector which doesn't have ParamTraits defined. We introduce a new struct
in content to transfer the data.

BUG=614608
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2146803004
Cr-Commit-Position: refs/heads/master@{#406163}

The GenSyncTokenCHROMIUM function may fail if it generates an error, or
the context already has an error on it. At that point the sync token
will not be updated, so we should have it initialized to 0 for this
case.

R=kbr@chromium.org
BUG=629008

Review-Url: https://codereview.chromium.org/2162673002
Cr-Commit-Position: refs/heads/master@{#406162}

Review-Url: https://codereview.chromium.org/2151793002
Cr-Commit-Position: refs/heads/master@{#406161}

Revert of Remove Mac10.11 specifiers from TestExpectations as an experiment. (patchset #1 id:1 of https://codereview.chromium.org/2106903002/ )

Reason for revert:
After this was committed, the webkit_tests on the waterfall went red (example build https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/7222)

This means that these lines in TestExpectations are *not* without effect.

Original issue's description:
> Remove Mac10.11 specifiers from TestExpectations as an experiment.
>
> Due to bug 624020, it seems possible that the Mac10.11 specifiers in TestExpectations have been ignored by the WebKit Mac 10.11 builder; if this is the case, then those specifiers in TestExpectations should have no effect and could theoretically be removed.
>
> Submitting this CL might cause WebKit Mac 10.11 to fail, and if that happens, then this should be reverted.
>
> BUG=624020
>
> Committed: https://crrev.com/63408fdbcfeaf1bd6fb298afee23ac9563bf218a
> Cr-Commit-Position: refs/heads/master@{#406134}

TBR=wkorman@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624020

Review-Url: https://codereview.chromium.org/2160113003
Cr-Commit-Position: refs/heads/master@{#406160}

Revert of Use common_custom_types instead of remapping base::ListValue in SafeJsonParser (patchset #9 id:180001 of https://codereview.chromium.org/2121793002/ )

Reason for revert:
Broke compilation https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20ChromeOS%20MSan%20Builder/builds/17876

Original issue's description:
> Use common_custom_types instead of remapping base::ListValue in SafeJsonParser
>
> Committed: https://crrev.com/623ad061886068c1ce323e7a499b91f61918c001
> Cr-Commit-Position: refs/heads/master@{#406139}

TBR=jochen@chromium.org,bauerb@chromium.org,dcheng@chromium.org,amistry@chromium.org,pmonette@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2158003003
Cr-Commit-Position: refs/heads/master@{#406159}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/c403207..7ca27cd

BUG=
TBR=kbr@chromium.org
TEST=bots
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2153413003
Cr-Commit-Position: refs/heads/master@{#406158}

Fix the crash on attempting to close an empty browser that is caused
by a racing when the test extension closes its window and
uninstalls itself at the same time.

BUG=628871
TEST=meacer_extension_apis passes.

Review-Url: https://codereview.chromium.org/2163443003
Cr-Commit-Position: refs/heads/master@{#406157}

This adds a much better testcase for bug 580196 -- this is a reduced version
of the original testcase for that bug, to ensure that we don't regress the
actual issue (which I almost did in https://codereview.chromium.org/2157093002/)

The testcase that I'm replacing was just verifying that we don't apply
min-height: auto to nested flexboxes, which is not very valuable.

BUG=580196
R=eae@chromium.org,dgrogan@chromium.org

Review-Url: https://codereview.chromium.org/2156403002
Cr-Commit-Position: refs/heads/master@{#406156}

This test has been reenabled in
https://codereview.chromium.org/2136873002, but unfortunately it's
still failing on the Windows FYI bot.

BUG=585194
NOTRY=true
TBR=creis@chromium.org

Review-Url: https://codereview.chromium.org/2162513003
Cr-Commit-Position: refs/heads/master@{#406155}

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2162713002
Cr-Commit-Position: refs/heads/master@{#406154}

BUG=628325
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2154833002
Cr-Commit-Position: refs/heads/master@{#406153}

Revert of analyze: ignore changes to OWNERS files (patchset #2 id:20001 of https://codereview.chromium.org/2117363002/ )

Reason for revert:
reverting this since I don't think it should've been needed and I'd like to look at the problem further. I will re-land or fix as appropriate if I can reproduce the underlying bug.

Original issue's description:
> analyze: ignore changes to OWNERS files
>
> BUG=595176
>
> Committed: https://crrev.com/f63a13b37a2ed66080bc4b91cff9cc1fa3678cb5
> Cr-Commit-Position: refs/heads/master@{#403797}

TBR=emso@chromium.org,sergiyb@chromium.org,tandrii@chromium.org,jam@chromium.org,phajdan.jr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=595176

Review-Url: https://codereview.chromium.org/2155323002
Cr-Commit-Position: refs/heads/master@{#406152}

No need for these additions/subtractions of border and padding.

R=eae@chromium.org,dgrogan@chromium.org
BUG=470729

Review-Url: https://codereview.chromium.org/2156323002
Cr-Commit-Position: refs/heads/master@{#406151}

BUG=612066
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2154403002
Cr-Commit-Position: refs/heads/master@{#406150}

Revert of Make the extension's sidebar pane auto-resizable. (patchset #7 id:120001 of https://codereview.chromium.org/1905493002/ )

Reason for revert:
Regression: sources tab extension panels do not render correctly
BUG=622456

Original issue's description:
> Make the extension's sidebar pane auto-resizable.
>
> Setting height of the sidebar pane is a relic from the old design where panes were expandable (https://developer.chrome.com/static/images/devtools-panels.png). In the current design, where panes are tabs, it doesn't make sense.
>
> BUG=438126
>
> Committed: https://crrev.com/7ff544f5fa1d09072def5419d74f8c0e5f42365e
> Cr-Commit-Position: refs/heads/master@{#391965}

TBR=paulirish@chromium.com,pfeldman@chromium.com,paulirish@chromium.org,kdzwinel@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=438126

Review-Url: https://codereview.chromium.org/2155173003
Cr-Commit-Position: refs/heads/master@{#406149}

With this CL, there is no remaining call to these methods on Mac:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Note that this CL also removes calls to these methods from files that
are not built on Mac.

These calls were not migrated by the clang-tidy script used previously
for various reasons (Objective-C code, templates, macros, header files,
std::unique_ptr<MessageLoop>...).

This CL was generated manually (with the help of a few regular
expressions).

BUG=616447
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=sdefresne@chromium.org (for ios/'s trivial application of this refactoring)

Review-Url: https://codereview.chromium.org/2132593002
Cr-Commit-Position: refs/heads/master@{#406148}

This is part of a larger effort to make all CSSValue::create() methods
return const pointers.

BUG=526586

Review-Url: https://codereview.chromium.org/2047813006
Cr-Commit-Position: refs/heads/master@{#406147}

windowID injection will fail if WKUserScript has not been injected yet
and __crWeb object is not present. windowID injection is critical for
many features to function and on failure it should be retried.

So far injection failure has been observed only in KIF test.

BUG=628316

Review-Url: https://codereview.chromium.org/2161463002
Cr-Commit-Position: refs/heads/master@{#406146}

The renderer process kills with reason RFH_INVALID_ORIGIN_ON_COMMIT are
checking parameters passed from the renderer process. However, we are
lacking a bunch of information since it is in the browser process and
it is hard to reason about what the state was in the renderer.

We can also try to implement similar checking in the renderer process,
so we can catch these mismatches closer to where we have more data.
This CL implements some of the checks performed browser side, but
it is a set that should catch the majority of the cases we have seen
in crash reports.

BUG=628677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2151323003
Cr-Commit-Position: refs/heads/master@{#406145}

Make ResourceBundle::IsScaleFactorSupported public.
(check when loading ash shell/sysui/tests resources)

Refactor GN's target for ash_test_strings.pak generation.
(can be used to generate locale-specific ash string paks)

Skip renaming of test string/resource paks for ash_sysui.
Update some comments and TODOs.

BUG=628715
TEST=No behavioral changes or regressions; automated tests.
R=jamescook@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2148363003
Cr-Commit-Position: refs/heads/master@{#406144}

These were temporary metrics intended to understand whether high/low
resolution clocks adversely impact page load metrics. After collecting a few
months of data it was determined that clock resolution doesn't adversely
impact our metrics, and it that these histograms were no longer needed.

BUG=394757

Review-Url: https://codereview.chromium.org/2155143003
Cr-Commit-Position: refs/heads/master@{#406143}

Currently, each page load through data_reduction_proxy will create a
pingback, and sends those pingbacks one at a time. The proto has
infrastructure to batch those page load metrics that will reduce the
request overhead for cases that are slow to send the pingback, but have
multiple page load metrics trying to be reported around the same time.

BUG=628721

Review-Url: https://codereview.chromium.org/2155783002
Cr-Commit-Position: refs/heads/master@{#406142}

BUG=

Review-Url: https://codereview.chromium.org/2154213002
Cr-Commit-Position: refs/heads/master@{#406141}

Just omit the link instead.

NOTRY=true

Review-Url: https://codereview.chromium.org/2151653005
Cr-Commit-Position: refs/heads/master@{#406140}

Review-Url: https://codereview.chromium.org/2121793002
Cr-Commit-Position: refs/heads/master@{#406139}

BUG=629004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2156393002
Cr-Commit-Position: refs/heads/master@{#406138}

Creating a directory for the new language detector called CLD3 and adding OWNERS, LICENSE, and README.chromium files.

BUG=

Review-Url: https://codereview.chromium.org/2110083003
Cr-Commit-Position: refs/heads/master@{#406137}

In order to be able to promote a buffer to full screen overlay on CrOS
the buffer needs to be in an RGB format and resource_size_in_pixels
has to be set on the quad.

This CL makes sure overlay candidates coming from exo satisfy those
two requirements.

BUG=b/29430506

Review-Url: https://codereview.chromium.org/2160113002
Cr-Commit-Position: refs/heads/master@{#406136}

This patch is only to ensure when submitting patches that no double
semicolons are submitted.

BUG=none

Review-Url: https://codereview.chromium.org/2153703003
Cr-Commit-Position: refs/heads/master@{#406135}

Due to bug 624020, it seems possible that the Mac10.11 specifiers in TestExpectations have been ignored by the WebKit Mac 10.11 builder; if this is the case, then those specifiers in TestExpectations should have no effect and could theoretically be removed.

Submitting this CL might cause WebKit Mac 10.11 to fail, and if that happens, then this should be reverted.

BUG=624020

Review-Url: https://codereview.chromium.org/2106903002
Cr-Commit-Position: refs/heads/master@{#406134}

BUG=628374
TEST=manual test looks good on https://webrtc.github.io/samples/src/content/devices/input-output/ when playing plugging and unplugging on chromeos.

Review-Url: https://codereview.chromium.org/2155503002
Cr-Commit-Position: refs/heads/master@{#406133}

Previously it printed nothing because it didn't collect the root nodes.

Review-Url: https://codereview.chromium.org/2157173002
Cr-Commit-Position: refs/heads/master@{#406132}

Because we will may need these values in future commits.

BUG=624366
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2105173006
Cr-Commit-Position: refs/heads/master@{#406131}

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2162683002
Cr-Commit-Position: refs/heads/master@{#406130}

This test:
virtual/threaded/fast/scroll-behavior/smooth-scroll/mousewheel-scroll-interrupted.html
is flaky under Release as well on Linux.

Please refer to the Chromium flakiness dashboard here:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fthreaded%2Ffast%2Fscroll-behavior%2Fsmooth-scroll%2Fmousewheel-scroll-interrupted.html

TBR=ymalik@chromium.org

Review-Url: https://codereview.chromium.org/2156953003
Cr-Commit-Position: refs/heads/master@{#406129}

Compiling w/ clang on CrOS, the compiler caught an unnecessary std::move()
in a CrOS-only file with the -Wpessimizing-move warning.

R=posciak@chromium.org, llozano@chromium.org
BUG=626241

Review-Url: https://codereview.chromium.org/2151483006
Cr-Commit-Position: refs/heads/master@{#406128}

Revert of Add a PGO tag for the PGO builds in chrome://version (patchset #3 id:40001 of https://codereview.chromium.org/2157563002/ )

Reason for revert:
It's breaking a chromiumos bot: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/23038

Original issue's description:
> Add a PGO tag for the PGO builds in chrome://version
>
> Also remove the VS2013 version string as we don't support it anymore.
>
> BUG=309849
>
> Committed: https://crrev.com/cbb31e640ae7ee7a9e03df917d5bba25415c13f0
> Cr-Commit-Position: refs/heads/master@{#406119}

TBR=brucedawson@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=309849

Review-Url: https://codereview.chromium.org/2160013003
Cr-Commit-Position: refs/heads/master@{#406127}

This is required to show the status area widget in mojo:ash.

* Initialize various service singletons in WindowManagerApplication
* Add ash strings to the window manager pak file

BUG=619636
TEST=ash_unittests, mash_unittests

Review-Url: https://codereview.chromium.org/2155743003
Cr-Commit-Position: refs/heads/master@{#406126}