GitLab

Including directories full of generated files causes incorrect incremental
builds.

There's already a data_deps on the action, so just setting `outputs`
correctly makes that do the right thing, without needing the explicit directory.

To make sure this does the right thing, I ran

gn gen out/gn --runtime-deps-list-file=<(echo -e \
//chrome/test:performance_test_suite\\n\
//chrome/test:ct_telemetry_perf_tests_without_chrome)

(...which is what

tools/mb/mb.py gen -m chromium.perf -b linux-builder-perf \
    --swarming-targets-file \
    <(echo -e performance_test_suite\\nct_telemetry_perf_tests_without_chrome) \
    out/gn

runs behind the scenes.)

I the compared these files before and after this patch:

out/gn/obj/chrome/test/performance_test_suite.stamp.runtime_deps
out/gn/obj/chrome/test/ct_telemetry_perf_tests_without_chrome.stamp.runtime_deps


$ diff -u performance_test_suite.stamp.runtime_deps out/gn/obj/chrome/test/performance_test_suite.stamp.runtime_deps
-gen/components/subresource_filter/tools/
+gen/components/subresource_filter/tools/default_local_state.json

$ diff -u ct_telemetry_perf_tests_without_chrome.stamp.runtime_deps out/gn/obj/chrome/test/ct_telemetry_perf_tests_without_chrome.stamp.runtime_deps
-gen/components/subresource_filter/tools/
+gen/components/subresource_filter/tools/default_local_state.json

I then grabbed an existing isolate off a recent
https://ci.chromium.org/p/chrome/builders/ci/linux-perf build from
a performance_test_suite run:

tools/swarming_client/isolateserver.py download -I https://chrome-isolated.appspot.com \
    --namespace default-gzip -s d60732b5f6374dc56d1b01c2e54c82fc411c83e5 --target foo

And inspected all the files in the tools directory:

$ ls foo/out/Release/gen/components/subresource_filter/tools/
GeneratedRulesetData		default_local_state.json

(gen/components/subresource_filter/tools/GeneratedRulesetData was already in
the .runtime_deps files.)

Bug: 912946,884035
Change-Id: Ife400071aa25589c66abfe693108a483ad14870d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769204
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690414}

This change implements hiding the bubble when the leak dialog is about
to be shown.

Bug: 986317
Change-Id: Ie53dd100d11d3e9015f9d9c0cc948d54ea430982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768531
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690413}

Bug: 997355

Change-Id: I8556f620cedcd5529cf4ef5c1803e1e4de1f5a12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771389Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Auto-Submit: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690412}

https://skia.googlesource.com/skia.git/+log/d617d5d29ca5..ea07123fedc7

git log d617d5d29ca5..ea07123fedc7 --date=short --no-merges --format='%ad %ae %s'
2019-08-26 michaelludwig@google.com Define Usage and image+origin wrapper for image filters
2019-08-26 fmalita@chromium.org Add a colortype conversion bench
2019-08-26 egdaniel@google.com Remove GrGpuTextureCommandBuffer class and rename to GrOpsRenderPass.
2019-08-26 reed@google.com remove unneeded noemptycheck variants of intersect
2019-08-26 herb@google.com Rename SkGlyphCacheState -> RemoteStrike

Created with:
  gclient setdep -r src/third_party/skia@ea07123fedc7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@google.com

Bug: None
Change-Id: Ieba9823ab83403d1faa5f9e91911b44b07f3624b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771581Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690411}

It is not clear which file stores the tracing data when --trace-dir
is specified.

Bug: none
Test: manually
Change-Id: I6e80e8f62adfa2091d271eaef1732891b69e33ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769801Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690410}

Bug: 980784
Change-Id: Ie37f1281ec068e6114abc815daa02a86a8a31602
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769045
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690409}

This reverts commit b0caf8a2.

Reason for revert: broke some protocol clients.

Original change's description:
> [DevTools] Perform Session id surgery in Blink.
> 
> That is, for messages coming from Blink, perform the surgery there.
> For messages that come from the browser, perform the surgery in
> content::DevToolsSession as before.
> 
> Longer term, we may include the session id prior to serializing the
> message. But this requires much deeper changes to the bindings etc.,
> so this just moves the computation closer to where it will be
> eventually.
> 
> Change-Id: I16efafec72e8077d7aaab6458f5253ddb018fd96
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734142
> Commit-Queue: Johannes Henkel <johannes@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#690168}

TBR=dgozman@chromium.org,dcheng@chromium.org,caseq@chromium.org,johannes@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I89d2e6a11fd38a0ab0484e26af793ebd230692a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771549Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690408}

UX prefers the icon to always be visible. Clicking on the icon closes
the drawer.

http://screen/5CjhZ4caxB1

Bug: 988012
Test: added to browser_tests
Change-Id: I1c593619126ca6394ccdf7bf93e3479dad1a8b33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764758
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690407}

The switch for the endpoint is --public-accounts-saml-acl-url.

Bug: 984021
Change-Id: I9a7250d0c49e63b2ff08d0f5254e012ebf763b89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760730Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Kamila Śledź <kamilasledz@google.com>
Cr-Commit-Position: refs/heads/master@{#690406}

https://swiftshader.googlesource.com/SwiftShader.git/+log/428c0b21e872..793707262d8d

git log 428c0b21e872..793707262d8d --date=short --no-merges --format='%ad %ae %s'
2019-08-26 chrisforbes@google.com Fix misleading UNIMPLEMENTED in image load

Created with:
  gclient setdep -r src/third_party/swiftshader@793707262d8d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: None
Change-Id: Ic31b55cd8b5699a452d7f43d9c6d6b8ae979d436
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771582Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690405}

This is partly clean-up, partly preparations for column-span:all, and at
least one fix: When a multicol container is nested inside another
fragmentation context and has column-fill:auto, we shouldn't balance the
columns, since its fragments are constrained by the outer fragmentation
context.

CalculateBalancedColumnBlockSize() now honors incoming break tokens,
rather than starting from the beginning of the content.

Change-Id: I3ddfde60ec310e11e09944b0b0ccb6964ca5fa96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766071
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690404}

Previously on managed CrOS devices, the managed-footnote banner displayed
a "Your Chrome[book|box|bit] is managed by domain.com". Now, only show
this message in OS-Settings. In all other instances (Browser Settings,
Downloads, Bookmarks, History), show "Your browse is managed by
domain.com.

Also, when in OS-Settings, chrome://management should open in a new
browser tab.


Bug: 996533, 996897
Change-Id: Iec7235e4e837f9fcad6ecec46d6408cc5a974a60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769041
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690403}

Do not DCHECK if values are saturated.

Bug: 996085
Change-Id: I1f9b299aef1f8bd5f18d6f4f05d50e33a7c1609d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769517
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690402}

This CL moves PointerDetails class to its own source files as well as to
//ui/events:events_base build target, so that it can be used in events_x.{h,cc}
and reused in x11_event_source_default.cc, thus cleaning up touch
PointerDetails creation code, especially in X11 code. This is part of
PlatformEvent migration to ui::Event for Aura/X11.

Bug: 965991
Test: event_unittests (no functional change)
Change-Id: I9a64a7c93cec772b51f770d0da2090ed641976b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765572Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#690401}

This is a reland of 66630f37.

Reverted in 1764333 for breaking linux-chromeos-rel.
This change incorporates the fix.

Original change's description:
> Removing dead ServiceManager constants
>
> Since ServiceManager went away, we're clearing up some leftover
> CupsProxyService constants. Trivial change.
>
> Bug: chromium:945409
> Test: confirmed service behavior unchanged
> Change-Id: I45ffdeb3b0ad1990798a4a4d5115e791a6eefbfe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764430
> Auto-Submit: Luum Habtemariam <luum@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#689164}

Bug: chromium:945409, chromium:996442
Change-Id: Ie2d2a835787d5d3c178ee632f00031f30746d1ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764525Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690400}

 * Pass const Document& to IsWellFormedDocument(...) helper.
 * Return SVGElement* from CreateInstanceTree(...).
 * Remove unnecessary local variable in ExpandUseElementsInShadowTree().

Bug: 997176
Change-Id: If1607a7332eb2b5e36ae8ed11e8eac42adb60574
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768640
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690399}

Tbr: juncai@chromium.org
Bug: 997549
Change-Id: I72c5b6949408d03b0716ab0223ce10654f11bf3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771553Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690398}

This CL simply adds a feature ([k]NtpRealbox).

This is for a11y purposes and to fix the [currently somewhat broken]
NTP fullscreen experience, and to allow on-focus suggestions.

R=mahmadi@chromium.org
BUG=243926, 778489, 996516

Change-Id: Ic7347be02391290dfc6214a1754558e91b6c7802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769035
Auto-Submit: Dan Beam <dbeam@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690397}

is_gaia_with_skip_save_password_form is already inside submitted_form.

Bug: 831123
Change-Id: I671cb3d2f1e423ef9128e3c05b8c26805d4c156e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768533Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690396}

This is a reland of [1] reverted in [2]. The test failure comes from [3]
that got merged a few minutes before [1]. The test expectations are now
updated to work with the changes brought by [3] to paragraphs break
heuristics.

[1] Original CL: crrev.com/753f8707
[2] Reverted in: crrev.com/003b20ab
[3] Caused by: crrev.com/f39b7b73

Original change's description:
> PDF a11y: kTextDirection attribute support
>
> The text direction attribute is now properly set for text runs in PDF.
> It is inferred by the position of the first and the last characters of
> a text run.
>
> This change includes a pdf-template file (text-direction.in) with RTL
> text representation used to generate our unit test PDF file.
>
> Bug: 985604
> Change-Id: If5d82296463331e95c4ded4e5244d65be3fbadfa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737019
> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#690163}

Change-Id: Ic8b7e62d1bce71db39af01473a66ea033aeaf7a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771551
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#690395}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/13847ac79387..f269f8e76a47


Created with:
  gclient setdep -r src-internal@f269f8e76a47

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I620ebe103069c33391f5d2ad0b09affd34dd955b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771817Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690394}

This class has been created one year ago, but it has never been used so
far.

This CL removes it from the chrome binary. It is kept in the test
binary, so that it continue to be maintained

Whether to remove this class or not should be considered.

For the context, I was looking about WebContentsObserver and their
interactions with the BackForwardCache. Being unused/removed simplify
the question.

Bug: 877550, 511340
Change-Id: Iae4c523528a1ad307c91ae7cb53aa855094d3c0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768322
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690393}

There's some cases where DOM feature collection takes an unusually long
time, or never completes at all. In these cases, we should still send
a PhishGuard ping, but with the DOM features missing.

Bug: 995466
Change-Id: I4d167a597ab04b8bbfbc80d318679151bd388ab5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766434
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690392}

When a <use> is scheduled to have its shadow tree built it should be
connected to the document and be the outermost <use>. The Element it
references should also be connected to the document (if it exists).

Simplify the code according to the above and add DCHECKs.

Bug: 997176
Change-Id: I4e9954df674b1dfdc5c1e674ea81df2f6e84d5da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768522Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#690391}

The Blink.DecodedImage.JpegDensity.100px, 400px and 1000px metrics count
the number of images per image bpp (bits per pixel) in the three
different categories of image size (decodec image >= 1000px, >= 400px and
>= 100px), requiring three different metrics to cover the spectrum.

A more direct approach introduced by this commit is to track the number
of KiB per image density, since this will allow us to focus on the image
compression density ranges (measured in bpp) that matter the most for
the user since they are the compression density ranges that take the
most network bandwidth. This also eliminates the need to have three
metrics and simplifies the analysis.

The old Blink.DecodedImage.JpegDensity.100px, 400px and 1000px are
marked as deprecated after the next release by this commit, allowing to
have both old and new metrics overlap for one full release (M78).

Bug: None
Test: Added unittests.
Change-Id: I6ead60fa9da3bc1b6080b12a6044c3ff9c8ce50e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742160
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690390}

https://swiftshader.googlesource.com/SwiftShader.git/+log/d6dc4b7e4533..428c0b21e872

git log d6dc4b7e4533..428c0b21e872 --date=short --no-merges --format='%ad %ae %s'
2019-08-26 swiftshader.regress@gmail.com Regres: Update test lists @ d6dc4b7e

Created with:
  gclient setdep -r src/third_party/swiftshader@428c0b21e872

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: None
Change-Id: I8474cfe1e35f17efd400d992509968d32dd20495
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771816Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690389}

This CL does the following changes:
- 1 for 1 replacement of PageLoadExtraInfo calls with delegate API.
- Removes PageLoadExtraInfo struct and all uses as a parameter.
- In offline_page_previews_page_load_metrics_observer.cc and
  service_worker_page_load_metrics_observer.cc, moves a function from
  file namespace to the observers so they have delegate access.
- largest_contentful_paint_handler.h receives a const& to observer
  delegate.
- expose new interface in TestingObserver to get delegate for
  PageLoadTestWaiter.

BUG=939403

Change-Id: Ia1350d8878178417ff499770269f6ac7354b193d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757285
Commit-Queue: Justin Miron <justinmiron@google.com>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690388}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bcfd55ce..678bea7e

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iaf6e8ac93ac0643a15a78e6a25befcab25e0e7b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771498Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690387}

https://chromium.googlesource.com/angle/angle.git/+log/39e2669a3e92..f2f111d77fa8

git log 39e2669a3e92..f2f111d77fa8 --date=short --no-merges --format='%ad %ae %s'
2019-08-26 cwallez@chromium.org LoggingAnnotator: don't output to trace file if there is no platform

Created with:
  gclient setdep -r src/third_party/angle@f2f111d77fa8

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Bug: chromium:997667
Change-Id: Ie070b7660d1f3ad3531e8aade32245de80b5291f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771546Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690386}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/81a5ea6cf04a..7064c6b3b409

git log 81a5ea6cf04a..7064c6b3b409 --date=short --no-merges --format='%ad %ae %s'
2019-08-26 yueherngl@google.com volteer: add board and paladin

Created with:
  gclient setdep -r src/third_party/chromite@7064c6b3b409

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ia5e60f28d2d098df7979ae6ce1721f290581f3c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771545Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690385}

This patch adds |NGFragmentItem::Style()|, by sharing the
code between |NGPhysicalFragment|.

Bug: 982194
Change-Id: I7153fb18df7aaa3e7d04995e1d99553fbf637d85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768604
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690384}

https://skia.googlesource.com/skia.git/+log/ba57aa2b4a60..d617d5d29ca5

git log ba57aa2b4a60..d617d5d29ca5 --date=short --no-merges --format='%ad %ae %s'
2019-08-26 senorblanco@chromium.org Update DEPS: roll spirv-tools and spirv-headers.

Created with:
  gclient setdep -r src/third_party/skia@d617d5d29ca5

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@google.com

Bug: None
Change-Id: I54b9e3965bfed4f21bfd88b0e0742a5aacd3967c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771572Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690383}

https://quiche.googlesource.com/quiche.git/+log/c8c02a5f788c..3de7170b31c5

$ git log c8c02a5f7..3de7170b3 --date=short --no-merges --format='%ad %ae %s'
2019-08-23 renjietang Maybe send SETTINGS for MaxPushIdFrame.
2019-08-23 renjietang Use real QPACK streams in QPACK stream tests instead of creating artificial ones.
2019-08-23 rch Change QUIC's AlpnForVersion method to omit the "google-" from the string to reduce the size of Alt-Svc advertisements which use this format.
2019-08-23 bnc Remove unused accessor.
2019-08-23 bnc Add knobs to QuicSpdySession for QPACK maximum table capacity and blocked stream limit.
2019-08-22 fayang gfe-relnote: In QUIC, add anti-amplification limit. Protected by version T099.
2019-08-22 rch gfe-relnote: n/a - Rename filtered_supported_versions() to filtered_transport_versions() in QuicVersionManager to match the name of the member variable.
2019-08-22 quiche-dev Deprecate --gfe2_reloadable_flag_quic_log_cert_name_for_empty_sct.
2019-08-22 fayang gfe-relnote: In QUIC, do not send control frames if connection does not have application keys for v99. Protected by quic_enable_version_99.
2019-08-22 fayang In QuicSentPacketManager, rename enable_pto_ to pto_enabled_.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I561c73d8f72584055896ae8c784d61ad1ce6655d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769543
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Auto-Submit: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690382}

Using wpt-import in Chromium 99bf5708.
With Chromium commits locally applied on WPT:
1194775a "Add ability to block same-origin access via document-access feature policy"
5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport."
d3b97055 "Update simulateUserActivation to match webxr-test-api spec"
6a3beaa9 "[WPT/referrer-policy] Fix races around history.back()"
2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
chcunningham@chromium.org, wolenetz@chromium.org:
  external/wpt/media-source
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Ifb5a1ffcdf603c502935835a57dd94f59ccac597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771616Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690381}

https://webrtc.googlesource.com/src.git/+log/6558fa5d64c4..4869bd6309bb

git log 6558fa5d64c4..4869bd6309bb --date=short --no-merges --format='%ad %ae %s'
2019-08-26 asapersson@webrtc.org Add method CanAdaptUp based on bitrate to BalancedDegradationSettings.
2019-08-26 sprang@webrtc.org Removes deprecated InsertPacket/TimeToSendPacket/TimeToSendPadding

Created with:
  gclient setdep -r src/third_party/webrtc@4869bd6309bb

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:none
Change-Id: I869bf5990d94545241b7708ce33cfd913b66f166
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771544Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690380}

For nested multicol we had some magic, so that we'd only consider the
last child break token when resuming layout in an inner multicol. Get
rid of that.

Change-Id: I22837176695092655aea1db9eb607f83b7b44dac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769438Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690379}

Previously vkCreateImagePipeSurfaceFUCHSIA was resolved in
VulkanImplementationScenic. Moving it to VulkanFunctionPointer makes
it more consistent with how all other Vulkan functions are resolved.

Change-Id: I20f2e394b0f529a5ebfedca5745c2c734b42e3b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769231
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690378}

* "Bitmap Array" files (OS/2)
* BITMAPV2HEADER info headers (Photoshop?)
* BITMAPV3HEADER info headers (Photoshop?)
* BI_ALPHABITFIELDS compression (Windows CE)
* 2bpp palettes (Windows CE)
* Top-down bitmaps with RLE compression (illegal per spec, but supported by
  Windows and Firefox)
* Truncated color palettes

This increases the number of testcases Chrome can render on
http://entropymine.com/jason/bmpsuite/bmpsuite/html/bmpsuite.html .

Bug: 552274
Change-Id: I4c86b8328d326992a2ebca2e5178727aeab3afc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769524
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Leon Scroggins <scroggo@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690377}

On win it's also flaky with the same error:
https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/39888

TBR=juncai@chromium.org

Bug: 997549
Change-Id: I5a6464aba2edff9d397581d103a1cc0d3548b772
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768534Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690376}

System colors should resolve differently based on the used color-scheme
value. See [1]. Ideally they should compute to the keyword to make
inheritance work and have different used values for system colors based
on color-scheme, but that needs to be resolved[2].

System colors are used for forms rendering. This CL is preparing for
color-scheme specific forms rendering.

Some places we use initial color-scheme in contexts where we have no
ComputedStyle. These are typically offscreen canvas not connected to a
particular element. It's possible we should use the root element
computed value instead.

The color interpolation needs to be fixed and I've added a TODO. Will
follow up in another CL.

No tests as there are no behavioral changes.

[1] https://github.com/w3c/csswg-drafts/issues/3804
[2] https://github.com/w3c/csswg-drafts/issues/3847

Bug: 929098
Change-Id: Ie734e399c0dba82c59b221222c8e7ef365cae79b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768139Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690375}