GitLab

BUG=368716

Review URL: https://codereview.chromium.org/302603004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276738 0039d316-1c4b-4281-b951-d872f2087c98

There's more optimization done on a PGO build than on a regular one, this results in some "Unreachable code" warnings that we don't see normally.

But probably anything that this would catch that wouldn't be caught in a normal build isn't going to actually be a bug, so the incremental value of C4702 for PGO builds is likely very small and blocks the setup of the PGO bots.

BUG=380175

Review URL: https://codereview.chromium.org/315323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276737 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=dewittj@chromium.org

Review URL: https://codereview.chromium.org/315053006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276736 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
should be safe to land now

Original issue's description:
> Revert of Remove now obsolete checkdeps copy (https://codereview.chromium.org/307333003/)
> 
> Reason for revert:
> Still referenced from blink
> 
> Original issue's description:
> > Remove now obsolete checkdeps copy
> > 
> > BUG=none
> > R=brettw@chromium.org
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275419
> 
> TBR=brettw@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=none
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275482

TBR=brettw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/334743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276734 0039d316-1c4b-4281-b951-d872f2087c98

> Fix slop region boundary handling.
> 
> Ensure the screenPosition of touches is never truncated to an integer.
> 
> Check if the unified gesture detector is enabled before disabling
> the inclusive slop region.
> 
> BUG=381174
> TEST=RenderWidgetHostViewAuraTest.TouchEventPositionsArentRounded
> 
> Review URL: https://codereview.chromium.org/328733003

TBR=tdresser@chromium.org

Review URL: https://codereview.chromium.org/330613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276732 0039d316-1c4b-4281-b951-d872f2087c98

Ensure the screenPosition of touches is never truncated to an integer.

Check if the unified gesture detector is enabled before disabling
the inclusive slop region.

BUG=381174
TEST=RenderWidgetHostViewAuraTest.TouchEventPositionsArentRounded

Review URL: https://codereview.chromium.org/328733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276728 0039d316-1c4b-4281-b951-d872f2087c98

Shrinks the padding and image size for a smaller screen. As an added bonus, also improves RTL handling (blue button should swap sides).

BUG=381260,331453

Review URL: https://codereview.chromium.org/328293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276727 0039d316-1c4b-4281-b951-d872f2087c98

The Ctrl-Shift-9 combination is used by Gmail to change formatting. Ctrl-Alt-P seems to be a viable alternative based on the discussion in the bug.

BUG=307661

Review URL: https://codereview.chromium.org/309293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276726 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that size passed into drag_utils_win.cc's SetDragImageOnDataObject function is in pixels and is obtained from the SkBitmap instance.

This is needed for the drag image to show up without being clipped.

Removed the size parameter from the drag_utils::SetDragImageOnDataObject functions as it is not needed. We can get the size from the ImageSkia object as needed.

BUG=381611
R=sky

Review URL: https://codereview.chromium.org/328993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276725 0039d316-1c4b-4281-b951-d872f2087c98

After this change, if libppGoogleNaClPluginChrome.so is placed in the install
directory it correctly starts and attempts to create a subprocess.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032
R=bradnelson@google.com, darin@chromium.org

Review URL: https://codereview.chromium.org/329853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276724 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes:
- "IsManaged" and similar methods in Profile, ProfileInfoCache, and a few other places (which mostly forward to either of those)
- Enum and constant names
- Variable names
- Comments

Still missing:
- I almost certainly missed a few variables and comments
- The actual SU implementation, i.e. c/b/managed_mode/
- JavaScript
- Resource names

But since this CL is already way too huge, I'll try to commit this part now and do the rest in one or more followup CLs.

TBR=thakis@chromium.org (chrome/)
TBR=rogerta@chromium.org (google_apis/)
TBR=haitaol@chromium.org (sync/ and components/sync_driver/)

All the TBRs are simple renames.

BUG=none

Review URL: https://codereview.chromium.org/316863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276722 0039d316-1c4b-4281-b951-d872f2087c98

We have seen crashes which indicates that CoreAudioUtil::CreateDeviceEnumerator can in fact fail with CO_E_NOTINITIALIZED in combination with certain 3rd party
modules. Calling CoInitializeEx is an attempt to resolve the reported
issues. 

BUG=383715,378465
TEST=WebRTC demos

Review URL: https://codereview.chromium.org/329383006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276721 0039d316-1c4b-4281-b951-d872f2087c98

It seems that right now we are granting it to child policy process even if the permission was not granted.
Rename the success parameter to is_allowed. To match what the renderer expects.

TBR=tsepez,dalecurtis
BUG=

Review URL: https://codereview.chromium.org/329993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276720 0039d316-1c4b-4281-b951-d872f2087c98

Update panel layout immediately after the user has finished resizing a panel.
Unfortunately, it is not possible to detect when a resize performed by the
window manager has ended. This CL does the resizing of panels entirely in
Chrome. This is slow and ugly but it is what we used to do in the GTK port.
(panel_drag_gtk.cc)

BUG=371616
TEST=Manual, see bug
R=erg, jianli
TBR=sadrul (For changes in ui/base/x/x11_util.* which have been taken verbatim from https://codereview.chromium.org/264713007/)

Review URL: https://codereview.chromium.org/320713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276719 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276718 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175979:176011&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/336493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276717 0039d316-1c4b-4281-b951-d872f2087c98

* Renamed print_settings_initializer.* into print_settings_conversion.*
* Dump on FILE thread.
* Added PrintSettingsToJobSettingsDebug to dump PrintSettings.
* Added PrintedDocument::CreateDebugDumpPath for consistent dump file naming.
* Dump PDFs received from renderer process.
* Moved GetCustomMarginsFromJobSettings into print_settings_conversion.cc.
* Moved Parsing PageRanges into print_settings_conversion.*

BUG=379961

Review URL: https://codereview.chromium.org/329683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276716 0039d316-1c4b-4281-b951-d872f2087c98

TiclInvalidationService was refactored to no longer depend on Profile.
However, it still is a KeyedService. While this does actually pull in
Profile as a dependency, it implies that TiclInvalidationService should
be considered a per-Profile service, like the other KeyedServices in
Chrome's code base.

This CL introduces ProfileInvalidationProvider, a KeyedService that is a
tiny wrapper around an InvalidationService. Given this wrapper,
InvalidationService (and with it, TiclInvalidationService) no longer have
to be KeyedServices.

BUG=362083
TEST=Updated unit and browser tests

TBR=dcheng (chrome/browser/extensions/api/push_messaging/*)
TBR=davemoore (chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc)
TBR=arv (chrome/browser/ui/webui/invalidations_message_handler.cc)

Review URL: https://codereview.chromium.org/327243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276715 0039d316-1c4b-4281-b951-d872f2087c98

Make AddMatch() append old matches rather than attempt to insert them
in order.  We call SortAndCull() after AddMatch() in the only code
path that uses AddMatch(), so the order doesn't matter.

Then eliminate AddMatch() because the revised version is short,
instead inlining the few things it still does in its only caller.

In some quick interactive testing, I didn't notice any problems.

The autocomplete_result tests still pass also.  (That said, I don't
think we test CopyOldMatches that extensively in it.)

BUG=380357

Review URL: https://codereview.chromium.org/329783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276714 0039d316-1c4b-4281-b951-d872f2087c98

There are outstanding bugs related to how Android code meant for WebView
is interacting with surfaceless EGL. These cause crashing on startup
and incorrect rendering on platforms that support surfaceless EGL. Work
around the issues by disabling surfaceless EGL on Android to unblock work
before a more complete solution can be developed.

BUG=382349

Review URL: https://codereview.chromium.org/330453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276713 0039d316-1c4b-4281-b951-d872f2087c98

BUG=304341

Review URL: https://codereview.chromium.org/324403007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276712 0039d316-1c4b-4281-b951-d872f2087c98

BUG=304341

Review URL: https://codereview.chromium.org/332563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276711 0039d316-1c4b-4281-b951-d872f2087c98

This patch:
* Brought back WindowSelector.CycleTime histogram with different name
  (WindowCycleController.CycleTime).
* Renamed WindowSelector.Selection to WindowCycleController.Cycle and fixed that it
  counted incorrectly overview mode selections.
* Fixed a bug in which the number of items in overview mode were not counted
  correctly.
* Added stats for:
** Number of closed items.
** Number of times the enter key is used to select a window.
** Number of arrow key presses per session.
** Ratio between arrow key presses and number of items.

BUG=364590
TEST=none

Review URL: https://codereview.chromium.org/320303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276710 0039d316-1c4b-4281-b951-d872f2087c98

Disable the App Info Dialog from being selectable for the Genius app,
which shows as a 'Get Help' link in the app launcher (and doesn't have
a proper description/proper metadata).

BUG=383713

Review URL: https://codereview.chromium.org/329383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276709 0039d316-1c4b-4281-b951-d872f2087c98

First, add a struct (MojoWaitFlagsState) to the public C API. We'll use
this to report additional (e.g., per-handle) information in
MojoWait()/MojoWaitMany().

Second, make a subclass struct (mojo::system::WaitFlagsState) that adds
a constructor and some simple methods for convenience (but adding no
overhead).

Third, convert our various separate handling of satisfied/satisfiable
state to use the new combined struct.

R=sky@chromium.org, darin@chromium.org

Review URL: https://codereview.chromium.org/325213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276708 0039d316-1c4b-4281-b951-d872f2087c98

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/328753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276707 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276706 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/b0b1aa04ed82a7cb16c7e6a06d92a411d7bd3749..679426c0b4b6568a79a7a69ac4fc9ba248009d19
TBR=scroggo@google.com
BUG=

Review URL: https://codereview.chromium.org/327413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276705 0039d316-1c4b-4281-b951-d872f2087c98

Rename chrome/browser/search_terms_data* to ui_thread_search_terms_data*.
Split SearchTermsData to a separate file and move it to components/search_engines.
Add DEPS from components/search_engines to components/google/core as it's used in search_terms_data.cc.

BUG=383283
TEST=git cl try
TBR=sky@chromium.org for include fix and DEPS removal

Review URL: https://codereview.chromium.org/324283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276704 0039d316-1c4b-4281-b951-d872f2087c98

I changed behavior of AsyncUtil.Aggregation and changed its name to AsyncUtil.RateLimiter.
Previously, AsyncUtil.Aggregation aggregates consecutive calls as much as possible.
To keep update the UI, from now the closure will be called as much as possible keeping given minimum interval.

BUG=373627
TEST=manually change the window size continuously.

Review URL: https://codereview.chromium.org/329083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276703 0039d316-1c4b-4281-b951-d872f2087c98

BUG=267773
NOTRY=true

Review URL: https://codereview.chromium.org/292313015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276702 0039d316-1c4b-4281-b951-d872f2087c98

This save us a system call and allows this code to be instrumented by the memory testing tools.

BUG=

Review URL: https://codereview.chromium.org/308683011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276701 0039d316-1c4b-4281-b951-d872f2087c98

The mock input method wasn't filtering WM_CHARs.

R=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/329803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276700 0039d316-1c4b-4281-b951-d872f2087c98

While in MaximizeMode if the rotation of the internal display is changed by a source other than MaximizeModeController rotation lock will be set. Thereby blocking future accelerometer rotations until the user toggles the lock.

The rotation lock tray will listen for these changes and update its visuals.

TEST=MaximizeModeControllerTest
BUG=371426, 369505

Review URL: https://codereview.chromium.org/303723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276699 0039d316-1c4b-4281-b951-d872f2087c98

Just to keep changes small.
Divide OnSynStream headers into request/response part.
Request headers are now delivered to stream via
OnPushPromiseHeadersReceived to ensure correct stream state.

BUG=377538

R=jgraettinger@chromium.org

TEST=All current push-related SpdyStream/SpdySession tests

Review URL: https://codereview.chromium.org/304353012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276698 0039d316-1c4b-4281-b951-d872f2087c98

Those suppressions were initially added in https://codereview.chromium.org/257003007/, but the scope of the errors was much reduced in the latest patch set where these suppressions became superfluous (since the only tests running that code path now properly flush the message queue before exiting).

BUG=371974

Review URL: https://codereview.chromium.org/280463006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276697 0039d316-1c4b-4281-b951-d872f2087c98

Likely caused these 43 browser test failures:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/24563

> Flag covering HID-detection OOBE screen removed.
> 
> BUG=127016
> TBR=rkc@chromium.org
> 
> Review URL: https://codereview.chromium.org/273533004

TBR=merkulova@chromium.org

Review URL: https://codereview.chromium.org/335643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276696 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276694 0039d316-1c4b-4281-b951-d872f2087c98

Broke Android bots runhooks:
http://build.chromium.org/p/chromium/builders/Android/builds/24889

> Roll webrtc & libjingle 6352:6406.
> 
> This CL is a takeover of https://codereview.chromium.org/329773004/
> 
> NOTRY=true
> 
> TBR=ronghuawu@chromium.org
> 
> Review URL: https://codereview.chromium.org/328303002

TBR=xians@chromium.org

Review URL: https://codereview.chromium.org/333693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276693 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276683 0039d316-1c4b-4281-b951-d872f2087c98