- 02 Aug, 2018 40 commits
-
-
Tommy C. Li authored
This moves the security chip label left by 2dp so it aligns with the label-less separator, as well as URLs. This improves the alignment of text with or without jog enabled. See bug for screenshot. Bug: 865546 Change-Id: I46918bc1dfe7ff43a8851206c92f2875fc1680f2 Reviewed-on: https://chromium-review.googlesource.com/1159686 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#580363}
-
Dan Sinclair authored
This pulls in: * d38a0a3 Validation within function body when doing a FunctionCall. * 6aa8a59 Simplify validation ProcessInstruction TBR=dsinclair@chromium.org Bug: 870156 Change-Id: Ia5fb99a01273b46602aaf49429a2ddc632d61531 Reviewed-on: https://chromium-review.googlesource.com/1161287Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#580362}
-
Matt Reynolds authored
This CL adds a command line switch and Feature entry for enabling event listeners to listen for gamepad button and axis inputs. Intent to implement thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9cfRxXx5Cis BUG=856290 Change-Id: I5323ff7692ffb235fc3759b1305216085ed6460c Reviewed-on: https://chromium-review.googlesource.com/1139092 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580361}
-
Stephen McGruer authored
Outside of test code, this was only ever set to 1. Bug: 630915 Change-Id: Ifd0e41e19f54287e9ba6faab44e336529b3d426d Reviewed-on: https://chromium-review.googlesource.com/1159163 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#580360}
-
Reilly Grant authored
These tests are now passing. Bug: 844951 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I0c886537f94ae525999e88485df41416ddc77752 Reviewed-on: https://chromium-review.googlesource.com/1161293Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#580359}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7d059ce0a2a3..d146987b6945 git log 7d059ce0a2a3..d146987b6945 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 lannm@chromium.org cbuildbot: Remove RepoRepository cleanup logic Created with: gclient setdep -r src/third_party/chromite@d146987b6945 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I1f4b20e15058b521c5f00f46250c01bdc00a3dfb Reviewed-on: https://chromium-review.googlesource.com/1161142Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580358}
-
David Vallet authored
See also https://crbug.com/771466 and https://crbug.com/866627 Bug: 856195 Change-Id: I2519b269ef126e106cb97dbe335a21549468d9a8 Reviewed-on: https://chromium-review.googlesource.com/1159556 Commit-Queue: David Vallet <dvallet@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#580357}
-
Tao Bai authored
Bug: 849913 Change-Id: I6f1bd722bc2af136c76653311e91b7a7ad1df0b2 Reviewed-on: https://chromium-review.googlesource.com/1157520Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#580356}
-
Wez authored
This test often flakes on the Fuchsia/ARM64 FYI bot, indicating that it is likely racey under pathological scheduler timings. TBR=tdresser@chromium.org Bug: 836996 Change-Id: I365050083bc4a7ee21d3ef5f1e05ccee35dc6cb1 Reviewed-on: https://chromium-review.googlesource.com/1161326Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#580355}
-
Quinten Yearsley authored
At first, we can enable Tricium with reporting disabled, just to see its affect on load/error rate and number of comments produced. Change-Id: Ie3ea0b0c0ac5844d893d965d84fbfb342681552f Reviewed-on: https://chromium-review.googlesource.com/1161006Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#580354}
-
mrefaat authored
Break dependency between post app launching logic and the app launching success status, and then use Asynchronous openURL instead to launch apps. Bug: 774736, 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id51a246df9f8a7bd809025d66d987520c4001c6e Reviewed-on: https://chromium-review.googlesource.com/1152545 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#580353}
-
Scott Violet authored
I'm hoping knowing the event type will at least help identify what might be going wrong in some way. BUG=867035 TEST=none Change-Id: I78109f72b27d932e1754a24fd0f8af5d81b86b0f Reviewed-on: https://chromium-review.googlesource.com/1161165Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#580352}
-
Scott Violet authored
Only tests need access to it. BUG=none TEST=none Change-Id: I968d84f1e677e00dfb181fa8140c72f265bc2aaa Reviewed-on: https://chromium-review.googlesource.com/1161290Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#580351}
-
Paul Miller authored
This reverts commit f8f05d06. Variations has launched, so this log is no longer needed. Original change's description: > WebView: Report test experiment via logcat > > This is for testing purposes and will be removed after launching > variations in WebView: https://crbug.com/841623. Skipping presubmit for > LOG(INFO). > > BUG=678288 > NOPRESUBMIT=true > > Change-Id: Ia100eb88a20b3155ef8d280e598644b3684990a0 > Reviewed-on: https://chromium-review.googlesource.com/1053375 > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Paul Miller <paulmiller@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557593} TBR=boliu@chromium.org,changwan@chromium.org,paulmiller@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 841623 Change-Id: Ia9259943b4b7896de98e917e29721ec5126aa00a Reviewed-on: https://chromium-review.googlesource.com/1161024Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580350}
-
Ben Kelly authored
New test case added to existing cache-keys.https.html tests. Bug: 831557 Change-Id: I26ba7b8fd616e4b7f9ab7382b42ef72c655dbfaf Reviewed-on: https://chromium-review.googlesource.com/1156886Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#580349}
-
Chris Lu authored
- stops all action sheet coordinators in ClearBrowsingDataTableViewController before dismissing itself. - sets historyClearBrowsingDataCoordinator to nil after finishing unwinding ClearBrowsingData and History to prevent race condition. Video: https://drive.google.com/open?id=1wDymlQtfStNWBY9mI9GYqlig8qkipBDF Bug: 867329 Change-Id: I7c0825b02ed7d3c6122f0a5ae37c99181fc6d182 Reviewed-on: https://chromium-review.googlesource.com/1159683 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#580348}
-
Becky Zhou authored
After the custom scrim is removed from the app modal dialog, we should handle cancel on touch outside on the dialog instead of the custom scrim. Bug: 870292 Change-Id: Ie4a4bb4f0c78b503d236eb1e1775953d734c446b Reviewed-on: https://chromium-review.googlesource.com/1161199Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580347}
-
Adithya Srinivasan authored
- Mojofies and removes all messages in file_system_messages.h. - Replaces FileAPIMessageFilter with FileSystemDispatcherHost. - Adds mojom types for FileSystemInfo and FileSystemType and adds type converters to convert these types to storage::FileSystemInfo and storage FileSystemInfo respectively. The storage types will be replaced with the mojom types in follow up CLs. Change-Id: I82aaf9dcb04149880e68238540766f21771d2b21 Bug: 787281 Reviewed-on: https://chromium-review.googlesource.com/1125316Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#580346}
-
erikchen authored
NativeEventObserver forwards will_run and did_run callbacks from the native event processor to responsiveness::Watcher. This CL also adds the macOS implementation. This requires modifying BrowserCrApplication and ShellCrApplication to support a new protocol: NativeEventProcessor, which allows observers to register for event will_run and did_run callbacks. Bug: 859155 Change-Id: Ie2db48efb4a93377ad54e91cbdb376d990b25f11 Reviewed-on: https://chromium-review.googlesource.com/1157235 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#580345}
-
Michael Thiessen authored
This is enabled by three things: 1. We now trust that 2D intents should launch 2D Chrome even if the user is in a VR headset so we don't have to use expensive APIs on launch. 2. Deep-linked apps and the associated launcher workarounds have been removed. 3. Daydream has stopped removing the Daydream category from its intents that target launching in VR. This should mean that Chrome no longer shows up multiple times in the default browser picker, and third-party ROMs won't get confused by Chrome having multiple intent handlers that support View intents. Bug: 847921 Change-Id: I236fab049e00f64eb04d6fcb4a82f05f0d31f728 Reviewed-on: https://chromium-review.googlesource.com/1157272Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#580344}
-
Doug Arnett authored
Bug: 867651, 856243 Change-Id: I8d96e49aaf814041954deef540bffe025e983f03 Reviewed-on: https://chromium-review.googlesource.com/1152358 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#580343}
-
Sergey Ulanov authored
When booting Fuchsia under qemu on test bots the system often hangs before SSH can be connected. To debug this issue this CL adds kernel.serial=legacy flag to Zircon and captures qemu output. Bug: 869753 Change-Id: Ibe5e979612abc740ef5081bdc5fdb583b0c57722 Reviewed-on: https://chromium-review.googlesource.com/1157920 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#580342}
-
Kyle Milka authored
Clear the pref if the feature is disabled. Update the unit tests to explicitly turn on the feature. Add a new test that the background url is not set when the feature is turned off. Bug: 864013 Change-Id: I472f690d870a930f5b9ce35c19117cb69ceb2001 Reviewed-on: https://chromium-review.googlesource.com/1161008Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#580341}
-
David Tseng authored
This change observes pref changes and triggers dynamic slider updates. Since a caller setting prefs is not aware of tick markings, we also make the slider resolve updates to round to the tick to the right of the value. Change-Id: I8a02ae2c18541a880596d6aefba117ff54234a4e Reviewed-on: https://chromium-review.googlesource.com/1159400 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#580340}
-
Changwan Ryu authored
TracingController is a new API in P, and VerifyClass issue in http://crbug.com/791099, http://crbug.com/838702 got resurfaced when we rolled P SDK in https://chromium-review.googlesource.com/c/chromium/src/+/1112729 Note that the issue might have been there in the downstream, which will also be fixed with this CL. Bug: 868250, 791099, 838702 Test: I no longer see logcat message 'Rejecting re-init on ... TracingControllerAdapter' Change-Id: Ia7a967d9dfa206f64b0ec7ae284af120ac449534 Reviewed-on: https://chromium-review.googlesource.com/1161003 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#580339}
-
Hector Carmona authored
Bug: 832938 Change-Id: I315fa5a1fbb25d321828b922271c067f38a54535 Reviewed-on: https://chromium-review.googlesource.com/1157513 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#580338}
-
Dale Curtis authored
Without this we end up using bogus source ids for reporting to UKM which end up dropped. BUG=870407 TEST=none Change-Id: I6dd43a70dad670613c9bffe440a5f4d8934d3a42 Reviewed-on: https://chromium-review.googlesource.com/1161162Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#580337}
-
Navid Zolghadr authored
Change-Id: I6482dcf43065cf07d994d35f7334e798915174e5 Reviewed-on: https://chromium-review.googlesource.com/1161204Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#580336}
-
Johannes Henkel authored
... except for the virtual time properties. I'll do these separately so it's possible to review them. Bug:851762 Change-Id: I49333c7e0265cfc855cdb550e6f3338f74d1ebb1 Reviewed-on: https://chromium-review.googlesource.com/1157696 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#580335}
-
Eric Roman authored
Moves CertBuilder higher in the file so it can be used in a follow-up change. Change-Id: Ic51018282de2deb851d08bfdc9246850babdb73c Reviewed-on: https://chromium-review.googlesource.com/1161108Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#580334}
-
Philip Rogers authored
This internals-only code is not needed post-rls. BUG=823365 Change-Id: I48e9a149230a89bc235e3323a132420764fbc394 Reviewed-on: https://chromium-review.googlesource.com/1154321Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#580333}
-
Quan Nguyen authored
Bug: 863620 Change-Id: Id15fc12e23ca4fd51b92454d27d87133120aee82 Reviewed-on: https://chromium-review.googlesource.com/1157249Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580332}
-
Chase Phillips authored
As a result of the recent IO thread hopping removals, |io_runner| is no longer needed. Bug: 717812 Change-Id: I525785fda65a2edfaf86f11bcfcc21d6c74de85b Reviewed-on: https://chromium-review.googlesource.com/1155830 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#580331}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5300616351f5..3481542a423d git log 5300616351f5..3481542a423d --date=short --no-merges --format='%ad %ae %s' 2018-08-02 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@3481542a423d The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Idb0f1f657c162e9e2293ab4eb0ede6b3b3a64e0e Reviewed-on: https://chromium-review.googlesource.com/1160793Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580330}
-
Johannes Henkel authored
There's just one field for the enabled bit so this one's trivial. For reference the PR that introduced the new InspectorSessionState / InspectorAgentState / Fields was https://chromium-review.googlesource.com/c/chromium/src/+/1149201. We're migrating things from state_ to this new mechanism, which allows incremental updates to flow back to the browser process. Bug: 851762 Change-Id: Ie709f8c99d196f5be018838e1cb9e70a2cb6aed8 Reviewed-on: https://chromium-review.googlesource.com/1159721 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#580329}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cc73f241145d..cb4ae446080b git log cc73f241145d..cb4ae446080b --date=short --no-merges --format='%ad %ae %s' 2018-08-02 thomaslmiller91@gmail.com Make Angle compile for Arm64 Windows Created with: gclient setdep -r src/third_party/angle@cb4ae446080b The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I5986cace96b3b6f981fe95b23aed231187ded690 Reviewed-on: https://chromium-review.googlesource.com/1160796Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580328}
-
Philip Rogers authored
This patch fixes a crash where we were using the wrong paint offset when snapping the scrolling contents rect. Previously, the scrollable area's location was used as the paint offset, but this is incorrect and the property tree builder's context should be used instead. This patch adds a unit test that mirrors a composited layer mapping test of the same issue (ScrollLayerSizingSubpixelAccumulation). It also adds a minimized layout test of the crash. Bug: 868613 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2d045ae4d50ccb7a8eae6efbe2817e6e93d462ee Reviewed-on: https://chromium-review.googlesource.com/1158798Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#580327}
-
Nico Weber authored
As far as I can tell, this is unused. Bug: 489490 Change-Id: I729acb5d1f50ad56848e00b3c2b771e1074dba00 Reviewed-on: https://chromium-review.googlesource.com/1160777Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#580326}
-
Eric Orth authored
Implemented as a single ResolveHost method in NetworkContext for now with all the real work in a separate ResolveHostRequest class that we'll be able to use from multiple places if we copy or move the ResolveHost method to other interfaces. Per recent discussions, we've diverged from the design in the doc. Responses are now always sent via a dedicated response client mojo pipe instead of using response callbacks on the request pipe. This makes cancellation and callback control much clearer and bug-proofed for clients because it's always clear which pipe controls the callbacks and the callbacks are usually tightly bound to the relevant mojo binding. The design doc will be updated after this CL is landed. Design doc: https://docs.google.com/document/d/1NmADJX00oRe9TxFCJTWl8ofdfyR22pbKT8-5Ad5lBsU Bug: 821021 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib0ae407008fdbec089437083796cae725cd8d8d0 Reviewed-on: https://chromium-review.googlesource.com/1113665Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#580325}
-
Alexis Hetu authored
As a result of replacing OSMesa with SwiftShader for running browser_tests recently, 4 tests have become flaky on ChromeOS: SiteDetailsBrowserTest.IsolateExtensions ArcVoiceInteractionArcHomeServiceTest.VoiceInteractionStructureMultipleSelectionTest ExtensionApiNewTabTest.Tabs PasswordManagerBrowserTestWithViewsFeature.PromptForFetchSubmitWithoutNavigation This cl temporarily disables these 4 tests on ChromeOs until we can find a proper fix for them. TBR=vasilii@chromium.org rdevlin.cronin@chromium.org hidehiko@chromium.org TBR_REASON="Making the linux-chromeos-rel bot less flaky" Bug: chromium:870372 chromium:870322 chromium:870319 chromium:671891 Change-Id: I55fdd44622f7fac13dafaa19699904178e37d1fb Reviewed-on: https://chromium-review.googlesource.com/1161202 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580324}
-