- 25 May, 2018 16 commits
-
-
Tetsui Ohkubo authored
Previously TrayDetailedView directly depended on SystemTrayItem. It did not work with UnifiedSystemTray. In this CL, bubble related actions from TrayDetailedView will be delegated to DetailedViewDelegate. This CL also includes SystemTrayDetailedViewDelegate, which implements the default behavior for old SystemTray. In upcoming CLs DetailedViewDelegate implementation for UnifiedSystemTray will be added. Design doc: go/cros-qs-restyling (See "detailed view" section) TEST=ash_unittests BUG=835733 Change-Id: I54074335f982ab4e1d07abdb88c5347e6c1d7ff1 Reviewed-on: https://chromium-review.googlesource.com/1068560Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#561713}
-
Stuart Langley authored
Loads all of the users team drives and writes them to metadata. To be called on startup, subsequent team drive changes will arrive via the users default corpus change list processing. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1063471 Bug: 715355 Change-Id: Id9cbc31cb81abc3cac7620984f65cb85c85fba4f Reviewed-on: https://chromium-review.googlesource.com/1068644 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#561712}
-
John Z Wu authored
reuse the one in //components/autofill. The pre-existing one contains a lot of helpful factory methods. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I715859456af7dc72c1f30f3aeace8bc906febb58 Reviewed-on: https://chromium-review.googlesource.com/1070567 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#561711}
-
David Black authored
Per spec, height should not exceed 640dip. Note that this fix will truncate content exceeding 640dip but our final content will be sized appropriately so truncation will not be an issue. See bug for before/after. Note that there was previously some issue with the anchoring logic but that is no longer an issue. Bug: b:79432250 Change-Id: I14274ed38c1dd3ecbd1d8fb8e765b646787ed609 Reviewed-on: https://chromium-review.googlesource.com/1072636Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#561710}
-
Kunihiko Sakamoto authored
After this patch, SignedExchangeHandler starts accepting "application/signed-exchange;v=b1" content-type in addition to v=b0. (But Accept-Header still advertises only v=b0.) For b1 signed exchanges, OCSP response from cert chain is passed to CertVerifier::Verify(), and signed exchange without valid OCSP response is rejected. For now, b1 has minimal test coverage, but when we drop b0 support after M68 branch cut, we'll be able to convert existing tests to b1. This also makes IgnoreErrorsCertVerifier set OCSP results if request has a non-empty ocsp response. This allows LayoutTests to work. Bug: 815024 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I611d68c1d4f26b1f97ea81f8f9f9b89ba3ad0d84 Reviewed-on: https://chromium-review.googlesource.com/1060933Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#561709}
-
Mark Pilgrim authored
This was requested by pkasting. The owners were specified here: https://chromium-review.googlesource.com/c/chromium/src/+/1070328#message-2ce2b6f61c3e2e42f9aea96203f51b74b83523da Change-Id: I44c2605cb0972b6be723c3f880c5bd0dabb75f27 TBR: pkasting@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1072558 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#561708}
-
David Jacobo authored
Making var names consistent accross ArcExternalProtocolDialog. Also a couple of style fixes for params comments. Bug: None Change-Id: Iae821c8d3a30e9e6886cda9f380dc050ceba9ef5 Tets: Build Reviewed-on: https://chromium-review.googlesource.com/1069715Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#561707}
-
Stuart Langley authored
Currently change list loader and directory loader use AboutResourceLoader to get the root folder id. However, with team drives the root folder id is a constant (the team drive id) and we need a way to supply this value when the change list loader and directory loader are loading changelists for team drives. The RootFolderIdLoader pure virtual class allows us to provide an abstraction for reading the root folder id either from AboutResource or a constant string. Bug: 835703, 715355 Change-Id: I7d0766c5f813353186d3fbd3f6b20219c809eb4e Reviewed-on: https://chromium-review.googlesource.com/1068527 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561706}
-
Katie D authored
Finds the voice that best matches the app locale so that the default voice is as close as possible to the app locale in the user's preferred language. Bug: 823359 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3374e2d38051cd7dbc089da2a9483887befc9fe4 Reviewed-on: https://chromium-review.googlesource.com/1067540Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#561705}
-
wutao authored
This cl adds the LogoView to the ActionView. Bug: b/78191547 Test: tested on eve. Change-Id: I6f5e220551c2faf118c216a29b6bbd8e31f70fc0 Reviewed-on: https://chromium-review.googlesource.com/1070553Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#561704}
-
Joel Einbinder authored
This is part of a series of patches to remove Panel.handleShortcut Change-Id: I9c66fa93da4ee7a1e0a12a68f09391c1c4651f7c Reviewed-on: https://chromium-review.googlesource.com/1060513 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561703}
-
Victor Costan authored
Bug: 729800 Change-Id: I17a1adba1fd3f29c8f0cd6e2798048402f9d3a99 Reviewed-on: https://chromium-review.googlesource.com/1070782Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#561702}
-
Scott Violet authored
Embedding owns the embedded WindowServiceClient (child). The ClientWindow the embedding is in owns the Embedding. This fixes a bug where destroying the root of an embedding didn't destroy the embedded WindowServiceClient. I will have to change this to support re-embedding, but until then I think this makes things clearer. BUG=837684 TEST=covered by tests Change-Id: I9e3b1d144ec63c80b660dabf1dd50fdb6c20c568 Reviewed-on: https://chromium-review.googlesource.com/1072806 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#561701}
-
Esmael El-Moslimany authored
When a polyer element style is overridden and there is no explicitly set style, all the other usages of that polymer element will erroneously try to override the style with an undefined variable and no default. Example: |padding-bottom: var(--cr-dialog-body_-_padding-bottom);| This is only happens when |optimize_webui=true| is set in the build arguments. Bug: 846254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I010c560e80f89c0473722351dce346d481cd3113 Reviewed-on: https://chromium-review.googlesource.com/1072236Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#561700}
-
Sahel Sharify authored
This is a reland of 63049f46 I reverted the original cl since I missed nit comments on the newly added test, this cl includes the changes for those comments. Original change's description: > Touchpad fling bubbling doesn't generate extra GSB. > > With browser side touchpad fling, the fling controller processes a GFS > and schedules fling progress. On flingProgress the controller generates > wheel events which get queued in the mouse wheel event queue(MWEQ). > > When we start wheel scrolling on an out of process iframe while it is > already at its extent the wheel events get processed in the MWEQ of the > child view but the generated gesture scroll events including the GFS get > bubbled to the parent view. When the GFS gets processed by the parent > view, the generated wheel events get queued in the MWEQ of the parent. > The MWEQ will generate a GSB for the first wheel event generated from > processing the fling since it is not aware of the GSB that is bubbled to > this view and it causes hitting this DCHECK: > https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_impl.cc?q=render_widget_host_impl&dr=C&l=1256 > > This cl changes the MWEQ to ask for the state of wheel scrolling from > RWHI rather than keeping its own state, this change will be also useful > for enabling touchpad fling boosting. > > Bug: 249063 > Test: SitePerProcessBrowserTest.TouchpadGestureFlingStart > Change-Id: I0c6faa81faa7f009517393440d6e37c7e7e6a053 > Reviewed-on: https://chromium-review.googlesource.com/1064792 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561550} TBR=kenrb@chromium.org,tdresser@chromium.org,nzolghadr@chromium.org Bug: 249063 Change-Id: Ic146479e5d8c5531f80d9babdb4ef8adfcc8dc72 Reviewed-on: https://chromium-review.googlesource.com/1072708Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561699}
-
Michael Lippautz authored
This CL duplicates SW::TraceWrappers into SW::Trace which is require to rely solely on Trace. Bug: chromium:841830 Change-Id: I27ef0b4590b1bb1ba26bd59308fa718a06ab6936 Reviewed-on: https://chromium-review.googlesource.com/1071028Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#561698}
-
- 24 May, 2018 24 commits
-
-
danakj authored
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1066987 Currently there is a HitTestDataProviderSurfaceLayer class in components/viz/client, which receives a cc::LayerTreeHostImpl* from cc/ and then calls back into cc::LayerTreeHostImpl* to build the HitTestRegionList from the active tree. This is problematic for these reasons: 1. cc is-a viz client, so it could depend on viz/client/ code. But the viz/client/ should not depend back on cc/. The use of the cc::LayerTreeHostImpl pointer breaks this. 2. The LayerTreeFrameSink implementation can call back to LayerTreeHostImpl, but it should not do so with the actual LTHI pointer type. Instead it should use the LayerTreeFrameSinkClient interface, which LayerTreeHostImpl implements. 3. The order of exection is that cc::LayerTreeHostImpl calls ClientLayerTreeFrameSink::SubmitCompositorFrame() (through the LayerTreeFrameSink interface), which then calls back to the cc::LayerTreeHostImpl class to generate the HitTestRegionList, creating the A-B-A anti-pattern. We can resolve this by passing the HitTestRegionList directly to SubmitCompositorFrame(), but to do so we need ClientLayerTreeFrameSink to not get it from the virtual HitTestDataProvider interface in this case. In order to satisfy these things we: A. Move the implementation of HitTestDataProviderSurfaceLayer into LayerTreeHostImpl, and move the unit test there. B. Add a BuildHitTestData() method to LayerTreeFrameSinkClient, which is implemented in LayerTreeHostImpl as per (A). C. Move the branching out of the HitTestDataProvider virtuality. If the HitTestDataProvider in ClientLayerTreeFrameSink is null, then it uses the LayerTreeFrameSinkClient to ask the LayerTreeHostImpl to build the HitTestRegionList. This does not break behaviour as the HitTestDataProvider is created as a HitTestDataProviderDrawQuad preferably, falling back to HitTestDataProviderSurfaceLayer. Similarly the HitTestDataProviderDrawQuad would be preferred if the pointer is not null, falling back to using LayerTreeFrameSinkClient. (We also leave a TODO that we can just submit the HitTestRegionList directly to SubmitCompositorFrame.) This patch would be pretty small.. except.. Because cc/ is building the HitTestRegionList, it can not depend on services/viz/ which depends back on cc/. So we implement the viz::mojom::HitTestRegionList and viz::mojom::HitTestRegion as standard c++ types viz::HitTestRegionList and viz::HitTestRegion in components/viz/common/hit_test/, which cc/ can make use of. And we add struct traits to pass these types to mojo and receive them from mojo. Then all plumbing code must be changed from the mojom-defined type to the standard-c++-defined type. The mojom type was viz::mojom::HitTestRegionListPtr (aka mojo::StructPtr<viz::mojom::HitTestRegionList>), which is an optional field in the CompositorFrame, so we must preserve its ability to be null. We may use a struct traits directly to viz::HitTestRegionList, and base::Optional<viz::HitTestRegionList> throughout the plumbing, or we can use a struct traits to a std::unique_ptr<viz::HitTestRegionList> (which is itself considered nullable by mojo) and plumb that through directly through everything. I don't actually know which is preferable here, but settled on making viz::HitTestRegionList move-only, and using the former option. This makes most of this patch just type renames. Lastly, we need LayerTreeHostImpl to not return a HitTestRegionList in cases where no HitTestDataProvider would have been given to the ClientLayerTreeFrameSink previously. This is in the case where features::IsVizHitTestingSurfaceLayerEnabled() returns false. So we add a field to LayerTreeSettings, which we set to the value of that feature flag, and have LayerTreeHostImpl return an empty optional value when the setting is false. TBR=gklassen@chromium.org, sadrul@chromium.org, reveman@chromium.org, avi@chromium.org, dcheng@chromium.org Bug: 722935 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iba36b0cb12e2e45b80211956fb932c26693d1cd3 Reviewed-on: https://chromium-review.googlesource.com/1072128Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#561697}
-
Sarah Hu authored
Change-Id: I819742fc61d41ffdeb00b5ccd888a1fe56feb3d2 Bug: 823536 Reviewed-on: https://chromium-review.googlesource.com/1068659Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#561696}
-
Noel Gordon authored
Woohoo, I suppose. Bug: 836254 Change-Id: Ic5aa72305b0884cfee57f77a66339bf0d83f3cd9 Reviewed-on: https://chromium-review.googlesource.com/1071029Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561695}
-
Gabriel Charette authored
This reverts commit 6a1485d2. Reason for revert: breaks Linux CFI, crbug.com/846492 Original change's description: > Add a LocalSiteCharacteristicsDataStore factory > > This follows the guidelines from this page: https://www.chromium.org/developers/design-documents/profile-architecture > > Bug: 773382 > Change-Id: I8517975f9881e3fa2d52fb26b16008d780255eef > Reviewed-on: https://chromium-review.googlesource.com/1047725 > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561176} TBR=bauerb@chromium.org,fdoray@chromium.org,erg@chromium.org,sebmarchand@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 773382 Change-Id: I9216725dd36891661b75a3d03a93d5298ea2dc30 Reviewed-on: https://chromium-review.googlesource.com/1072787 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561694}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b1a5e452d31e..af2ffd933d0e $ git log b1a5e452d..af2ffd933 --date=short --no-merges --format='%ad %ae %s' 2018-05-24 agable Remove cq_client from depot_tools Created with: roll-dep src/third_party/depot_tools BUG=chromium:770408 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ibd05c61891c11981e0aa3546b2aed95be31d6916 Reviewed-on: https://chromium-review.googlesource.com/1072687Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561693}
-
David Jacobo authored
Constructing a basic default Referrer for ArcExternalProtocolDialog based on the last committed url. Bug: None Test: Build. Change-Id: I6aeb677d57632198b69c7cc229f92a2571526a0c Reviewed-on: https://chromium-review.googlesource.com/1072513Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#561692}
-
Hector Carmona authored
This affects both chrome://settings and chrome://extensions. Bug: 840633 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5e69e542a9c08fd35c2f6b02a8277d7ee87998fe Reviewed-on: https://chromium-review.googlesource.com/1068114 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#561691}
-
Brandon Jones authored
If GVR reports a floor offset from the current tracking origin the floor grid will be adjusted to render at the same offset. This should help user comfort when using standalone devices. Bug: 845225 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I08bd081087f4f6528ec8200ee424d08f9bf9f059 Reviewed-on: https://chromium-review.googlesource.com/1067541 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#561690}
-
Ben Pastene authored
Similar to https://chromium-review.googlesource.com/1069867, but for the ios-simulator CQ bot. Bug: 846443 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic2377312b47e029bc1804a8ad94a95f595deab4a Reviewed-on: https://chromium-review.googlesource.com/1072733Reviewed-by:
Menglu Huang <huangml@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#561689}
-
David Bertoni authored
The chrome:// scheme is sensitive enough that any extension that can have permission to run on a chrome:// page should have to specially request access to that page. Prevent <all_urls> from implicitly matching the chrome:// scheme. Bug: 821858 Change-Id: Ie321749cd93ee4b51e89f501a9a25088d3df84c4 Reviewed-on: https://chromium-review.googlesource.com/993753 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#561688}
-
Mark Pilgrim authored
Bug: 844920 Change-Id: Iabbe4f3367ca8ade1afa09d595bc05483f0e1d49 TBR: pkasting@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1070328 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#561687}
-
Felicia Lim authored
The license header has been added to third_party/opus/src/autogen.sh upstream and updated here R=thestig@chromium.org Change-Id: I8e1adf14995d6d184edf4e77a77e0991516df7d1 Reviewed-on: https://chromium-review.googlesource.com/1062068Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Felicia Lim <flim@chromium.org> Cr-Commit-Position: refs/heads/master@{#561686}
-
Sarah Chan authored
Currently the Virtual Keyboard is difficult to use when the Fullscreen Magnifier is enabled Improvements include: - Keeping the Virtual Keyboard in the same size and position when Fullscreen Magnifier is enabled. This is done by applying the magnifier's inverse transform on the Virtual Keyboard's container. - Reduce the bottom margin to pan down the magnifier so that you can interact with the keyboard without panning. This CL disables keyboard overscroll when the fullscreen magnifier is enabled since overscroll would cause layout issues. Screenshot: https://screenshot.googleplex.com/BXnT2RG4A7h Testing: ash_unittests - MagnificationControllerTest.TextfieldFocusedWithKeyboard - MagnificationControllerTest.KeyboardOverscrollDisabled Bug: 347252 Change-Id: Ibcdd43573b211d6bad21b60bb19f427a58490c3f Reviewed-on: https://chromium-review.googlesource.com/1009269 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#561685}
-
Joel Einbinder authored
This lets you scroll the text prompt horizontally by selecting text with the mouse. Bug: 800038 Change-Id: I6e6970a6998530d3355c458d826923b471616e4a Reviewed-on: https://chromium-review.googlesource.com/1072417Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#561684}
-
John Rummell authored
If Widevine comes with an improperly formatted manifest file, don't register the CDM and indicate the failure to the component updater so that Widevine doesn't show up in chrome://components. As the latest version of Widevine is bundled with Chrome, any invalid manifests should be caught by the Chrome waterfall. BUG=837840,841988 TEST=tested locally with incorrect manifest Change-Id: I51993f4748c23436cddcc2dd35c33333d2ad27e8 Reviewed-on: https://chromium-review.googlesource.com/1056202Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#561683}
-
Marijn Kruisselbrink authored
The use counter is showing pretty much zero usage of this API, so as a first step towards removing the implementation of DownloadToFile, this changes the exposed API to always fail when attempting to use it. Bug: 823522 Change-Id: Ic82280d3d203684467fa4845b255cff9a02e1e12 Reviewed-on: https://chromium-review.googlesource.com/1062705Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#561682}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0f8aab8b5421..ba1627086779 $ git log 0f8aab8b5..ba1627086 --date=short --no-merges --format='%ad %ae %s' 2018-05-24 brandon1.jones Fix entry point generation on non-Windows 2018-05-21 tobine Enable sysroot install on x86 & x64 based-systems 2018-05-17 jmadill dEQP: Abort gtest run on exception. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I0880eb7566b1db48481f1c2b6596bf379d124441 Reviewed-on: https://chromium-review.googlesource.com/1072425 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561681}
-
David Jacobo authored
This CL allows ArcExternalProtocolDialog to use omnibox's IntentPickerView icon as an anchor for the picker UI. For that we had to plumb a new flag to ShowIntentPickerView, notice that IntentPickerBubbleView::ShowBubble() already expects this flag so it was only plumbing. Make sure omnibox's icon is not visible after the user takes a decision in the picker UI, at the moment the way IntentPickerView queries for apps is not compatible with a persistent non-http(s) url. Bug: b/67653046 Test: Try Change-Id: I0d0457ecbbebc2e6556db0bb54e394038c7f6cdf Reviewed-on: https://chromium-review.googlesource.com/1069597 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#561680}
-
Erik Staab authored
Bug: 731967,790413 Change-Id: I3b6043efbad9d35a86b19c7b40970ee8df29df4c Reviewed-on: https://chromium-review.googlesource.com/1072799Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561679}
-
Philip Rogers authored
This patch removes the !RLS codepaths in PaintLayerCompositor (PLC) because PLC does not create layers with Root Layer Scrolling (RLS). Now RLS has launched, we can remove this obsolete technology. Bug: 823365 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I999a7239c88acd48ba781ff5bcdcd6079994daaa Reviewed-on: https://chromium-review.googlesource.com/1072487 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#561678}
-
Oskar Sundbom authored
CL 5 of 5 to plumb echo canceller output device information from the renderer into native AEC implementations. For a full outline of the changes, see: https://docs.google.com/document/d/1ZH3lk4MdoEtmOleFD3ip6X0JF2-6_24_NTUjxshvM3U/edit?usp=sharing Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I945a8e30fbf1410a00167c2a50930639c20835be Bug: 837661 Reviewed-on: https://chromium-review.googlesource.com/1032594Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#561677}
-
Chris Harrelson authored
Previously, we used the bounds of the containing block. This can be very inefficient in cases such as long paragraphs of text within a single block, leading to excessive numbers of column fragments. Bug:797591 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I455ef37cad4d97f8069aa37dc3542e290b6aeab6 Reviewed-on: https://chromium-review.googlesource.com/1070562 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#561676}
-
Andrey Kosyakov authored
This introduces additional methods in headless::Request so that we can stop exposing GetURLRequest(). The end goal is to be able to have different Request implementations not backed by a URLRequest. TBR: eseckler@chromium.org, alexclarke@chromium.org Change-Id: Ibdf18d28851e69c986b22f441692e94cb017d50d Reviewed-on: https://chromium-review.googlesource.com/1072230Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561675}
-
Philip Rogers authored
This patch removes the !RLS codepaths in paint layer clipper and root scroller controller. Now that Root Layer Scrolling (RLS) is enabled by default, this code is no longer needed. Bug: 823365 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I55e925d572dfbcee2cb4db53c73ca9f841a4d01b Reviewed-on: https://chromium-review.googlesource.com/1072632Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#561674}
-