- 01 Oct, 2018 40 commits
-
-
Kevin Marshall authored
content::NavigationEntry contains more useful data about the page load state compared to |validated_url|, which obscures the URLs that caused page load errors. Add an |is_error| field to indicate if an error occurred during navigation. BUG=890533 Change-Id: If7407cec236ddd5b1474f52ac2538b3a3657a366 Reviewed-on: https://chromium-review.googlesource.com/1252637 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#595647}
-
Sophie Chang authored
Bug: 889621 Change-Id: Ibb038ec8ea75a75129dd9ccbfb20c86da750a901 Reviewed-on: https://chromium-review.googlesource.com/1255262Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#595646}
-
Bailey Berro authored
- Marks username and password as optional in the add share dialog. Bug: chromium:891020 Change-Id: Ie3ea8c2a021dd6be42a129865aac30fe00f67dcb Reviewed-on: https://chromium-review.googlesource.com/1255900Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#595645}
-
Jinho Bang authored
In the current implementation, memory leaks occur becuase the internal view_stack_ for payment sheet grows incrementally whenver calling retry(). So, this patch uses GoBackToPaymentSheet() instead of ShowInitialPaymentSheet() in RetryDialog(). The method has a logic to reduce stack's size internally. Bug: 861704 Change-Id: I2cb94772485165d1fa96463f16f39edf20ccf7bc Reviewed-on: https://chromium-review.googlesource.com/1255082Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#595644}
-
chrome://flagsMoe Ahmadi authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7303af44d7ada834b3d22e1cfdf5245976d7defc Reviewed-on: https://chromium-review.googlesource.com/1249910 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#595643}
-
Nate Fischer authored
This implements the Quiet Billing interstitial and adds the approved strings from http://crbug.com/887186 and adds the interstitial to the debug WebUI page (chrome://interstitials). WebView support will come in a follow-up CL. Bug: 887186 Test: browser_tests --gtest_filter=InterstitialUITest.BillingInterstitialQuiet Test: Manual - observe chrome://interstitials page Change-Id: I4ff9811d925bdde81bf1349ac714c2533ad563bb Reviewed-on: https://chromium-review.googlesource.com/1256021Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595642}
-
Matt Menke authored
A recent change (https://chromium-review.googlesource.com/1161479) accidentally resulted in treating 304 responses as downloads. This CL treats them as ERR_ABORTED instead. This doesn't exactly match old behavior, which passed them on to the renderer, which then aborted them. The new code results in correctly restoring the original URL in the omnibox, and has a shiny new test to prevent future regressions. Bug: 882270 Change-Id: Ic73dcce9e9596d43327b13acde03b4ed9bd0c82e Reviewed-on: https://chromium-review.googlesource.com/1252684 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595641}
-
David Black authored
Already we are handling interactions that end in error if they contain TTS. As it turns out, these interactions do not always include TTS so we need to handle this case as well to show a message to the user. Bug: b:116786185 Change-Id: Ic1b281c5d84f4cc2d955e01e31ffe3218cc82503 Reviewed-on: https://chromium-review.googlesource.com/1249077 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#595640}
-
Thomas Tangl authored
Record user action for signout button in user menu when the user is signed into Chrome (not syncing) and Dice is enabled. Bug: 891070 Change-Id: I3990093b7a59d047eff3ad07310c5c686c90e3ea Reviewed-on: https://chromium-review.googlesource.com/1255626Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#595639}
-
Gabriel Marin authored
Original CL: - https://codereview.chromium.org/11823061 GTTF: cherry-pick memalign/realloc mismatch debug code Especially ffmpeg may be prone to errors in this area. Googlers: see b/1397952 for reference. BUG=30715 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177171 BUG=724399,b:70905156 Change-Id: Iac78c1c49014a0454eacb651f549001e76c0cf93 Reviewed-on: https://chromium-review.googlesource.com/1130799Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#595638}
-
Andrey Kosyakov authored
Network conditions management is now done in content, so support for this in headless is redundant. Change-Id: I559de2c65e659c026b7e8e9d9021340e6271af92 Reviewed-on: https://chromium-review.googlesource.com/1255610Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#595637}
-
Marijn Kruisselbrink authored
Bug: 714018 Change-Id: I02bc49853ff630a0422ba0ddc8f08b7412046327 Reviewed-on: https://chromium-review.googlesource.com/1255148Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#595636}
-
Lukasz Anforowicz authored
We've decided to not ship this feature and focus on other isolation modes instead. Bug: 884842 Change-Id: I5895e12f4c80fa22e9fef8ea7045a1bb6a7913bb Reviewed-on: https://chromium-review.googlesource.com/1228944Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#595635}
-
Scott Violet authored
During the conversion to ws2 a handful of aura unittests got an early out. This adds comments as to why these tests fail with MUS, and updates one to work with MUS. For the ones I didn't update I didn't feel fixing the test was worth it, given we get coverage in the LOCAL case. BUG=866502 TEST=test only changes Change-Id: If6d1d0bd50c79b727fd9f38c3662312a76ca7d53 Reviewed-on: https://chromium-review.googlesource.com/1256011 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#595634}
-
David Black authored
Previously a voice interaction was only started if in tablet mode. Now, we'll also factor in user preference to start a voice interaction on Assistant entry. This CL is reliant on and cannot be submitted before: https://chromium-review.googlesource.com/c/chromium/src/+/1244441 Bug: b:115843337 Change-Id: Ia50b992843e542027e26faa2b522f3d4d48aa58e Reviewed-on: https://chromium-review.googlesource.com/1252631 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#595633}
-
Xiaohan Wang authored
The word "should" here is odd to read in some context. For example, in tests, when we "should bundle widevine CDM", we run tests that requires the CDM. This CL simply drops the word "should" so the gn/build flag becomes "bundle_widevine_cdm", which is more definitive. This CL also refactors widevine.gni to better support common variations. Bug: 349182,843649 Test: No functionality change. Rename only. Change-Id: Iaa8c6c29a33409bb1b31be86cb6202ff3f4b7cd9 Reviewed-on: https://chromium-review.googlesource.com/1249736 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#595632}
-
Bence Béky authored
StrCat is 2-4x faster, so use that instead of Printf/Appendf. This CL lands server changes 211484351 by dzetkulic and 215218657 by bnc. BUG=488484 Change-Id: I5b6cab6db94c1cb5f75106832d45858a92924875 Reviewed-on: https://chromium-review.googlesource.com/1252161 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Dianna Hu <diannahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#595631}
-
Thomas Tangl authored
The Clear Browsing Data dialog is updated: - A footer is added to display the sync account information. - The string descriptions for the data items depend on the sync state. - Information on how to resolve sync errors is added. Screenshots: https://drive.google.com/drive/folders/1AFV0ttCuS5g4IEOypktqeH3MGk8d_ac1?usp=sharing Bug: 889137 Change-Id: Ie79e9ff4bb68ec3f0a9b5a0231aaee707875618c Reviewed-on: https://chromium-review.googlesource.com/1251627 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595630}
-
Yuichiro Hanada authored
According to the reference doc of InputConnection.commitText(), we should clear the current composition text when commitText() is called instead of commiting the current composition text. Bug: 845079 Test: Typing text wiht Google Japanse Input app and it works well. Change-Id: Ie2d9cd73d64f5728dc82f3f441d73af7a2740836 Reviewed-on: https://chromium-review.googlesource.com/1252226 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#595629}
-
Mike Wasserman authored
PointerWatcher is no longer needed with Ash hosting the Window Service. Add StylusEventHandler to notify PaletteTray on stylus events. Fix odd logic for showing the bubble; remove event handler when done. Convert PaletteWelcomeBubble to EventHandler and simplify show/close. Update tests and perform some minor cleanup. Bug: 872450 Test: No (bad) behavior changes in palette tray / stylus welcome bubble. Change-Id: If8d6da88d6a70979978f227f10ebb8357fb0d34e Reviewed-on: https://chromium-review.googlesource.com/1252910 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#595628}
-
Mike Reed authored
Change-Id: I330bdfe4dcbfed55a03385043e703af6fe070ffd Reviewed-on: https://chromium-review.googlesource.com/1254341 Commit-Queue: Mike Reed <reed@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#595627}
-
Jun Choi authored
Currently, the only identifier for showing Bluetooth authenticators on WebAuthN UI modals is the authenticator ID which represents the MAC id of the device. As this is not user friendly, add human-readable authenticator_display_name to AuthenticatorReference. Bug: 877344 Change-Id: I2d3b35db669d8f8f61e9989870122a211d80e80f Reviewed-on: https://chromium-review.googlesource.com/1247681 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595626}
-
Kevin Marshall authored
This reverts commit af3f31af. Reason for revert: Breaks Android buildbot runs with errors like: ```../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/IncognitoToggleTabLayout.java:18: error: cannot find symbol import org.chromium.chrome.browser.widget.TintedImageView;``` Full run here: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933828868736954944/+/steps/compile__with_patch_/0/stdout Original change's description: > [Android] Replace TintedImageView and TintedImageButton > > This CL replaces Chrome-specific tinting view classes with their > AppCompat equivalents: TintedImageView -> AppCompatImageView and > TintedImageButton -> AppCompatImageButton. > 1. Entries in XML layouts have fully qualified names because some > layouts are inflated outside AppCompatActivity, so AppCompat magic > doesn't work for them. > 2. AppCompatImageView doesn't have setTint, so > ImageViewCompat.setImageTintList is used instead. > 3. AppCompatImageView uses 'tint' XML attribute instead of 'chrometint', > so these are replaced, too. > > Bug: 727723 > Change-Id: Id1614af64fa6ddd7cfdc6e12ad565ed32628d3c1 > Reviewed-on: https://chromium-review.googlesource.com/1245786 > Commit-Queue: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595500} TBR=tedchoc@chromium.org,twellington@chromium.org,bsazonov@chromium.org,huayinz@chromium.org Change-Id: I83efa81fce074f24f330281460b2685f1765f0e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 727723 Reviewed-on: https://chromium-review.googlesource.com/1255456Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#595625}
-
yusukes authored
BUG=b:116761000 TEST=None Change-Id: I353b0b183df8242b9a799face70be560f186e56c Reviewed-on: https://chromium-review.googlesource.com/1252386Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#595624}
-
yusukes authored
BUG=b:116761000 TEST=None Change-Id: I005557605a60296cc77f7dd4fd949b5ff4ff75f2 Reviewed-on: https://chromium-review.googlesource.com/1253211Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#595623}
-
Kenichi Ishibashi authored
Motivations behind this change are: - To track time spent executing fetch event handers - To track IPC delay for navigation case (renderer -> browser). - To track thread hopping delay for subresource case (renderer SW thread -> renderer background thread). Cq-Include-Trybots: luci.chromium.try:linux_mojo Bug: 877972 Change-Id: I1ea2e17e3270c9f79e6b5104885562b96ac497b0 Reviewed-on: https://chromium-review.googlesource.com/1242579Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595622}
-
Li Lin authored
Enable timer notification by default. We can disable the feature by overriding the flag to false with finch. Bug: b:110107505 Change-Id: Ide23cebd82ec2a51727abf6b87b408c98623aed3 Reviewed-on: https://chromium-review.googlesource.com/1251631 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#595621}
-
Dániel Bátyai authored
When using ChromeOS on ARM with a 64bit userspace, the early sandbox blocks the Mali/GLES/EGL libraries from loading, because only the 32bit paths are allowed. Whitelist the 64bit paths when building for aarch64 on ChromeOS. BUG=882033 TEST=Device boots, GPU process is sandboxed Change-Id: Iba2e696291b96c23aaaafc417d4eb96f084f4f46 Reviewed-on: https://chromium-review.googlesource.com/1230066 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595620}
-
Lukasz Anforowicz authored
Thanks to a clang fix (*) things work fine on Mac now. (*) rC342600 fixes https://bugs.llvm.org/show_bug.cgi?id=38896 Bug: 881875 Change-Id: I8c65848bf09f1a7f80f640e8b2e09bb2ef1e3789 Reviewed-on: https://chromium-review.googlesource.com/1249837Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#595619}
-
Karan Bhatia authored
BUG=696822 Change-Id: I77b3ed6aba80cf1c41e27148b560fbe7094fb19e Reviewed-on: https://chromium-review.googlesource.com/1222158Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#595618}
-
Nico Weber authored
The tests seem to pass now. Bug: 630357,845389 Change-Id: I7e74c1a41f578dc70866d533742e36bafb787f63 Reviewed-on: https://chromium-review.googlesource.com/1251327Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#595617}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/3448987ab20a..2beb5c9f91e7 $ git log 3448987ab..2beb5c9f9 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 jingning Remove deprecated get_arf_buffer_indices() 2018-09-28 jingning Remove deprecated arf_update_index from GF_GROUP 2018-09-27 paulwilkins Fix minor bug in calculation of max arf group length. 2018-09-28 paulwilkins Adjustment of GOP intra factor for multi-layer. 2018-09-25 huisu Add ml_var_partition experiment 2018-09-28 paulwilkins Revert "Merge "Adapt GOP size threshold to the allowed layer depth"" 2018-09-27 jingning Add MID_OVERLAY_UPDATE frame type 2018-09-27 jingning Refactor gf_overlay frame type update 2018-09-27 huisu Fix a loophole in nonrd_pick_partition() 2018-09-27 jingning Remove deprecated variables from GF_GROUP structure 2018-09-27 jingning Remove unused for-loop in multi-layer arf bit allocation 2018-09-26 jingning Adapt GOP size threshold to the allowed layer depth 2018-09-26 angiebird Add vpx_clear_system_state to new mv search func 2018-09-26 angiebird Change mv color to red 2018-09-26 johann.koenig add cfi sanitizer 2018-09-26 johann.koenig CONFIG_WEBM_IO: include webmids.h 2018-09-25 angiebird Call vp9_full_pixel_diamond_new in tpl mv search 2018-09-25 angiebird Add vp9_full_pixel_diamond_new 2018-09-24 angiebird Add vp9_refining_search_sad_new 2018-09-24 angiebird Add vp9_diamond_search_sad_new (...) Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I0dc3ae4855a3faaa94086bfa9e4a5cb022f09689 Reviewed-on: https://chromium-review.googlesource.com/1254753Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#595616}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2b4d11c0f133..ce342184e625 git log 2b4d11c0f133..ce342184e625 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 thestig@chromium.org Update some third_party/base headers. 2018-10-01 thestig@chromium.org Make header guards consistent in third_party/base/*.h. 2018-10-01 thestig@chromium.org Fix #include ordering / formatting. 2018-10-01 thestig@chromium.org Initialize more CXFA_Node members in the header. 2018-10-01 thestig@chromium.org Remove some "exceptions" from reedsolomon code. 2018-10-01 thestig@chromium.org Use size_t and FX_ArraySize() for some arrays. 2018-10-01 rharrison@chromium.org Add XFA JPG pixel test 2018-10-01 rharrison@chromium.org Add XFA GIF pixel test Created with: gclient setdep -r src/third_party/pdfium@ce342184e625 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If39e1827d0a99dc2b2e7d1701ecbfa4e617f7417 Reviewed-on: https://chromium-review.googlesource.com/1255302Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595615}
-
Andrew Grieve authored
Regressed in recent commit: d0567449 Bug: 890360 Change-Id: I1589295c40eff98a6255d9dd01ad9c2a66817dc4 Reviewed-on: https://chromium-review.googlesource.com/1255888Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#595614}
-
Kevin Strohbehn authored
Bug: 885232 Change-Id: I08943ff79a7dfae036acb8842bc67e8fe90c2999 Reviewed-on: https://chromium-review.googlesource.com/1253073Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#595613}
-
Joone Hur authored
Here is the call stack when the crash happens: (chrome - scoped_refptr.h: 191) libgtkui::SelectFileDialogImplGTK::OnFileChooserDestroyThunk(_GtkWidget*, void*) (chrome - select_file_dialog_impl_gtk.cc: 98) libgtkui::SelectFileDialogImplGTK::~SelectFileDialogImplGTK() (chrome - select_file_dialog_impl_gtk.cc: 89) <name omitted> (chrome - ref_counted.h: 414) DownloadFilePicker::~DownloadFilePicker() (chrome - select_file_dialog_impl_gtk.cc: 284) libgtkui::SelectFileDialogImplGTK::FileSelected(_GtkWidget*, base::FilePath const&) A dialog is destroyed in FileSelected(), but it seems that the same dialog is destroyed again in OnFileChooserDestroy. BUG=880073 Change-Id: I1f47bbc26b4af81b4c73d7cf03ac684edc4f97fd Reviewed-on: https://chromium-review.googlesource.com/1256020 Commit-Queue: Joone Hur <joone.hur@intel.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#595612}
-
Kevin Marshall authored
This resolves the connection error log spam seen in suites like content_unittests. Change-Id: I26d1959b9be67247af10c454b21159755b68eb72 Reviewed-on: https://chromium-review.googlesource.com/1256019 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#595611}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5ddbdbf70c50..624fbdcf55b0 git log 5ddbdbf70c50..624fbdcf55b0 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 oetuaho@nvidia.com Refactor CompileProgram utility 2018-10-01 thakis@chromium.org Remove an exit-time destructor from a frequently-included header. 2018-10-01 geofflang@chromium.org Vulkan: Implement robustness extensions. 2018-10-01 jmadill@chromium.org Vulkan: Record blit commands inside blit methods. 2018-10-01 geofflang@chromium.org Reland "D3D11: Resolve multisampled EGL surfaces at eglSwapBuffers" 2018-10-01 jmadill@chromium.org Vulkan: Use copyImageDataToBuffer in Texture mipmap gen. 2018-10-01 syoussefi@google.com Vulkan: Add support for VkPipelineCache Created with: gclient setdep -r src/third_party/angle@624fbdcf55b0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:887403 TBR=cwallez@chromium.org Change-Id: If26142dca4cbbae4598e48f346fbc5b3d0b4af1f Reviewed-on: https://chromium-review.googlesource.com/1255508Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595610}
-
Xiaohan Wang authored
This makes it easy to organize the doc and find files. This CL does minimal reordering of the files listed in the current README, with some rough grouping. It is expected that we'll improve the structure of the file gradually over time. Bug: 818048 Change-Id: I8f19fa388d6cd599fc32824b91d184bd49b2767a Reviewed-on: https://chromium-review.googlesource.com/1253207Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#595609}
-
Jinsuk Kim authored
Lazy init (https://crrev.com/578223) doesn't work for TextSuggestionHost whose UI gets triggered by native from Blink. It expects the related components (java TextSuggestionHost and blink::mojom::TextSuggestionHost) to be ready before it makes the first call. This CL initializes the objects in eager fashion. Bug: 884214 Change-Id: I1ef96d7d617a1fb745f2652a7e1f94e5d9406a24 Reviewed-on: https://chromium-review.googlesource.com/1253312Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#595608}
-