GitLab

    I tested: 1. open pip window, 2. move around, 3. resize, 4. close,
    5. re-open, 6. close tab destroying the window
    off.

Bug: 841886
Test: Chrome PIP works with rounded corners flag both on and off.
Test: Android PIP window works with rounded corners flag both on and
Change-Id: Iec59abde476d56c58e197b9220ac6ba418801395
Reviewed-on: https://chromium-review.googlesource.com/c/1347969Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611957}

ChromeContentBrowserClient is already reviewable by all. It seems
the other parts of ChromeContent*Client should also, so do the
same for ChromeContentClient and ChromeContentRendererClient.

Change-Id: I855d7ab540366bd6512b1c1d9e9042975e3456c5
Reviewed-on: https://chromium-review.googlesource.com/c/1352083Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611956}

At onLoad, Preconnect to the origin that has the highest preconnect
score as long as the score is above the specified threshold.
Currently, due to privacy constraints, this is restricted to
only the document origin.

Effectively, this means that we preconnect to the document origin
only if its preconnect score is more than the specified threshold.
If not, no preconnect action is taken.

The preconnect score of an origin is computed from the score
of all the anchor elements on the webpage that point to that
origin.

Change-Id: Ie3178f352cb5106124e13cb6f7e39b9ecf81174c
Bug: 903945
Reviewed-on: https://chromium-review.googlesource.com/c/1349874Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611955}

This patch makes CL:1251142 tests pass. LayoutNG was not setting
the  InlineOutlineWithContinuation flag.

Bug: 835484
Change-Id: If42b64316e71bb3c23ef05284b2c220b6baf4700
Reviewed-on: https://chromium-review.googlesource.com/c/1354319
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611954}

Fix two typos and align IntDef definition to definitions from other files.

Change-Id: I034d3cf27ceb745c5584f3449df1827383ebdefd
Reviewed-on: https://chromium-review.googlesource.com/c/1353994Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#611953}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I37c3a50a0b51a7bdad1162c1d0e1670c55c95f06
Reviewed-on: https://chromium-review.googlesource.com/c/1354336Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611952}

This CL removes macro usage from /ios/chrome/browser/ssl.

This CL was uploaded by git cl split.

R=estark@chromium.org

Bug: 589840
Change-Id: I603edc1c7e8aff2d4aae44722285ed7c0976c613
Reviewed-on: https://chromium-review.googlesource.com/c/1351966Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611951}

https://chromium.googlesource.com/angle/angle.git/+log/c4e0a1e511fc..5829c03d383e


git log c4e0a1e511fc..5829c03d383e --date=short --no-merges --format='%ad %ae %s'
2018-11-28 syoussefi@chromium.org Vulkan: fix ProgramVk never releasing uniform buffers
2018-11-28 syoussefi@chromium.org Vulkan: Make DynamicBuffer use BufferHelper
2018-11-28 ynovikov@chromium.org Rearrange Android lib deps


Created with:
  gclient setdep -r src/third_party/angle@5829c03d383e

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I87bb56bc3f997ea442c04b049f9bdd20dcbedce8
Reviewed-on: https://chromium-review.googlesource.com/c/1354306Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611950}

This is a reland of e45a6ef0

The original CL was reverted because a DCHECK was being hit. The
TrayBluetoothHelperLegacy implementation would sometimes call
OnBluetoothSystemStateChanged without the state actually changing
which would cause the DCHECK to be hit.

A separate CL (https://crrev.com/c/1352123) fixed
TrayBluetoothHelperLegacy so now the DCHECK shouldn't be hit.

Original change's description:
> bluetooth: Query for devices every second in TrayBluetoothHelper
>
> Before TrayBluetoothHelper would get notified of any changes to devices.
> This caused problems in busy environments because TrayBluetoothHelper
> would get notified hundreds or even thousands of times per second of
> devices changes.
>
> This CL changes to a "pull" pattern where TrayBluetootHelper queries
> for devices every second. The devices are then cached so that clients
> of TrayBluetoothHelper can access them synchronously.
>
> TrayBluetoothHelper queries for devices as long as the state is
> kPoweredOn. If the state changes, the device list is cleared.
>
> Bug: 882346
>
> TEST=The following actions should be performed:
>
> 1. Turn bluetooth on and off in system tray.
> 2. Open device list in system menu.
> 3. Connect to a device.
> 4. See that the pod feature button in the system tray indicates a
>    device is connected when connected to a device.
>
> Change-Id: Id9028546a627f260527aa737f51c032f74a447ec
> Reviewed-on: https://chromium-review.googlesource.com/c/1347638
> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611069}

TBR=tetsui@chromium.org

Bug: 882346
Change-Id: Ief9ce3d77a317dfde2a5fcc49cb0c598aaa9012d
Reviewed-on: https://chromium-review.googlesource.com/c/1352078Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611949}

This wires the IsUserVerifyingPlatformAuthenticator API call up to its
implementation in the native Windows API, where available.

Bug: 898718
Change-Id: I40307ff39f8dc8e02197debc48041aad62d253ac
Reviewed-on: https://chromium-review.googlesource.com/c/1351900
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611948}

The package was removed from nacl_list in r607986.

BUG=None
TBR=dpranke

Change-Id: I052e3a0fdc5f58834bfec9b38502b5aa60e2edf0
Reviewed-on: https://chromium-review.googlesource.com/c/1354353Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611947}

This is a reland of afad6853

Original change's description:
> Move device service to new service APIs
>
> Migrates device service code and tests from deprecated service APIs to
> new ones. Namely this phases out its use of ServiceContext and
> ServiceTest in favor of ServiceBinding and plain old unit tests.
>
> Bug: 891780,906239
> Change-Id: I7677134b5d11e7297b162bbb532dfabb810504d2
> Reviewed-on: https://chromium-review.googlesource.com/c/1345124
> Commit-Queue: Ken Rockot <rockot@google.com>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611379}

TBR=jam@chromium.org
TBR=blundell@chromium.org
NOPRESUBMIT=true

Bug: 891780, 906239
Change-Id: I3d61c1d0229e04d10adc4bcfe9032a50d5238ced
Reviewed-on: https://chromium-review.googlesource.com/c/1352805Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611946}

Add support for extensions requesting content script permissions in the
permissions API. This allows extensions to request withheld content
script permissions through chrome.permissions.request().

Add tests to cover the same.

Bug: 889654
Change-Id: I0b77215ec154e42d1152df3277307d0383cda204
Reviewed-on: https://chromium-review.googlesource.com/c/1347061Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611945}

Bug: 827582
Change-Id: I86a4d5cba5901fb7430c554a4fc978789f51fb49
Reviewed-on: https://chromium-review.googlesource.com/c/1354418
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611944}

Tab no longer use the VoiceSearchTabHelper, so ordering is not needed
any more

Bug: 778416
Change-Id: I37a84f76de97be5af8956eb829808f86ac839468
Reviewed-on: https://chromium-review.googlesource.com/c/1353937Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611943}

This was replaced by ScenicGpuHost but not removed.

Bug: 861853
Test: compile
Change-Id: I6c982b87a6f9d64abb975ebfd4ac2d024333d503
Reviewed-on: https://chromium-review.googlesource.com/c/1354480Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611942}

This is a reland of d3708f20

The previous CL did not return the device to the original rotation.

Original change's description:
> [ios] Create UI test for page info (site info)
>
> This CL creates an UI integration test that tests that the
> page info view gets automatically dismissed on device rotation.
>
> Change-Id: I02611cc2fab5a214b74af01d15cd8d12e19eff6e
> Reviewed-on: https://chromium-review.googlesource.com/c/1338561
> Commit-Queue: edchin <edchin@chromium.org>
> Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: edchin <edchin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608844}

Change-Id: I5c4a8286275b1ab3d411d4e355557d499607437a
Reviewed-on: https://chromium-review.googlesource.com/c/1343517
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611941}

The motivation to do this is to be able to convert in annotation mode
when the plugin is not active.

Fortunately it turns out that there is enough information to do this
without communicating with the plugin -- the dimensions of each page
are available and the translation from points to pixels is straightforward.

This new implementation also deals with the case where the
document has been rotated.

Bug: 902646
Change-Id: Id2814f96f6020c44cee07f725f5170494f1b512b
Reviewed-on: https://chromium-review.googlesource.com/c/1347646Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dstockwell <dstockwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611940}

When using native GTK frame buttons, we only want the padding returned by
NavButtonProvider::GetTopAreaSpacing() to apply to the side(s) that actually
have frame buttons on them, otherwise the padding on a tab that is adjacent to
the frame edge will depend on which GTK theme is used, rather than being
constant across all themes.

BUG=None
R=pkasting

Change-Id: Ibf5bb40c0d51d6387ca2b21abc54b1adad8f69b0
Reviewed-on: https://chromium-review.googlesource.com/c/1287261
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611939}

Add docs for using MediaController.

BUG=893296

Change-Id: I5e836749d94b0274d7bc10ee31c03469d1d01cb4
Reviewed-on: https://chromium-review.googlesource.com/c/1354481
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611938}

Originally landed as:
https://chromium-review.googlesource.com/c/1352855
Reverted as:
https://chromium-review.googlesource.com/c/chromium/src/+/1354327

First patch set includes original CL, and subsequent patches contain
updates to fix the failing test.

Original CL descrition:

When a SecureChannel disconnects due to authentication failures,
BleConnectionManagerImpl invokes the relevant failure callback, which
then causes ConnectionAttemptBase to cancel the connection attempt.

When the attempt is cancelled, the SecureChannel object is deleted via
BleConnectionManagerImpl::ProcessPotentialLingeringChannel(), but
BleConnectionManagerImpl::HandleSecureChannelDisconnection() assumed
that the object was still valid and tried to to remove itself as an
observer, causing a segfault.

The fix is to check whether the object has been deleted before
attempting to call RemoveObserver().

Bug: 905904, 909883
Change-Id: I770bff8f05865aeac8b7513d7193d0b7a40d056e
Reviewed-on: https://chromium-review.googlesource.com/c/1354333Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611937}

* Pass in profile instead of mojom connector, this will guarantee the
  profile and connector always matches

Bug: 908919
Test: locally build and run
Change-Id: Iae0a73524456c108c75e1a21400d28a99afe6cd2
Reviewed-on: https://chromium-review.googlesource.com/c/1352769
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611936}

This interface is unused within CallStackProfileBuilder. The equivalent
functionality will be supported eventually within the class but will
occur via the metadata mechanism.

Bug: 851163
Change-Id: I3bd8430de70c973c3e4a293118403312b977f8d1
Reviewed-on: https://chromium-review.googlesource.com/c/1351533Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611935}

Flaky DCHECKs in the ash process, likely threading issues.

Bug: 909736
Change-Id: I080d1a30b415e10a33bb957711c0f4a68328c7ba
Reviewed-on: https://chromium-review.googlesource.com/c/1354345Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611934}

Bug: 891303
Change-Id: I07686b8d72934ad32574aa8d2b901e110c41457c
Reviewed-on: https://chromium-review.googlesource.com/c/1352506Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611933}

These scripts were erroneously omitted from the page, resulting in a
DCHECK() failure.

Change-Id: I9b1ccb554d096767d949ede14914aae13d00fbdc
Reviewed-on: https://chromium-review.googlesource.com/c/1354133Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611932}

Bug: 884020
Change-Id: I072b6902757149f93bbf40443e45b56670b04858
Reviewed-on: https://chromium-review.googlesource.com/c/1350410Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611931}

This will allow using Autofill API rather than the legacy server to query
and upload form data for crowdsourcing. Using the Autofill API is gated by the feature flag "AutofillUseApi".

Changes should be no op if using the legacy server.

Summary of the changes:
 > Added a function to parse the API response.
 > Added logic to make request data (query and upload) for API.
 > Added an API key attribute to AutofillDownloadManager.
 > Added unittests for new code branches of the API.

Tests:
 > Updated unittests.
 > Did a small integration test between a local API and a chrome browser built at this CL
   with the API feature enabled. Tested both query and upload.

Change-Id: I5933949c25d9ad9566e910002bdcd09c39983af5
Reviewed-on: https://chromium-review.googlesource.com/c/1343068
Commit-Queue: Vincent Boisselle <vincb@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611930}

This should fix the Android Mojo bot failing. The asserts in this test
were changed in http://crrev.com/c/1338660.

TBR=timvolodine@chromium.org

Bug: 893580
Change-Id: I9ce72b7726e553758f80b379c0c652df72b5909d
Reviewed-on: https://chromium-review.googlesource.com/c/1354441Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611929}

This DCHECK() asserted that a SecureChannel status change could only be
AUTHENTICATED => DISCONNECTING, AUTHENTICATED => DISCONNECTED, or
DISCONNECTING => DISCONNECTED.

However, AUTHENTICATING => AUTHENTICATED is also a valid status change,
so I added that to part of the DCHECK().

This issue was discovered when attempting to enable DCHECK()s by
default in accordance with the recent e-mail announcements.

Change-Id: Ia5126b70e25245f49d04939ae2e1e0bc0ea9315a
Reviewed-on: https://chromium-review.googlesource.com/c/1352996Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611928}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cbdf45b8cca9..172196a4380a


Created with:
  gclient setdep -r src-internal@172196a4380a

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I86427541b8dabb2fcf848525527e7e21d983f432
Reviewed-on: https://chromium-review.googlesource.com/c/1354163Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611927}

To show that this case is not currently supported.

Bug: 909730
Change-Id: Iaca51858fa9987ef95cd9c4341386472dc55cb57
Reviewed-on: https://chromium-review.googlesource.com/c/1352507Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611926}

Using wpt-import in Chromium 58af8aa9.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: Ifebbee7d79380894ac0fb87246f81a3bae510972
Reviewed-on: https://chromium-review.googlesource.com/c/1352940
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611925}

Bug: 908003
Change-Id: Iada2d816073d4f38cd0438838548d10f94d5b7db
Reviewed-on: https://chromium-review.googlesource.com/c/1352944
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611924}

Sometimes video containers report audio packet timestamps as -1,
which was triggering the packet drop code from background track seeking.

Bug: 902634
Change-Id: I2b74fde01f9f2e06aeaf5fa4c2a3a1a4af8ead5d
Reviewed-on: https://chromium-review.googlesource.com/c/1352579
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611923}

conformance2/textures/misc/tex-mipmap-levels.html fails on some
configurations, presumably due to driver bugs.

TBR: kbr@chromium.org
Bug: 909879
Change-Id: Icba22da20242c9dea3e9bf19f5842e75e88e7c2f
Reviewed-on: https://chromium-review.googlesource.com/c/1353954Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611922}

This is allowing the test to run and mark it properly as a leak test
problem.

Bug: 733494
Change-Id: I9c4b9276745510482e58ea89dce9c65c596bcba5
Reviewed-on: https://chromium-review.googlesource.com/c/1352619Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611921}

It needs to hold onto a reference to itself until the end of the method,
instead of just until its HasOneRef() check has completed.

Bug: 907524
Change-Id: I75fab97b07fe55f30a6a7c6def390f5d0bc28c4f
Reviewed-on: https://chromium-review.googlesource.com/c/1352684
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611920}

Bug: 901896
Change-Id: I932d2a34b63c803f1455b9d908539072ce350cd8
Reviewed-on: https://chromium-review.googlesource.com/c/1351820
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611919}

Bug: 790309,790294,790286
Change-Id: I9e6a5ff635b6edda8bbe4fb87826f8cf7a5dcd5f
Reviewed-on: https://chromium-review.googlesource.com/c/1354137Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611918}