GitLab

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: Ic9ea29d50b11385db9641a0d106a80b68ea0b1da
Reviewed-on: https://chromium-review.googlesource.com/c/1327417Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606949}

1) The Home Launcher used to use the wrong display ID when in
   Unified Desktop mode.
2) If (1) is fixed, we hit https://crbug.com/902601. The captive
   portal dialog widget used to be leaked and never destroyed.
3) If (2) is fixed, we crash on the first attempt to press the
   app list button. The reason is tablet mode triggers a switch
   to mirror mode. This switch happens asynchronously after the
   Home Launcher had already been created. Switching from Unified
   to mirror mode destroys the Unified host and the Home Launcher.
   That's why we need to ensure that the Home Launcher is
   recreated.

TBR=oshima@chromium.org,weidongg@chromium.org
BUG=900956, 902601
TEST=Added a test that crashes without the fix.

Reviewed-on: https://chromium-review.googlesource.com/c/1325389
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#606687}
Change-Id: Ia0558bf1eba4234535b3826e671929e37db8dee1
Reviewed-on: https://chromium-review.googlesource.com/c/1329550Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606948}

In VerifyEndpoint(), the code that catches an exception tries to
continue, only to hit an UnboundLocalError. Instead of doing that, raise
an SystemExit to fail gracefully.

Change-Id: Idf1174ef01fbe7a086712fa6e7b9cca7ada97a69
Reviewed-on: https://chromium-review.googlesource.com/c/1313561Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Prasad Vuppalapu <prasadv@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606947}

This is a reland of 05e6d611

Original change's description:
> Fix page slip issue after dragging
>
> Changes:
> Update the selected page to be the target page of dragged item at the
> end of dragging.
>
> Bug: 893832
> Change-Id: I91dcf8e03f62eab1597e3899bdbcafdad1fec2df
> Reviewed-on: https://chromium-review.googlesource.com/c/1324851
> Commit-Queue: Weidong Guo <weidongg@chromium.org>
> Reviewed-by: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606585}

Bug: 893832
Change-Id: I51c2d7d5d2a9a7ed4e752d71f3f6bee083ac84e0
Reviewed-on: https://chromium-review.googlesource.com/c/1329894Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606946}

Proper color is set by theme services using the color returned
from COLOR_TAB_ALERT_CAPTURING.

TBR=estade@chromium.org

Bug: 870134
Change-Id: I23e153840ed10857054daa4c8ba97de8dcaae94c
Reviewed-on: https://chromium-review.googlesource.com/c/1330065Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606945}

This test was made flaky by this CL:
  https://chromium-review.googlesource.com/c/chromium/src/+/1213864

TBR=masonfreed@chromium.org
NOTRY=true

Bug: 903019
Change-Id: Ifd936eb36d2a2731a66f391c54de5ec019963d5e
Reviewed-on: https://chromium-review.googlesource.com/c/1330216Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606944}

When flinging, we currently have 3 notifications show up. The
notification surfaced from the Chrome MediaRouter offers a better path
to control the media route directly, and the media session controls are
redundant.

This CL adds |is_flinging_| into UpdatePlayState's computations, in
order to hide the MediaSession controller when using RemotePlayack.

Bug: 790766
Change-Id: If1acd5eb845875cbc19f08b71b74e27aba048c50
Reviewed-on: https://chromium-review.googlesource.com/c/1327537Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606943}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f6ed3c5d..934bab09

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ib44db3e4d58ea958f082f39b104dda88e5439236
Reviewed-on: https://chromium-review.googlesource.com/c/1329886Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606942}

R=kariah@chromium.org

Change-Id: Id505548c23807e135477240e0ea82804e5ecfb78
Reviewed-on: https://chromium-review.googlesource.com/c/1330072Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606941}

Previously we relied on Blink to correctly fill in the
row and column index of every cell in a table. This
tends to be expensive to do in Blink because it
requires invalidating and reserializing the entire table
if any cell changes.

Instead, try to defer as much of those calculations to
downstream to be computed when AT actually requests
table attributes.

This is more efficient, because Blink accessibility code
needs to run any time the page is updated, like when a
table is being built dynamically using JS - whereas AT
typically only queries table attributes when users
explore a table explicitly, so it makes sense to defer
computation until then.

This is also more accurate and less error-prone, as it
allows us to completely validate the table in a single
pass and fix any errors in table indexes.

Finally, a potential added benefit is that this makes it
easier to handle tables from Views or Arc++ that
don't have all of the table attributes set, we can
compute them automatically.

A follow-up change will remove the code that computes
some of these table attributes from Blink.

Bug: 832289

Change-Id: I252a592c854e47cf6d6e5bd6b7c4bc5d51775e72
Reviewed-on: https://chromium-review.googlesource.com/c/1307840Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606940}

Change-Id: I6cc93c62ca8c8d96929d3184f4b17b83d5371e63
Reviewed-on: https://chromium-review.googlesource.com/c/1330021Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606939}

Chrome ClusterFuzz has support for Windows while OSS-Fuzz does not.
Enable low hanging fruit that can easily be built in a Chromium build.

Bug: 903632
Change-Id: I9b6c9bf883271d33135a4fea31a05be3d13648df
Reviewed-on: https://chromium-review.googlesource.com/c/1328225Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606938}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5fa11106b909..31d1c800f1a0


Created with:
  gclient setdep -r src-internal@31d1c800f1a0

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I994d668fe3a75e970e5fd0f684615bfd5e042d8b
Reviewed-on: https://chromium-review.googlesource.com/c/1329983Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606937}

This CL adds the GetAriaLabel() and GetAriaDescription() helper functions
to the autofill::form_util namespace. These functions return the ARIA
label and description strings associated with an element.

The ARIA Label is the text referenced by one or more containing element
ids in the labelled elements aria-labelledby attribute, or the value
of the element's aria-label attribute, with preference given to the
aria-labelledby attribute. For example:

    <div id='foo-label'>Label for Foo</div>
    <input name='foo' aria-labelledby='foo-label'>
    <input name='bar' aria-label='Label for Bar'>

The aria-description is similar to aria-labelledby. For example:

    <div id='foo-description'>Long descriptive text for Foo</div>
    <input name='foo' aria-describedby='foo-descrition'>

Bug: 896719
Change-Id: Ida72c467d2e876b4d7a60ad56de56c7bac5489ec
Reviewed-on: https://chromium-review.googlesource.com/c/1325535
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606936}

A relevant patch is ag/5473995.

Bug: b:111367421
Test: build
Change-Id: Icdf9cf1dcd6b391ef4190c4fac89c00ef3fddb54
Reviewed-on: https://chromium-review.googlesource.com/c/1327332Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Cr-Commit-Position: refs/heads/master@{#606935}

Uses a drop-down rather than a slider or text field because
this seems like it would be easier for Autoclick users to
activate.

This still needs UI review but is hidden behind the
--enable_experimental_accessibility_features flag.

Bug: 894907
Change-Id: If4de66488df32ea2929961159ebfdaad15216f55
Reviewed-on: https://chromium-review.googlesource.com/c/1324376
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606934}

Bug: 899980
Change-Id: I4916f6e284a1fd0a99fff2c9d60535a389fb4655
Reviewed-on: https://chromium-review.googlesource.com/c/1329082Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606933}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/63924982b3fd..ffec6a8edd68


git log 63924982b3fd..ffec6a8edd68 --date=short --no-merges --format='%ad %ae %s'
2018-11-09 wutao@chromium.org Make tricky-chrome-pfq important


Created with:
  gclient setdep -r src/third_party/chromite@ffec6a8edd68

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Id0f114f713ec094b9d39c6f1e09c2cf67d57c297
Reviewed-on: https://chromium-review.googlesource.com/c/1329982Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606932}

Chrome currently won't autofill credentials into forms which have a
"new-password" field. A better criterion seems to be: only fill into
forms with a "current-password" field.

This CL adds a UKM metric to understand the impact of such change.

Privacy review of this metric:
The whole UKM event "PasswordForm" has been reviewed in
crbug.com/728707 and go/gkmnc, where the privacy TL agreed that adding
new metrics for this event is OK under certain conditions (see the
linked doc). The new metric, which measures changes to filling on load
of forms for which the user previously stored some credentials,
satisfies such conditions, in the opinion of the CL author, and hence
is covered by that review. The new metric has been added to the
requested spreadsheet listing all passwords-related metrics.

Bug: 895781
Change-Id: I8bb6537f97c96d0ed345d885a7ddd7c065370b22
Reviewed-on: https://chromium-review.googlesource.com/c/1326497Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606931}

This causes Write to block on the ServerHello, which is a somewhat
interesting I/O pattern.

Bug: 641225
Change-Id: I0faf9783cf027848e832c091032e5cd0efa2ceee
Reviewed-on: https://chromium-review.googlesource.com/c/1285449
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606930}

r603810 recently turned on the IO checks for ChromeOS browser tests.

Change-Id: Iaf3c654361a0502d5069a5e90a494d78df90ee90
Reviewed-on: https://chromium-review.googlesource.com/c/1329882Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606929}

Use Chromium's allocator shim interface to create a shim that samples
allocations to the GuardedPageAllocator. Add a function to enable
GWP-ASan that checks various feature flags to see if GWP-ASan should be
enabled and with what parameters.

In order to optimize the allocation hot-path, sampling is performed
using a thread-local counter to avoid contention. The sampling interval
is sampled from a poisson-distribution with a supplied frequency.

In order to optimize the deallocation hot-path, the GuardedPageAllocator
bounds are stored in global variables and the bounds check referencing
those globals are inlined into the deallocation routine to avoid the
indirection of accessing GlobalPageAllocator::PointerIsMine through a
singleton.

Bug: 896019
Change-Id: Id389d95a23067e2518cd58316db7b12935ec84af
Reviewed-on: https://chromium-review.googlesource.com/c/1306401
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606928}

This CL follows crrev.com/c/1056168 and removes |image_id_| from
CanvasResourceGpuMemoryBuffer, since it's not needed (it was
mentioned in that CL description but finally not removed).

Bug: 839970, 903837
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7540363f131e3a33609c945e68c8106992e0ba77
Reviewed-on: https://chromium-review.googlesource.com/c/1130170Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606927}

Use the size of the staged log instead of the size of the hash to check if it should be uploaded on cellular.

Bug: 902465
Change-Id: Ic7ffe0c5d5639b99f590c4ad7ebbf334254ea05f
Reviewed-on: https://chromium-review.googlesource.com/c/1329501
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606926}

Skip iframe elements when predicting the next navigation.

Change-Id: I2720ad4e59b70ca40a385e966e4c38844c83a1e2
Bug: 903884
Reviewed-on: https://chromium-review.googlesource.com/c/1328708Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606925}

Added functionality to set the isContentInvalid attribute of
NodeAccessibilityInfo, with the larger goal of exposing this
information to TalkBack. Added a test to check the presence of this
attribute in an invalid editText object.

R=dmazzoni@chromium.org

Bug: 847233
Change-Id: Ib5ddc3287d719dce184e57af825df5720be0c5db
Reviewed-on: https://chromium-review.googlesource.com/c/1320219Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606924}

This avoids depending on the name of the C struct. BoringSSL already
provides a header with forward declarations.

Change-Id: I0187f4c51c674746d5926b372ab48ea0e72eae4e
Reviewed-on: https://chromium-review.googlesource.com/c/1287044Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606923}

This reverts commit bb253c29.

This is a reland of the original breaking commit,
d0392055, with a fix for the build
failure.

Bug: 898718
Change-Id: I0e14e97861d060bb6378dc6ad43ca52806812f1e
Reviewed-on: https://chromium-review.googlesource.com/c/1328232
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606922}

Previously PaintChunk::hit_test_data was updated only in
HitTestData::RecordHitTestRect(), so when we copied cached subsequence,
the PaintChunks didn't have hit_test_data.

Now add HitTestDisplayItem to store the hit test data in display items,
and update PaintChunk::hit_test_data in PaintArtifact constructor.

Change-Id: I8a96823f15c0107fc21e5b388763ebfc3925eef0
Reviewed-on: https://chromium-review.googlesource.com/c/1325570
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606921}

Remove the Most Visited 'loaded' event listener after the 'loaded'
message is sent. This was interfering with other domAutomationController
listeners in subsequent script executions.

Bug: 903265
Change-Id: Iccd33d3eb04330a23880735b48a00d2f97a50866
Reviewed-on: https://chromium-review.googlesource.com/c/1327425
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606920}

Some assembler directives are OS specific, like .type and .hidden only
make sense in ELF. They are not valid for Windows ARM64 even with the
same assembler syntax. This change defines macro to select directives
according to target OS. This looks like a convention for assebmly
source code.


Bug: 893460
Change-Id: I7b5a8dc1648987932f11422d3b393513b6b69fbe
Reviewed-on: https://chromium-review.googlesource.com/c/1327884Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#606919}

Just simple refactoring.

Bug: 792774
Change-Id: I90e97fb8fd4e1ab5bb91f03b19ec8031eeb24375
Reviewed-on: https://chromium-review.googlesource.com/c/1326145Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#606918}

Bug: 902286, 843903
Change-Id: I2f4a836bfb448e092a7301a326c0caed722d607e
Reviewed-on: https://chromium-review.googlesource.com/c/1329175Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606917}

Adds is_chromeos checks to the build files for the add-smb-share-dialog

Bug: chromium:887135
Change-Id: I7ba729324c9e523f82924927f6eab86be8e4247f
Reviewed-on: https://chromium-review.googlesource.com/c/1323806Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606916}

Bug: 901331
Change-Id: I597c20c8726c0d25c37de04c1001502e535bf6f5
Reviewed-on: https://chromium-review.googlesource.com/c/1318831Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606915}

Missed changing these two perf tests while making this change:
https://chromium-review.googlesource.com/c/chromium/src/+/1318390

Bug: 903445
Change-Id: I8d151bfc464aae4cc1d0bd8fa993607cde25d18d
Reviewed-on: https://chromium-review.googlesource.com/c/1327524Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606914}

Report when the presentation-timestamp reporter by the driver is earlier
than the swap-time. Report this metric on all platforms. Change the
metric for reporting presentation-timestamps from the future to be
reported on all platforms (instead of just android).

This also removes DumpWithoutCrashing() for the future-timestamps.

BUG=894440

Change-Id: I663fdeab41b3f7de3e76f0e0ae440efbdae79bd8
Reviewed-on: https://chromium-review.googlesource.com/c/1325417
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606913}

Together with CRX_INSTALL_ERROR_* reason, the details of the failure
are reported in a separate
"Extensions.ForceInstalledFailureCrxInstallError" histogram.

Bug: 787970
Change-Id: Icd76bf2f1b15f219aa99f37385e77a63eb3573f2
Reviewed-on: https://chromium-review.googlesource.com/c/1323652Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606912}

Since the InfobarView is no longer communicating its size to Infobar.cc
there's no need to have the machinery necessary so Infobar.cc communicates
with our InfobarContainerView.

The InfobarContainerView will be updated via the VC viewDidLayoutSubviews
which was the change made on https://crrev.com/c/1321849/

Adds an extra test case.

Bug: 892376
Change-Id: I5457c17a8e1e586b02b5ca9906abd4341e5a56d4
Reviewed-on: https://chromium-review.googlesource.com/c/1325034Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606911}

Ash has a transitive dependency on the device fingerprint service, so
the test-only ash_shell_with_content won't start up without
declaring that requirement.

Bug: none
Test: run ash_shell_with_content, it starts
Change-Id: Id8acd41c154738a9470b8b19f63da93fede1740f
Reviewed-on: https://chromium-review.googlesource.com/c/1329623Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606910}