- 17 Dec, 2020 40 commits
-
-
Frédéric Wang authored
This CL adds tests for the following functions: SecurityOrigin::IsSecure network::IsUrlPotentiallyTrustworthy network::IsOriginPotentiallyTrustworthy They cover various cases of [1] as well as existing support in Blink. There is no behavior change, the expectations are just set to make the tests pass with the current implementations. This will make easier to compare and unify them. [1] https://w3c.github.io/webappsec-secure-contexts/#is-url-trustworthy Bug: 1153336 Change-Id: I40b6b8aaabd8ae7d0f97ceaa5ab4462eebfff585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593629Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#837984}
-
Fredrik Söderqvist authored
LayoutSVGPath is now the only user of this function. Currently the set of elements that should have markers applied equals the set of elements that create/use LayoutSVGPath, so just DCHECK() this in the constructor (as future-proofing) and drop the actual check. Change-Id: Icb3b8aab1dd1b569e16bb14dfade43232d442ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595378Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#837983}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ee505470..448c4502 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id350bd525b45593caacd53624403649e04d8c19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596832Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837982}
-
Jin Young Hur authored
The info would be useful for debugging. For example, print format is like below. password: 2051817934, type=password, renderer_id = 207, SERVER_PREDICTION: ACCOUNT_CREATION_PASSWORD, PASSWORD_REQUIREMENTS: {priority: 10, symbols: {character_set: "!@*^#.~?$-_+&%/)`(", min: 1, max: 4294967295, }, } Bug: 1068549 Change-Id: I1a791201962e36658160555d2aadf83f03b8c598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586297Reviewed-by:Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#837981}
-
Kinuko Yasuda authored
Looks like following tests are still frequently failing on Win 7 fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl.html fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl.html fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar.html fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar.html fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew.html fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl.html https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 Bug: 1043488 Change-Id: I8d4c645528ee72ec2c5e031437838ac8358e5650 Tbr: masonfreed@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596905Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#837980}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e35dcb0515eb..7ee7c8ce1be5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kinuko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kinuko@google.com Change-Id: I88a057db30c1e50a851e3584b28b7bec03ef8b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596505Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837979}
-
Camillo Bruni authored
Instead of mutating the const ref, we copy the params object in JSModuleScript::Create when clearing the source text. Introduce ModuleScriptFetcher::NotifyFetchFinishedError and ModuleScriptFetcher::NotifyFetchFinishedSuccess to make it clearer which arguments are used. Bug: 1154943 Change-Id: I4ed2ca75e56c8cbefb8d49c11e77d1846ce43f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571877 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#837978}
-
Alice Wang authored
This CL moves SigninHelper to signin.services target. Bug: 1158799 Change-Id: I53e5efda1d18b3233de01d11fde3e67d479fea2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595408Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837977}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/20f1b3462878..b64da3907f76 2020-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6bcd4aceef10 to b31cd871ad10 (17 revisions) 2020-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from cdbef3e3 to 09282fd5 (484 revisions) 2020-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 328f72ae21cb to 909ea88b5e6d (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: I15e385015c89ee59a580ee7de8d40954b5a14401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597096Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837976}
-
Anastasiia N authored
Bug: 1158450 Change-Id: I6531f36a6e9fe8eb4b0aa29211d1ecf9f6a0f481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593089Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#837975}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608163120-6c9e93d828b8e2586093ed8c8e6e7f26f6a53c36.profdata to chrome-mac-master-1608184288-cb58ee992bc6f0c310a42c0975312525970a8ab7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6ab68b458b34dac24aee0f6cb2b0ae5bfa91fb17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596748Reviewed-by:
-
Nazerke authored
This CL changes the width of the tabs in the tabstrip according to the number of visible tabs. Bug: 1154121,1128249 Change-Id: Ia06af6ac7971fa413d00b7cf7e1e54aa4966126b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580071Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#837973}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608163120-124e90d18fac2bedecb2b27b978f1959d49c27fb.profdata to chrome-linux-master-1608184288-1281f0d86ddb8ecec434b137fd8cebeb5fab6875.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id39421cfe7b2774961de046cb760d957e5899da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596749Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1608141458-c308516ff1ef658b0966cc17b391babeaf39cbb5.profdata to chrome-win32-master-1608163120-4986bcffa849ffffd428f29082c0e0792a369cda.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4d063b0f89cff65493c101f944bce959b20f3d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596006Reviewed-by:
-
dpapad authored
In this CL addressing Mocha test files that did not already use test_loader.html. - Serve test_loader.html/js from TestDataSource - Replace chrome://test?module= URLs with chrome://test/test_loader.html?module= URLs - Stop using |extraLibraries| for mocha.js and mocha_adapter.js from affected tests. Note: chrome://test?module= URLs are still used by a few none Mocha tests and can't be removed from TestDataSource. Bug: 1158471 Change-Id: Ic49ea31a875ae066ea0d3981724db45e3ba697ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593233Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#837970}
-
Juan Mojica authored
Also adds feature flags for lens prewarming. Bug: 1098431 Change-Id: Iae61ec71d6ab2f7d40f1231823cddc8b00ceabb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500525 Commit-Queue: Juan Mojica <juanmojica@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ben Goldberger <benwgold@google.com> Cr-Commit-Position: refs/heads/master@{#837969}
-
Joel Hockey authored
Rearranged ProfileManager::GetPrimaryUserProfile() to be able to run in unit tests. The early check of g_browser_process->profile_manager() is not relevant for IS_CHROMEOS_ASH with a logged in user and it causes unit tests to fail unnecessarily. This has resulted in a few places where the code is duplicated which can now be removed and use ProfileManager::GetPrimaryUserProfile(). Change-Id: I164b5c20dbc54cbd59c22bf7f84b5376af1b88c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596903 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#837968}
-
Yuta Hijikata authored
The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Unlike other patches with similar changes, //build changes are done manually following similar rules outlined in http://go/lacros-macros. Bug: 1052397 Cq-Depend: chromium:2581632 Change-Id: Ieda2c12eafa2e3f1a75ca024ecda60362fb2515e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581183Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#837967}
-
Mirko Bonadei authored
In https://webrtc-review.googlesource.com/c/src/+/196903, WebRTC is refactoring //rtc_base:rtc_base and rtc::AsyncResolver will be moved to a new header. The new header has been introduced by https://webrtc-review.googlesource.com/c/src/+/197941. Bug: webrtc:9987 Change-Id: I7de84e369ba5cded63b536f3b086b797a434db7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593640Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#837966}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/85d4952bb4fa..9eeb00431109 2020-12-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4d8e37158f1815cfaa0c0e146abe180177f48a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597097Reviewed-by:
-
WangHui authored
No logic changed. Bug:1095227 Change-Id: I891d6f9ddc61d83c25796d9674e7f8038103f190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592278 Commit-Queue: HuiWang <wanghui210@huawei.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#837964}
-
Sammie Quon authored
Was also causing some UI issues (but not crashing) on devices. Bug: 1159068 Test: manual, ash_unittests DeskAcceleratorsTest.HitAcceleratorWhenAlreadyAtEdge Change-Id: I728dd7d5fab32ef7aca8e729d1611474f6f9d875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596058Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#837963}
-
Jérémie Boulic authored
Bug: 1133186 Change-Id: Ibfc7b5d351178726292bbc9fac95ae82d0f3c264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595559 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#837962}
-
Victor Hugo Vianna Silva authored
This CL brings the java version of ProfileSyncService closer to the native one by merging the requestStart() and requestStop() methods into a single setSyncRequested() one. No behavior is changed. Bug: 985290 Change-Id: I56700c65ec5ee9152eee4bc21603802fc0ef7962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592806 Auto-Submit: Victor Vianna <victorvianna@google.com> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#837961}
-
Shannon Chen authored
Add padding to point scan layer so that both lines in range scanning have same line width. Adjust scanning speed so that range scanning has faster speed than line scanning. Signed-off-by:
Shannon Chen <shannc@chromium.org> Bug: 1061537 Change-Id: I90d8623bcdac226488804682ede16447f18270a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596021 Commit-Queue: Shannon Chen <shannc@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#837960}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30400dc10e22..e35dcb0515eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kinuko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1131051 Tbr: kinuko@google.com Change-Id: Iad0c691c53cf7e0ce52e6fbe4642810e1eed179d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595674Reviewed-by:
-
Dominic Farolino authored
This CL introduces: - AgentSchedulingGroupHostFactory - MockAgentSchedulingGroupHostFactory - MockAgentSchedulingGroupHost ... and uses them in the appropriate browser unit tests. For a detailed description of the problem and solution see: https://docs.google.com/document/d/1ZUNxjEr-TlVaDhJDk7mPtkBF_fK8OWcNQ0eJORSfiUU/edit#heading=h.csweqm2d9mc Bug: 1158656 Change-Id: I1636cdb47d93a4883aae60d1ffbf0315c4ca8fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594317 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Wei Lee authored
Bug: b/174728995 Test: Manually Change-Id: I7a572bce165c661dadf22d808840e71a54225a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592571 Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#837957}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0b561ca8. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I959f1d2b11396159d813317674b7cd5923c3aaea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596360Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837956}
-
Shik Chen authored
Bug: b/172879638 Test: Manually Change-Id: Ife8f50a1ec7040c75eab504d770c0a6ba6a0e2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596758Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#837955}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I6ee37b134823b45cfec71249c75acdaeee4bffce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596422Reviewed-by:
-
David authored
This change makes image annotation default true. Image annotation uses the ink library which is now built with the CrOS Media App see http://cl/347557653 & crrev/c/2542926. Since this updated version of ink is now in the CrOS binary, we can flip this flag to default true! Also adds an integration test to ensure ink loads in our guest frame. The integration test is only built & run in `linux-chromeos-chrome` since it tries to load ink which will fail in `linux-chromeos-rel` as that doesn't pull in our CIPD package. Bug: b/170161460, 1150244, 1139469 Change-Id: I1460ed2e7fb682ed54a4ee3b210f425b233a6150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594615 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Reviewed-by:
David Lei <dlei@google.com> Auto-Submit: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#837953}
-
Jason Lin authored
Bug: b/167491603 Change-Id: I43f80edb10684efb9fcb864a2c0a0c723ce9a241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595560Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#837952}
-
Luciano Pacheco authored
Files: - //u/f/f/b/j/drive_sync_handler_unittest.m.js - //u/f/f/b/j/drive_sync_handler.js Bug: 1133186 Change-Id: I463c68a02bb942415b8d66161855d74bbc0b0c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595556 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837951}
-
Jérémie Boulic authored
JS Modules for the following files in ui/file_manger/video_player/js: - background.js - error_util.js - test_util.js Add the main_background.m.js to act as the entry point for the background page. Bug: 1133186 Change-Id: I0c1a205047c85f70e4629d5a3f52ddfcfcbedd7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596467 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6bf9e131d05a..0da7da798b33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If255f68a34c2929747ad18a1aa6cceb1df963307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596134Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Creates a WebUIConfig and WebUIController for the Sample System Web App's untrusted context. Bug: 1080384 Change-Id: I516339dd8b2412f377b460817d16fdb51146aefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592075 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#837948}
-
WangHui authored
When the download request is intercepted by the webview, we will delete the ResourceDownloader and stream as soon as possible. But the stream is deleted in the Download task runner and the ResourceDownloader is deleted in the IO task runner, there will be a race that the error caused by destroying the stream send to webview before the ResourceDownloader is destroyed. Bug:1048335 Change-Id: Iae2a62688debee6adaa7161209dd33d6ac3b32f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592280 Commit-Queue: HuiWang <wanghui210@huawei.com> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#837947}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7839f66540b6..20f1b3462878 2020-12-17 bsalomon@google.com Use ManagedBackendTexture in backend allocation tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: If171661344e8f11fafc9571d4aaeda146cef7e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596392Reviewed-by:
-
James Vecore authored
This is a clone of this CL: https://crrev.com/c/2594273 with fixes for browser tests that were failing. PS1: original CL PS2: changes to get browser tests running There were a duplicate string resource id being used and some issues with not waiting for the page to re-render fully. Original Message: This change adds support for Transfer in Progress and No Connection Medium available. Screenshots: https://screenshot.googleplex.com/7HUWhCacjyWanCP.png https://screenshot.googleplex.com/9vpAjoNMJnkw32n.png Bug: 1156391 Change-Id: If4d0ff802e398567bd06500688713d31a098bb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596819 Auto-Submit: James Vecore <vecore@google.com> Commit-Queue: James Vecore <vecore@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#837945}
-
