- 26 Aug, 2020 40 commits
-
-
Antonio Gomes authored
... instead of base::EndsWith(). BUG=787254 R=guidou@chromium.org Change-Id: Ia14a71fc3d04918cbc8d65738ad7bca3b0cb6dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363553 Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#801765}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1303230f0260..b77998026e82 2020-08-26 alexrudenko@chromium.org Simplify the grid tooling settings 2020-08-26 tvanderlippe@chromium.org Typecheck bindings/BlackboxManager.js with TypeScript 2020-08-26 szuend@chromium.org [ts] Type-check ui/ListControl.js with TypeScript 2020-08-26 szuend@chromium.org [ts] Type-check ui/ListWidget.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1109177 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I899bfa5e974729b0c75fcb3d246e5027a8c21361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377856Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801764}
-
Jeremy Roman authored
This reverts commit 6a1fac8e. Reason for revert: <INSERT REASONING HERE> Original change's description: > Mostly remove refcount thrashes of value in setAttribute. > > Relanding https://chromium-review.googlesource.com/c/chromium/src/+/2351950 > > This mostly removes the refcount thrashes in Element::setAttribute() > which accounts for nearly 13% of regression in blink_perf.bindings > set-attribute.html story when StringImpl is made threadsafe. > > Because of some reentrant behavior in Element::setAttribute() -> > Element::SetAttributeInternal() -> Element::DidModifyAttribute() -> > Element::AttributeChanged() -> Element::ParseAttribute() -> > Element::setAttribute(), the qname for the Attribute, the old value, > and the new value cannot be easily transfered into the Element's internal > ElementData::Attributes() collection while also publishing the change to > observers via the DidModifyAttribute() call. Removal of that thrash will > be done in a follow-up CL. > > Bug: 1083392 > Change-Id: I7f7f4bfa22a2e553e703c0375bd04bb77f71de23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369348 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Commit-Queue: Albert J. Wong <ajwong@chromium.org> > Auto-Submit: Albert J. Wong <ajwong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801214} TBR=ajwong@chromium.org,jbroman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1083392,1121429 Change-Id: Ia42214b62e1efc218afb055fcc60bea52039587c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376705Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#801763}
-
Amr Aboelkher authored
This reverts commit 154433da. Reason for revert: linux-trusty-rel build and external blink web_driver tests are failing, and that's a possible root cause. See: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/15138 Original change's description: > [Perfect Negotiation] Re-enable temporarily disabled WPTs. > > Now that https://webrtc-review.googlesource.com/c/src/+/180620 has > rolled into chromium, we can re-enable the disabled tests and update > the expectations that more tests are passing. > > Follow-up CLs will make us pass even more tests. > > Bug: chromium:1060083 > Change-Id: Ia1e1432746293fa395e5bda72e163f223f316b7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377707 > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801716} TBR=hta@chromium.org,hbos@chromium.org Change-Id: I3250545b0fff846a8c4c3a9352f5a342ae613599 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1060083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377872Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#801762}
-
Fergus Dall authored
Bug: None Change-Id: Ifbda9222895575bb2471036df15c4778fe7b89bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374935 Auto-Submit: Fergus Dall <sidereal@google.com> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#801761}
-
Alice Wang authored
This CL renames AccountPickerBottomSheetState as ViewState to make the code more readable. There is no behavior change in this CL. Bug: 1121499 Change-Id: Idaa9d72238e6012fe6f71dec7928ed41760d8582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375291Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801760}
-
Weilun Shi authored
The split histogram_suffies_list.xml under histograms_xml/ should also be pretty-printed. Bug: 1121852 Change-Id: Icbdc0891c214be95b51a94c0a8520b2eb2e6aaa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376885 Auto-Submit: Weilun Shi <sweilun@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#801759}
-
Alice Wang authored
This CL cleans up AccountPickerBottomSheetTest. Bug: 1121536 Change-Id: I00d8e5506bf38411bfd16a664c1667ebbd074379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374867Reviewed-by:
-
Elly Fong-Jones authored
These importer tests rely on loading some dylibs out of //chrome/test/data/firefox3_nss_mac, which aren't yet (and may never) be available for arm64. Bug: 1121685 Change-Id: Ifb316784e3ffd851d3b507baa630f746695bdb29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375895Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#801757}
-
arthursonzogni authored
Without this, Canary users won't see the chrome://flags Bug: 1059303 Change-Id: I30874282ac3be605198b8e44d2e831e05289d502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377490 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#801756}
-
Martynas Sinkievic authored
This CL adds support for removing affixes from the |parseable_name| attribute stored in a |FormStructure|. The current version only removes common prefixes longer than 16 chars. The new implementation also removes both common prefixes and suffixes at least as long as |kMinCommonNameAffixLength| chars (currently set to 3). Change-Id: I53c34ca169ba669df289392b2942dfe116705056 Bug: 1121990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332193 Commit-Queue: Martynas Sinkievič <marsin@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#801755}
-
Yi Gu authored
TBR=dcheng@chromium.org Bug: None Change-Id: Id34814442f8b763782eb70657de33b57a7e03617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375799 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#801754}
-
Michael Chang authored
Control Service was never terminating due to lacking the App Server's TaskStarted and TaskCompleted methods. Change-Id: I16da30af01fbf9a04ec3996dd893548fd3699f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377147 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
Ioana Pandele authored
This status only gets sent when the UI and bridge are being torn down while a check is running. At this point, no UI update is needed. Bug: 1121145 Change-Id: I0a413da4432d346a07f7252263c2626ae93aadac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377865Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#801752}
-
Owen Min authored
EnableOriginBoundCerts EnableMemoryInfo ExtensionInstallListsMergeEnabled are all policies that have never launched and they will be deleted. VariationsRestrictParameter and DeviceVariationsRestrictParameter are internal policies and will be hidden with the new feature flag BYPASS_POLICY_COMPATIBILITY_CHECK=[Device]VariationsRestrictParameter are two policies launched years before and we only change the way of hidding the policies. Bypass the check so that we are not foced to use the current milestone. Bug: 1117637 Change-Id: I9d2cf9d77accc2e3f26d54bd5632347e285cdff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376528Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801751}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ead4ca052b99..5da7327358e3 2020-08-26 rmistry@google.com Use GCLIENT_PY3=0 in recreate_skps.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ie4d0202ee849c7ccd2aced134e1d5c334f368087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377855Reviewed-by:
-
Brian Osman authored
The color filters used for exotic color space conversion in skia_renderer are built on SkRuntimeEffect. The required signature for main() in the SkSL has changed, this just adapts to the new signature and semantics. Bug: skia:10613 Change-Id: I031cbd597810ec9629b3308db4548c5842b0b5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375932Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#801749}
-
Friedrich Horschig authored
The dialog now contains banners which should not extend to the borders of the dialog since they don't user a lot of whitespace. Instead, they should use the same padding that is used for texts, too. The change applies to all users of the dialog but depends on the password check feature being enabled. Once the check is launched (which seems the most-likely scenario), we can inline the layout params into the layout file. Mocks and screenshots in the linked bug. Bug: 1121959, 1092444 Change-Id: Ifef5352c08a159e4e6bc01e024e42fe9e82f7960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377728Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#801748}
-
ssid authored
The version number is not sufficient to differentiate between 32 or 64 bit binaries for symbolization, so include the module debug id in trace for correct symbolization. Change-Id: I3411821b55b9ce2c73ea616bf791866542aebe0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373235Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#801747}
-
Clemens Arbesser authored
See linked bug for details. Bug: b/166406201 Change-Id: Ie66c1a19d0f657ba25c1737211974603e5cdf08d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376849 Auto-Submit: Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#801746}
-
Noel Gordon authored
Comment only change. Use "metadata Worker" everywhere, fix grammatical errors, createError_ is not just used by the Worker, add minor TODO. Bug: 1114622 Change-Id: I009879b0763c7d33114acfcf1353b713e9924c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377331 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#801745}
-
Morten Stenshorne authored
This flakiness is probably not limited to the virtual/layout_ng_block_frag/ version of the test, but the test seems too valuable to mark as flaky in general. TBR=rakina@chromium.org Bug: 1121965 Change-Id: If6c6df6ecc99325a80115b172000f681894586ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377927Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#801744}
-
nancylingwang authored
|icon_scale_| is used to decode the compress icon file, and when encode the uncompressed icon, |icon_scale_for_compressed_response_| is used for the scale. |icon_scale_for_compressed_response_| is set for web apps in the function IconLoadingPipeline::LoadWebAppIcon, but not set for Crostini icon load function LoadIconFromCompressedData, so modify LoadIconFromCompressedData to set |icon_scale_for_compressed_response_|, the same as the web apps implementation. BUG=1115831 Change-Id: I6add4f481d7c0390895352b8cdad4441c2820d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377168Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801743}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/99b0f8d26cbe..c093d9ad623d 2020-08-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d4203a22..09ff1141 (801568:801677) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I79979ccece7daa9cb09370c183c2c4432b326fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377852Reviewed-by:
-
chrome://flagsJonathan Mengedoht authored
Bug: 927473 Change-Id: I3023effa43f57cf5a106e11667028818f4b25df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375293Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Cr-Commit-Position: refs/heads/master@{#801741}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/346ebfc47a54..95c5b87ad1a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC amraboelkher@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1090105 Tbr: amraboelkher@google.com Change-Id: I2010a5a2ffa90cc6f710275a67d6375ad5526041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377523Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Yi Gu authored
UKM recording is not supported on WebView. i.e. the ukm recorder and source id are both invalid [1]. [1] https://source.chromium.org/chromium/chromium/src/+/master:android_webview/browser/aw_autofill_client.cc;l=93 Bug: 1121722 Change-Id: I3e1d1a5a478f94562a5efa1da016a691ae57f12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376465Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801739}
-
Danyao Wang authored
Both canMakePayment() and hasEnrolledInstrument() are expected to return true if a device supports Secure Payment Confirmation: i.e. has a compatible authenticator, regardless of the presence of payment credentials. These new tests verify these behaviors. Also fixed a crash that happens when PaymentRequest is destroyed after the associated RenderFrameHost. This is new to Secure Payment Confirmation because PaymentRequest now holds an InternalAuthenticator, which must be out-lived by the RenderFrameHost. This patch fixes the bug by observing WebContentsObserver::RenderFrameDeleted() and perform the necessary clean up before the RenderFrameHost is actually destroyed. This crash was detected by the new tests, which triggers PaymentRequest destructor during browser shutdown. Bug: 1121168 Change-Id: I1e7ab94c3c6fac23ef5e3104beccc1ab1da2f3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375887 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#801738}
-
Yuki Shiino authored
https://crrev.com/c/2300380 is failing to build on android_cronet bot due to a conflict in GN settings between use_allocator=="partition" and use_partition_alloc=false. Ideally, we shouldn't have two flags and we'd better to remove use_partition_alloc in future. This patch mitigates the issue by prioritizing use_allocator over use_partition_alloc. Bug: 998048 Change-Id: I293a884186dfa9804930b835ba236efb818a761d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368797Reviewed-by:
-
Nela Kaczmarek authored
This change renames MockAffiliationService to MockAndroidAffiliationService due to change 2339661. Bug: 1108279 Change-Id: I26bb0a1a265e595b1a7640efb3cdd1faa8b9467b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372394 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#801736}
-
Jan Krcal authored
This CL expands the Profile.AddNewUser histogram with additional enum entries: one for the sign-in interception and one for (long-existing) profile creation from the sync confirmation flow. Bug: 1076880, 1121944 Change-Id: Ibe8a2e00b26dd12d2db4fa46309588e1cda994c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362852Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#801735}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c21b8329. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org: external/wpt/css/css-cascade NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I1a13539eede33cfc0ecb838dd86dbcd04e84481d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377457Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801734}
-
Michele Mancina authored
Bug: b/159308598 Change-Id: Ic067a1a60cb5a202daa5f21d9f909d9b5f3b1486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375427 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#801733}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3c2454b82c05..bc993b2771f9 2020-08-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 12df3cafeee0 to 2205254cfb50 (4 revisions) 2020-08-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from e798df982b1b to 7a71abb602a2 (7 revisions) 2020-08-26 jmadill@chromium.org Vulkan: Fix optimizeRenderPassForPresent regression. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I63edfacf2098ecb116044d5250cb987a38a209a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377522Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c3e3c30b0d7f..4f8bdaf473fb 2020-08-26 cwallez@chromium.org Make ShaderModuleBase use an internal EntryPointMetadata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I6411e9127489bb146609d0cdd8a854dfd24d4eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377847Reviewed-by:
-
Patrick Brosset authored
The DevTools grid overlay was recently modified to support RTL direction. The fix included the required changes for lines and gaps to be drawn correctly (see https://chromium-review.googlesource.com/c/chromium/src/+/2213530). However it did not include changes for the labels to appear in the right places (line numbers, line names, area names, track sizes). This is what this change is about. In it, I also updated the web test for RTL grids as the expected label positions were now wrong. Bug: 1096971 Change-Id: Ib4ed28462ab3bd5ad746d955da4d56db5f95dcfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375687 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#801730}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e7d4ae57bbbb..1303230f0260 2020-08-26 sigurds@chromium.org [ts] Type-check sdk/OverlayModel.js with TypeScript 2020-08-26 petermarshall@chromium.org components: Remove old PieChart If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iadbcb97822741199e9e19cc75c948d600700e3d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377846Reviewed-by:
-
Mohamed Amir Yosef authored
This is a reland of d705fd61 Original change's description: > [Passwords] Remove passwords from the correct store in ... > > ... CompromisedCredentialsManager() > > Bug: 1108422 > Change-Id: I66ea95309a1c3242fe8e32591ae986d68dbe5ee2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372429 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801348} Bug: 1108422 Change-Id: I27710fb2db2356ac5cce088ea1a27e67ac13d58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375466Reviewed-by:
-
Benoit Lize authored
Bug: 1072567 Change-Id: I0a1930a42275e8fbd9e9460a152e4b8297c8b713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351972Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/12df3cafeee0..9e26ae045526 2020-08-26 afdx@google.com spirv-fuzz: Overflow ids (#3734) 2020-08-26 greg@lunarg.com Fix DebugNoScope to not output InlinedAt operand. (#3748) 2020-08-25 vasniktel@gmail.com spirv-fuzz: Split the fact manager into multiple files (#3699) 2020-08-25 andreperezmaselco.developer@gmail.com spirv-fuzz: Add inline function transformation (#3517) 2020-08-25 vasniktel@gmail.com spirv-fuzz: Fix MaybeGetZeroConstant (#3740) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I75bbe77145ce986b6b52e50d4a29ba501ff01cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377515Reviewed-by:
-
