- 28 Oct, 2019 40 commits
-
-
Evan Stade authored
Bug: 268984 Change-Id: Ied766d3006009fbd5534eca799bf095bf48dbc28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876083 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#709976}
-
Peter Kotwicz authored
This CL re-enables TrustedWebActivityTest#testStatusBarColorCertificateError() TrustedWebActivityTest#testToolbarVisibleCertificateError() - It modifies the tests to use different origins for "pages without a certificate error" and "pages with a certificate error". This is now necessary due to http://crrev.com/c/1872423 - Uses host-resolver-rules command line flag in order to use multiple origins in tests. The command line flag has the side effect of causing "redirected-urls" to throw a certificate error when navigated to - It also fixes a bug with the testStatusBarColorCertificateError() test on Lollipop BUG=1016743,1016746 Change-Id: I20bbfdd7828c243af991e62f9c7d9a173d326c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876872Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#709975}
-
Robert Liao authored
Upward ancestor traversal by class name is not a common pattern used in Views clients. BUG= Change-Id: If0aefc9084836526225441a4d8f15131b7c1f3fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881888 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#709974}
-
Clark DuVall authored
The PrefetchURLLoader's lifetime is managed using mojo::MakeStrongBinding, which means it may live until after the BrowserContext is destroyed. Instead of keeping the browser context around to check if signed exchange is allowed, we check in the constructor and cache the value. Bug: 1016373 Change-Id: Ia6722ed37a8213078be856b11b9dde70ef230e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881379 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#709973}
-
Steven Bingler authored
This changed modified the test fixture, CookieSettingsTest, to both add a feature-list and disable kSameSiteByDefaultCookies. This prevents tests from breaking when cookies become SameSite-by-Default. Bug: 1016512 Change-Id: I4a31ae48467f79883b58fa275478a5e5a58e61ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877253 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#709972}
-
Albert Chaulk authored
The embedder implementation assumes that channels are persistent and set up ahead of time, so now we track RenderFrameHosts for our WebContents and dispatch channel events to every frame Bug: b/141864193 Test: on device with weather Change-Id: I74182d226fae7d6d63b618aa92f60fadb9516d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881671Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#709971}
-
Simon Que authored
These entries were added in: https://chromium-review.googlesource.com/c/chromium/src/+/1875857 They were incorrectly labeled. Bug: 950413 Change-Id: I033401f51da5bb420b7af5a6590f51d649ca8180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884391 Auto-Submit: Simon Que <sque@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#709970}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::MhtmlFileWriter with replacing AssociatedBinding and MhtmlFileWriterAssociatedRequest with AssociatedReceiver and PendingAssociatedReceiver. Bug: 955171 Change-Id: I55f3209dcddbaa734e029ec34b881015bd5a2d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880207 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#709969}
-
Peter Kasting authored
Bug: 82078 Change-Id: Ie0f4f0c7a5a78eb8a5086721b6146c00401034ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879996 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#709968}
-
Sergio Villar Senin authored
In order to remove the WebContextMenuData dependency from chrome/browser we need to extract all the data types used in c/b from web_context_menu_data.h and move them to different files under third_party/blink/public/common. WebContextMenuData::EditFlags is moved to a different file under public/common so that chrome/browser does not depend on public/web. This is the last step of the web_context_menu_data.h dependency removal from chrome/browser so we're safe to remove it from DEPS file. Bug: 1014517 Change-Id: I32bc847b596de9558607700288b650bd557b9318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878252 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Manu Cornet authored
Also add a test. Bug: 1018363 Change-Id: I99b2a24b7cd292ac1ec3963d0ebdb343591a5a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881231 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#709966}
-
Andrew Xu authored
There is a loophole in scrollable shelf's code: if the incoming gesture event is not handled by neither scrollable shelf nor shelf view, the scroll status is not reset. Because resetting the scroll status relies on the gesture end event while the scrollable shelf view will not receive the gesture end event if it is not the correct event handler. This CL fixes such an issue. Bug: 1012888 Change-Id: I98927dd068b6dd75008936eb8bee9f5249091f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882560Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709965}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLStyleElement> and DynamicTo<HTMLStyleElement> as new downcast helper 2. Use IsA<HTMLStyleElement>(element) in place of IsHTMLStyleElement(element) Bug: 891908 Change-Id: I6c41fe0a6b0efd5f00580b154cb740e1070b513b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880997 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#709964}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d6f6ff7083d1..d039ea0c1799 git log d6f6ff7083d1..d039ea0c1799 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 khokhlov@google.com [tracing/ui] Truncate long thread names instead of showing ellipsis 2019-10-28 simonhatch@chromium.org Dashboard - Add a cron job to update sheriffs Created with: gclient setdep -r src/third_party/catapult@d039ea0c1799 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1014544,chromium:1006252 Change-Id: I6509bdf1aef35ed64adce52d1299ecbccc4b6a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883779Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709963}
-
Anastasia Helfinstein authored
The deps/externs for various files got out of sync with what was actually being used. This brings those back to sync. Bug: None Change-Id: I1c1bf99abf3825e4e2acca7945a482cf98021bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877147Reviewed-by:
Chris Hall <chrishall@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#709962}
-
Peter Kasting authored
Also shortens/cleans up some existing code (no functional change). Bug: 82078 Change-Id: I4d3ee878d6c4f6e301dcaaa19e5fc7877bb1b5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881696 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#709961}
-
Caroline Rising authored
Bug: 1013958 Change-Id: Ic653e7febf1161b23ed1ccc0e2f2b4fecc1f7817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880584 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#709960}
-
Changwan Ryu authored
When you click a node, it takes some time before the node can be focused. This was not properly considered and caused the flakiness. Test: tried 100+ times on Pixel 2 XL. 50% flakiness --> 0%. Bug: 990209 Change-Id: I6e209495931b51381c04230cd49ac080674206fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880371Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709959}
-
Juan Antonio Navarro Perez authored
Had written these, but forgot to upload before landing: https://chromium-review.googlesource.com/c/chromium/src/+/1879207 TBR=crouleau@chromium.org Bug: 1001038 Change-Id: I8794343b81129e18736277bad88c23088e3b18fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883722Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#709958}
-
Peter Wen authored
Since //components/sync/driver:resources has been broken out of //components/resources as a separate target and separate pak file, it needs to be added back into the iOS app bundle. This fixes the missing iOS dependencies from: https://crrev.com/c/1864564 Bug: 1016465 Change-Id: I0274f5575fd02e0e344fc48619dd05cfda37e51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883119Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709957}
-
Adam Ettenberger authored
AXPlatformNodeBase::UpdateComputedHypertext was using an expensive path to navigate unignored children. Replacing use of |ChildAtIndex| with |GetFirstChild| and |GetNextSibling| when iterating unignored children. Now instead of having to walk over all children up to the Nth unignored child for each iteration, it will find the first unignored child, then chain finding each unignored sibling. For the scenario I was measuring, this CL reduced the overall amount of time spent in AXTree::Unserialize by ~77%, and time spent in AXPlatformNodeBase::UpdateComputedHypertext by ~90%! I crafted a document where loading the document resulted in Unserialize having to process ~40k AXNodeData items in one AXTreeUpdate. I used "UI for ETW" to capture perf traces, and WPA to view the data. Before : * Weight in callstack of AXTree::Unserialize : 6424 * Weight in callstack of UpdateComputedHypertext : 5449 After : * Weight in callstack of AXTree::Unserialize : 1457 * Weight in callstack of UpdateComputedHypertext : 447 Bug: 1017829 Change-Id: I0edd29f4bba4811942a96c4f65fa96401dd10cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879767Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#709956}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5cb7807a3692..cff20c2615d8 git log 5cb7807a3692..cff20c2615d8 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 sprang@webrtc.org Adds protected bitrate helper methods to RtpRtcpImpl 2019-10-28 hbos@webrtc.org Reland "[PeerConnection] Use an OperationsChain in PeerConnection for async ops." 2019-10-28 brandtr@webrtc.org Add .clangd to .gitignore Created with: gclient setdep -r src/third_party/webrtc@cff20c2615d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ia38756d59f194fa460075ec01c534f6bb712f1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883780Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/225301d6dc53..0964988b77ab git log 225301d6dc53..0964988b77ab --date=short --no-merges --format='%ad %ae %s' 2019-10-28 jmadill@chromium.org Fixups to ANGLE_get_image boilerplate. Created with: gclient setdep -r src/third_party/angle@0964988b77ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: Id68127d55be33b570e48139be1ea903d987ff894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882813Reviewed-by:
-
Aidan Beggs authored
This CL ensures that all safety tip heuristics are always run, in lieu of the previous short-circuiting behavior, in preparation for recording metrics. This CL also refactors the reputation check results out into a wrapper struct, to cut down on the number of variables that need to be passed down the call chain. Finally, this CL fixes a few miscellaneous typos. Bug: 1014598 Change-Id: Ibeda24f817f46d8d36f23fab60f30615821e544f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881126 Commit-Queue: Aidan Beggs <beggs@google.com> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#709953}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/91527d03092e..3c3f17f3c2e1 Created with: gclient setdep -r src-internal@3c3f17f3c2e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ifb6c7cb14773711de118fed190f98c045b095cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882030Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709952}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/428b5de64a08..18f5b1a6dd77 git log 428b5de64a08..18f5b1a6dd77 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 rmistry@google.com [Android compile bots] Add comment to CL when both nopatch and withpatch builds fail Created with: gclient setdep -r src/third_party/skia@18f5b1a6dd77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: None Change-Id: Iac5e0d82476d9d05b74ae08ccf53905ef6d6c6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883776Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4517c7b883c5..ec12de913124 git log 4517c7b883c5..ec12de913124 --date=short --no-merges --format='%ad %ae %s' 2019-10-27 afdx@google.com spirv-fuzz: rename class, and fix bug related to dominance (#2990) 2019-10-25 afdx@google.com spirv-fuzz: Rework management of data synonyms (#2989) 2019-10-25 afdx@google.com spirv-fuzz: add class to represent equivalence relation (#2988) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@ec12de913124 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Bug: None Change-Id: Iaf5bf4af6f25f4a25653e81bd823e0a23a3fc00d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883062Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#709950}
-
Anastasiia Nikolaienko authored
After attaching device id for secondary account sign-ins (https://crrev.com/c/1859784), old tokens will be revoked automatically. Revocation of the old tokens for account sign-ins with device id attached would also result in revocation of the new tokens. Bug: 1012723 Change-Id: I282aa2117204138cf8d3e5d68c45aee96d6b9cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859783 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#709949}
-
Leonard Grey authored
Bug: 1018333 Change-Id: I0d185dfa8d39a3c07a9d275b64a4c2f00e4c2620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883873 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#709948}
-
Tommy Steimel authored
This CL fixes the separator line color on Mac by removing the transparency of the MediaNotificationListView. The 12% opacity lines against the transparent list view was part of the issue. The other part is crbug.com/1012024, and while this change makes the lines work properly on Mac, it does not fix crbug.com/1012024. This change also switches from using a hard-coded SkColor value for the line to using the MenuSeparatorColor from the NativeTheme. Bug: 1016717 Change-Id: I60e132e6019722e59bdc0247fc19eedd9ae3d8d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880570Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#709947}
-
ckitagawa authored
Adds a paint preview compositor service for compositing collections of SkPictures representing frames into bitmaps. This is very similar in principle to the PDF compositor service, but produces tileable bitmaps rather than a PDF. A client to this service should start the compositing collection portion of the service in a utility process. The client can then create and delete dedicated compositor instances for each group of SkPictures. Realistically only one compositor will be actively communicating at a time. However, multiple compositors can be "warm" (data is deserialized and in memory for fast switching). Bug: 1011430 Change-Id: I21cb594cd94982f8d4fc5800d9ae4d74b5d9973b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842273Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#709946}
-
Christoph Schwering authored
Bug: 1007974 Change-Id: Icc17b93647324cc347aae12cb4679461a2922077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883075 Auto-Submit: Christoph Schwering <schwering@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#709945}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ebba8d75bf65..27eb01c35517 git log ebba8d75bf65..27eb01c35517 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 ehmaldonado@chromium.org Revert "gerrit_util: Refactor ReadHttpResponse and add more tests." Created with: gclient setdep -r src/third_party/depot_tools@27eb01c35517 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1016601 Change-Id: I728ab7d58a999296f3135e1223b66eee5783ecd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883777Reviewed-by:
-
Darin Fisher authored
This involved adding a mojom type corresponding to ContentSettingsType. I went with just using '[Native]' after exploring a variety of ways of moving the definition of this enum to mojom. There's a lot of dependencies on the existing c++ header, including an auto-generated java definition. This step seems best left for another CL. My solution is to move the param_traits for this type from //chrome/common to //components/content_settings. As part of this CL, I discovered that we do not use the 'details' parameter sent by the renderer via ChromeViewHostMsg_ContentBlocked, so I removed all of the plumbing for that parameter. Change-Id: I0fc42ca9bfb9ec07805aa728ab929506154134cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879791Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709943}
-
Christos Froussios authored
These histograms will be removed. They were introduced to monitor the deprecation of the linux native backends, which is now complete. - PasswordManager.StorePerformance.* This histogram will be maintained, since it monitors health issues. Some of these issues could be ongoing. - PasswordManager.StoreDecryptionResult Bug: 1006986 Change-Id: I21dacd9860ef4a6205fa7f75f0a4ae6e7fb77b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872104 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Auto-Submit: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Tricia Crichton authored
Activate the SetLocation command in w3c mode. This is not part of the webdriver spec, but this is a valuable function for testing. Bug: chromedriver:3180 Change-Id: If379b56891f5326b7a6bdf51ec6044d192d485c5 Fixed: 3180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881479Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#709941}
-
Etienne Pierre-Doray authored
This CL removes usage of LzmaFileAllocator and tries to write unpack result directly in the output file. When uncompressing a folder that maps directly to a file, this is possible and a memory mapping is used. In practice, this is always the case. Support for folder containing multiple files is kept as fallback and uses a pre-allocated file buffer, which is then copied in individual files. For running full setup install from chrome.packed.7z (Kb) Before: Setup.Install.PeakPagefileUsage 19748 Setup.Install.PeakWorkingSetSize 250528 GetCumulativeDiskUsageInBytes 761134 After: Setup.Install.PeakPagefileUsage 19720 Setup.Install.PeakWorkingSetSize 250512 GetCumulativeDiskUsageInBytes 297818 The difference in memory is not significant, but improvement are expected mostly for disk usage. Bug: 933975 Change-Id: I26c1b118fc512d2caaa8112d3da37e6db460486b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845956 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#709940}
-
Javier Ernesto Flores Robles authored
Remove deprecate test that would require new code to be migrated. Update and enable keyboard disappear test. Create app interface to interact with a shared instance of the observer in the app. Remove OCMock usage in the test. TBR=eugenebut@chromium.org Change-Id: Iaa5384f241e63b95ee516d4666b2e2adf65b7da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881566 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709939}
-
Tommy Steimel authored
This reverts commit 15cb261d. Reason for revert: causing compile error on linux-archive-rel: https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/12634 Original change's description: > media: Add ENABLE_CDM_PROXY BUILDFLAG > > CdmProxy is still under development and will not be enabled on all > platforms. Hence, this CL adds a new buildflag so it's not enabled by > default. > > Tbr: nasko@chromium.org > Bug: 785563 > Change-Id: Id1a1b65032e15f4d31a7755b01912deac0b3766d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869561 > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709933} TBR=nasko@chromium.org,xhwang@chromium.org,jrummell@chromium.org Change-Id: I09d36127e7b47a390ce19a7ef28e63c2fe9c27e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 785563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881637Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#709938}
-
Dave Tapuska authored
CheckCompleted moves to mojo. There already is an implementation on LocalFrame so this uses that same signature for implementation. BUG=1008432 Change-Id: I23381f935f06290cebf0181bc6c6af462323ab28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877130 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
