- 13 Aug, 2019 40 commits
-
-
Eric Stevenson authored
This CL moves the generated registration methods to an anonymous namespace so that targets can have multiple generate_jni_registration() dependencies that use @NativeMethods. Currently this would cause a link time error due to duplicate symbols being defined. Bug: 929661 Change-Id: I240b8848bd37adfc02de6d70f40f81c2a2f057aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749481Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#686389}
-
Mario Sanchez Prada authored
Adapted the original CL to the change done in the precursor CL to rename the new blink::mojom::SurroundingText Mojo interface into blink::mojom::Frame instead. Original change's description: > Now that we have blink::SurroundingText inside Blink and implemented > using internal Blink types like WTF::String and LocalFrame, we can > finally migrate blink::SurroundingTextImpl away from WebLocalFrame > and remove the DEPS exception rule we previously introduced during > this process of Onion Soup'ing the SurroundingText API. > > Additionally, we move the instantiation of blink::SurroundingTextImpl > from WebLocalFrame to LocalFrame as well and, with that, we remove any > reference to public Blink classes from SurroundingText-related code. > > Bug: 980151 > Change-Id: I1a1014dbf6671b9327a068ceca4f62d873cb5fb3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698413 > Commit-Queue: Mario Sanchez Prada <mario@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680346} Bug: 980151 Change-Id: Ifbec56f9391ff5b450ebeb6532d5089a53f94350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738454 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#686388}
-
Julian Pastarmov authored
Per discussion on the bug this policy should not be visible in the documentation yet. BUG=991307 Change-Id: I9528effd46d9dddb25b21ecf5df4601a88292a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751327 Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#686387}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f0fc887f5682..827c26f6435e git log f0fc887f5682..827c26f6435e --date=short --no-merges --format='%ad %ae %s' 2019-08-13 carmenjackson@google.com Add the suspend_resume trace event to Perfetto ftrace config 2019-08-12 treehugger-gerrit@google.com Merge "processor: Ignore misordered slice events." Created with: gclient setdep -r src/third_party/perfetto@827c26f6435e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: chromium:137289935 Change-Id: I2320380839a1af3b5fcd81c47c0715bfefadbd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751266Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686386}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9e4b116ccc40..956770025c8c git log 9e4b116ccc40..956770025c8c --date=short --no-merges --format='%ad %ae %s' 2019-08-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 95386f9e45a2..f701237f2d88 (1 commits) Created with: gclient setdep -r src/third_party/angle@956770025c8c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: chromium:None Change-Id: I9c2ace876d1f0dcf1b676390b5f0e180b104b6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750897Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/95386f9e45a2..f701237f2d88 git log 95386f9e45a2..f701237f2d88 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 stevenperron@google.com Remove useless semi-colons (#2789) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@f701237f2d88 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,syoussefi@chromium.org Bug: None Change-Id: I8be05fa95a0467d5917e33efe6be94a0cbc5816f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750898Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4bd4f700..1d37448e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie6acbc807d254adee1148dd7360ddc92d4ab08ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751022Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686383}
-
Michael van Ouwerkerk authored
Bug: 992345 Change-Id: I825496fc0a0da3084f741c420a8abcea84e5daf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745473 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#686382}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/43faee09e50a..34aee67c1145 git log 43faee09e50a..34aee67c1145 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 514a5433..3ae2445b (686198:686310) Created with: gclient setdep -r src/third_party/webrtc@34aee67c1145 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Idcfe13ecb43b9ffab6b136f244b4e49bda04c050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750890Reviewed-by:
-
Sebastien Marchand authored
Clarify that this metric doesn't give an exact representation of Chrome's physical memory footprint because there's some double accounting of the shared resident set. Change-Id: I8d1b6138b20bf7bf1f51179ab071dd74ae93c637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749209Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#686380}
-
Vasiliy Telezhnikov authored
This CL fixes races in BluetoothLowEnergyApiTest tests: ServiceEvents, GetRemovedService, DescriptorValueChanged that cause flaking in browser_tests Bug: 992460 Change-Id: I634ea6da0264e72697fa23c24ee98e701cb592f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749707Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#686379}
-
Ivan Sandrk authored
Currently managed Chrome OS devices support remote commands issued by the admin on CPanel. Add a command that starts a powerwash on the device when received. Design doc @ go/remote-powerwash-command Bug: 891222 Change-Id: I8aab58db3de12681fd655642e984cff6f24e392f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729219Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#686378}
-
Takuto Ikuta authored
This is just for workaround the swarming output collapsion bug. TBR=thakis@chromium.org, mohsen@chromium.org Bug: 993247 Change-Id: Id1383aaf292419622997217276cb05faefcd4084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750477Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#686377}
-
Yang Guo authored
When using hosted mode, --custom-devtools-frontend specifies the URL rather than the path to the debug devtools bundle. This change fixes the workflow of opening a bundled DevTools instance on a hosted DevTools instance. R=dgozman@chromium.org Change-Id: I6fcc4641c8d1dff324fb9a1096d3b38e10c9344f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751182Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#686376}
-
Alex Clarke authored
Layout test debugging is much easier if we can see the task logging in the driver output. Running with verbose logging is too spamy I'm forever making and reverting this change locally, lets land it. Change-Id: I6df5ff3757b92a9001ef67b25d090bc967a05d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751186Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#686375}
-
Abhijeet Kandalkar authored
This CL convert media_session.mojom to use new mojo types and port dependent files to adopt new implementation. Bug: 955171, 978694 Change-Id: I2dbd7e682784cefc7a12cc19831e5b0749fd3827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743876Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#686374}
-
Javier Ernesto Flores Robles authored
Bug: 976675 Change-Id: I13d1ca5d725fb83e4f3d1187f7f9fe81e8689ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748891 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#686373}
-
Javier Ernesto Flores Robles authored
Use dynamic colors instead. Bug: 976675 Change-Id: I1350150d441600368ff9ca2e021c6ab0b6857b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746263 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Updates the background of the cells from a default white color to a dynamic color. Bug: 976675, 991209 Change-Id: I5df54407fc53ade588de5a6d28f537fe140e3bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745479 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: 991161, 847523 Change-Id: Iadb4a31fc16134e14b078d056184b88f1b23ad9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738372Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#686370}
-
Julian Pastarmov authored
s/nrparker/nparker/g BUG=none Change-Id: I215bfa4e238720ae0cd28524ff322bde900575bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751249 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#686369}
-
Mario Sanchez Prada authored
Adapted the original CL to the change done in the precursor CL to rename the new blink::mojom::SurroundingText Mojo interface into blink::mojom::Frame instead. Original change's description: > This class is now only used from blink::SurroundingTextImpl, so we can > move it down into renderer/core/editing and remove it from the public API. > > Also, make the most of this move to make the new blink::SurroundingText > class use internal Blink types (i.e. WTF::String, LocalFrame) instead of > the public Web* types (i.e. WebString, WebLocalFrame), which will allow > migrating blink::EditingImpl away from WebLocalFrame on a follow-up CL. > > Bug: 980151, 919392 > Change-Id: I2a6ba1aa9e00603d40b4ccb9acb69f46baf5931b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699608 > Commit-Queue: Mario Sanchez Prada <mario@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680007} Bug: 980151, 919392 Change-Id: I0666c5714e8db7060c4a65dc89d9a43f5bcc7b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738555 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#686368}
-
Pavel Shmakov authored
In WebAPKs, showing splash screens before browser launch is restricted to Android N+ because of visual glitches on M-. The visual glitches occur because translucency flipping doesn't play well with SurfaceViews. To support this behavior in TWAs, we add a parameter allowing to opt-out from translucency flipping. Change-Id: Ibde67c49577afff32207c239b0736829b178520e Bug: 989603 Change-Id: Ibde67c49577afff32207c239b0736829b178520e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744412Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#686367}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ebcf8f6f. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I011ed52d436c2203cb805317c5e690d1477d5b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751282Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686366}
-
Koji Ishii authored
This patch adds |MoveToNextSkippingChildren| to |NGInlineCursor|. To support this, this patch also adds |ChildrenCount| to |NGFragmentItem| so that we can compute the box tree structure from a flat list of |FragmentItem|. Bug: 982194 Change-Id: I0a5768d7cc8d522a52c5d7bb1556390583e6d172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746333Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#686365}
-
Vladislav Kuzkokov authored
Use return value instead of output parameter. Bug: 964948 Change-Id: I8a5cbc329b9d95dfb77e0fbb66b0c1d7d178e7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749091Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#686364}
-
Julie Jeongeun Kim authored
This CL converts DevToolsSessionHost and DevToolsSession to new Mojo types. It updates BindDevToolsAgent from frame.mojom, OnReadyForInspection from embedded_worker.mojom and OnReadyForInspection from shared_worker_host.mojom with new Mojo types. Along with updating mojom interfaces, it also updates methods and members which take DevToolsAgentPtrInfo, DevToolsAgentPtr, DevToolsAgentHostRequest, DevToolsAgentHostAssociatedPtrInfo, DevToolsAgentAssociatedRequest with new Mojo types. Bug: 955171, 978694 Change-Id: Ida673d762d4e5bb7dd2696cba28bc681a6f04552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748906 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
Thomas Tangl authored
Bug: 966388 Change-Id: I09461f0f9f64f162d53cece7c81a013b84d2ba2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749090 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#686362}
-
Kenichi Ishibashi authored
We don't support on-the-main-thread script fetch anymore. Bug: 967272 Change-Id: I25cd1a56e16e928709cda11b705089e62bc840d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745110Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#686361}
-
Mitsuru Oshima authored
The frame layout depends on window state as well as immersive state. However SetEnabeldForWidget may skip updating the frame if the target state is same. Make sure we relayout the frame when it is called. Bug: b/128864049 Test: Covered by unit test. manually tested on the device. Change-Id: I254b7326f01acb359cd18a66c2624c57072957ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714113 Commit-Queue: Mitsuru Oshima (OOO 8/12,13) <oshima@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#686360}
-
Balazs Engedy authored
ImportantSitesUtil::GetImportantRegisterableDomains tried to access the SearchPermissionsService under certain circumstances in incognito mode, but the service is not instantiated for off-the-record profiles. This CL only fixes the crash, and does not otherwise change the logic, which also seems to be broken, as documented in crbug.com/993021. Bug: 989890 Change-Id: I9b93bd5007855e1906fcc67c43ed625030ed7142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747011Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#686359}
-
Robbie Gibson authored
This CL adds dark mode colors to the share extension. Besides colors, it also removes the blur effect view. Before, there was a blur effect over the background. There weren't any other views behind it though, so the blur just helped color the background. Now, all the colors are chrome-specific colors, so the background can be colored automatically. Screenshots can be found in the linked bug. Also, when building on iOS 13, the default presentation style for the extension has changed to automatic, so the dimmed background is now added automatically. Finally, this modernizes some parts of share_extension_view.mm. Bug: 992391 Change-Id: I16e5321ebc9018b41bfe617ad304fd3c3b6bb32e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748754 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
-
Benoît Lizé authored
This test fails on CFI bots, see attached bug. This is due to it being too strict. It would be correct if there are no PA allocations triggered elsewhere in the process, which is an assumption that can break with test harness changes. Make the assert more tolerant to these changes, by asserting that memory is reduced, instead of having a strict value. Bug: 993219 Change-Id: I1e5e3b1f7e1f14357171a06a31a2eba9380babfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751183Reviewed-by:
-
Vasilii Sukhanov authored
Bug: 986298 Change-Id: Idbac7135d6ed958529bea6968d4405f5e689c84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746476Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#686356}
-
Julian Watson authored
BUG=992293 Change-Id: Id54f0b0f26e06b1ce5c2c7c4e725889867e88334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750516 Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#686355}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I90311089fd94cae99be12b4b3261555f83bcadd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750900Reviewed-by:
-
Nathan Rogers authored
Address the previous TODO by replacing the iterator based loop with a range-based for loop. Change-Id: I1f68e03233fc0a37b91aa6c8e29c29660a3a1abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750932Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Nathan Rogers <nathanrogers@google.com> Cr-Commit-Position: refs/heads/master@{#686353}
-
Julie Jeongeun Kim authored
This CL converts DevToolsSessionHost and DevToolsSession to new Mojo types. The changes are two CLs and it is the first CL and the second on is [1]. It updates AttachDevToolsSession and ChildWorkerCreated from devtools_agent.mojom It also converted methods and members which take these DevToolsAgent and DevToolsAgentHost to new Mojo types. SharedWorkerDevToolsAgentHost::WorkerReadyForInspection and ServiceWorkerDevToolsAgentHost::WorkerReadyForInspection still keep old types and these are handled at [1] with the rest of code which still uses old types. [1] https://crrev.com/c/1748906 Bug: 955171, 978694 Change-Id: I2d67a390b3299bfd71d4539857973481f349849e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745944Reviewed-by:
-
Dominik Röttsches authored
Previously this test relied on font fallback and broke up runs unnecessarily. Make font selection for the Devanagari tests explicit. Rephrase test expectations to rely less on font-selection-induced run splitting, but rather create assertions that test for the script properties independent of run layout. Preparation for moving font fallback on Windows to an OOP call instead of hardcoding our fallback tables. Unit tests cannot perform such OOP calls as the browser side fallback Mojo service is not available. Bug: 976737 Change-Id: I7126979efe40848325b1859c2e0b8ecfef64d775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748946 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
As a preparation for adding parser-related tests. Bug: 990561 Change-Id: I8fdb07059514fe088438e8499cd4ac20e1c0b528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734328 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
