- 12 Mar, 2020 40 commits
-
-
Kuo Jen Wei authored
Bug: none Test: tast run <DUT> CCAUI* Change-Id: Iebc496e5d8b82b8b140a3b54221f5366cb479562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097782Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#749614}
-
tby authored
Bug: 1034842 Change-Id: I531624ef20a3c03eb62c25b6bfc97f3864a45b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100147 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#749613}
-
Jinho Bang authored
This patch is initiated from the review comment[1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1144587/13/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc@89 Bug: none Change-Id: I2be17d7e83dd6afad1b2c3ca059460ba1bc6fe06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099685Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#749612}
-
Mathias Carlen authored
This feature is approved for all channels starting with M81. Launch Bug: crbug/1019997 Bug: b/148647596 Change-Id: I50c5f9f36144b3f4a778155e2bb82ceb77d08c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098784Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#749611}
-
Koji Ishii authored
Following bot results are included. 1693 1694 5 lines were removed and 0 lines were deflaked by consecutive results since 1674. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I8645e21d82d4fddcd4ffb6f7e93621c14273dc11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100169Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749610}
-
Yuki Shiino authored
IDL attributes of type Nullable (e.g. "long?") are currently implemented as: int32_t attrName(bool& is_null); void setAttrName(int32_t value, bool is_null); however, the following APIs are preferable. base::Optional<int32_t> attrName(); void setAttrName(base::Optional<int32_t> value); In order to update bindings APIs of IDL attributes, this patch adds the base::Optional version. Once the bindings generator switches to the new APIs, the old explicit is_null version will be removed. Bug: 1060971, 839389 Change-Id: Iad728b1b9a7a289dcfa4f637cb84304ff48c4cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059032Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#749609}
-
Kamila Hasanbega authored
This reverts commit 5a7d3fed. Reason for revert: [Sheriff] Reverting for now, as I suspect the cl is causing failures in https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20x64/b8886078290056207296 Original change's description: > [Fuchsia] Implement Frame/SetPermissionState() > > Now WebEngine implements SetPermissionState() which allows to grant > permissions for web features. > > Bug: 922833 > Change-Id: I356e54646ad870bb7882a5b9a95bc87deccba453 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058086 > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749428} TBR=ddorwin@chromium.org,wez@chromium.org,mlamouri@chromium.org,sergeyu@chromium.org Change-Id: Ib7f824e173044474d281705b865ba8072becd8e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 922833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098787Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Commit-Queue: Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#749608}
-
Hans Wennborg authored
This gets us off the hook from fixing failures in a build config which is not well tested upstream, reduces the package build time, and simplifies our build script. It also make thinlto faster, due to lld now being built with PGO (although we don't train on lld, it benefits from the training on clang). Bug: 884608, 949626 Change-Id: I55859efbde9071da72c1057765d0d1900e069eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095544Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#749607}
-
Rouslan Solomakhin authored
Before this patch, payment_app_provider_impl.cc cleared the |ready_for_minimal_ui| and |account_balance| fields of CanMakePaymentResponsePtr before forwarding the struct the service worker payment app factories. This patch validates the |account_balance| field of the CanMakePaymentResponsePtr struct and forwards to the payment app factories either the valid unchanged struct or a blank struct in case of validation failure. After this patch, the service worker payment app factories receive the full validated CanMakePaymentResponsePtr struct from the renderer. Bug: 1005076 Change-Id: I27c3b07e29804cce0b52ae7f137225007dfe4853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091647 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#749606}
-
Huanzhong Huang authored
Bug: 1060967 Change-Id: Ia79941fe20a1e6f71165a6f53c1237f53ed2cf82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098685Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#749605}
-
Simon Zünd authored
The force-pseudo-state.js web test was ported to an devtools e2e in: * https://crrev.com/c/2095297 * https://crrev.com/c/2096706 As the web test is flaky and disabled on most platforms, its better to only rely on the e2e test and remove the web test altogether. R=tvanderlippe@chromium.org Bug: chromium:1060270 Change-Id: I130200ced1d7e4f2c4be84be5a7e2445c56f5f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098626 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#749604}
-
arthursonzogni authored
When a response is blocked by CORP because of the COEP header, check the reporting API is worker. This patch adds 4x2=8 new WPT tests. For every 4 context: - Document - SharedWorker - DedicatedWorker - ServiceWorker For the 2 headers: - Cross-Origin-Embedder-Policy - Cross-Origin-Embedder-Policy-Report-Only Bug: 1059727, 1031542, 887967 Change-Id: I797e36d0cfc982862e85dbc9a49c661fee46bf85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096687 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#749603}
-
Kamila Hasanbega authored
This reverts commit 546fc2fa. Reason for revert: [Sheriff] This causes failures https://ci.chromium.org/p/chromium/builders/ci/Network%20Service%20Linux/2304 Original change's description: > Add a first integration test involving both Sync and PasswordManager > > The test sets up Sync-the-transport, has the user opt-in to the account > password storage, and makes sure that saves go to the correct store. > > This requires a few changes to password_manager_test_base.h/cc: > - Most notably: The password manager tests used to set up a > MockPasswordFeatureManager (in order to make IsGenerationEnabled() > return true), but the new combined tests require a real > PasswordFeatureManager. So this CL removes the mock (which also lets > us remove CustomPasswordManagerClient), and instead sets up a > TestSyncService which claims "everything is active" and so also makes > IsGenerationEnabled() true. > - Some simple refactorings to avoid duplicating test setup code: > - Split the "GetNewTab" part out of SetUpOnMainThreadAndGetNewTab(), > into a new static helper. > - Exposed PasswordStoreResultsObserver (it used to be fully defined > in the .cc). > - Exposed a version of CheckThatCredentialsStored() that takes a > PasswordStore parameter. > > Bug: 1058339 > Change-Id: If9b040cbd56ee10ba6b6badd1b4b4d772603f13a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089825 > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749220} TBR=treib@chromium.org,mastiz@chromium.org,mamir@chromium.org Change-Id: Ifb6bdf160c9b53d2b1b50bdaef69389668376910 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098705Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/484bb8a03b97..2896bf697b66 git log 484bb8a03b97..2896bf697b66 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 mbonadei@webrtc.org Add ios_use_goma_rbe=true to iOS bots. Created with: gclient setdep -r src/third_party/webrtc@2896bf697b66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic7e479afadf0d9686972222f82caf94554a14123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100235Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749601}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I2cc48ece3f4fffe121ec2402617ff3a1b6ecd4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100287Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749600}
-
Clemens Arbesser authored
EQUAL is available for all value types. All other comparisons are currently only supported for strings, integers, and dates. Bug: b/145043394 Change-Id: I003074fd5437e1f1e83aa7f4b779a3416b707193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095113Reviewed-by:
-
Michael Lippautz authored
Avoid biasing the metric with many 0-samples and only emit the sample when the GC was actually compacting memory. Bug: 1056170 Change-Id: I906b7b639fa96b53acc6f3b7235a015f6322123f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098625Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#749598}
-
Yuki Shiino authored
IDL attributes of type Nullable (e.g. "long?") are currently implemented as: int32_t attrName(bool& is_null); void setAttrName(int32_t value, bool is_null); however, the following APIs are preferable. base::Optional<int32_t> attrName(); void setAttrName(base::Optional<int32_t> value); In order to update bindings APIs of IDL attributes, this patch adds the base::Optional version. Once the bindings generator switches to the new APIs, the old explicit is_null version will be removed. Bug: 1060971, 839389 Change-Id: I6d06d0f2a241c8405f814ce16b9aade8abbe6caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007326Reviewed-by:
-
Gyuyoung Kim authored
This CL converts BlinkTestHostMsg_PrintMessage to BlinkTestClient interface. But, BlinkTestRunner::PrintMessage needs to send a message only when it's on the mainframe in order to sync with the existing behavior. Like BlinkTestHostMsg_ResetDone conversion, this message has been sent to the main frame. So, this CL moves |is_secondary_window| from WebTestRenderFrameObserver to BlinkTestRunner. Additionally, this CL removes blink_test_messages.h/cc files and related things(e.g. BlinkTestMsgStart) finally. Bug: 1039247, 1059322 Change-Id: I91dfc9256cacc63b1397c46ed1d6c582ab01b6ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089435 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#749596}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c1fd0b36..55e6902b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I43f1a9fcd23cc3626686b6b1e2e9b60039db0605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100209Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749595}
-
Andrey Zaytsev authored
Bug: 1015841 Change-Id: I32a0a2622c45838df1a7cc51009d88e5adb8bde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089775 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749594}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ee9e28d54f35..a5e36d303614 git log ee9e28d54f35..a5e36d303614 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 szuend@chromium.org Consider all JavaScript to have side effects Created with: gclient setdep -r src/third_party/devtools-frontend/src@a5e36d303614 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1031243 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I56c62577c7b146b6d531676dfe62915151f1e82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100232Reviewed-by:
-
Anastasiia Nikolaienko authored
Add profile image fetcher to fetch parent profile images for 'parents list' screen. Bug: 1043108 Change-Id: Id21f43359d2470c5d68129a7d75821acd0fd5be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043877 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#749592}
-
Ewann authored
- Implements the page info site security view controller. - Fixes stop [pageInfoCoordinator stop]. - Renames PageInfoButtonAction to PageInfoSiteSecurityButtonAction. screenshots: https://drive.google.com/drive/folders/1ilG-PTprtWe3QO7sbJUhv_ilwWNmXPwx?usp=sharing Bug: 1038919 Change-Id: I09a492c31cf50c3472903017e871fd8a0757d54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093218Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#749591}
-
Koji Ishii authored
This is a follow up for r749120 crrev.com/c/2089894 This patch has no behavior changes. Bug: 982194 Change-Id: I18775e577dae67b90e98ecddb5b28babca1175e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098165Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749590}
-
Anastasiia Nikolaienko authored
Bug: 1043108 Change-Id: Ie64acba83e6965a0fd7efe88fbb8c15a95550047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091345 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2e5bd9b1e658..84780f7dc5e1 git log 2e5bd9b1e658..84780f7dc5e1 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 shrekshao@google.com Speculative fix: getProgramiv always returns a valid program Created with: gclient setdep -r src/third_party/angle@84780f7dc5e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:991020 Tbr: jmadill@google.com Change-Id: I3264c3e42594f7345899f405d074c291b5a572e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099646Reviewed-by:
-
Kei Nakashima authored
Implemented iterators of NewLinkedHashSet using those of VectorBackedLinkedList. Also made some iterator-related APIs public to use them in NewLinkedHashSet. Change-Id: Ifa4a7c60bfbd3673a1f3923f911cde3eebca612f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097904 Commit-Queue: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, RespondWithCallbacks in payment_app_provider_impl.cc contained three callbacks, only one of which was used at any time. This patch changes RespondWithCallbacks into an abstract class with three concrete sub-classes instead: CanMakePaymentResponWithCallback, InvokeRespondWithCallback, and AbortRespondWithCallback. In addition, when the payment handler respond with "false" to "abortpayment" event, payment_app_provider_impl.cc no longer clears the list of Invoke callbacks, because "false" indicates that the payment has not been aborted. After this patch, there're three callback classes with one callback member variable each. Bug: 1060298 Change-Id: Ie5c141bc01a6d3c663afd768ea829b750587f0de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094666 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#749586}
-
Hiroshige Hayashizaki authored
As a part of turning down Built-in Modules in Blink. Bug: 829084, 972476, 1055006 Change-Id: Ibd0fcc327977d1fcd5da811e7f0b245ae9f9f797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094493 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#749585}
-
Makoto Shimazu authored
This adds COEP reporter for service worker contexts. CORP failures happening on subresource requests initiated from a service worker are reported to the COEP reporter owned by EmbeddedWorkerInstance. Bug: 1056122 Change-Id: I7884487e0261b4d85bf98b5844c3e34c0b985ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098166 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#749584}
-
Side Yilmaz authored
|getLastUsedRegularProfileKey|. |ProfileKey#getLastUsedProfileKey| is depreciated and replaced with |ProfileKey#getLastUsedRegularProfileKey|. This change replaces |ProfileKey#getLastUsedProfileKey#getOriginalKey| with |ProfileKey#getLastUsedRegularProfileKey|. Note: This change is only code clean-up, does not change any behaviour. Bug: 1041781 Change-Id: Ic55693571ad10395ff9c88e5bf965b0578768c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089869Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#749583}
-
Domenic Denicola authored
This seems to be leftover from a Blink-side implementation of origin policy. The classes defined in these files are not referenced elsewhere in the Chromium codebase and are not involved in our current origin policy implementation. https://crbug.com/1060184 tracks adding a new fuzzer for the modern implementation, to replace the one deleted here (that is currently fuzzing dead code). Fixes: 1056673 Change-Id: Idccac39753caa275c62f303a5f635cf6f74235b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079258Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a0e10db6f8d6..905a6de3705f Created with: gclient setdep -r src-internal@905a6de3705f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040328,chromium:996088 Tbr: jbudorick@google.com Change-Id: Ie9907a73866865febc31891bcc9aedf051e1a9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100143Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749581}
-
Rouslan Solomakhin authored
Before this patch, payment_app_provider_impl.cc received a CanMakePaymentResponsePtr from the renderer process and forwarded only its "can_make_payment" field to the service worker payment app factories. This patch forwards the full CanMakePaymentResponsePtr instead of the boolean, but the "ready_for_minimal_ui" field is always false and "account_balance" field is never set. After this patch, payment_app_provider_impl.cc forwards the full CanMakePaymentResponsePtr structure to the service worker payment app factories. Bug: 1005076 Change-Id: I3e076034a83f66bf42b92fcadf0e9f248395f15a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090803Reviewed-by:
-
Alan Cutter authored
This test started flakily crashing after: https://chromium-review.googlesource.com/c/chromium/src/+/2090877 First failing build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17501 TBR=pkasting@chromium.org Bug: 1060421 Change-Id: Ib24e672b8757992c0d10bc3e7b745d3cb8e79f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100172Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#749579}
-
Eriko Kurimoto authored
This CL adds tests for subresource fetching from HTTP(S) scheme url dedicated workers and shared workers. Currently, we have subresource fetching tests from ONLY data: URL dedicated workers . In this CL, we improve the test coverage by adding subresource fetching tests from HTTP(S) scheme url workers which are more normal. Bug: 989399 Change-Id: Icf83cd359fa64df94c5ff93210c7a1c7bce12944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077321Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#749578}
-
Colin Blundell authored
This is a direct dependency on ExternalNavigationDelegateImpl, which will stay in //chrome after ExternalNavigationHandler is componentized. This CL abstracts the method through ExternalNavigationDelegate. Bug: 1031465 Change-Id: Ia307d675d08af0492a1bad658c95f76ae8778111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095547 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#749577}
-
Ahmed Mehfooz authored
Bug: 1056451 Change-Id: I23fb1ad19251bae8e1917b6089b3cb75385e74c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097031 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#749576}
-
David authored
This cl also * adds the id of the MediaApp into chromium (will need it for metrics later) * adds a test parameterized test (since SystemWebAppManagerBrowserTest is now paramterized), currently expects the inverse. Bug: b/144886504, 877898, 1054195 Change-Id: I1d862b04d47092e45ad08415b707612a1e5464fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082659 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#749575}
-
