GitLab

due to fame navigation flakiness.

TBR=jochen@chromium.org 
BUG=141497
Review URL: https://chromiumcodereview.appspot.com/10827258

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150892 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10825275

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150891 0039d316-1c4b-4281-b951-d872f2087c98

DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING
Changes from original CL only in downloads_api.*

Reviewers:
Ben Goodger: chrome/browser/ui/views/download/download_item_view.*, chrome/browser/plugin_installer.*, chrome/browser/automation/automation_provider.cc
rdsmith, asanka: all
Nico (thakis): chrome/browser/ui/cocoa/download/download_item_mac.*
Achuith: chrome/browser/chromeos/gdata/gdata_download_observer.*
Evan (estade): chrome/browser/ui/gtk/download/download_item_gtk.*, chrome/browser/ui/webui/downloads_dom_handler.*
Scott (sky): chrome/browser/history/history_unittest.cc
Aaron (aa): chrome/browser/extensions/webstore_installer.*

Add DownloadItem::Observer::OnDownloadRemoved() to signal when a download is being removed from history.
Make chrome.downloads.onErased trigger from DownloadItem::Observer::OnDownloadRemoved() so that extensions don't think that all downloads are being erased just because the browser is closing.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149794
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=150086
http://crbug.com/140687

Review URL: https://chromiumcodereview.appspot.com/10704026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150890 0039d316-1c4b-4281-b951-d872f2087c98

Resubmit of r145925

BUG=136828
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10702038


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150889 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150888 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yutak@chromium.org

BUG=

Review URL: https://chromiumcodereview.appspot.com/10823236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150887 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10827248

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150886 0039d316-1c4b-4281-b951-d872f2087c98

Original CL http://codereview.chromium.org/10827154/ was failed on linux_chromeos. This CL fixed the test.

Preload default wallpaper.


BUG=139929
TBR=nkostylev, sky

Review URL: https://chromiumcodereview.appspot.com/10827247

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=the new test passed on try

Review URL: https://chromiumcodereview.appspot.com/10855068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150884 0039d316-1c4b-4281-b951-d872f2087c98

Chromium already behaves like this in the IPC plumbing for IDB,
but the code can be simplified by pushing this into the WebKit
implementation itself.

Full landing sequence is:

(1) WebKit prep: Add new API stubs http://webkit.org/b/92414 
(2) Chromium changes: dispatch to old and new API https://chromiumcodereview.appspot.com/10830028 (this patch)
(3) WebKit changes: use the new API http://webkit.org/b/92278
(4) Chromium cleanup: delete old API usage
(5) WebKit changes: delete old API


Review URL: https://chromiumcodereview.appspot.com/10830028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150883 0039d316-1c4b-4281-b951-d872f2087c98

Currently we have the debugd logs prefixed with debugd and then duplicated in another key called debugd; this will be fixed with http://code.google.com/p/chromium/issues/detail?id=138582 but for M22, we want to fix the UI to display the logs more appropriately.

Reviews requested,
ellyjones@ - main review.
xiyuan@ - OWNER's review.

R=ellyjones@chromium.org,xiyuan@chromium.org
BUG=140489
TEST=debugd- prefixed keys are gone; so is the debugd key which contained all the logs again.


Review URL: https://chromiumcodereview.appspot.com/10825260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150882 0039d316-1c4b-4281-b951-d872f2087c98

Add in support for timing chrome's startup and session restore times.

BUG=130212
TEST=Included


Review URL: https://chromiumcodereview.appspot.com/10834015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137676
TBR=tony, sky

Review URL: https://chromiumcodereview.appspot.com/10837158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150878 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10831234

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150877 0039d316-1c4b-4281-b951-d872f2087c98

R=ben@chromium.org,groby@chromium.org
BUG=109425,128964


Review URL: https://chromiumcodereview.appspot.com/10830102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150876 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141134

Review URL: https://chromiumcodereview.appspot.com/10830138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150875 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=yefim

Review URL: https://chromiumcodereview.appspot.com/10836183

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150874 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140306
Tested: Added new browser tests!

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150654

Review URL: https://chromiumcodereview.appspot.com/10830072

TBR=fsamuel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827257

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150873 0039d316-1c4b-4281-b951-d872f2087c98

The number of calles of FindEntryByPathSync() is reduced from 15 to 13.

BUG=137694, 126634, 139446
TEST=Moving a file to another directory and renaming in the same directory work as before from file manager

Review URL: https://chromiumcodereview.appspot.com/10854072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150871 0039d316-1c4b-4281-b951-d872f2087c98

The hit-region for windows need to be larger for touch events to allow
resizing windows easily, while continuing to use a smaller hit-region
for mouse-events.

BUG=135187

Review URL: https://chromiumcodereview.appspot.com/10854060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150870 0039d316-1c4b-4281-b951-d872f2087c98

and need to share existing code with other developers.

BUG=125307


Review URL: https://chromiumcodereview.appspot.com/10533086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150869 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150867 0039d316-1c4b-4281-b951-d872f2087c98

This was causing the description to be stored as a tuple, which was serialized
to JSON as an array, which makes naclsdk list display the description as
[u'Chrome ... bundle, revision ...']

BUG=none
R=noelallen@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10830223

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150866 0039d316-1c4b-4281-b951-d872f2087c98

Just moving vpx_version.h to a new place. Roll to include changes.

TEST=Tree is green


Review URL: https://chromiumcodereview.appspot.com/10836140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150865 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10825274

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150864 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140306
Tested: Added new browser tests!

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150654

Review URL: https://chromiumcodereview.appspot.com/10830072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150863 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150862 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10829264

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150861 0039d316-1c4b-4281-b951-d872f2087c98

(GTK only) For internal chrome pages display only a bubble with an info string instead of the Website Settings popup.


BUG=140450
TEST=For internal chrome pages like chrome://settings only a small bubble with an info string is displayed.
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10837174

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150858 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150857 0039d316-1c4b-4281-b951-d872f2087c98

control: http://codereview.chromium.org/10836175/
Review URL: https://chromiumcodereview.appspot.com/10832223

TBR=robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/10834258

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150856 0039d316-1c4b-4281-b951-d872f2087c98

+++ REVERT NOTICE +++
Test should pass on QA bots now that a new official build is available.
+++ +++

BUG=141410
TEST=Ran on chrome-qa bot to witness failing steps identified in the bug.
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10826206

TBR=dyu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150855 0039d316-1c4b-4281-b951-d872f2087c98

Clicking on a maximizer dialog button and dragging out of the dialog left the phantom window open

BUG=141438
TEST=Visual


Review URL: https://chromiumcodereview.appspot.com/10836176

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150854 0039d316-1c4b-4281-b951-d872f2087c98

When a fling happens at the end of a scroll, instead of generating both a scroll-end
and a fling-start event, generate only fling-start event. Unfortunately, WebKit still
requires an explicit scroll-end gesture before a fling, so continue to do that as a
special case.

BUG=141460,141309

Review URL: https://chromiumcodereview.appspot.com/10826209

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150852 0039d316-1c4b-4281-b951-d872f2087c98

Both java.gypi and apk_test.gypi expect the jar path in
input_jars_paths. This means that we were specifying the dependence in
both 'dependencies' and 'input_jars_paths'. This change makes it so that
we don't need that redundancy.

Also, make java.gypi use input_jars_paths in its input so that we
actually rebuild targets when we should.

BUG=136756


Review URL: https://chromiumcodereview.appspot.com/10837143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150850 0039d316-1c4b-4281-b951-d872f2087c98

This removes prior solution where a duplicate web_contents for the NTP was
stored in the search_tab_helper.  Replaces that solution with this where the
main browser window's web view is reparented into the search overlay when the
search overlay is active and displaying the NTP.  When the NTP is dismissed or
navigated away, the web view is reparented back to the main browser_view's
contents container as per usual.

BUG=133529
TEST=--enable-instant-extended-api, load NTP, click on a most visited link.  Expect navigation in main browser window.
R=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10832216

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150849 0039d316-1c4b-4281-b951-d872f2087c98

Fixes page cycler netsim test on Linux.

BUG=133069
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10829259

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150848 0039d316-1c4b-4281-b951-d872f2087c98

Rather than excluding safe_browsing dependencies for non-safe_browsing
builds only include them when needed. This is a baby-step towards a
safe_browsing component.

This is part of Android upstreaming (smhasher isn't used).

BUG=137571


Review URL: https://chromiumcodereview.appspot.com/10825226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150846 0039d316-1c4b-4281-b951-d872f2087c98

Fix reference to WebContentsDelegate and make the entire
ShellWindow implementation private.

R=jianli@chromium.org
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10831230

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150845 0039d316-1c4b-4281-b951-d872f2087c98

R=mangini@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10825266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150844 0039d316-1c4b-4281-b951-d872f2087c98