- 10 Sep, 2019 40 commits
-
-
Antonio Gomes authored
These are phases 3.4 and 3.5 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ The CL moves both classes together for simplicity and because one depends on another. In a secondary step, they will be moved out of the Blink exposed API. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Icd9bd32d860613db933dd19b2b88ee2ad16d5d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792846 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695104}
-
chrome://settings/passwordsMarc Treib authored
This requires making PasswordManagerPresenter multi-store-aware (which is actually pretty straightforward). For now, passwords from the two stores are not differentiated at all in settings; they just show up together in the same list. Bug: 1002063 Change-Id: I24faa431f73eb79c1f829889d8cd2c7f29552ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789296Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#695103}
-
Denis Kuznetsov authored
Bug: 999477 Change-Id: I1cd1df490123ba0ce1160589d2bbcc6ebb76b82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792868Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#695102}
-
David Roger authored
This pref is deprecated since M43 and can now be removed. TBR=jzw Change-Id: Ie01b4946af6453f786aa05a348ce51c8e3477f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787782 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#695101}
-
Rakina Zata Amni authored
The focus delegation behavior might change as proposed in https://github.com/w3c/webcomponents/issues/830. This CL adds use counter for when a host with delegatesFocus is focused, and when the result of the focus delegation is different than the proposed change, to see the possible impact of the change. Bug: 692678 Change-Id: I90a0a10e1e5adbd3fe018ea772e1d560fedec9a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794945Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#695100}
-
Takashi Toyoshima authored
This reverts commit 2eda3ac7. Reason for revert: continues to fail on Linux Tests Builder. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests Original change's description: > Reland "Notification scheduler: Add a browser test." > > Reverted in > https://chromium-review.googlesource.com/c/chromium/src/+/1787277 > due to flakiness on chromeos builders. > > This CL tries to reland the browser test that the test seems no longer > failed on those trybots. Also can't reproduce the test failure on > local machine with linux-chromeos build. > > TBR=dtrainor@chromium.org > > Bug: 1001003,963295 > Change-Id: Ia1b553aa46f9256b9a94004d2426cf35bc9bf4e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793821 > Reviewed-by: Xing Liu <xingliu@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695001} TBR=dtrainor@chromium.org,xingliu@chromium.org,hesen@chromium.org Change-Id: I3bf84db4e976a7c79a79122dd14282d7ee73f61d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001003, 963295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795522Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#695099}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c77df78931bc..0cd61b6e287c git log c77df78931bc..0cd61b6e287c --date=short --no-merges --format='%ad %ae %s' 2019-09-10 asapersson@webrtc.org MultiCodecReceiveTest: fix for flaky test. 2019-09-10 titovartem@webrtc.org Add ability to provide TEXT hint only when requested in PC framework 2019-09-10 nisse@webrtc.org Add empty build target modules/video_coding:video_coding_legacy Created with: gclient setdep -r src/third_party/webrtc@0cd61b6e287c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Id890a85b808794cf240b2d391abcacc9aa39d525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795082Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695098}
-
Rune Lillesveen authored
This is necessary for a correct serialization of colors in devtools which would otherwise serialize as simple space separated color values. Bug: 939811 Change-Id: If9f3cc7d42c9c603ac3e743037ed23f2bebb7226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789393 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#695097}
-
Martin Šrámek authored
...which is flaking on linux-blink-rel. TBR: foolip@chromium.org Bug: 1000734 Change-Id: Id76d6a44461a0d3c542162e5fb3e8e5cb9ed8e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794804Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#695096}
-
Kent Tamura authored
V8GlobalValueMap had three arguments, and the third argument was always v8::kNotWeak. So, this CL removes the third argument. Change-Id: I839be8160dcd1a45b74795f82d73a21d8c62851f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794366Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#695095}
-
Eric Willigers authored
When we update 'counter-increment' or 'counter-reset' to 'inherit', we now overwrite the previously resolved values, instead of merging in the parent values. Existing Blink fails test with FAIL Inheritance of counter-reset replaces existing value assert_equals: expected "first 1" but got "first 1 fourth 4" FAIL Inheritance of counter-increment replaces existing value assert_equals: expected "second 2" but got "second 2 fifth 5" Existing Safari fails test with FAIL Inheritance of counter-reset replaces existing value assert_equals: expected "second 0 first 1" but got "second 0 fifth 0 first 1" FAIL Inheritance of counter-increment replaces existing value assert_equals: expected "second 2 first 0" but got "second 2 fourth 0 first 0" Bug: 1001776 Change-Id: Ic7279a84f022f0bc156bdab1a044b3403cb2c7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789213Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#695094}
-
Antonio Gomes authored
This is phases 3.2 and 3.3 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ The CL moves both classes together for simplicity and because one depends on another. In a secondary step, they will be moved out of the Blink exposed API. BUG=787254 R=haraken@chromium.org Change-Id: Id0141088729bbf6bac748793f282ced3dfd53fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792845 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b09e9fc89fa7..add85d2b6cb6 Created with: gclient setdep -r src-internal@add85d2b6cb6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0ee9733cc64bf094b0409b1f36b8dbde70bcb7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794742Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695092}
-
Yoichi Osato authored
So that we can test with query: websocket/receive-arraybuffer-1MBx100.html?iteration=10&server=ws://127.0.0.1:8001/text Result Chrome M78: 144 MB/s Firefox 69.0: 189 MB/s Bug: 1001009 Change-Id: I41089a0098de51d9b0ea12695eb7e82450f3675e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794324 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Auto-Submit: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#695091}
-
Finnur Thorarinsson authored
Crashes when cancelling the dialog when no contacts are present. Bug: None (found manually) Change-Id: I677ca4f040d9e99beaabb68056331c92f3c07a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793166 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#695090}
-
Denis Solonkov authored
None of the existing python packages in third_party/ can modify ELF structure and as such not fit for the script. This library allows the script to parse the library and read useful information from it. Bug: 998082 Change-Id: I7d3197b93cf1a3b9c1797249a77d7ed8f130b519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777928 Commit-Queue: Denis Solonkov <solonkovda@google.com> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#695089}
-
Friedrich Horschig authored
This CL updates the keyboard accessory field trial by removing the old config (which uses already deleted features) and adding the config for the follow-up version. Bug: None Change-Id: I23df28aee763b898fe3b5472e5d320a78ad308aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789810 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#695088}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/76261e2a7df1..7f7236f1eba0 git log 76261e2a7df1..7f7236f1eba0 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 stevenperron@google.com Handle id overflow in the constant manager. (#2844) 2019-09-09 alanbaker@google.com Add generic builtin validation of target (#2843) 2019-09-09 stevenperron@google.com Don't register duplicate decoration in validator. (#2841) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@7f7236f1eba0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,syoussefi@chromium.org Bug: None Change-Id: Icab153ce2fd99aba13c04a5b2e156f6331df7282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794199Reviewed-by:
-
Lowell Manners authored
These tests were removed in https://crrev.com/c/1782902, but we can avoid deleting them by allowing tests to set the BackForwardCache's size limit. Bug: 1000658 Change-Id: Iff92a2fe6172382c319f34c5f4aaf73da17a75b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790447 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#695086}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/58c5b07b47cf..3255f493db0d git log 58c5b07b47cf..3255f493db0d --date=short --no-merges --format='%ad %ae %s' 2019-09-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 76261e2a7df1..7f7236f1eba0 (3 commits) Created with: gclient setdep -r src/third_party/angle@3255f493db0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: chromium:None Change-Id: I9d70c692d7c6213481f8fc45b04821a57fcabd65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794198Reviewed-by:
-
Rune Lillesveen authored
Multiple issues with previous patch: - color_scheme check was not correct - we did not resolve the chosen color value from the pair correctly Bug: 939811 Change-Id: I519ed2c70f5f28ceaf102f9c7c466d155779db05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789538 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Tanisha Mandre authored
- 'Add' button: Test enable/disable, test alert on adding wrong number. - 'Cancel button: Test dismissing 'Add Credit Card' view on tap. Bug:1000669 Change-Id: I7303be8416a43493d07d51b7bf966dbcc5f61ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787645 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#695083}
-
Gauthier Ambard authored
On iOS 12, when the screen time Content Restriction is enabled with SlimNav, this DCHECK is hit. This CL relaxes it in that case. As iOS 13 should be out soon, the usage of iOS 12 among our users should become smaller. Bug: 1000366 Change-Id: I39e02361ce0771a140d17060ed35f6be20f30a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791154 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Peter Kasting authored
Bug: 1000055 Change-Id: I4e7fdbe09f31460f27ad88b4bb2f075d42d21a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793289 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695081}
-
Tanisha Mandre authored
- Enables CreditCardScanner feature flag in setup. - Tests text fields appear - name, card number, expiry month, expiry year. - Tests 'Use Camera' button appears only in iOS 13. Bug:1000669 Change-Id: Idf4d39061b715bab322e88b65ccc2d31e715bb98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787378Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Cr-Commit-Position: refs/heads/master@{#695080}
-
Friedrich Horschig authored
The keyboard accessory was still using the old announcement. It would shout "Passwords available" which isn't wrong since passwords fallbacks are available but it is very unprecise, incomplete and misleading if the accessory is filled with Address autofill suggestion. Bug: 969202 Change-Id: I5792ff1479b361344d976b3036bec7b46cdf5638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793082Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#695079}
-
Mario Sanchez Prada authored
This CL migrates code to the new BrowserInterfaceBroker class. This allows retrieving the remote implementation from the renderer process without relying on FrameClient's InterfaceProvider, as well as simplify code in RenderFrameHostImpl by using the new service_manager::BinderMap class directly, instead of using the old service_manager::BinderRegistry object. Last, this CL also adds missing includes in browser_interface_binders.cc Bug: 955171, 978694, 936482 Change-Id: I72354777751fe407680d7935db6e6bd41d194095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768338Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Eliot Courtney authored
This makes sure that the HIDDEN occlusion update is delivered when hiding the window, not when showing it later. Subsurface additions are processed at any time (not only commit), which means hidden windows can get added to the hierarchy. Their occlusion will be computed as hidden until the next CommitSurfaceHierarchy where they are made visible. This change moves that HIDDEN occlusion update to the time of hiding, rather than the time of showing. sent upon entering PIP, not leaving. Bug: 140563748 Test: Alt-tab to trigger PIP on Youtube. Occlusion fraction of 1.0 is Change-Id: I9a4a8f74bdaa0a55a65a6152b9df1232bd0e6e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792041 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#695077}
-
Robbie Gibson authored
Bug: 974255 Change-Id: Ib0ba38dfee28e87f744818b350af8dd77d37a4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792870Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#695076}
-
Mohamed Amir Yosef authored
Change-Id: Ibae7013f4690d43d5fe576f82096ab1e6b1ee5fc Bug: 991510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774285 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#695075}
-
Anastasiia Nikolaienko authored
For Active Directory login there is no primary account, since it has to be Gaia acccount. - We will not abort reconciliation if primary account has an error. - GetFirstGaiaAccountForReconcile will keep the order of Gaia accounts even if there is no primary account. Bug: 993317 Change-Id: I2a20933a3a9627b83cce2d4e027d91eb7d52795f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758072Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#695074}
-
Mario Sanchez Prada authored
Convert the remaining bits in //content that still use the old mojo types for content.mojom.Echo to the new mojo types. Bug: 955171 Change-Id: Ia57bf99582ebf6d280de6eca7971ca30c805f550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792871Reviewed-by:
-
Pâris MEULEMAN authored
In preparation of the creation of PrimaryAccountMutator.java, move the java signin metrics enums to //components/signin, aligning them with their C++ counterpart. Indeed, these will be used by PrimaryAccountMutator.java within the component. Bug: 934688 Change-Id: I4574d9caba9464328ffa0c6859dbbeefc2e18901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782901 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#695072}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c7b6bab50170..b09e9fc89fa7 Created with: gclient setdep -r src-internal@b09e9fc89fa7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I5ab2c9a9c26f1acc1c52fb35ae40cf48364124f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793888Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/008a1db55909..9e5c47936b17 git log 008a1db55909..9e5c47936b17 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a7ff7df26f28..58c5b07b47cf (7 commits) 2019-09-10 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 44e6523d7ff3..cebb9635a5d5 (1 commits) Created with: gclient setdep -r src/third_party/skia@9e5c47936b17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: chromium:None,chromium:None Change-Id: I0c4e40a1c4d41652816527fdb92b82af0ed9b91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793887Reviewed-by:
-
Dominik Röttsches authored
Reland after reason for printing test timeouts has been identified in issue 996185. This will prefer performing DWrite API based font fallback on all Windowses, particularly on Windows 8.0 and below, where API based fallback was previously not available and hard-coded lookup tables were used. A content feature is used to flip the switch on this as a last-resort deactivation method, should this lead to unexpected fallback problems. Sheriffs, if there are individual layout tests failing with differences in arrow icons or different fonts used for Chinese, Japanese or Korean text, please disable the test and assign it to me - I will add the new baselines. Bug: 976737 Change-Id: I8546d1cb095af4691f6848209ba521b96d0b3cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778604 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#695069}
-
Sergio Villar Senin authored
It's unused so there is no point in passing it. Bug: 994811 Change-Id: Ib7923897beaaf7b302c3d49b23d5da9fe11e32e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792892Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#695068}
-
Jérôme Lebel authored
Updating the header image in the user consent view to support dark mode. https://drive.google.com/open?id=1lZj0o-kIoTZsa5bMnRirKr-YfSUXEo_D Bug: 1002075 Change-Id: I09acf58a8c236a24f5c10c488896f85206083f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790111Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#695067}
-
Maksim Sisov authored
Now, the DWTHPlatform just minimally responsible for setting the window into fullscreen/maximized state or even restoring its state. Most of the functionality has been moved from DWTHX11 to X11Window instead. What is more, AdjustSize has been moved to X11Window and is Linux/X11 specific now. Show/Hide methods have also been reworked and DWTHPlatform determines inactivity now and is responsible for for window state changes. Also, the WindowManagerTogglesFullscreen test has been changed in such a way that it expects that Chromium reacts on fullscreen changes made from a window manager side. This is what we have already been doing in Wayland, btw. Last, SetBoundsInPixels method has been removed from the DWTHX11. Instead, the WTHPlatform::SetBoundsInPixels is used. And, as said previously, AdjustSize for that method is implemented in the X11Window now. Bug: 990756 Change-Id: Ia4a7d4859a4b42bd7de99eb7c4309ac55e34e9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769450 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#695066}
-
Maksim Sisov authored
This CL moved the Get/SetZOrderLevel to DWTHPlatform. This method is useful for both Windows(if it eventually starts to use this path) and Linux. Also, SetAlwaysOnTop and IsAlwaysOnTop have been added to the PlatformWindow interface. However, default implementation is also added to avoid messing much with other platforms, which do not support that on the PlatformWindow level like Ozone/Drm. Instead, ChromeOS sets a property on an aura::Window. Both Windows and X11 support setting the always on top value. In case of Wayland, we'd need to add gtk_shell support and use it whenever Chromium is run on gtk. Thus, I've added NOTIMPLEMENTED to those PlatformWindows, which could potentially support that. Bug: 990756 Change-Id: Id69cca5ac59556384f1a7e01d59ab021370f19a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774454Reviewed-by:
-
