- 03 Jan, 2018 40 commits
-
-
Reid Kleckner authored
Created by patching in https://chromium-review.googlesource.com/c/chromium/src/+/835358 and manually editting the revision in update.py. TBR-ing rsesek@ again for the sandbox changes. TBR-ing bretw@ again for the ppapi adapter LLD warning suppression. I will manually build and test net_unittests after uploading to goma, but I've built this clang revision locally and they are not flaky for me. R=inglorion@chromium.org,hans@chromium.org TBR=rsesek@chromium.org,brettw@chromium.org Bug: 787920, 797267, 797168 Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_mips_dbg;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Change-Id: Ifd25c014e79ad7a5d4533941ae7fd74a86860191 Reviewed-on: https://chromium-review.googlesource.com/845700Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#526748}
-
Troy Hildebrandt authored
When updating the menu item spacing for the Chrome Home bottom navigation menu, we were checking the length of a potentially null array so a null check has been added. Bug: 796185 Change-Id: I1382aace706ad2b0ffb13e9c84bf78efc7284ceb Reviewed-on: https://chromium-review.googlesource.com/848242 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#526747}
-
danakj authored
This is a reland of 5c4d3d4a The IOSurface textures for RenderPasses do this, citing bug 146070. We can do the same for the RenderPass textures. This affects any pixel tests that have anti-aliasing, as the float value of texcoords is changed. So we have to add anti-aliased versions of a few pixel tests, and rebase a number. TBR=piman Bug: 146070 Change-Id: I7b1c86f821b86485c571d5b97e0e22f04705d99a Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/848354Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#526746}
-
Dave Tapuska authored
Invalid input should be thrown out not cause a crash of the browser. BUG=772626 Change-Id: I26128ff4491987cb6798f7f0f0078102c44dca43 Reviewed-on: https://chromium-review.googlesource.com/847305Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#526745}
-
Xianzhu Wang authored
I'm investigating the flakiness. According blink-dev discussion we should skip flaky tests instead of marking them flaky. Bug: 798116 Change-Id: I9d2fcf31ab2475169c97108bc0d2c02c242c7658 TBR: battre@chromium.org Reviewed-on: https://chromium-review.googlesource.com/848274Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#526744}
-
Rouslan Solomakhin authored
Bug: 792961 Change-Id: I9643f51f355711af731e2e77021d50598099327c Reviewed-on: https://chromium-review.googlesource.com/849152Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#526743}
-
stkhapugin@chromium.org authored
Removes almost all usage of scoped_nsobject in ios/. Bug: 717540 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ide8fc8476e2dccaa91ba2311cdf5bb06b91d3779 Reviewed-on: https://chromium-review.googlesource.com/846805Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526742}
-
Steven Bennetts authored
This CL: * Moves a bunch of related DisplayManager and DisplayConfigurator code to a separate InitializeDisplayManager method to help improve managability of Shell::Init. * Renames ShutdownObserver -> DisplayShutdownObserver. * Removes unnecessary DBusThreadManager dependencies from shell.cc. * Moves observer responsibility from Shell to ProjectingObserver Bug: 678949 Change-Id: I07159d0562bc032f03c653beb927ab8aaf053bbc Reviewed-on: https://chromium-review.googlesource.com/833500Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#526741}
-
Ryan Landay authored
This CL fixes a bug where using Find In Page to search for text in an element using a :first-letter CSS psuedo element highlights one extra character at the end of the result text and skips a character at the beginning. We have the same bug in the function we use for other marker types (e.g. composition and spelling) so I'm fixing it there too. There's still another issue that this CL does not fix that prevents the first letter itself from becoming highlighted. I am not yet sure what else needs to be changed to fix this. Bug: 798004 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If1f09dd5485be8f2817e06b3b3ef65f8b1bb11ec Reviewed-on: https://chromium-review.googlesource.com/847834Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#526740}
-
Sidney San Martín authored
r526520 started including a bookmark button's inset when calculating its width. This turns out to change the layout and, because the inset is cr_lineWidth, there's no way to pick padding constants which make the padding and spacing the same on retina and non-retina. The inset (which comes from GradientButton) isn't really used in MD, so overriding insetInView: to return zero gets the right behavior back. This class's layout code could still use cleanup. Bug: 796836 Change-Id: I52741d9fb92db92fa07ba8b27077d8451383a47f Reviewed-on: https://chromium-review.googlesource.com/848032Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#526739}
-
Michael Lippautz authored
The limit was defined as ~0ul (unsigned long) which is unsigned 32bit on Windows 64bit and thus extended with 0 for uintptr_t. This results in bogus return of StackFrameDepth::IsSafeToRecurse of true even though recursion might be disabled due to stack pressure. This reverts commit e5d92d31. Tbr: haraken@chromium.org Bug: chromium:798479 Change-Id: Id7a897af323e230e11c7a1417f383bc868f6fe05 Reviewed-on: https://chromium-review.googlesource.com/848896Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#526738}
-
Bin Zhao authored
It seems possible that socket is closed but not removed from CastSocketService. Calling send() on a closed socket may cause crash. Added a check. Bug: 784899 Change-Id: I9f0af39a10194321395213d167a09a947619fde2 Reviewed-on: https://chromium-review.googlesource.com/846240Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526737}
-
Gabriel Charette authored
Partial reland... keep StartWatching() calls to try to isolate the issue This is a reland of 91c22dbf Original change's description: > Remove hang watching of deprecated BrowserThreads. > > This is a partial reland of https://chromium-review.googlesource.com/c/chromium/src/+/705775 > > That CL caused issue 768886 (spike in hang reports). I suspect this > was caused by a change in enum IDs rather than this change to the > hang watching code and this CL will help narrow down the cause. > > R=asvitkine@chromium.org > > Bug: 689520,768886 > Change-Id: Id7bf1c7b5f5d34c4b1e7b1e71e9b015725695997 > Reviewed-on: https://chromium-review.googlesource.com/743846 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#512509} Bug: 689520, 768886 Change-Id: I138fc4b33e6316496ff35e927b2cfb5246b53a6d NOPRESUBMIT=TRUE (shuffling of code using deprecated BrowserThread IDs) Change-Id: I138fc4b33e6316496ff35e927b2cfb5246b53a6d Reviewed-on: https://chromium-review.googlesource.com/848355Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#526736}
-
Sadrul Habib Chowdhury authored
The root windows should use the FrameSinkId of the compositor. In regular aura, compositors get valid FrameSinkId from context_factory_private(). If window server is hosting viz, then use the id from that. BUG=754872 Change-Id: I7b1de89f9575ebd532042ffcd0b3a8058d85f251 Reviewed-on: https://chromium-review.googlesource.com/847333 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#526735}
-
Rouslan Solomakhin authored
Bug: 781291 Change-Id: I4405edc4e76f3c00b4ea83eab07b3387edc7a80f Reviewed-on: https://chromium-review.googlesource.com/849155Reviewed-by:
-
Xing Liu authored
This CL introduces a backend that uses URLFetcher and save in memory download data to a blob. Currently there is an issue that only content/browser uses storage::BlobStorageContext and content/public does not expose it. Only BrowserContext::CreateMemoryBackedBlob does the browser side save blob task for media API, which only expose the UUID in content::BlobHandle. Bug: 95809 Change-Id: Iac93952dd9a73a8c3eba6e6a1d1bf642a9a0d50f Reviewed-on: https://chromium-review.googlesource.com/833026 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#526733}
-
Mark Cogan authored
As of iOS 9, it's not necessary to stop observing notifications on dealloc. Bug: 798685 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib1a330d9dc9145fc9d5c546f0eca1b6faec401f8 Reviewed-on: https://chromium-review.googlesource.com/848932Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#526732}
-
Daniel Bratell authored
base::Time in the global scope collides with X11 headers which have a global typedef of Time to int. This patch moves the code so that the symbols are imported into the local namespace (content) instead. X11 headers appear in some non-standard jumbo configurations (extremely large jumbo chunks) but could happen at any time otherwise as well. Bug: 746953 Change-Id: Iadc929ca4eb7d556490d58c791bbe8b2ef119726 Reviewed-on: https://chromium-review.googlesource.com/848916 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Fady Samuel authored
During tear down, surfaces will be garbage collected which may force other surfaces to activate. However, during tear down, a RenderWidgetHostViewChildFrame may no longer have a CrossProcessFrameConnector and so it cannot send the new SurfaceInfo anywhere. If RWHVChildFrame does not have a CPFC then we should just simply drop the SurfaceInfo. Bug: 797801 Change-Id: I4b22af61ebc786dcc285311512cbc81bb570ba74 Reviewed-on: https://chromium-review.googlesource.com/849132Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#526730}
-
Ned Nguyen authored
Change-Id: I575ea1ce33848592ff725c7824078143df445f2f Reviewed-on: https://chromium-review.googlesource.com/849012 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#526729}
-
Tarun Bansal authored
Bug: 656170 Change-Id: I44efd7c4209a0acac58c3a9857cf6842d1c9f509 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/848234 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#526728}
-
Simon authored
TBR=nednguyen@google.com NOTRY=true Bug: 798536 Change-Id: Ie01236ca17cd385de37e3f97730258aed9832544 Reviewed-on: https://chromium-review.googlesource.com/849013Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#526727}
-
Becky Zhou authored
Browser controls are accessible if the browser controls are not hidden before the tab modal javascript dialog is shown. The app modal dialog is also using the same dialog view now for consistency. Bug: 687010 Change-Id: I6f36e8ef06129dd220d75d08878480672993fc72 Reviewed-on: https://chromium-review.googlesource.com/757166 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#526726}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/7365f0261183..77863be41ffd $ git log 7365f0261..77863be41 --date=short --no-merges --format='%ad %ae %s' 2018-01-03 nednguyen Move the call to set platform performance mode out of platform_backend.DidCreateBrowser and remove that API Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I86304e72fc36369803ef926c1afd27306503a563 Reviewed-on: https://chromium-review.googlesource.com/848746 Commit-Queue: <catapult-deps-roller@chromium.org> Reviewed-by: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526725}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/731082ce7ea6..35d2b7e9de9d $ git log 731082ce7..35d2b7e9d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If67063d4a798edd8bf4baa8e33879aff5c05ce99 Reviewed-on: https://chromium-review.googlesource.com/848749 Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526724}
-
Ned Nguyen authored
NOTRY=true Bug: 771997 Change-Id: Ifacd6cb915236770e1ef0c4f90d23fc41c106401 Reviewed-on: https://chromium-review.googlesource.com/726239 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
-
Philippe Hamel authored
Bug: 786472 Change-Id: I03a23cc70529ff2854ec538d6954411d6d89abdd Reviewed-on: https://chromium-review.googlesource.com/830824 Commit-Queue: Philippe Hamel <hamelphi@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#526722}
-
kylechar authored
In VizProcessTransportFactory we already have a context provider that is shared on the main thread. It's used for all ui::Compositors already. Implement VizProcessTransportFactory::SharedMainThreadContextProvider() to return that context provider. Bug: 776050 Change-Id: Ie113fab9d2b49042f173138e4f9f143b191ae848 Reviewed-on: https://chromium-review.googlesource.com/827687 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
-
Helen Li authored
The paths to quic certs are changed in r525466. This CL is to update the run.py to use the new paths. Bug: 763998 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ia55e97118b13d2e7b56fba95c6dca8aeb6ecb3c9 Reviewed-on: https://chromium-review.googlesource.com/848078Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#526720}
-
Sandra Sun authored
As we have implemented Snap at GestureScrollEnd on main thread, https://chromium-review.googlesource.com/c/chromium/src/+/756887, we'd like to turn the flag to experimental so it would be easier to test the feature on Canary. Bug: 497851 Change-Id: Ibdd23f17cbbbc47cbbe6d52bc492c2d910f32ce8 Reviewed-on: https://chromium-review.googlesource.com/836463Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#526719}
-
Wez authored
This reverts commit b86ebc88. Reason for revert: Introduces flakiness due to removal of global StatisticsRecorder teardown - see crbug.com/798717. This is a cross-platyform issue but in practice only caused base_unittests failures on the Fuchsia FYI bots, presumably due to differences in test ordering. Original change's description: > Simplified and optimized StatisticsRecorder. > > StatisticsRecorder is now an actual container of collections. > > There is only one global recorder at any time, referenced by > StatisticsRecorder::top_. > > Each StatisticsRecorder also has a pointer to the previous global recorder. > > We now have a stack (singly linked list) of StatisticsRecorder objects, where > the top of the stack (StatisticsRecorder::top_) is the current global recorder. > > This pattern is clearer and cleaner. It avoids a bunch of static variables, > indirections, unique_ptrs and calls to operator new. It gets rid of the ugly > hacks of UninitializeForTesting. It reduces memory fragmentation by having fewer > dynamically allocated objects. > > Removed methods Reset, UninitializeForTesting and DumpHistogramsToVlog. They are > now unnecessary. > > Reviewed, clarified and documented the thread safety status of each method. > > Added comments. > > > Change-Id: Ia1a7611905009d0449068c801464ad0df7813c0d > Bug: > Reviewed-on: https://chromium-review.googlesource.com/830997 > Commit-Queue: François Degros <fdegros@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526570} TBR=asvitkine@chromium.org,gayane@chromium.org,holte@chromium.org,skare@chromium.org,fdegros@chromium.org Change-Id: I4bd60c636a821bf681eb452636ade1098d3a4899 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/848273Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#526718}
-
Bence Béky authored
Motivation: Suppose the server pushes a stream and then cancels it. Consider the following three events: (A) HttpStreamFactoryImpl::Job calls Http2PushPromiseIndex::Find() to look for the SpdySession that has an unclaimed pushed stream for the request URL. (B) SpdyHttpStream calls GetPushStream() on that SpdySession instance. (C) SpdySession deletes the pushed stream when it receives the RST_STREAM frame from the server, before the response is pushed. (B) always happens after (A), and it involves a PostTask (see bug for details). If (C) happens after (B), then the request fails with a user-visible error (that upper layers like HttpNetworkTransaction might intercept and do a retry). If (C) happens after (A) but before (B), then currently, the request is sent out on the SpdySession which might not be used if there was not a pushed stream on it. That is, the server is allowed to hijack the request, and see the request headers, by pushing a stream and then closing it at the right time. After this CL, the request will fail in this case as well, with a new error code. Details: Rename Http2PushPromiseIndex::FindSession() to ClaimPushedStream() and make it unregister the pushed stream if found. Record pushed stream ID in HttpStreamFactoryImpl::Job, pass it on to SpdyHttpStream, then back to SpdySession::GetPushStream(). Fail request with new error code ERR_SPDY_PUSHED_STREAM_NOT_AVAILABLE if pushed stream was cancelled in the meanwhile. Add new SpdySessionTest for modified GetPushStream() behavior. Add SpdyNetworkTransactionTest to cover the case that the server cancels the pushed stream after it is claimed but before SpdyHttpStream calls SpdySession->GetPushStream(). Bug: 776415 Change-Id: I14150b933b09ee5c96722aa0fb2392afbcbb65b1 Reviewed-on: https://chromium-review.googlesource.com/829993Reviewed-by:Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#526717}
-
Doug Turner authored
The DNSErrorPageTest::DoClickLink tests clicks on a anchor pointing at title2.html which was handled internally by net. This CL converts loading and testing this resource to use the embedded test server. There are two parts to this CL. The first is a handling the response to mock-link-doctor.json requests need to be modified to return an embedded server url. This is so that urlCorrection returns something that can be loaded by the embedded test server. Note that the embedded server does not run on default ports and that we can not use relative links. The second part of the CL is plumbing to ensure that the Expect* functions know what url to look for. I also moved the starting the server to one place and factored out the test that needed to do something special (SniffSmallHttpErrorResponseAsDownload). Bug: 776589 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7af69dec8bc376aa2fe45a9f0c06cb6299f55440 Reviewed-on: https://chromium-review.googlesource.com/848415Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#526716}
-
Tim Volodine authored
This patch implements the mechanism for the tracing api in the chromium part of android webview. Contains AwTracingController.java and its native counterpart aw_tracing_controller.{h,cc} with JNI. There is not more than one instance of AwTracingController which is created on first call to getTracingController() in AwBrowserContext. Also makes sure that the TraceRecordMode enum Java counterparts are created in org.chromium.base. BUG=781249 Change-Id: Ie407117efb97da0894f8441e9db5d1c5b60e5a7e Reviewed-on: https://chromium-review.googlesource.com/824605 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#526715}
-
stkhapugin@chromium.org authored
Removes usage of scoped_nsobject in ios/web/public. Bug: 717540 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icec9644b72efd0d57db00c4ed106575d5de59c9f Reviewed-on: https://chromium-review.googlesource.com/846804Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526714}
-
Randy Smith authored
Bug: 785420 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id4d111a9bdae51a4b83438239c09c3e4d41127e9 Reviewed-on: https://chromium-review.googlesource.com/844454Reviewed-by:
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/d8724a947bd8..93b059db4a5a $ git log d8724a947..93b059db4 --date=short --no-merges --format='%ad %ae %s' 2017-12-20 oetuaho Index symbols by id in OutputHLSL Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I44e352223ba5f81eadd7e3ee5c619668357ef297 Reviewed-on: https://chromium-review.googlesource.com/848750 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526712}
-
Mohamed Heikal authored
Removes static and member functions that initialize CmdLine from BaseChromiumApplication. Functionality is moved to ChromeApplication as well as other "Application"s Bug: 560466 Change-Id: Ia5115dc5ce6009e645e01432c0013af5491e15e4 Reviewed-on: https://chromium-review.googlesource.com/794031 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526711}
-
Antonio Gomes authored
... rather than on the stack. In practice, although the change brings no behavior difference, it will allow WaylandTest ctor to set the proper KeyboardLayoutEngine instance before the WaylandConnection object is created, which in turn will allow WaylandKeyboardTest unittests to be fixed (follow up patch). BUG=None Change-Id: I7f18965a90ea468591c7a6ac7a473c31a1a827cf Reviewed-on: https://chromium-review.googlesource.com/847612Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#526710}
-
Gauthier Ambard authored
Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I05511ee9479c12153ac69b4c794c769d73c0f329 Reviewed-on: https://chromium-review.googlesource.com/848833Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#526709}
-
